From: Weili Qian <qianweili@huawei.com> The variable 'pos' is enumeration type, and the case branches cover all values. So remove default branch. Signed-off-by: Weili Qian <qianweili@huawei.com> Signed-off-by: Qi Tao <taoqi10@huawei.com> --- drv/hisi_dae.c | 24 ++++++++++++++---------- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/drv/hisi_dae.c b/drv/hisi_dae.c index b9f6ee07..1a1741b7 100644 --- a/drv/hisi_dae.c +++ b/drv/hisi_dae.c @@ -294,6 +294,10 @@ static void put_ext_addr(struct dae_extend_addr *ext_addr, int idx) static void fill_hashagg_task_type(struct wd_agg_msg *msg, struct dae_sqe *sqe) { + /* + * The variable 'pos' is enumeration type, and the case branches + * cover all values. + */ switch (msg->pos) { case WD_AGG_REHASH_INPUT: case WD_AGG_STREAM_INPUT: @@ -303,8 +307,6 @@ static void fill_hashagg_task_type(struct wd_agg_msg *msg, struct dae_sqe *sqe) case WD_AGG_REHASH_OUTPUT: sqe->task_type_ext = DAE_HASHAGG_OUTPUT; break; - default: - break; } } @@ -337,9 +339,13 @@ static void fill_hashagg_table_data(struct dae_sqe *sqe, struct dae_addr_list *a struct wd_agg_msg *msg) { struct hashagg_ctx *agg_ctx = (struct hashagg_ctx *)msg->priv; - struct hash_table_data *table_data = NULL; - struct dae_table_addr *hw_table = NULL; + struct hash_table_data *table_data = &agg_ctx->table_data; + struct dae_table_addr *hw_table = &addr_list->src_table; + /* + * The variable 'pos' is enumeration type, and the case branches + * cover all values. + */ switch (msg->pos) { case WD_AGG_STREAM_INPUT: case WD_AGG_REHASH_INPUT: @@ -347,15 +353,11 @@ static void fill_hashagg_table_data(struct dae_sqe *sqe, struct dae_addr_list *a table_data = &agg_ctx->table_data; break; case WD_AGG_STREAM_OUTPUT: - hw_table = &addr_list->src_table; - table_data = &agg_ctx->table_data; break; case WD_AGG_REHASH_OUTPUT: hw_table = &addr_list->src_table; table_data = &agg_ctx->rehash_table; break; - default: - break; } sqe->table_row_size = agg_ctx->row_size; @@ -454,6 +456,10 @@ static void fill_hashagg_input_data(struct dae_sqe *sqe, struct dae_ext_sqe *ext __u32 agg_col_num = 0; __u32 i, usr_col_idx; + /* + * The variable 'pos' is enumeration type, and the case branches + * cover all values. + */ switch (msg->pos) { case WD_AGG_STREAM_INPUT: agg_data = cols_data->input_data; @@ -477,8 +483,6 @@ static void fill_hashagg_input_data(struct dae_sqe *sqe, struct dae_ext_sqe *ext agg_col_num = cols_data->output_num; fill_hashagg_normal_info(sqe, ext_sqe, cols_data, cols_data->input_num); break; - default: - break; } for (i = 0; i < agg_col_num; i++) { -- 2.33.0