------------------ Original ------------------ From: "Akhil Goyal" <gakhil@marvell.com>; Date: Sun, Aug 28, 2022 09:02 PM To: "Zhangfei Gao"<zhangfei.gao@linaro.org>;"Declan Doherty"<declan.doherty@intel.com>;"Fan Zhang"<roy.fan.zhang@intel.com>;"Ashish Gupta"<ashishg@marvell.com>;"Ray Kinsella"<mdr@ashroe.eu>; Cc: "dev@dpdk.org"<dev@dpdk.org>; Subject: RE: [EXT] [PATCH 0/3] Add uadk compression and crypto PMD > UADK compression PMD provides poll mode compression & decompression > driver > UADK crypto PMD provides poll mode driver > All cryptography operations are using UADK crypto API. > All compression operations are using UADK compress API. > > Hardware accelerators using UADK are supposed to be supported. > Currently supported hardware platforms: > HiSilicon Kunpeng920 and Kunpeng930 > > Test: > sudo dpdk-test --vdev=compress_uadk > sudo dpdk-test --vdev=crypto_uadk > > v1: > Target to DPDK 22.11 > Rebased on http://git.dpdk.org/next/dpdk-next-crypto/ > > Suggested from Akhil Goyal <gakhil@marvell.com> > > Current release cycle is DPDK-22.07 for which this patchset is late. > > As we had the V1 deadline last month. > > This patchset can go for next release cycle which is 22.11. > > Zhangfei Gao (3): >   compress/uadk: add uadk compression PMD >   test/crypto: add cryptodev_uadk_autotest >   crypto/uadk: add uadk crypto PMD > >  app/test/test_cryptodev.c                 |    7 + >  app/test/test_cryptodev.h                 |    1 + >  doc/guides/compressdevs/index.rst         |    1 + >  doc/guides/compressdevs/uadk.rst          |   60 ++ >  doc/guides/cryptodevs/index.rst           |    1 + >  doc/guides/cryptodevs/uadk.rst            |   70 ++ >  drivers/compress/meson.build              |    1 + >  drivers/compress/uadk/meson.build         |   28 + >  drivers/compress/uadk/uadk_compress_pmd.c |  489 +++++++++ >  drivers/compress/uadk/version.map         |    3 + >  drivers/crypto/meson.build                |    1 + >  drivers/crypto/uadk/meson.build           |   28 + >  drivers/crypto/uadk/uadk_crypto_pmd.c     | 1137 +++++++++++++++++++++ >  drivers/crypto/uadk/version.map           |    3 + >  14 files changed, 1830 insertions(+) >  create mode 100644 doc/guides/compressdevs/uadk.rst >  create mode 100644 doc/guides/cryptodevs/uadk.rst >  create mode 100644 drivers/compress/uadk/meson.build >  create mode 100644 drivers/compress/uadk/uadk_compress_pmd.c >  create mode 100644 drivers/compress/uadk/version.map >  create mode 100644 drivers/crypto/uadk/meson.build >  create mode 100644 drivers/crypto/uadk/uadk_crypto_pmd.c >  create mode 100644 drivers/crypto/uadk/version.map > Please split the series into two - crypto pmd and compression pmd. And split each of the PMD into logical small (individually compiled) patches. Update MAINTAINERS file Update documentation in doc/guides/cryptodevs/features/uadk.ini and doc/guides/compressdevs/features/uadk.ini Also UADK does not look to be a PMD name. It is some development kit Outside of DPDK. Can you rename it to something else? Is there some dependency to build it using external libraries etc? Can you explain what exactly is UADK? Regards, Akhil