mailweb.openeuler.org
Manage this list

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

Compass-ci

Threads by month
  • ----- 2025 -----
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2021 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2020 -----
  • December
  • November
  • October
  • September
compass-ci@openeuler.org

July 2025

  • 1 participants
  • 2 discussions
[PATCH] lib/result.rb: Restore PATH_SCHEME of LOCAL_RUN in ResultPath
by Zheng Zengkai 31 Jul '25

31 Jul '25
Commit cd1d0c6cff23 ("run-local: simplify result path") changes LOCAL_RUN path scheme to "%w[path_params run]" like below: /root/.cache/lkp/result/unixbench/1-100-syscall/0 /root/.cache/lkp/result/unixbench/1-100-syscall/1 /root/.cache/lkp/result/unixbench/96-100-syscall/0 According to the lkp compare usage, user can use the -d option with "commit, kconfig, fs, etc" dimensions to compare results generated by different kernel versions with different commits, kconfigs, or rootfs, it's useful for evaluating the impact of different dimensions(like commits) on performance by running benchmarks on local server. " [root@localhost ~]# lkp compare --help Usage: compare [options] RESULT_ROOT... options: -d, --dimension DIMENSION DIMENSION to compare: commit, kconfig, fs, etc. " But with the simplified result path scheme for local run, this usage is not supported, as the remove of commit, kconfig and rootfs elements, the result_root path will not contain these sub-directories and when setup_result_root_hash greps "dim value" in the "~/.cache/lkp/paths", nothing will be matched, then $_result_root_tuple is empty and no stats can be compared and shown. This patch changes the PATH_SCHEME of LOCAL_RUN to support this usage. Signed-off-by: Zheng Zengkai <zhengzengkai(a)huawei.com> --- lib/result.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/result.rb b/lib/result.rb index 492e43b82..8260c8671 100755 --- a/lib/result.rb +++ b/lib/result.rb @@ -28,7 +28,7 @@ class ResultPath < Hash AXIS_KEYS = (MAXIS_KEYS + ['run']).freeze PATH_SCHEME = { - 'LOCAL_RUN' => %w[path_params run], + 'LOCAL_RUN' => %w[path_params tbox_group rootfs kconfig compiler commit run], 'default' => %w[path_params tbox_group rootfs kconfig compiler commit run], 'kvm:default' => %w[path_params tbox_group rootfs kconfig compiler commit run], 'health-stats' => %w[path_params run], -- 2.43.0
1 0
0 0
[PATCH] sbin/compare: Fix undefined method for false in sort_stats
by Zheng Zengkai 30 Jul '25

30 Jul '25
when doing lkp compare, it complains: /home/lkp-tests/sbin/compare:826:in `block in sort_stats': undefined method `=~' for false:FalseClass (NoMethodError) from /home/lkp-tests/sbin/compare:814:in `each' from /home/lkp-tests/sbin/compare:814:in `sort_by' from /home/lkp-tests/sbin/compare:814:in `sort_by!' from /home/lkp-tests/sbin/compare:814:in `sort_stats' from /home/lkp-tests/sbin/compare:860:in `<main>' After checking the code and operator priority in ruby, since the 'Logical NOT operator !' has a higher priority than the 'Regex match operator =~', there is a mistake introduced by the commit 8fa05e8aae9f ("cleanup rubpcop issue Style/AndOr"). Add Parentheses to fix it. Fixes: 8fa05e8aae9f ("cleanup rubpcop issue Style/AndOr") Signed-off-by: Zheng Zengkai <zhengzengkai(a)huawei.com> --- sbin/compare | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sbin/compare b/sbin/compare index 11c4fbb05..f5db5ef33 100755 --- a/sbin/compare +++ b/sbin/compare @@ -823,7 +823,7 @@ def sort_stats(stats) if x =~ ABS_CHANGE_STATS_RE [stat_priority(fields[0]), fields[1], abs_change] - elsif fields.size >= 3 && !fields[1] =~ /^node\d+$/ + elsif fields.size >= 3 && !(fields[1] =~ /^node\d+$/) # when a monitor can be broken into sub-groups of stats # under which values can be logically compared [stat_priority(fields[0]), fields[1], rel_change] -- 2.20.1
1 0
0 0

HyperKitty Powered by HyperKitty