- Compass-ci - mailweb.openeuler.org

[PATCH compass-ci] remove empty changes for metric compare result
by Lu Weitao 25 Nov '20

25 Nov '20

[Why] With template compare mode, it's useless return an empty changes for a metric like: { ... "tables": { "vmstat.system.cs": { ... "change": { "dimensions": [ "compare_dimension" ], "source": [ [ "8G", "16G" ] ] } } } [How] Skip assign metric change value, if the metric only have one dimension, the empty change will disappear automatically Signed-off-by: Lu Weitao <luweitaobe(a)163.com> --- lib/compare_matrixes.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/compare_matrixes.rb b/lib/compare_matrixes.rb index 14c14cb..0b49e59 100644 --- a/lib/compare_matrixes.rb +++ b/lib/compare_matrixes.rb @@ -466,8 +466,8 @@ end def assign_metric_change(metrics_values) metrics_values.each do |metric, values| - metrics_values[metric]['change'] = {} next if values['average'].size < 2 + metrics_values[metric]['change'] = {} dimension_list = values['average'].keys dimension_groups = get_dimensions_combination(dimension_list) -- 2.23.0

1 0

[PATCH compass-ci] doc/job/: add os.md
by Zhang Yu 25 Nov '20

25 Nov '20

add a document for introducing the os field Signed-off-by: Zhang Yu <2134782174(a)qq.com> --- doc/job/os.md | 14 ++++++++++++++ 1 file changed, 14 insertions(+) create mode 100644 doc/job/os.md diff --git a/doc/job/os.md b/doc/job/os.md new file mode 100644 index 0000000..0d0102c --- /dev/null +++ b/doc/job/os.md @@ -0,0 +1,14 @@ +# os + +Meaning: +- Each test tells which os is to be testing on, the vm will run a os according to different need. +- Os is a key for users to specify a os type. +- If os is not given by users, it will use the default debian. +- Here are the os type that we support: + openeuler + debian + centos + ... + +Usage example: +- submit iperf.yaml testbox=vm-2p8g queue=vm-2p8g~$USER os=openeuler os_arch=aarch64 os_version=20.03 os_mount=cifs -- 2.23.0

2 2

Re: [PATCH lkp-tests] stats/iperf: fix rubocop offenses
by Wei Jihui 25 Nov '20

25 Nov '20

hi, everyone, some lkp-tests's scripts is not our create, it is better not to modify them. Thanks, Jihui Reply-To: In-Reply-To: <20201125015157.2194483-1-2134782174(a)qq.com> On Wed, Nov 25, 2020 at 09:51:57AM +0800, Zhang Yu wrote: >Inspecting 1 file > >iperf:19:86: C: Style/IfUnlessModifier: Modifier form of if makes the line too long. >puts 'tcp.sender.bps: ' + obj['end']['streams'][0]['sender']['bits_per_second'].to_s if obj['end']['streams'][0]['sender'] > ^^ > >iperf:20:90: C: Style/IfUnlessModifier: Modifier form of if makes the line too long. >puts 'tcp.receiver.bps: ' + obj['end']['streams'][0]['receiver']['bits_per_second'].to_s if obj['end']['streams'][0]['receiver' > ^^ > >Signed-off-by: Zhang Yu <2134782174(a)qq.com> >--- > stats/iperf | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) > >diff --git a/stats/iperf b/stats/iperf >index b5c6c403..f2521db6 100755 >--- a/stats/iperf >+++ b/stats/iperf >@@ -16,6 +16,12 @@ end > > exit if obj['end'].empty? > >-puts 'tcp.sender.bps: ' + obj['end']['streams'][0]['sender']['bits_per_second'].to_s if obj['end']['streams'][0]['sender'] >-puts 'tcp.receiver.bps: ' + obj['end']['streams'][0]['receiver']['bits_per_second'].to_s if obj['end']['streams'][0]['receiver'] >-puts 'udp.bps: ' + obj['end']['streams'][0]['udp']['bits_per_second'].to_s if obj['end']['streams'][0]['udp'] >+if obj['end']['streams'][0]['sender'] >+ puts 'tcp.sender.bps: ' + obj['end']['streams'][0]['sender']['bits_per_second'].to_s >+end >+if obj['end']['streams'][0]['receiver'] >+ puts 'tcp.receiver.bps: ' + obj['end']['streams'][0]['receiver']['bits_per_second'].to_s >+end >+if obj['end']['streams'][0]['udp'] >+ puts 'udp.bps: ' + obj['end']['streams'][0]['udp']['bits_per_second'].to_s >+end >-- >2.23.0 >

1 0

[PATCH lkp-tests] stats/iperf: fix rubocop offenses
by Zhang Yu 25 Nov '20

25 Nov '20

Inspecting 1 file iperf:19:86: C: Style/IfUnlessModifier: Modifier form of if makes the line too long. puts 'tcp.sender.bps: ' + obj['end']['streams'][0]['sender']['bits_per_second'].to_s if obj['end']['streams'][0]['sender'] ^^ iperf:20:90: C: Style/IfUnlessModifier: Modifier form of if makes the line too long. puts 'tcp.receiver.bps: ' + obj['end']['streams'][0]['receiver']['bits_per_second'].to_s if obj['end']['streams'][0]['receiver' ^^ Signed-off-by: Zhang Yu <2134782174(a)qq.com> --- stats/iperf | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/stats/iperf b/stats/iperf index b5c6c403..f2521db6 100755 --- a/stats/iperf +++ b/stats/iperf @@ -16,6 +16,12 @@ end exit if obj['end'].empty? -puts 'tcp.sender.bps: ' + obj['end']['streams'][0]['sender']['bits_per_second'].to_s if obj['end']['streams'][0]['sender'] -puts 'tcp.receiver.bps: ' + obj['end']['streams'][0]['receiver']['bits_per_second'].to_s if obj['end']['streams'][0]['receiver'] -puts 'udp.bps: ' + obj['end']['streams'][0]['udp']['bits_per_second'].to_s if obj['end']['streams'][0]['udp'] +if obj['end']['streams'][0]['sender'] + puts 'tcp.sender.bps: ' + obj['end']['streams'][0]['sender']['bits_per_second'].to_s +end +if obj['end']['streams'][0]['receiver'] + puts 'tcp.receiver.bps: ' + obj['end']['streams'][0]['receiver']['bits_per_second'].to_s +end +if obj['end']['streams'][0]['udp'] + puts 'udp.bps: ' + obj['end']['streams'][0]['udp']['bits_per_second'].to_s +end -- 2.23.0

1 1

[PATCH compass-ci] doc/job/: add suite.md
by Bai Jing 25 Nov '20

25 Nov '20

add a document for introducing the suite field Signed-off-by: Bai Jing <799286817(a)qq.com> --- doc/job/suite.md | 9 +++++++++ 1 file changed, 9 insertions(+) create mode 100644 doc/job/suite.md diff --git a/doc/job/suite.md b/doc/job/suite.md new file mode 100644 index 0000000..aecf06f --- /dev/null +++ b/doc/job/suite.md @@ -0,0 +1,9 @@ +# suite + +Meaning: +- Test suite is a collection of test cases. The test case and test purposes +are also described in detail, system configuration information during the test, +and steps to be performed before the test. A series of test cases serving the +same test purpose or running environment are combined through the test suite. +- When you write a job yaml, you should better to assign the value of the +program to the suite. -- 2.23.0

2 2

[PATCH lkp-tests] lkp-tests/*: update mount option
by Wang Yong 25 Nov '20

25 Nov '20

[why] mount error(2): No such file or directory [how] add port=446 option to mount.cifs Signed-off-by: Wang Yong <wangyong0117(a)qq.com> --- tests/cci-depends | 2 +- tests/cci-makepkg | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/cci-depends b/tests/cci-depends index 4b885dc0c..d5c21541d 100755 --- a/tests/cci-depends +++ b/tests/cci-depends @@ -30,7 +30,7 @@ pack_arch=$os_arch . $LKP_SRC/distro/$DISTRO is_mount_point ${DEPS_MNT} && umount ${DEPS_MNT} -mount -t cifs -o guest,vers=1.0,noacl,nouser_xattr //$LKP_SERVER$DEPS_MNT $DEPS_MNT || die "Failed to run mount" +mount -t cifs -o guest,vers=1.0,noacl,nouser_xattr,port=446 //$LKP_SERVER$DEPS_MNT $DEPS_MNT || die "Failed to run mount" umask 002 diff --git a/tests/cci-makepkg b/tests/cci-makepkg index e49f66998..d08f23718 100755 --- a/tests/cci-makepkg +++ b/tests/cci-makepkg @@ -36,7 +36,7 @@ cd $LKP_SRC/pkg/$benchmark || die "pkg is empty" [ -n "$LKP_SERVER" ] && { is_mount_point ${PKG_MNT} && umount ${PKG_MNT} - mount -t cifs -o guest,vers=1.0,noacl,nouser_xattr //$LKP_SERVER$PKG_MNT $PKG_MNT || die "Failed to run mount" + mount -t cifs -o guest,vers=1.0,noacl,nouser_xattr,port=446 //$LKP_SERVER$PKG_MNT $PKG_MNT || die "Failed to run mount" } curl_pkgfile() -- 2.23.0

3 4

[PATCH v4 lkp-tests 1/2] tests/iozone: explicit support test=all
by Lu Kaiyi 25 Nov '20

25 Nov '20

[example] iozone-bs.yaml ... suite: iozone category: benchmark file_size: 4g test: all block_size: - 64k ... [output] ... Run began: Sat Nov 21 16:48:22 2020 Record Size 64 kB File size set to 4194304 kB Command line used: iozone -r 64k -s 4g -f /fs/sdb/iozonetest Output is in kBytes/sec Time Resolution = 0.000001 seconds. Processor cache size set to 1024 kBytes. Processor cache line size set to 32 bytes. File stride size set to 17 * record size. random random bkwd record stride kB reclen write rewrite read reread read write read rewrite read fwrite frewrite fread freread 4194304 64 13650392 11529057 7878373 7763936 7166639 10774159 7520609 16188351 7362482 9751567 9453804 7981606 7932187 --- tests/iozone | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/iozone b/tests/iozone index b6a1e206..bafc0087 100755 --- a/tests/iozone +++ b/tests/iozone @@ -19,6 +19,8 @@ if [ -n "$block_size" ]; then for ele in ${array[@]} do case $ele in + "all") args+=" -a" + ;; "write") args+=" -i 0" ;; "read") args+=" -i 1" -- 2.23.0

2 1

[PATCH v2 lkp-tests] lkp-tests/*: update mount option
by Wang Yong 24 Nov '20

24 Nov '20

[why] refer-to: compass-ci: commit 96584b45e528a4bad1f9 [how] add port=446 option to mount.cifs Signed-off-by: Wang Yong <wangyong0117(a)qq.com> --- tests/cci-depends | 2 +- tests/cci-makepkg | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/cci-depends b/tests/cci-depends index 4b885dc0c..d5c21541d 100755 --- a/tests/cci-depends +++ b/tests/cci-depends @@ -30,7 +30,7 @@ pack_arch=$os_arch . $LKP_SRC/distro/$DISTRO is_mount_point ${DEPS_MNT} && umount ${DEPS_MNT} -mount -t cifs -o guest,vers=1.0,noacl,nouser_xattr //$LKP_SERVER$DEPS_MNT $DEPS_MNT || die "Failed to run mount" +mount -t cifs -o guest,vers=1.0,noacl,nouser_xattr,port=446 //$LKP_SERVER$DEPS_MNT $DEPS_MNT || die "Failed to run mount" umask 002 diff --git a/tests/cci-makepkg b/tests/cci-makepkg index e49f66998..d08f23718 100755 --- a/tests/cci-makepkg +++ b/tests/cci-makepkg @@ -36,7 +36,7 @@ cd $LKP_SRC/pkg/$benchmark || die "pkg is empty" [ -n "$LKP_SERVER" ] && { is_mount_point ${PKG_MNT} && umount ${PKG_MNT} - mount -t cifs -o guest,vers=1.0,noacl,nouser_xattr //$LKP_SERVER$PKG_MNT $PKG_MNT || die "Failed to run mount" + mount -t cifs -o guest,vers=1.0,noacl,nouser_xattr,port=446 //$LKP_SERVER$PKG_MNT $PKG_MNT || die "Failed to run mount" } curl_pkgfile() -- 2.23.0

1 0

[PATCH lkp-tests] lkp-tests/*: update AUR Helper for archlinux
by Wang Yong 24 Nov '20

24 Nov '20

yaourt is unmaintained and yay also support native pacman operation, so only minor changes are needed Signed-off-by: Wang Yong <wangyong0117(a)qq.com> --- distro/archlinux | 15 +++++++++++++++ distro/installer/archlinux | 15 +++++++++------ lib/install.sh | 2 +- 3 files changed, 25 insertions(+), 7 deletions(-) diff --git a/distro/archlinux b/distro/archlinux index 408c5fa23..8e3fbbce7 100755 --- a/distro/archlinux +++ b/distro/archlinux @@ -109,3 +109,18 @@ pack_benchmark() ) done } + +add_aur_helper() +{ + pacman -Q yay 2>/dev/null && return + + local user=lkp + local dir=/home/${user} + + mkdir -p ${dir} && chown ${user}:${user} ${dir} + echo "lkp ALL=(ALL) NOPASSWD:ALL" >> /etc/sudoers + + pacman -S --needed --noconfirm git base-devel 2>/dev/null + su - ${user} -c "git clone https://aur.archlinux.org/yay.git" + su - ${user} -c "cd yay && makepkg -si --needed --noconfirm" +} diff --git a/distro/installer/archlinux b/distro/installer/archlinux index 27cdc63cf..af98e466f 100755 --- a/distro/installer/archlinux +++ b/distro/installer/archlinux @@ -2,12 +2,15 @@ # Archlinux package installation -# yaourt is a wrapper for pacman that adds automated access -# to the AUR. -# See: https://wiki.archlinux.org/index.php/Yaourt +# Yet Another Yogurt - An AUR Helper Written in Go +# Yay is based on the design of yaourt, apacman and pacaur +# See: https://github.com/Jguer/yay -# yaourt not support root to build package +# Yay not support root to build package # Use regular user to do this -regular_user=`grep 1000 /etc/passwd | awk -F':' '{ print $1 }'` +. $LKP_SRC/distro/${DISTRO} +add_aur_helper -sudo -u $regular_user yaourt -S --noconfirm $* +regular_user=`grep 1090 /etc/passwd | awk -F':' '{ print $1 }'` + +sudo -u $regular_user yay -S --needed --noconfirm $* diff --git a/lib/install.sh b/lib/install.sh index 881ade9f4..bf7bf21d7 100755 --- a/lib/install.sh +++ b/lib/install.sh @@ -17,7 +17,7 @@ sync_distro_sources() yum update fi ;; redhat) yum update ;; - archlinux) yaourt -Sy ;; + archlinux) yay -Sy ;; opensuse) zypper update ;; oracle) yum update ;; -- 2.23.0

1 1

[PATCH v3 lkp-tests] tests/iozone: explicit support test=all and add invalid test option identification
by Lu Kaiyi 24 Nov '20

24 Nov '20

[example] iozone-bs.yaml ... suite: iozone category: benchmark file_size: 4g test: all block_size: - 64k ... [output] ... Run began: Sat Nov 21 16:48:22 2020 Record Size 64 kB File size set to 4194304 kB Command line used: iozone -r 64k -s 4g -f /fs/sdb/iozonetest Output is in kBytes/sec Time Resolution = 0.000001 seconds. Processor cache size set to 1024 kBytes. Processor cache line size set to 32 bytes. File stride size set to 17 * record size. random random bkwd record stride kB reclen write rewrite read reread read write read rewrite read fwrite frewrite fread freread 4194304 64 13650392 11529057 7878373 7763936 7166639 10774159 7520609 16188351 7362482 9751567 9453804 7981606 7932187 --- tests/iozone | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tests/iozone b/tests/iozone index b6a1e206..5186766f 100755 --- a/tests/iozone +++ b/tests/iozone @@ -19,6 +19,8 @@ if [ -n "$block_size" ]; then for ele in ${array[@]} do case $ele in + "all") args+=" -a" + ;; "write") args+=" -i 0" ;; "read") args+=" -i 1" @@ -45,6 +47,9 @@ if [ -n "$block_size" ]; then ;; "preadv") args+=" -i 12" ;; + *) echo "invalid test option, please check again!" + exit 1 + ;; esac done else -- 2.23.0

1 0