[Compass-ci] Re: [PATCH v6 lkp-tests 1/2] sbin/makepkg: support applying patch for PKGBUILD

11 Nov 2020


      On Tue, Nov 10, 2020 at 04:32:56PM +0800, Lin Jiaxin wrote:
...
On Tue, Nov 10, 2020 at 04:20:40PM +0800, Wu Fengguang wrote:
...
...
+PKGBUILD_TAG=$PKGBUILD_TAG
Is that necessary?
Unnecessary, i will delete it.
...
...
if (( INFAKEROOT )); then
  if [[ -z $FAKEROOTKEY ]]; then
@@ -3691,7 +3695,7 @@ else
  if [[ ${BUILDFILE:0:1} != "/" ]]; then
      BUILDFILE="$startdir/$BUILDFILE"
  fi
-	source_buildfile "$BUILDFILE"
+	source_buildfile "$BUILDFILE" "$BUILDFILE$PKGBUILD_TAG"
What if the latter file does not exist?
Thanks,
Fengguang
If $PKGBUILD_TAG undefined, it will source_buildfile "$BUILDFILE"
twice now.
How about
source_buildfile "$BUILDFILE"
[[ -n $PKGBUILD_TAG ]] && source_buildfile "$BUILDFILE$PKGBUILD_TAG"
That looks better.

Thanks,
Fengguang

    