On Mon, Oct 19, 2020 at 02:46:06PM +0800, Wu Fengguang wrote:
On Fri, Oct 16, 2020 at 02:06:55PM +0800, Luan Shengde wrote:
add setup smpt for intranet/internet smtp
smpt looks like spell error
I got it
enable send mail to both curystal.ci and WAN email
curystal?
spell error
WAN?
world area networ email I will update it
+ 'from' => data['from'] || (ENV['DEFAULT_EMAIL']).to_s,
DEFAULT_EMAIL is what?
when sending email to crystal.ci, the DEFAULT_EMAIL is team@crystal.ci
+def check_smtp(mail_info, mail_server) + if [nil, 'crystal.ci'].include? mail_info['to'].split('@')[1] + intranet_smtp(mail_server) + else + internet_smtp + mail_info['from'] = (ENV['EMAIL_ADDR']).to_s
EMAIL_ADDR is what?
user's email address
Looks DEFAULT_EMAIL/EMAIL_ADDR naming should be improved.
Thanks, Fengguang