Reuse the "--no-hide-noises" option and allow to bypass some checks for stats and show more stats comparisions if "--no-hide-noises" option is given when using lkp compare. It is useful when tester wants to see more stats comparisions between different runs, for example when the change ratio is less than 10%. Before the patch: [root@localhost /]# lkp compare -twa -d commit 5.10.0-4a4dbce046f7+ 5.10.0-47abaacd89b8+ info: "export LKP_GIT_WORK_TREE=/path/to/project/git/repo/" to enable parsing non-sha1 commit names. tests: 1 [root@localhost /]# lkp compare -twa --no-hide-noises -d commit 5.10.0-4a4dbce046f7+ 5.10.0-47abaacd89b8+ info: "export LKP_GIT_WORK_TREE=/path/to/project/git/repo/" to enable parsing non-sha1 commit names. tests: 1 [root@localhost /]# After the patch: [root@localhost /]# lkp compare -twa --no-hide-noises -d commit 5.10.0-4a4dbce046f7+ 5.10.0-47abaacd89b8+ info: "export LKP_GIT_WORK_TREE=/path/to/project/git/repo/" to enable parsing non-sha1 commit names. tests: 1 suite/path_params/tbox_group/run: unixbench/syscall/localhost 5.10.0-4a4dbce04 5.10.0-47abaacd89b8+ ---------------- -------------------------- %stddev change %stddev \ | \ 62340 -8% 57520 unixbench.System_Call_Overhead fail:runs %reproduction fail:runs | | | 2:2 0% 3:3 dmesg.tstage.last 2:2 0% 3:3 kmsg.eid.ACPI:IORT:[Firmware_Bug]:[map(____ptrval____)]conflicting_mapping_for_input_ID 2:2 0% 3:3 kmsg.eid.ACPI:IORT:[Firmware_Bug]:applying_workaround 2:2 0% 3:3 kmsg.eid.integrity:Unable_to_open_file:/etc/keys/x509_ima.der(-#) 2:2 0% 3:3 kmsg.eid.integrity:Unable_to_open_file:/etc/keys/x509_evm.der(-#) 2:2 0% 3:3 kmsg.eid.hisi_sas_v3_hw#:#:#:#hw_queues 2:2 0% 3:3 kmsg.eid.hisi_sas_v3_hw###:#hw_queues 158:2 0% 237:3 kmsg.msg.ACPI:IORT:[Firmware_Bug]:[map(____ptrval____)]conflicting_mapping_for_input_ID.message 100:2 0% 150:3 kmsg.msg.ACPI:IORT:[Firmware_Bug]:applying_workaround.message 114:2 0% 171:3 kmsg.msg.integrity:Unable_to_open_file:/etc/keys/x509_ima.der(-#).message 114:2 0% 171:3 kmsg.msg.integrity:Unable_to_open_file:/etc/keys/x509_evm.der(-#).message 84:2 0% 126:3 kmsg.msg.hisi_sas_v3_hw#:#:#:#hw_queues.message 84:2 0% 126:3 kmsg.msg.hisi_sas_v3_hw###:#hw_queues.message 0.72:2 0% 1.08:3 kmsg.ts.ACPI:IORT:[Firmware_Bug]:[map(____ptrval____)]conflicting_mapping_for_input_ID 0.72:2 0% 1.08:3 kmsg.ts.ACPI:IORT:[Firmware_Bug]:applying_workaround 83.19:2 -4% 124.69:3 kmsg.ts.last 28.85:2 -2% 43.22:3 kmsg.ts.integrity:Unable_to_open_file:/etc/keys/x509_evm.der(-#) 28.85:2 -2% 43.22:3 kmsg.ts.integrity:Unable_to_open_file:/etc/keys/x509_ima.der(-#) 33.27:2 -24% 49.18:3 kmsg.ts.hisi_sas_v3_hw#:#:#:#hw_queues 48.59:2 -171% 67.75:3 kmsg.ts.hisi_sas_v3_hw###:#hw_queues [root@localhost /]# Signed-off-by: Zheng Zengkai <zhengzengkai@huawei.com> --- lib/stats.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/stats.rb b/lib/stats.rb index 3ef5c937a..be2331936 100755 --- a/lib/stats.rb +++ b/lib/stats.rb @@ -630,7 +630,7 @@ def __get_changed_stats(a, b, is_incomplete_run, options) b.each_key { |k| a[k] = [0] * cols_a unless a.include?(k) } # rubocop:disable Style/CombinableLoops a.each do |k, v| - is_force_stat = options["force_#{k}"] + is_force_stat = options["force_#{k}"] || $opt_no_hide_noises next if v[-1].is_a?(String) next if options['perf'] && !perf_metric?(k) -- 2.20.1