[Compass-ci] Re: [PATCH v2 compass-ci] sched: refactor get_boot_ipxe to job class

ping On Fri, Oct 09, 2020 at 07:13:49PM +0800, Wu Fengguang wrote:

...

+ private def set_kernel + self["kernel"] = "kernel #{vmlinuz()}" + end

That's counter intuitive. job.kernel should be the kernel, not some initrd string.

...

+ self["initrds"] = temp_initrds.join(" ")

Why not use Array?

Thanks, Fengguang