[Compass-ci] Re: [PATCH v6 compass-ci 03/12] mail-robot: check to assign account

13 Nov 2020

      TO ALL

On Fri, Nov 13, 2020 at 10:32:38AM +0800, Wu Fengguang wrote:
...
...
+# assign uuid/account for user
+# send_account
+#   parse my_commit_url and my_ssh_pubkey
+#   apply account
+#   store account info
+#   send mail
+class AssignAccount
这样的注释不够。
还需要说明，which service, where, when call this class.
And what's the input/output.
别的类也这么写注释。

还有，以后别写这么大的patchset.
先搭好框架，实现核心功能。submit&merge small patches。
然后逐步实现外围功能。

Thanks,
Fengguang