[Compass-ci] Re: [PATCH v4 compass-ci 1/6] container/send-internet-mail: mail-post.rb

On Wed, Oct 21, 2020 at 02:51:00PM +0800, Luan Shengde wrote:

...

...

+ +def check_send_mail(mail_info) + if ENV['SMTP_REGION'] == 'internet-smtp'

Perhaps no need to test that. Just use

mail_info['from'] ||= ENV['FROM_ADDRESS']

And let the 2 containers pass different FROM_ADDRESS env into docker.

for send internet mail, the FROM_ADDRESS must be same to the user_name setted in smtp

Then let it fail. Why would the client set "from:" for Internet email at all? Thanks, Fengguang