[Compass-ci] Re: [PATCH v3 compass-ci 2/4] assign-account: add new option for ssh key

13 Nov 2020


      On Fri, Nov 13, 2020 at 10:14:29AM +0800, Luan Shengde wrote:
...
On Fri, Nov 13, 2020 at 10:01:49AM +0800, Wu Fengguang wrote:
...
...
+  my_info['my_ssh_pubkey'] << if mail_content.part[1].filename == 'id_rsa.pub'
+                                mail_content.part[1].body.decoded
+                              end
Will that add nil to the array?
this is a bug,
style as below will fix it
if mail_content.part[1].filename == 'id_rsa.pub'
It's not necessarily named id_rsa.pub
...
my_info['my_ssh_pubkey'] << mail_content.part[1].body.decoded
end
Thanks,
Luan Shengde
...
Thanks,
Fengguang