20 Oct
2020
20 Oct
'20
7:15 p.m.
On Tue, Oct 20, 2020 at 05:00:15PM +0800, Luan Shengde wrote:
On Tue, Oct 20, 2020 at 04:51:00PM +0800, Wu Fengguang wrote:
+ puts ENV['EMAIL_ADDRESS'] + puts ENV['EMAIL_PASSWORD']
EMAIL_ADDRESS 名字还没改掉啊！
这个是放在全局配置文件里的。 在那个上下文下，谁知道EMAIL_ADDRESS是干嘛的？
你们就这么一而再的忽略review意见？!
this email address is the compass-ci@qq.com, need to change it to my_email?
Please rename the global EMAIL_ADDRESS to some more descriptive and un-ambiguous name. It's not my_email. Thanks, Fengguang