[Compass-ci] Re: [PATCH v3 compass-ci] src/lib/job.cr: optimize the get_pkg_common_dir function

10 Mar 2021

      ...
...
...
+      tmp = @hash[item]?
+      break if tmp
just do a rename? tmp is a little vague. maybe you can use tmp_pkg_style or tmp_style?
ok, i will rename it.
       Thanks,
       Ping
...
for you do assignment at:
 tmp = @hash[item]?
it will be nil if no @hash[item] or with nil value,
do not need to assign a nil value at:
 tmp = nil
...
end
-    return nil unless pkg_style
+    return nil unless tmp
i will use the tmp value later.
       so, i have to define it first.
I learned it.

Thanks, 
Luan Shengde
...