On Mon, Oct 12, 2020 at 09:51:18AM +0800, Wu Fengguang wrote:
+++ b/container/osimage/centos-7/build
Please follow container/ convention: this script should be "run" not "build".
Ok. I had fix it
pull_docker() code should be content of build.
Ok
@@ -0,0 +1,29 @@ +#!/bin/bash +# SPDX-License-Identifier: MulanPSL-2.0+ +# Copyright (c) 2020 Huawei Technologies Co., Ltd. All rights reserved. + +. ${CCI_SRC}/container/osimage/centos-7/bin/lib
centos-7 is too specific.
Please move code here.
修改成 ${CCI_SRC}/container/osimage/centos/* 这样可以吗？ 因为后续还有会debian/openeuler等，他们的创建过程和centos都不太一样， 对不同的系统可能需要不同的代码来创建镜像.
+. ${CCI_SRC}/container/defconfig.sh + +check_passwd_file "$root_pwd_file"
+docker cp -a init_docker:/${image_name} ./
./ is where?
cp_package() { docker cp -a init_docker:/${image_name} $HOME/ echo "result: $(ls $HOME/${image_name})" }
+echo "build finished!!!"
No !!! please.
sorry, i had delete it.
Call docker_rm() here?
Ok. Thanks, Chenglong
Thanks, Fengguang