[Compass-ci] Re: [PATCH compass-ci] job.cr: def var initrd_os_dir for used multi times

On Fri, Oct 16, 2020 at 11:21:00AM +0800, Xiao Shenwei wrote:

On Fri, Oct 16, 2020 at 10:49:09AM +0800, Xu Xijian wrote:

...

initrd_os_dir is used twice here, define a var fo it.

Signed-off-by: Xu Xijian <xuxijian@huawei.com> --- src/lib/job.cr | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/lib/job.cr b/src/lib/job.cr index 32aa662..fc712ba 100644 --- a/src/lib/job.cr +++ b/src/lib/job.cr @@ -299,10 +299,11 @@ class Job private def initramfs_initrds temp_initrds = [] of String

+ initrd_os_dir = "#{SRV_INITRD}/osimage/#{os_dir}"

i think should name it osimage_dir not initrd_os_dir

Thanks, Shenwei

good! Thanks, Xijian