On Mon, Jan 04, 2021 at 07:02:19PM +0800, Yu Chuan wrote:
has_cmd ntpdate || { detect_system local DISTRO=$_system_name_lowercase + [ "$DISTRO" == "unknown" ] && { + echo "[WARNING] Current os cannot be recognized by lkp-test, so skip run_ntpdate." + return + } . $LKP_SRC/distro/installer/$DISTRO $(echo ntpdate | $LKP_SRC/sbin/adapt-packages $DISTRO)
Well ntpdate is common requirement and that line will install it on every test run. Why it's not pre-installed?
OTOH, ntpdate is typically not a must for each and every job. Bare metal HW should be enough to run ntpdate once per day. And VM could inherit host time.
Currently, ntpdate is not installed as a basic package for every rootfs.
So, how about install it for every rootfs, and after install finished,
Nope. nfsroot may be fine, but probably not every rootfs. Like docker image and some minimal rootfs. What's the scope of problem and what's the minimal change to fix it?
we can delete this step in lib/bootstrap.sh?
Nope. Don't add this mess to bootstrap.sh Thanks, Fengguang