[Compass-ci] Re: [PATCH compass-ci] scheduler: fix condition when setting default queue

On Fri, Nov 27, 2020 at 07:48:26PM +0800, Ren Wen wrote:

Hash.*has_key?* returns true although there is no value of the key.

have error message? if queue field not exist @hash.has_key?("queue") will return false, why do this change Thanks, Shenwei

Signed-off-by: Ren Wen <15991987063@163.com> --- src/lib/job.cr | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/lib/job.cr b/src/lib/job.cr index e836d1f..55bac7f 100644 --- a/src/lib/job.cr +++ b/src/lib/job.cr @@ -247,7 +247,7 @@ class Job end

private def set_queue - return if @hash.has_key?("queue") + return unless self["queue"].empty?

# set default value self["queue"] = tbox_group -- 2.23.0