On Fri, Oct 16, 2020 at 05:29:18PM +0800, Xu Xijian wrote:
Function set_pp_initrd() is confusing, since what it does is to set depends, so change function name to set_depends_initrd.
"pp" is come from the lkp-tests domain. job has an "pp" field. it seems to be a "domain name". advice to "make clear" at lkp-tests first. can add a comment at scheduler.
Signed-off-by: Xu Xijian <xuxijian@huawei.com> --- src/lib/job.cr | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/lib/job.cr b/src/lib/job.cr index 20afa65..1e44d15 100644 --- a/src/lib/job.cr +++ b/src/lib/job.cr @@ -133,7 +133,7 @@ class Job set_result_root() set_result_service() set_os_mount() - set_pp_initrd() + set_depends_initrd() set_initrds_uri() set_kernel_uri() set_kernel_append_root() @@ -391,7 +391,7 @@ class Job self["user_lkp_src"] = Jobfile::Operate.prepare_lkp_tests(lkp_initrd_user, os_arch) end
- private def set_pp_initrd + private def set_depends_initrd initrd_deps_arr = Array(String).new initrd_pkg_arr = Array(String).new initrd_http_prefix = "http://#{INITRD_HTTP_HOST}:#{INITRD_HTTP_PORT}" -- 2.23.0
-- Thanks. chief <tongqunfeng@huawei.com>