[PATCH compass-ci] job.cr: use specified version of performance tool test
[why] Now we are required to use specified version of performance tool to test. But the tool package used is latest.cgz by default. [how] job yaml: ${program}_version: 1.0-17 Signed-off-by: Zhang Yu <2134782174@qq.com> --- src/lib/job.cr | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/lib/job.cr b/src/lib/job.cr index 07873ab..d10a1e9 100644 --- a/src/lib/job.cr +++ b/src/lib/job.cr @@ -424,8 +424,14 @@ class Job program = $1 end + if @hash["#{program}_version"]? + program_version = @hash["#{program}_version"] + else + program_version = "latest" + end + deps_dest_file = "#{SRV_INITRD}/deps/#{mount_type}/#{os_dir}/#{program}/#{program}.cgz" - pkg_dest_file = "#{SRV_INITRD}/pkg/#{mount_type}/#{os_dir}/#{program}/latest.cgz" + pkg_dest_file = "#{SRV_INITRD}/pkg/#{mount_type}/#{os_dir}/#{program}/#{program_version}.cgz" if File.exists?(deps_dest_file) initrd_deps_arr << "#{initrd_http_prefix}" + JobHelper.service_path(deps_dest_file) -- 2.23.0
On Tue, Nov 10, 2020 at 06:33:07PM +0800, Zhang Yu wrote:
[why] Now we are required to use specified version of performance tool to test. But the tool package used is latest.cgz by default.
[how] job yaml: ${program}_version: 1.0-17
Signed-off-by: Zhang Yu <2134782174@qq.com> --- src/lib/job.cr | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/src/lib/job.cr b/src/lib/job.cr index 07873ab..d10a1e9 100644 --- a/src/lib/job.cr +++ b/src/lib/job.cr @@ -424,8 +424,14 @@ class Job program = $1 end
+ if @hash["#{program}_version"]?
how about check if @hash has key "#{program}_version"? Thanks, Luan Shengde
+ program_version = @hash["#{program}_version"] + else + program_version = "latest" + end + deps_dest_file = "#{SRV_INITRD}/deps/#{mount_type}/#{os_dir}/#{program}/#{program}.cgz" - pkg_dest_file = "#{SRV_INITRD}/pkg/#{mount_type}/#{os_dir}/#{program}/latest.cgz" + pkg_dest_file = "#{SRV_INITRD}/pkg/#{mount_type}/#{os_dir}/#{program}/#{program_version}.cgz"
if File.exists?(deps_dest_file) initrd_deps_arr << "#{initrd_http_prefix}" + JobHelper.service_path(deps_dest_file) -- 2.23.0
+ if @hash["#{program}_version"]?
how about check if @hash has key "#{program}_version"?
Check the value maybe more accurate, because if value nill, the program_version is nill, this will call error. Thanks Zahngyu
+ program_version = @hash["#{program}_version"] + else + program_version = "latest" + end + deps_dest_file = "#{SRV_INITRD}/deps/#{mount_type}/#{os_dir}/#{program}/#{program}.cgz" - pkg_dest_file = "#{SRV_INITRD}/pkg/#{mount_type}/#{os_dir}/#{program}/latest.cgz" + pkg_dest_file = "#{SRV_INITRD}/pkg/#{mount_type}/#{os_dir}/#{program}/#{program_version}.cgz"
if File.exists?(deps_dest_file) initrd_deps_arr << "#{initrd_http_prefix}" + JobHelper.service_path(deps_dest_file) -- 2.23.0
On Tue, Nov 10, 2020 at 06:33:07PM +0800, Zhang Yu wrote:
[why] Now we are required to use specified version of performance tool to test. But the tool package used is latest.cgz by default.
[how] job yaml: ${program}_version: 1.0-17
Signed-off-by: Zhang Yu <2134782174@qq.com> --- src/lib/job.cr | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/src/lib/job.cr b/src/lib/job.cr index 07873ab..d10a1e9 100644 --- a/src/lib/job.cr +++ b/src/lib/job.cr @@ -424,8 +424,14 @@ class Job program = $1 end
+ if @hash["#{program}_version"]? + program_version = @hash["#{program}_version"] + else + program_version = "latest" + end +
More options. if @hash.key? "#{program}_version" program_version = @hash["#{program}_version"] || 'latest' Thanks, Zhang Yuhang
deps_dest_file = "#{SRV_INITRD}/deps/#{mount_type}/#{os_dir}/#{program}/#{program}.cgz" - pkg_dest_file = "#{SRV_INITRD}/pkg/#{mount_type}/#{os_dir}/#{program}/latest.cgz" + pkg_dest_file = "#{SRV_INITRD}/pkg/#{mount_type}/#{os_dir}/#{program}/#{program_version}.cgz"
if File.exists?(deps_dest_file) initrd_deps_arr << "#{initrd_http_prefix}" + JobHelper.service_path(deps_dest_file) -- 2.23.0
+ if @hash["#{program}_version"]? + program_version = @hash["#{program}_version"] + else + program_version = "latest" + end +
More options.
if @hash.key? "#{program}_version"
Check value maybe better.
program_version = @hash["#{program}_version"] || 'latest'
Good Thanks, Zahngyu
On Wed, Nov 11, 2020 at 10:17:29AM +0800, Zhang Yuhang wrote:
end
+ if @hash["#{program}_version"]? + program_version = @hash["#{program}_version"] + else + program_version = "latest" + end +
More options.
if @hash.key? "#{program}_version"
program_version = @hash["#{program}_version"] || 'latest'
it's ok used in ruby, but will meet error in crystal, we can use like: program_version = @hash["#{program}_version"] ? @hash["#{program}_version"] : "latest" Thanks, weitao
Thanks, Zhang Yuhang
On Wed, Nov 11, 2020 at 10:57:21AM +0800, Lu Weitao wrote:
On Wed, Nov 11, 2020 at 10:17:29AM +0800, Zhang Yuhang wrote:
end
+ if @hash["#{program}_version"]? + program_version = @hash["#{program}_version"] + else + program_version = "latest" + end +
More options.
if @hash.key? "#{program}_version"
program_version = @hash["#{program}_version"] || 'latest'
it's ok used in ruby, but will meet error in crystal, we can use like: program_version = @hash["#{program}_version"] ? @hash["#{program}_version"] : "latest"
Thanks, weitao
Learned. I thought it was Ruby. Thanks, Zhang Yuhang
Thanks, Zhang Yuhang
On Wed, Nov 11, 2020 at 11:12:41AM +0800, Zhang Yu wrote:
program_version = @hash["#{program}_version"] || 'latest'
it's ok used in ruby, but will meet error in crystal, we can use like: program_version = @hash["#{program}_version"] ? @hash["#{program}_version"] : "latest" ^ This looks the same as || in ruby?
sorry, it's ruby grammar for crystal: if key must exist, the value may be nil, we can use: program_version = @hash["#{program}_version"]? ? @hash["#{program}_version"] : "latest" if key does exist, we can use: program_version = @hash.has_key?("#{program}_version") ? @hash["#{program}_version"] : "latest" if key may be does exist or nil, we can sue: program_version = (@hash.has_key?("#{program}_version") && @hash["#{program}_version"]?) ? @hash["#{program}_version"] : "latest" Thanks, Weitao
Thanks, Zhangyu
On Wed, Nov 11, 2020 at 11:41:50AM +0800, Lu Weitao wrote:
On Wed, Nov 11, 2020 at 11:12:41AM +0800, Zhang Yu wrote:
program_version = @hash["#{program}_version"] || 'latest'
it's ok used in ruby, but will meet error in crystal, we can use like: program_version = @hash["#{program}_version"] ? @hash["#{program}_version"] : "latest" ^ This looks the same as || in ruby?
sorry, it's ruby grammar
for crystal: if key must exist, the value may be nil, we can use: program_version = @hash["#{program}_version"]? ? @hash["#{program}_version"] : "latest" if key does exist, we can use: program_version = @hash.has_key?("#{program}_version") ? @hash["#{program}_version"] : "latest" if key may be does exist or nil, we can sue: program_version = (@hash.has_key?("#{program}_version") && @hash["#{program}_version"]?) ? @hash["#{program}_version"] : "latest"
Good, thanks for the explanation, learned a lot. Thanks, Zhangyu
On Tue, Nov 10, 2020 at 06:33:07PM +0800, Zhang Yu wrote:
[why] Now we are required to use specified version of performance tool to test. But the tool package used is latest.cgz by default.
[how] job yaml: ${program}_version: 1.0-17
that seems an example for how to use preogram_version in job.yaml so how bout "[how] => [example] or [how to use]
Signed-off-by: Zhang Yu <2134782174@qq.com> --- src/lib/job.cr | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/src/lib/job.cr b/src/lib/job.cr index 07873ab..d10a1e9 100644 --- a/src/lib/job.cr +++ b/src/lib/job.cr @@ -424,8 +424,14 @@ class Job program = $1 end
+ if @hash["#{program}_version"]? + program_version = @hash["#{program}_version"] + else + program_version = "latest" + end +
this block can also write like: program_version = @hash["#{program}_version"] ? @hash["#{program}_version"] : "latest" Thanks, Weitao
deps_dest_file = "#{SRV_INITRD}/deps/#{mount_type}/#{os_dir}/#{program}/#{program}.cgz" - pkg_dest_file = "#{SRV_INITRD}/pkg/#{mount_type}/#{os_dir}/#{program}/latest.cgz" + pkg_dest_file = "#{SRV_INITRD}/pkg/#{mount_type}/#{os_dir}/#{program}/#{program_version}.cgz"
if File.exists?(deps_dest_file) initrd_deps_arr << "#{initrd_http_prefix}" + JobHelper.service_path(deps_dest_file) -- 2.23.0
On Tue, Nov 10, 2020 at 06:33:07PM +0800, Zhang Yu wrote:
[why] Now we are required to use specified version of performance tool to test. But the tool package used is latest.cgz by default.
[how] job yaml: ${program}_version: 1.0-17
Signed-off-by: Zhang Yu <2134782174@qq.com> --- src/lib/job.cr | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/src/lib/job.cr b/src/lib/job.cr index 07873ab..d10a1e9 100644 --- a/src/lib/job.cr +++ b/src/lib/job.cr @@ -424,8 +424,14 @@ class Job program = $1 end
+ if @hash["#{program}_version"]? + program_version = @hash["#{program}_version"] + else + program_version = "latest" + end +
The "#{program}_version" is used more than once, so you can define a var instead of directly using, that costs less. Thanks, Yuanchao
On Tue, Nov 10, 2020 at 06:33:07PM +0800, Zhang Yu wrote:
[why] Now we are required to use specified version of performance tool to test. But the tool package used is latest.cgz by default.
[how] job yaml: ${program}_version: 1.0-17
Signed-off-by: Zhang Yu <2134782174@qq.com>
Looks good~ Thanks Yale
--- src/lib/job.cr | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/src/lib/job.cr b/src/lib/job.cr index 07873ab..d10a1e9 100644 --- a/src/lib/job.cr +++ b/src/lib/job.cr @@ -424,8 +424,14 @@ class Job program = $1 end
+ if @hash["#{program}_version"]? + program_version = @hash["#{program}_version"] + else + program_version = "latest" + end + deps_dest_file = "#{SRV_INITRD}/deps/#{mount_type}/#{os_dir}/#{program}/#{program}.cgz" - pkg_dest_file = "#{SRV_INITRD}/pkg/#{mount_type}/#{os_dir}/#{program}/latest.cgz" + pkg_dest_file = "#{SRV_INITRD}/pkg/#{mount_type}/#{os_dir}/#{program}/#{program_version}.cgz"
if File.exists?(deps_dest_file) initrd_deps_arr << "#{initrd_http_prefix}" + JobHelper.service_path(deps_dest_file) -- 2.23.0
On Thu, Nov 12, 2020 at 02:34:27PM +0800, Zhang Yale wrote:
On Tue, Nov 10, 2020 at 06:33:07PM +0800, Zhang Yu wrote:
[why] Now we are required to use specified version of performance tool to test. But the tool package used is latest.cgz by default.
[how] job yaml: ${program}_version: 1.0-17
Signed-off-by: Zhang Yu <2134782174@qq.com>
Looks good~
ok Thanks Zhangyu
participants (6)
-
Li Yuanchao -
Lu Weitao -
Luan Shengde -
Zhang Yale -
Zhang Yu -
Zhang Yuhang