[PATCH compass-ci] sparrow: fix 3-code/dev-env no such file error

[why] when execute 3-code/dev-env, error: ./dev-env: line 45: ./os/openEuler: No such file or directory Signed-off-by: Liu Yinsi <liuyinsi@163.com> --- sparrow/3-code/dev-env | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sparrow/3-code/dev-env b/sparrow/3-code/dev-env index 77027d9..e17ddcc 100755 --- a/sparrow/3-code/dev-env +++ b/sparrow/3-code/dev-env @@ -42,4 +42,5 @@ EOF source /etc/os-release -. $(dirname ${BASH_SOURCE[0]})/os/${ID} +[ -x $(dirname ${BASH_SOURCE[0]})/os/${ID} ] && + . $(dirname ${BASH_SOURCE[0]})/os/${ID} -- 2.23.0

On Thu, Nov 12, 2020 at 09:18:22AM +0800, Liu Yinsi wrote:
[why]
No need use why, unless you give the how or others. Thanks, Xueliang
when execute 3-code/dev-env, error: ./dev-env: line 45: ./os/openEuler: No such file or directory
Signed-off-by: Liu Yinsi <liuyinsi@163.com> --- sparrow/3-code/dev-env | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/sparrow/3-code/dev-env b/sparrow/3-code/dev-env index 77027d9..e17ddcc 100755 --- a/sparrow/3-code/dev-env +++ b/sparrow/3-code/dev-env @@ -42,4 +42,5 @@ EOF
source /etc/os-release
-. $(dirname ${BASH_SOURCE[0]})/os/${ID} +[ -x $(dirname ${BASH_SOURCE[0]})/os/${ID} ] && + . $(dirname ${BASH_SOURCE[0]})/os/${ID} -- 2.23.0

On Thu, Nov 12, 2020 at 09:23:35AM +0800, Cao Xueliang wrote:
On Thu, Nov 12, 2020 at 09:18:22AM +0800, Liu Yinsi wrote:
[why]
No need use why, unless you give the how or others.
Thanks, Xueliang
Is it a fixed format usage? I think here [why] is appropriate. Thanks, Xijian
when execute 3-code/dev-env, error: ./dev-env: line 45: ./os/openEuler: No such file or directory

On Thu, Nov 12, 2020 at 09:23:35AM +0800, Cao Xueliang wrote:
On Thu, Nov 12, 2020 at 09:18:22AM +0800, Liu Yinsi wrote:
[why]
No need use why, unless you give the how or others.
ok Thanks, Yinsi
Thanks, Xueliang
when execute 3-code/dev-env, error: ./dev-env: line 45: ./os/openEuler: No such file or directory
Signed-off-by: Liu Yinsi <liuyinsi@163.com> --- sparrow/3-code/dev-env | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/sparrow/3-code/dev-env b/sparrow/3-code/dev-env index 77027d9..e17ddcc 100755 --- a/sparrow/3-code/dev-env +++ b/sparrow/3-code/dev-env @@ -42,4 +42,5 @@ EOF
source /etc/os-release
-. $(dirname ${BASH_SOURCE[0]})/os/${ID} +[ -x $(dirname ${BASH_SOURCE[0]})/os/${ID} ] && + . $(dirname ${BASH_SOURCE[0]})/os/${ID} -- 2.23.0

On Thu, Nov 12, 2020 at 09:18:22AM +0800, Liu Yinsi wrote:
[why] when execute 3-code/dev-env, error: ./dev-env: line 45: ./os/openEuler: No such file or directory
Signed-off-by: Liu Yinsi <liuyinsi@163.com> --- sparrow/3-code/dev-env | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/sparrow/3-code/dev-env b/sparrow/3-code/dev-env index 77027d9..e17ddcc 100755 --- a/sparrow/3-code/dev-env +++ b/sparrow/3-code/dev-env @@ -42,4 +42,5 @@ EOF
source /etc/os-release
-. $(dirname ${BASH_SOURCE[0]})/os/${ID} +[ -x $(dirname ${BASH_SOURCE[0]})/os/${ID} ] && + . $(dirname ${BASH_SOURCE[0]})/os/${ID}
如果该文件不存在,怎么处理? 没有看到程序终止,或者有错误输出 对后面代码执行会不会造成影响,不便于定位错误 thenks sunyukui
2.23.0

error: ./dev-env: line 45: ./os/openEuler: No such file or directory
-. $(dirname ${BASH_SOURCE[0]})/os/${ID} +[ -x $(dirname ${BASH_SOURCE[0]})/os/${ID} ] && + . $(dirname ${BASH_SOURCE[0]})/os/${ID}
如果该文件不存在,怎么处理?
不存在就不处理。 为了适配在debian执行install-tiny一键部署compass-ci才加的, 在openeuler上部署的时候不需要这个。 Thanks, Yinsi
没有看到程序终止,或者有错误输出 对后面代码执行会不会造成影响,不便于定位错误 thenks sunyukui
2.23.0
participants (4)
-
Cao Xueliang
-
Liu Yinsi
-
Sun Yukui
-
Xu Xijian