[PATCH lkp-tests] fix(lkp-bootstrap.servce):lkp-bootstrap cannot run in CentOS7 initramfs
To deal with "$GOCAHE is not defined with jobs that use go-lang", lkp-bootstrap runs with "su -c". But it is not suitable for CentOS7 initramfs and will get errors like below: lkp-bootstrap.service:8] Executable path is not absolute, ignoring: su -c /etc/init.d/lkp-bootstrap Cannot add dependency job for unit lkp-bootstrap.service, ignoring: Unit is not loaded properly: Invalid argument. Use "Enviroment" instead of "su -c" Signed-off-by: Zhou Shengrui <zhoushengrui@qq.com> --- rootfs/addon/usr/lib/systemd/system/lkp-bootstrap.service | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/rootfs/addon/usr/lib/systemd/system/lkp-bootstrap.service b/rootfs/addon/usr/lib/systemd/system/lkp-bootstrap.service index 92e7e5ee..842c4aef 100644 --- a/rootfs/addon/usr/lib/systemd/system/lkp-bootstrap.service +++ b/rootfs/addon/usr/lib/systemd/system/lkp-bootstrap.service @@ -5,7 +5,8 @@ After=network.target [Service] Type=forking -ExecStart=su -c /etc/init.d/lkp-bootstrap +Environment=HOME=/root +ExecStart=/etc/init.d/lkp-bootstrap IgnoreSIGPIPE=no KillMode=none TasksMax=infinity -- 2.23.0
On Thu, Oct 15, 2020 at 08:28:40PM +0800, Zhou Shengrui wrote:
To deal with "$GOCAHE is not defined with jobs that use go-lang", lkp-bootstrap runs with "su -c". But it is not suitable for CentOS7 initramfs and will get errors like below:
Your changelog looks maybe too long...
lkp-bootstrap.service:8] Executable path is not absolute, ignoring: su -c /etc/init.d/lkp-bootstrap Cannot add dependency job for unit lkp-bootstrap.service, ignoring: Unit is not loaded properly: Invalid argument. diff --git a/rootfs/addon/usr/lib/systemd/system/lkp-bootstrap.service b/rootfs/addon/usr/lib/systemd/system/lkp-bootstrap.service index 92e7e5ee..842c4aef 100644 --- a/rootfs/addon/usr/lib/systemd/system/lkp-bootstrap.service +++ b/rootfs/addon/usr/lib/systemd/system/lkp-bootstrap.service @@ -5,7 +5,8 @@ After=network.target
[Service] Type=forking -ExecStart=su -c /etc/init.d/lkp-bootstrap +Environment=HOME=/root
^-- maybe you can add double quota here. -------- Thanks Yu Chuan
+ExecStart=/etc/init.d/lkp-bootstrap IgnoreSIGPIPE=no KillMode=none TasksMax=infinity -- 2.23.0
Hi Fengguang: Please check this email. this bug is not fixed. Thanks, Chenglong On Thu, Oct 15, 2020 at 08:28:40PM +0800, Zhou Shengrui wrote:
To deal with "$GOCAHE is not defined with jobs that use go-lang", lkp-bootstrap runs with "su -c". But it is not suitable for CentOS7 initramfs and will get errors like below:
lkp-bootstrap.service:8] Executable path is not absolute, ignoring: su -c /etc/init.d/lkp-bootstrap Cannot add dependency job for unit lkp-bootstrap.service, ignoring: Unit is not loaded properly: Invalid argument.
Use "Enviroment" instead of "su -c"
Signed-off-by: Zhou Shengrui <zhoushengrui@qq.com> --- rootfs/addon/usr/lib/systemd/system/lkp-bootstrap.service | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/rootfs/addon/usr/lib/systemd/system/lkp-bootstrap.service b/rootfs/addon/usr/lib/systemd/system/lkp-bootstrap.service index 92e7e5ee..842c4aef 100644 --- a/rootfs/addon/usr/lib/systemd/system/lkp-bootstrap.service +++ b/rootfs/addon/usr/lib/systemd/system/lkp-bootstrap.service @@ -5,7 +5,8 @@ After=network.target
[Service] Type=forking -ExecStart=su -c /etc/init.d/lkp-bootstrap +Environment=HOME=/root +ExecStart=/etc/init.d/lkp-bootstrap IgnoreSIGPIPE=no KillMode=none TasksMax=infinity -- 2.23.0
participants (3)
-
Wang Chenglong -
Yu Chuan -
Zhou Shengrui