[PATCH lkp-tests 2/2] lib/job2sh.rb: fix bug: can not find the file: pkg/$program/PKGBUILD
Signed-off-by: Li Ping <15396232681@163.com> --- lib/job2sh.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/job2sh.rb b/lib/job2sh.rb index 9c95ff4b..7e6a5d7c 100755 --- a/lib/job2sh.rb +++ b/lib/job2sh.rb @@ -350,6 +350,7 @@ class Job2sh < Job out_line out_line "\texport define_files='#{define_files.keys.join ' '}'" define_files.each do |file, val| + out_line "\tmkdir -p $LKP_SRC/$(dirname #{file})" out_line "\tcat > $LKP_SRC/#{file} <<'EOF'" out_line val out_line "EOF" -- 2.23.0
Can you add some error message? Thanks, Jiaxin On Wed, Nov 04, 2020 at 04:00:54PM +0800, Li Ping wrote:
Signed-off-by: Li Ping <15396232681@163.com> --- lib/job2sh.rb | 1 + 1 file changed, 1 insertion(+)
diff --git a/lib/job2sh.rb b/lib/job2sh.rb index 9c95ff4b..7e6a5d7c 100755 --- a/lib/job2sh.rb +++ b/lib/job2sh.rb @@ -350,6 +350,7 @@ class Job2sh < Job out_line out_line "\texport define_files='#{define_files.keys.join ' '}'" define_files.each do |file, val| + out_line "\tmkdir -p $LKP_SRC/$(dirname #{file})" out_line "\tcat > $LKP_SRC/#{file} <<'EOF'" out_line val out_line "EOF" -- 2.23.0
On Wed, Nov 04, 2020 at 04:00:54PM +0800, Li Ping wrote:
Signed-off-by: Li Ping <15396232681@163.com> --- lib/job2sh.rb | 1 + 1 file changed, 1 insertion(+)
The error output can be handled accordingly, but should not be eliminated Thanks sunyukui
diff --git a/lib/job2sh.rb b/lib/job2sh.rb index 9c95ff4b..7e6a5d7c 100755 --- a/lib/job2sh.rb +++ b/lib/job2sh.rb @@ -350,6 +350,7 @@ class Job2sh < Job out_line out_line "\texport define_files='#{define_files.keys.join ' '}'" define_files.each do |file, val| + out_line "\tmkdir -p $LKP_SRC/$(dirname #{file})" out_line "\tcat > $LKP_SRC/#{file} <<'EOF'" out_line val out_line "EOF" -- 2.23.0
On Wed, Nov 04, 2020 at 05:10:52PM +0800, Sun Yukui wrote:
On Wed, Nov 04, 2020 at 04:00:54PM +0800, Li Ping wrote:
Signed-off-by: Li Ping <15396232681@163.com> --- lib/job2sh.rb | 1 + 1 file changed, 1 insertion(+)
The error output can be handled accordingly, but should not be eliminated
I did not filter out the error message I just fix a bug "can not find the file" is a systematic error message when the $dir not exist, cat > $dir/$file << 'EOF' xxx EOF will echo such error message
Thanks sunyukui
diff --git a/lib/job2sh.rb b/lib/job2sh.rb index 9c95ff4b..7e6a5d7c 100755 --- a/lib/job2sh.rb +++ b/lib/job2sh.rb @@ -350,6 +350,7 @@ class Job2sh < Job out_line out_line "\texport define_files='#{define_files.keys.join ' '}'" define_files.each do |file, val| + out_line "\tmkdir -p $LKP_SRC/$(dirname #{file})" out_line "\tcat > $LKP_SRC/#{file} <<'EOF'" out_line val out_line "EOF" -- 2.23.0
participants (3)
-
Li Ping -
Lin Jiaxin -
Sun Yukui