Re: [PATCH lkp-tests] lib/job.sh: modify the generated file suffix
On Thu, Jan 14, 2021 at 03:44:10PM +0800, Li Ping wrote:
[why] user extract $program result actually generating a YAML file. and compass-ci/sbin/result2stats have already support merge yaml file
Signed-off-by: Li Ping <1477412247@qq.com> --- lib/job.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/job.sh b/lib/job.sh index 03c49e0ad..dc65f68d8 100755 --- a/lib/job.sh +++ b/lib/job.sh @@ -318,5 +318,5 @@ run_test() run_target_stats() { local script_name=$1 - $LKP_SRC/stats/$script_name < $TMP_RESULT_ROOT/$script_name > $TMP_RESULT_ROOT/$script_name.json + $LKP_SRC/stats/$script_name < $TMP_RESULT_ROOT/$script_name > $TMP_RESULT_ROOT/$script_name.yaml
it's only write the key-value into $script_name.yaml like: hackbench.throughput: 18277.704125399672 actually we need a matrix with josn file like: { "hackbench.throughput": [ 18277.704125399672 ] } or yaml like: hackbench.throughput: - 18277.704125399672 so we'd better use like: # make sure ENV include RESULT_ROOT # make sure lkp-tests/stats/$script_name exists $LKP_SRC/stats/wrapper $script_name, it will output $RESULT_ROOT/$script_name.json Thanks, Weitao ~
} -- 2.23.0
On Thu, Jan 14, 2021 at 04:12:40PM +0800, Lu Weitao wrote:
On Thu, Jan 14, 2021 at 03:44:10PM +0800, Li Ping wrote:
[why] user extract $program result actually generating a YAML file. and compass-ci/sbin/result2stats have already support merge yaml file
Signed-off-by: Li Ping <1477412247@qq.com> --- lib/job.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/job.sh b/lib/job.sh index 03c49e0ad..dc65f68d8 100755 --- a/lib/job.sh +++ b/lib/job.sh @@ -318,5 +318,5 @@ run_test() run_target_stats() { local script_name=$1 - $LKP_SRC/stats/$script_name < $TMP_RESULT_ROOT/$script_name > $TMP_RESULT_ROOT/$script_name.json + $LKP_SRC/stats/$script_name < $TMP_RESULT_ROOT/$script_name > $TMP_RESULT_ROOT/$script_name.yaml
it's only write the key-value into $script_name.yaml like: hackbench.throughput: 18277.704125399672
actually we need a matrix with josn file like: { "hackbench.throughput": [ 18277.704125399672 ] } or yaml like: hackbench.throughput: - 18277.704125399672
Why it must be an array?
so we'd better use like: # make sure ENV include RESULT_ROOT # make sure lkp-tests/stats/$script_name exists $LKP_SRC/stats/wrapper $script_name, it will output $RESULT_ROOT/$script_name.json
Thanks, Weitao ~
} -- 2.23.0
On Thu, Jan 14, 2021 at 04:36:14PM +0800, Wu Fengguang wrote:
On Thu, Jan 14, 2021 at 04:12:40PM +0800, Lu Weitao wrote:
On Thu, Jan 14, 2021 at 03:44:10PM +0800, Li Ping wrote:
[why] user extract $program result actually generating a YAML file. and compass-ci/sbin/result2stats have already support merge yaml file
Signed-off-by: Li Ping <1477412247@qq.com> --- lib/job.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/job.sh b/lib/job.sh index 03c49e0ad..dc65f68d8 100755 --- a/lib/job.sh +++ b/lib/job.sh @@ -318,5 +318,5 @@ run_test() run_target_stats() { local script_name=$1 - $LKP_SRC/stats/$script_name < $TMP_RESULT_ROOT/$script_name > $TMP_RESULT_ROOT/$script_name.json + $LKP_SRC/stats/$script_name < $TMP_RESULT_ROOT/$script_name > $TMP_RESULT_ROOT/$script_name.yaml
it's only write the key-value into $script_name.yaml like: hackbench.throughput: 18277.704125399672
actually we need a matrix with josn file like: { "hackbench.throughput": [ 18277.704125399672 ] } or yaml like: hackbench.throughput: - 18277.704125399672
Why it must be an array?
if yaml like: virsh.destroy.result.ok: 17 ... when extract stats by compass-ci/sbin/result2stats, load the yaml => { "virsh.destroy.result.ok" => 17 } the value will be value.sum / sample_size so we met the error like: Traceback (most recent call last): 7: from /home/lwt/work2/compass-ci/sbin/result2stats:42:in `<main>' 6: from /home/lwt/work2/compass-ci/lib/matrix2.rb:54:in `create_stats' 5: from /home/lwt/work2/compass-ci/lib/matrix2.rb:54:in `each' 4: from /home/lwt/work2/compass-ci/lib/matrix2.rb:60:in `block in create_stats' 3: from /home/lwt/work2/compass-ci/lib/matrix2.rb:30:in `extract_pre_result' 2: from /home/lwt/work2/compass-ci/lib/matrix2.rb:30:in `each' 1: from /home/lwt/work2/compass-ci/lib/matrix2.rb:33:in `block in extract_pre_result' /home/lwt/work2/compass-ci/lib/matrix2.rb:22:in `set_pre_value': undefined method `sum' for 17:Integer (NoMethodError) Did you mean? succ Main code: compass-ci/lib/matrix2.rb: def exract_pre_result(stats, monitor, file) monitor_stats = load_json file # yaml.load_json sample_size = max_cols(monitor_stats) monitor_stats.each do |k, v| next if k == "#{monitor}.time" stats[k] = set_pre_value(k, v, sample_size) <-------------- look here ... end def set_pre_value(item, value, sample_size) if value.size == 1 value[0] elsif independent_counter? item value.sum elsif event_counter? item value[-1] - value[0] else value.sum / sample_size <---------------- look here end end So if ues $LKP_SRC/stats/wrapper $script_name by $LKP_SRC/dump-stats, ouput like: { key: [value_1], ... } Thanks, Weitao
$LKP_SRC/stats/wrapper $script_name, it will output $RESULT_ROOT/$script_name.json
Thanks, Weitao ~
} -- 2.23.0
It's illogical to ask tests/ansible_test to output array values. Please propose a way to fix the data processing script to handle this case. Thanks, Fengguang On Thu, Jan 14, 2021 at 06:23:11PM +0800, Lu Weitao wrote:
On Thu, Jan 14, 2021 at 04:36:14PM +0800, Wu Fengguang wrote:
On Thu, Jan 14, 2021 at 04:12:40PM +0800, Lu Weitao wrote:
On Thu, Jan 14, 2021 at 03:44:10PM +0800, Li Ping wrote:
[why] user extract $program result actually generating a YAML file. and compass-ci/sbin/result2stats have already support merge yaml file
Signed-off-by: Li Ping <1477412247@qq.com> --- lib/job.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/job.sh b/lib/job.sh index 03c49e0ad..dc65f68d8 100755 --- a/lib/job.sh +++ b/lib/job.sh @@ -318,5 +318,5 @@ run_test() run_target_stats() { local script_name=$1 - $LKP_SRC/stats/$script_name < $TMP_RESULT_ROOT/$script_name > $TMP_RESULT_ROOT/$script_name.json + $LKP_SRC/stats/$script_name < $TMP_RESULT_ROOT/$script_name > $TMP_RESULT_ROOT/$script_name.yaml
it's only write the key-value into $script_name.yaml like: hackbench.throughput: 18277.704125399672
actually we need a matrix with josn file like: { "hackbench.throughput": [ 18277.704125399672 ] } or yaml like: hackbench.throughput: - 18277.704125399672
Why it must be an array?
if yaml like: virsh.destroy.result.ok: 17 ...
when extract stats by compass-ci/sbin/result2stats, load the yaml => { "virsh.destroy.result.ok" => 17 } the value will be value.sum / sample_size
so we met the error like: Traceback (most recent call last): 7: from /home/lwt/work2/compass-ci/sbin/result2stats:42:in `<main>' 6: from /home/lwt/work2/compass-ci/lib/matrix2.rb:54:in `create_stats' 5: from /home/lwt/work2/compass-ci/lib/matrix2.rb:54:in `each' 4: from /home/lwt/work2/compass-ci/lib/matrix2.rb:60:in `block in create_stats' 3: from /home/lwt/work2/compass-ci/lib/matrix2.rb:30:in `extract_pre_result' 2: from /home/lwt/work2/compass-ci/lib/matrix2.rb:30:in `each' 1: from /home/lwt/work2/compass-ci/lib/matrix2.rb:33:in `block in extract_pre_result' /home/lwt/work2/compass-ci/lib/matrix2.rb:22:in `set_pre_value': undefined method `sum' for 17:Integer (NoMethodError) Did you mean? succ
Main code: compass-ci/lib/matrix2.rb: def exract_pre_result(stats, monitor, file) monitor_stats = load_json file # yaml.load_json sample_size = max_cols(monitor_stats)
monitor_stats.each do |k, v| next if k == "#{monitor}.time"
stats[k] = set_pre_value(k, v, sample_size) <-------------- look here ... end
def set_pre_value(item, value, sample_size) if value.size == 1 value[0] elsif independent_counter? item value.sum elsif event_counter? item value[-1] - value[0] else value.sum / sample_size <---------------- look here end end
So if ues $LKP_SRC/stats/wrapper $script_name by $LKP_SRC/dump-stats, ouput like: { key: [value_1], ... }
Thanks, Weitao
$LKP_SRC/stats/wrapper $script_name, it will output $RESULT_ROOT/$script_name.json
Thanks, Weitao ~
} -- 2.23.0
To be exact: tests/ansible_test will write to result_root/ansible_test.yaml That yaml file format will be exactly same with the direct output of stats/* Your data processing script should be able to handle that kind of result_root/ansible_test.yaml as if there is a stats/ansible_test that output that content. Thanks, Fengguang On Thu, Jan 14, 2021 at 06:56:16PM +0800, Wu Fengguang wrote:
It's illogical to ask tests/ansible_test to output array values. Please propose a way to fix the data processing script to handle this case.
Thanks, Fengguang
On Thu, Jan 14, 2021 at 06:23:11PM +0800, Lu Weitao wrote:
On Thu, Jan 14, 2021 at 04:36:14PM +0800, Wu Fengguang wrote:
On Thu, Jan 14, 2021 at 04:12:40PM +0800, Lu Weitao wrote:
On Thu, Jan 14, 2021 at 03:44:10PM +0800, Li Ping wrote:
[why] user extract $program result actually generating a YAML file. and compass-ci/sbin/result2stats have already support merge yaml file
Signed-off-by: Li Ping <1477412247@qq.com> --- lib/job.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/job.sh b/lib/job.sh index 03c49e0ad..dc65f68d8 100755 --- a/lib/job.sh +++ b/lib/job.sh @@ -318,5 +318,5 @@ run_test() run_target_stats() { local script_name=$1 - $LKP_SRC/stats/$script_name < $TMP_RESULT_ROOT/$script_name > $TMP_RESULT_ROOT/$script_name.json + $LKP_SRC/stats/$script_name < $TMP_RESULT_ROOT/$script_name > $TMP_RESULT_ROOT/$script_name.yaml
it's only write the key-value into $script_name.yaml like: hackbench.throughput: 18277.704125399672
actually we need a matrix with josn file like: { "hackbench.throughput": [ 18277.704125399672 ] } or yaml like: hackbench.throughput: - 18277.704125399672
Why it must be an array?
if yaml like: virsh.destroy.result.ok: 17 ...
when extract stats by compass-ci/sbin/result2stats, load the yaml => { "virsh.destroy.result.ok" => 17 } the value will be value.sum / sample_size
so we met the error like: Traceback (most recent call last): 7: from /home/lwt/work2/compass-ci/sbin/result2stats:42:in `<main>' 6: from /home/lwt/work2/compass-ci/lib/matrix2.rb:54:in `create_stats' 5: from /home/lwt/work2/compass-ci/lib/matrix2.rb:54:in `each' 4: from /home/lwt/work2/compass-ci/lib/matrix2.rb:60:in `block in create_stats' 3: from /home/lwt/work2/compass-ci/lib/matrix2.rb:30:in `extract_pre_result' 2: from /home/lwt/work2/compass-ci/lib/matrix2.rb:30:in `each' 1: from /home/lwt/work2/compass-ci/lib/matrix2.rb:33:in `block in extract_pre_result' /home/lwt/work2/compass-ci/lib/matrix2.rb:22:in `set_pre_value': undefined method `sum' for 17:Integer (NoMethodError) Did you mean? succ
Main code: compass-ci/lib/matrix2.rb: def exract_pre_result(stats, monitor, file) monitor_stats = load_json file # yaml.load_json sample_size = max_cols(monitor_stats)
monitor_stats.each do |k, v| next if k == "#{monitor}.time"
stats[k] = set_pre_value(k, v, sample_size) <-------------- look here ... end
def set_pre_value(item, value, sample_size) if value.size == 1 value[0] elsif independent_counter? item value.sum elsif event_counter? item value[-1] - value[0] else value.sum / sample_size <---------------- look here end end
So if ues $LKP_SRC/stats/wrapper $script_name by $LKP_SRC/dump-stats, ouput like: { key: [value_1], ... }
Thanks, Weitao
$LKP_SRC/stats/wrapper $script_name, it will output $RESULT_ROOT/$script_name.json
Thanks, Weitao ~
} -- 2.23.0
On Thu, Jan 14, 2021 at 07:01:27PM +0800, Wu Fengguang wrote:
To be exact:
tests/ansible_test will write to result_root/ansible_test.yaml That yaml file format will be exactly same with the direct output of stats/*
Your data processing script should be able to handle that kind of result_root/ansible_test.yaml as if there is a stats/ansible_test that output that content.
OK, merge result_root/ansible_test.yaml to stats.json directly? that means: stats/$script extract result_root/$script without called stats/wrapper current logical of data processing script: tests/ansible_test can output any format data to result_root/ansible_test stats/ansible_test extract result_root/ansible_test, just output key-value lkp-tests/stats/wrapper + lkp-tests/sbin/dump-stat handle the key-value: {key => [value]} then save it to result_root/ansible_test.json before merge result_root/ansible_test.json, there are other logical
Thanks, Fengguang
On Thu, Jan 14, 2021 at 06:56:16PM +0800, Wu Fengguang wrote:
It's illogical to ask tests/ansible_test to output array values.
tests/ansible_test can output any format data to result_root/ansible_test, as long as stats/ansible_test recognize it Thanks, Weitao
Please propose a way to fix the data processing script to handle this case.
Thanks, Fengguang
On Thu, Jan 14, 2021 at 06:23:11PM +0800, Lu Weitao wrote:
On Thu, Jan 14, 2021 at 04:36:14PM +0800, Wu Fengguang wrote:
On Thu, Jan 14, 2021 at 04:12:40PM +0800, Lu Weitao wrote:
On Thu, Jan 14, 2021 at 03:44:10PM +0800, Li Ping wrote:
[why] user extract $program result actually generating a YAML file. and compass-ci/sbin/result2stats have already support merge yaml file
Signed-off-by: Li Ping <1477412247@qq.com> --- lib/job.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/job.sh b/lib/job.sh index 03c49e0ad..dc65f68d8 100755 --- a/lib/job.sh +++ b/lib/job.sh @@ -318,5 +318,5 @@ run_test() run_target_stats() { local script_name=$1 - $LKP_SRC/stats/$script_name < $TMP_RESULT_ROOT/$script_name > $TMP_RESULT_ROOT/$script_name.json + $LKP_SRC/stats/$script_name < $TMP_RESULT_ROOT/$script_name > $TMP_RESULT_ROOT/$script_name.yaml
it's only write the key-value into $script_name.yaml like: hackbench.throughput: 18277.704125399672
actually we need a matrix with josn file like: { "hackbench.throughput": [ 18277.704125399672 ] } or yaml like: hackbench.throughput: - 18277.704125399672
Why it must be an array?
if yaml like: virsh.destroy.result.ok: 17 ...
when extract stats by compass-ci/sbin/result2stats, load the yaml => { "virsh.destroy.result.ok" => 17 } the value will be value.sum / sample_size
so we met the error like: Traceback (most recent call last): 7: from /home/lwt/work2/compass-ci/sbin/result2stats:42:in `<main>' 6: from /home/lwt/work2/compass-ci/lib/matrix2.rb:54:in `create_stats' 5: from /home/lwt/work2/compass-ci/lib/matrix2.rb:54:in `each' 4: from /home/lwt/work2/compass-ci/lib/matrix2.rb:60:in `block in create_stats' 3: from /home/lwt/work2/compass-ci/lib/matrix2.rb:30:in `extract_pre_result' 2: from /home/lwt/work2/compass-ci/lib/matrix2.rb:30:in `each' 1: from /home/lwt/work2/compass-ci/lib/matrix2.rb:33:in `block in extract_pre_result' /home/lwt/work2/compass-ci/lib/matrix2.rb:22:in `set_pre_value': undefined method `sum' for 17:Integer (NoMethodError) Did you mean? succ
Main code: compass-ci/lib/matrix2.rb: def exract_pre_result(stats, monitor, file) monitor_stats = load_json file # yaml.load_json sample_size = max_cols(monitor_stats)
monitor_stats.each do |k, v| next if k == "#{monitor}.time"
stats[k] = set_pre_value(k, v, sample_size) <-------------- look here ... end
def set_pre_value(item, value, sample_size) if value.size == 1 value[0] elsif independent_counter? item value.sum elsif event_counter? item value[-1] - value[0] else value.sum / sample_size <---------------- look here end end
So if ues $LKP_SRC/stats/wrapper $script_name by $LKP_SRC/dump-stats, ouput like: { key: [value_1], ... }
Thanks, Weitao
$LKP_SRC/stats/wrapper $script_name, it will output $RESULT_ROOT/$script_name.json
Thanks, Weitao ~
} -- 2.23.0
On Mon, Jan 18, 2021 at 10:37:42AM +0800, Lu Weitao wrote:
On Thu, Jan 14, 2021 at 07:01:27PM +0800, Wu Fengguang wrote:
To be exact:
tests/ansible_test will write to result_root/ansible_test.yaml That yaml file format will be exactly same with the direct output of stats/*
Your data processing script should be able to handle that kind of result_root/ansible_test.yaml as if there is a stats/ansible_test that output that content.
OK, merge result_root/ansible_test.yaml to stats.json directly? that means: stats/$script extract result_root/$script without called stats/wrapper
current logical of data processing script: tests/ansible_test can output any format data to result_root/ansible_test stats/ansible_test extract result_root/ansible_test, just output key-value lkp-tests/stats/wrapper + lkp-tests/sbin/dump-stat handle the key-value: {key => [value]} then save it to result_root/ansible_test.json before merge result_root/ansible_test.json, there are other logical
Thanks, Fengguang
On Thu, Jan 14, 2021 at 06:56:16PM +0800, Wu Fengguang wrote:
It's illogical to ask tests/ansible_test to output array values.
tests/ansible_test can output any format data to result_root/ansible_test, as long as stats/ansible_test recognize it
Thanks, Weitao
Please propose a way to fix the data processing script to handle this case.
Thanks, Fengguang
On Thu, Jan 14, 2021 at 06:23:11PM +0800, Lu Weitao wrote:
On Thu, Jan 14, 2021 at 04:36:14PM +0800, Wu Fengguang wrote:
On Thu, Jan 14, 2021 at 04:12:40PM +0800, Lu Weitao wrote:
On Thu, Jan 14, 2021 at 03:44:10PM +0800, Li Ping wrote: >[why] >user extract $program result actually generating a YAML file. >and compass-ci/sbin/result2stats have already support merge yaml file > >Signed-off-by: Li Ping <1477412247@qq.com> >--- > lib/job.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/lib/job.sh b/lib/job.sh >index 03c49e0ad..dc65f68d8 100755 >--- a/lib/job.sh >+++ b/lib/job.sh >@@ -318,5 +318,5 @@ run_test() > run_target_stats() > { > local script_name=$1 >- $LKP_SRC/stats/$script_name < $TMP_RESULT_ROOT/$script_name > $TMP_RESULT_ROOT/$script_name.json >+ $LKP_SRC/stats/$script_name < $TMP_RESULT_ROOT/$script_name > $TMP_RESULT_ROOT/$script_name.yaml
it's only write the key-value into $script_name.yaml like: hackbench.throughput: 18277.704125399672
actually we need a matrix with josn file like: { "hackbench.throughput": [ 18277.704125399672 ] } or yaml like: hackbench.throughput: - 18277.704125399672
Why it must be an array?
if yaml like: virsh.destroy.result.ok: 17 ...
when extract stats by compass-ci/sbin/result2stats, load the yaml => { "virsh.destroy.result.ok" => 17 } the value will be value.sum / sample_size
so we met the error like: Traceback (most recent call last): 7: from /home/lwt/work2/compass-ci/sbin/result2stats:42:in `<main>' 6: from /home/lwt/work2/compass-ci/lib/matrix2.rb:54:in `create_stats' 5: from /home/lwt/work2/compass-ci/lib/matrix2.rb:54:in `each' 4: from /home/lwt/work2/compass-ci/lib/matrix2.rb:60:in `block in create_stats' 3: from /home/lwt/work2/compass-ci/lib/matrix2.rb:30:in `extract_pre_result' 2: from /home/lwt/work2/compass-ci/lib/matrix2.rb:30:in `each' 1: from /home/lwt/work2/compass-ci/lib/matrix2.rb:33:in `block in extract_pre_result' /home/lwt/work2/compass-ci/lib/matrix2.rb:22:in `set_pre_value': undefined method `sum' for 17:Integer (NoMethodError) Did you mean? succ
Main code: compass-ci/lib/matrix2.rb: def exract_pre_result(stats, monitor, file) monitor_stats = load_json file # yaml.load_json sample_size = max_cols(monitor_stats)
monitor_stats.each do |k, v| next if k == "#{monitor}.time"
stats[k] = set_pre_value(k, v, sample_size) <-------------- look here ... end
def set_pre_value(item, value, sample_size) if value.size == 1 value[0] elsif independent_counter? item value.sum elsif event_counter? item value[-1] - value[0] else value.sum / sample_size <---------------- look here end end
So if ues $LKP_SRC/stats/wrapper $script_name by $LKP_SRC/dump-stats, ouput like: { key: [value_1], ... }
Thanks, Weitao
$LKP_SRC/stats/wrapper $script_name, it will output $RESULT_ROOT/$script_name.json
Thanks, Weitao ~
> } >-- >2.23.0 >
participants (2)
-
Lu Weitao -
Wu Fengguang