the Title is: lib/params_group.rb => lib/params_group.rb: On Mon, Dec 28, 2020 at 10:23:36AM +0800, Lu Weitao wrote:

[Why] We had for-each in hash, needn't query value by key once more

Signed-off-by: Lu Weitao <luweitaobe@163.com> --- lib/params_group.rb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/params_group.rb b/lib/params_group.rb index 7bb7f5b..bf229e6 100644 --- a/lib/params_group.rb +++ b/lib/params_group.rb @@ -72,10 +72,10 @@ end

def filter_groups(groups) groups.each do |group_key, value| - value.each_key do |dim_key| - value.delete(dim_key) if value[dim_key].empty? + value.each do |dim_key, job_list| + value.delete(dim_key) if job_list.empty? end - groups.delete(group_key) if groups[group_key].empty? + groups.delete(group_key) if value.empty? end end

-- 2.23.0

On Mon, Dec 28, 2020 at 10:23:36AM +0800, Lu Weitao wrote:

[Why] We had for-each in hash, needn't query value by key once more

Signed-off-by: Lu Weitao <luweitaobe@163.com> --- lib/params_group.rb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/params_group.rb b/lib/params_group.rb index 7bb7f5b..bf229e6 100644 --- a/lib/params_group.rb +++ b/lib/params_group.rb @@ -72,10 +72,10 @@ end

def filter_groups(groups) groups.each do |group_key, value| - value.each_key do |dim_key| - value.delete(dim_key) if value[dim_key].empty? + value.each do |dim_key, job_list| + value.delete(dim_key) if job_list.empty? end - groups.delete(group_key) if groups[group_key].empty? + groups.delete(group_key) if value.empty?

I think you can modify like this, improve the processing efficiency. if value.empty? groups.delete(group_key) continue end value.each do |dim_key, job_list| value.delete(dim_key) if job_list.empty? end Thanks, Liushaofei

end end

-- 2.23.0