[PATCH v3 compass-ci] providers/docker: fix failed to pull image from local repository
[why] lys@crystal ~/compass-ci/providers% ./my-docker Donehttp://$DOCKER_REGISTRY_HOST:$DOCKER_REGISTRY_PORT/boot.container/hostname/d... pull image from local repository Error response from daemon: manifest for 127.0.0.1:5001/centos:7 not found pull image from docker hub 7: Pulling from library/centos [how] if pull image failed from local repository, it will pull from docker hub, so hide error info for first failed pull. Signed-off-by: Liu Yinsi <liuyinsi@163.com> --- providers/docker/docker.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/providers/docker/docker.rb b/providers/docker/docker.rb index 8e489c6..849ea22 100755 --- a/providers/docker/docker.rb +++ b/providers/docker/docker.rb @@ -80,7 +80,7 @@ end def start_container(hostname, load_path, hash) docker_image = hash['docker_image'] - system "#{ENV['CCI_SRC']}/sbin/docker-pull #{docker_image}" + system "#{ENV['CCI_SRC']}/sbin/docker-pull #{docker_image} 2> /dev/null" system( { 'hostname' => hostname, 'docker_image' => docker_image, 'load_path' => load_path }, ENV['CCI_SRC'] + '/providers/docker/run.sh' -- 2.23.0
On Wed, Nov 18, 2020 at 09:41:40AM +0800, Liu Yinsi wrote:
[why] lys@crystal ~/compass-ci/providers% ./my-docker Donehttp://$DOCKER_REGISTRY_HOST:$DOCKER_REGISTRY_PORT/boot.container/hostname/d... pull image from local repository Error response from daemon: manifest for 127.0.0.1:5001/centos:7 not found pull image from docker hub 7: Pulling from library/centos
[how] if pull image failed from local repository, it will pull from docker hub, so hide error info for first failed pull.
Signed-off-by: Liu Yinsi <liuyinsi@163.com> --- providers/docker/docker.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/providers/docker/docker.rb b/providers/docker/docker.rb index 8e489c6..849ea22 100755 --- a/providers/docker/docker.rb +++ b/providers/docker/docker.rb @@ -80,7 +80,7 @@ end
def start_container(hostname, load_path, hash) docker_image = hash['docker_image'] - system "#{ENV['CCI_SRC']}/sbin/docker-pull #{docker_image}" + system "#{ENV['CCI_SRC']}/sbin/docker-pull #{docker_image} 2> /dev/null"
add this step on bin/docker-pull may be better Thanks, Shenwei
system( { 'hostname' => hostname, 'docker_image' => docker_image, 'load_path' => load_path }, ENV['CCI_SRC'] + '/providers/docker/run.sh' -- 2.23.0
On Wed, Nov 18, 2020 at 09:45:11AM +0800, Xiao Shenwei wrote:
On Wed, Nov 18, 2020 at 09:41:40AM +0800, Liu Yinsi wrote:
[why] lys@crystal ~/compass-ci/providers% ./my-docker Donehttp://$DOCKER_REGISTRY_HOST:$DOCKER_REGISTRY_PORT/boot.container/hostname/d... pull image from local repository Error response from daemon: manifest for 127.0.0.1:5001/centos:7 not found pull image from docker hub 7: Pulling from library/centos
[how] if pull image failed from local repository, it will pull from docker hub, so hide error info for first failed pull.
Signed-off-by: Liu Yinsi <liuyinsi@163.com> --- providers/docker/docker.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/providers/docker/docker.rb b/providers/docker/docker.rb index 8e489c6..849ea22 100755 --- a/providers/docker/docker.rb +++ b/providers/docker/docker.rb @@ -80,7 +80,7 @@ end
def start_container(hostname, load_path, hash) docker_image = hash['docker_image'] - system "#{ENV['CCI_SRC']}/sbin/docker-pull #{docker_image}" + system "#{ENV['CCI_SRC']}/sbin/docker-pull #{docker_image} 2> /dev/null"
add this step on bin/docker-pull may be better
ok Thanks, Yinsi
Thanks, Shenwei
system( { 'hostname' => hostname, 'docker_image' => docker_image, 'load_path' => load_path }, ENV['CCI_SRC'] + '/providers/docker/run.sh' -- 2.23.0
On Wed, Nov 18, 2020 at 09:41:40AM +0800, Liu Yinsi wrote:
[why] lys@crystal ~/compass-ci/providers% ./my-docker Donehttp://$DOCKER_REGISTRY_HOST:$DOCKER_REGISTRY_PORT/boot.container/hostname/d... pull image from local repository Error response from daemon: manifest for 127.0.0.1:5001/centos:7 not found pull image from docker hub 7: Pulling from library/centos
[how] if pull image failed from local repository, it will pull from docker hub, so hide error info for first failed pull.
^^^^^ no need indent. Thanks, Baijing
Signed-off-by: Liu Yinsi <liuyinsi@163.com> --- providers/docker/docker.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/providers/docker/docker.rb b/providers/docker/docker.rb index 8e489c6..849ea22 100755 --- a/providers/docker/docker.rb +++ b/providers/docker/docker.rb @@ -80,7 +80,7 @@ end
def start_container(hostname, load_path, hash) docker_image = hash['docker_image'] - system "#{ENV['CCI_SRC']}/sbin/docker-pull #{docker_image}" + system "#{ENV['CCI_SRC']}/sbin/docker-pull #{docker_image} 2> /dev/null" system( { 'hostname' => hostname, 'docker_image' => docker_image, 'load_path' => load_path }, ENV['CCI_SRC'] + '/providers/docker/run.sh' -- 2.23.0
[how] if pull image failed from local repository, it will pull from docker hub, so hide error info for first failed pull.
^^^^^ no need indent.
ok Thanks, Yinsi
Thanks, Baijing
Signed-off-by: Liu Yinsi <liuyinsi@163.com> --- providers/docker/docker.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/providers/docker/docker.rb b/providers/docker/docker.rb index 8e489c6..849ea22 100755 --- a/providers/docker/docker.rb +++ b/providers/docker/docker.rb @@ -80,7 +80,7 @@ end
def start_container(hostname, load_path, hash) docker_image = hash['docker_image'] - system "#{ENV['CCI_SRC']}/sbin/docker-pull #{docker_image}" + system "#{ENV['CCI_SRC']}/sbin/docker-pull #{docker_image} 2> /dev/null" system( { 'hostname' => hostname, 'docker_image' => docker_image, 'load_path' => load_path }, ENV['CCI_SRC'] + '/providers/docker/run.sh' -- 2.23.0
participants (3)
-
Bai Jing -
Liu Yinsi -
Xiao Shenwei