[PATCH v2 compass-ci] sched: simplify logic and code
def has_key?(key) : Returns true when key given by key exists, otherwise false. Signed-off-by: Ren Wen <15991987063@163.com> --- src/lib/job.cr | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/lib/job.cr b/src/lib/job.cr index 2418c82..1815b93 100644 --- a/src/lib/job.cr +++ b/src/lib/job.cr @@ -289,9 +289,7 @@ class Job "SCHED_PORT"] initialized_keys.each do |key| - if @hash.has_key?(key) == false - return false - end + return false unless @hash.has_key?(key) end return false if "#{@hash["id"]}" == "" -- 2.23.0
On Thu, Nov 12, 2020 at 05:28:46PM +0800, Ren Wen wrote:
def has_key?(key) : Returns true when key given by key exists, otherwise false.
No need the changelog, it's too easy to see from the code. Thanks, Xueliang
Signed-off-by: Ren Wen <15991987063@163.com> --- src/lib/job.cr | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/src/lib/job.cr b/src/lib/job.cr index 2418c82..1815b93 100644 --- a/src/lib/job.cr +++ b/src/lib/job.cr @@ -289,9 +289,7 @@ class Job "SCHED_PORT"]
initialized_keys.each do |key| - if @hash.has_key?(key) == false - return false - end + return false unless @hash.has_key?(key) end
return false if "#{@hash["id"]}" == "" -- 2.23.0
On Thu, Nov 12, 2020 at 06:14:14PM +0800, Cao Xueliang wrote:
On Thu, Nov 12, 2020 at 05:28:46PM +0800, Ren Wen wrote:
def has_key?(key) : Returns true when key given by key exists, otherwise false.
No need the changelog, it's too easy to see from the code.
Got it. Thanks, RenWen
Thanks, Xueliang
Signed-off-by: Ren Wen <15991987063@163.com> --- src/lib/job.cr | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/src/lib/job.cr b/src/lib/job.cr index 2418c82..1815b93 100644 --- a/src/lib/job.cr +++ b/src/lib/job.cr @@ -289,9 +289,7 @@ class Job "SCHED_PORT"]
initialized_keys.each do |key| - if @hash.has_key?(key) == false - return false - end + return false unless @hash.has_key?(key) end
return false if "#{@hash["id"]}" == "" -- 2.23.0
participants (2)
-
Cao Xueliang -
Ren Wen