On Mon, Dec 21, 2020 at 10:25:50AM +0800, Ren Wen wrote:

Why remove ':' after 'lib/matrix2.rb'?

Thanks, RenWen

ok we'd better add ':' Thanks, weitao

Reply-To: In-Reply-To: <20201221022051.3690974-1-luweitaobe@163.com>

On Mon, Dec 21, 2020 at 10:20:51AM +0800, Lu Weitao wrote:

...

[Why] In compare results: the value of *timestamp*(metric) doesn't mean the number of occurrences, it may confuse user like bellow:

openeuler centos archLinux metric -------------------- ------------------------------ ------------------------------ ------------------------------ fails:runs change fails:runs change fails:runs | | | | | 3585:13 +6913.7% 344:1 -2.6e+4% 11:1 dmesg.timestamp:last 2350:13 +1.6e+4% 344:1 -1.7e+4% 10:1 kmsg.timestamp:last 2:13 -15.4% 0:1 +84.6% 1:1 last_state.exit_fail

[How] remove the metric that include "timestamp" from matrix

Signed-off-by: Lu Weitao <luweitaobe@163.com> --- lib/matrix2.rb | 2 ++ 1 file changed, 2 insertions(+)

diff --git a/lib/matrix2.rb b/lib/matrix2.rb index c712e32..2769f7c 100644 --- a/lib/matrix2.rb +++ b/lib/matrix2.rb @@ -87,6 +87,8 @@ def create_matrix(job_list) next unless stats

stats.each do |key, value| + next if key.include?('timestamp') + matrix[key] = [] unless matrix[key] matrix[key] << value end -- 2.23.0