[PATCH lkp-tests] tests/build-pkg: fix to create soft link failure
[why] the cgz file is not generated, so soft link cannot be created. error messages: ==> ERROR: Failure while downloading avro-c-1.9.2.tar.gz Aborting... ==> /tmp/stderr <== realpath: /initrd/build-pkg/nfs/openeuler/aarch64/20.03/avro-c/HEADCHECK.cgz: No such file or directory ln: failed to create symbolic link '/initrd/build-pkg/nfs/openeuler/aarch64/20.03/avro-c/latest.cgz' -> '': No such file or directory Signed-off-by: Liu Shaofei <liushaofei5@huawei.com> --- tests/build-pkg | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/build-pkg b/tests/build-pkg index ad8d4843..c29b6a20 100755 --- a/tests/build-pkg +++ b/tests/build-pkg @@ -93,6 +93,8 @@ create_softlink() local soft_path="$PKG_MNT/${pack_to}/${pkgname}" local bm_name=$(basename $(realpath ${cgz_name})) + [ -e "$cgz_name" ] || return 0 + if [ -n "$upstream_tag" ]; then echo "create soft link: ${upstream_tag}.cgz -> ${bm_name}" ln -sf "${bm_name}" "${soft_path}/${upstream_tag}.cgz" -- 2.23.0
On Sat, Nov 07, 2020 at 02:31:28PM +0800, Liu Shaofei wrote:
[why] the cgz file is not generated, so soft link cannot be created.
error messages:
==> ERROR: Failure while downloading avro-c-1.9.2.tar.gz Aborting...
==> /tmp/stderr <== realpath: /initrd/build-pkg/nfs/openeuler/aarch64/20.03/avro-c/HEADCHECK.cgz: No such file or directory ln: failed to create symbolic link '/initrd/build-pkg/nfs/openeuler/aarch64/20.03/avro-c/latest.cgz' -> '': No such file or directory
Signed-off-by: Liu Shaofei <liushaofei5@huawei.com> --- tests/build-pkg | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/tests/build-pkg b/tests/build-pkg index ad8d4843..c29b6a20 100755 --- a/tests/build-pkg +++ b/tests/build-pkg @@ -93,6 +93,8 @@ create_softlink() local soft_path="$PKG_MNT/${pack_to}/${pkgname}" local bm_name=$(basename $(realpath ${cgz_name}))
+ [ -e "$cgz_name" ] || return 0
Can be tested earlier before the bm_name= and soft_path= lines. Thanks, Fengguang
+ if [ -n "$upstream_tag" ]; then echo "create soft link: ${upstream_tag}.cgz -> ${bm_name}" ln -sf "${bm_name}" "${soft_path}/${upstream_tag}.cgz" -- 2.23.0
On Wed, Nov 11, 2020 at 10:49:51AM +0800, Wu Fengguang wrote:
On Sat, Nov 07, 2020 at 02:31:28PM +0800, Liu Shaofei wrote:
[why] the cgz file is not generated, so soft link cannot be created.
error messages:
==> ERROR: Failure while downloading avro-c-1.9.2.tar.gz Aborting...
==> /tmp/stderr <== realpath: /initrd/build-pkg/nfs/openeuler/aarch64/20.03/avro-c/HEADCHECK.cgz: No such file or directory ln: failed to create symbolic link '/initrd/build-pkg/nfs/openeuler/aarch64/20.03/avro-c/latest.cgz' -> '': No such file or directory
Signed-off-by: Liu Shaofei <liushaofei5@huawei.com> --- tests/build-pkg | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/tests/build-pkg b/tests/build-pkg index ad8d4843..c29b6a20 100755 --- a/tests/build-pkg +++ b/tests/build-pkg @@ -93,6 +93,8 @@ create_softlink() local soft_path="$PKG_MNT/${pack_to}/${pkgname}" local bm_name=$(basename $(realpath ${cgz_name}))
+ [ -e "$cgz_name" ] || return 0
Can be tested earlier before the bm_name= and soft_path= lines.
got it. Thanks, Liushaofei
Thanks, Fengguang
+ if [ -n "$upstream_tag" ]; then echo "create soft link: ${upstream_tag}.cgz -> ${bm_name}" ln -sf "${bm_name}" "${soft_path}/${upstream_tag}.cgz" -- 2.23.0
participants (2)
-
Liu Shaofei -
Wu Fengguang