[PATCH v3 compass-ci 1/2] sched: response ipxe_response value if ipxe_response field in job yaml
The install-iso job need scheduler response the ipxe_response value, when consume the install-iso job. Signed-off-by: Cao Xueliang <caoxl78320@163.com> --- src/scheduler/find_job_boot.cr | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/scheduler/find_job_boot.cr b/src/scheduler/find_job_boot.cr index 9e2898e..88db69e 100644 --- a/src/scheduler/find_job_boot.cr +++ b/src/scheduler/find_job_boot.cr @@ -160,6 +160,8 @@ class Sched end private def get_boot_ipxe(job : Job) + return job["ipxe_response"] if job["suite"] == "install-iso" && job["ipxe_response"]? + response = "#!ipxe\n\n" _initrds_uri = Array(String).from_json(job.initrds_uri).map { |uri| "initrd #{uri}" } -- 2.23.0
本质上这是指 Job 自定义(user-defined) ipxe 启动脚本。 How about naming it to something like 'custom_ipxe'?
private def get_boot_ipxe(job : Job) + return job["ipxe_response"] if job["suite"] == "install-iso" && job["ipxe_response"]? + response = "#!ipxe\n\n"
_initrds_uri = Array(String).from_json(job.initrds_uri).map { |uri| "initrd #{uri}" } -- 2.23.0
On Mon, Mar 01, 2021 at 08:55:17AM +0800, Wu Fengguang wrote:
本质上这是指 Job 自定义(user-defined) ipxe 启动脚本。
How about naming it to something like 'custom_ipxe'?
Ok, @yc let's rename the field to custom_ipxe or others name. Thanks, Xueliang
private def get_boot_ipxe(job : Job) + return job["ipxe_response"] if job["suite"] == "install-iso" && job["ipxe_response"]? + response = "#!ipxe\n\n"
_initrds_uri = Array(String).from_json(job.initrds_uri).map { |uri| "initrd #{uri}" } -- 2.23.0
On Mon, Mar 01, 2021 at 08:55:17AM +0800, Wu Fengguang wrote:
本质上这是指 Job 自定义(user-defined) ipxe 启动脚本。
How about naming it to something like 'custom_ipxe'?
How about naming it to 'my_ipxe', just like my_email? Thanks, Xueliang
private def get_boot_ipxe(job : Job) + return job["ipxe_response"] if job["suite"] == "install-iso" && job["ipxe_response"]? + response = "#!ipxe\n\n"
_initrds_uri = Array(String).from_json(job.initrds_uri).map { |uri| "initrd #{uri}" } -- 2.23.0
participants (2)
-
Cao Xueliang -
Wu Fengguang