[PATCH lkp-tests] bin/lkp-setup-rootfs: refactor the chmod_root_ssh()

Add blank line after return cmd. Signed-off-by: Xu Xijian <hdxuxijian@163.com> --- bin/lkp-setup-rootfs | 1 + 1 file changed, 1 insertion(+) diff --git a/bin/lkp-setup-rootfs b/bin/lkp-setup-rootfs index cf48c8f6b..bc0f04b2a 100755 --- a/bin/lkp-setup-rootfs +++ b/bin/lkp-setup-rootfs @@ -245,6 +245,7 @@ chmod_root_ssh() { [ -d "/root/.ssh" ] || return [ -f "/root/.ssh/id_rsa" ] || return + chmod 700 /root/.ssh/ chmod 600 /root/.ssh/id_rsa } -- 2.23.0

Too trivial cleanup. Please further improve: - the first -d test is not necessary - consider support ssh key other than rsa Here are my files wfg ~% ls .ssh/id* .ssh/id_dsa .ssh/id_dsa.pub .ssh/id_ecdsa .ssh/id_ecdsa.pub .ssh/id_rsa .ssh/id_rsa.pub Thanks, Fengguang On Fri, Jan 22, 2021 at 03:59:19PM +0800, Xu Xijian wrote:
Add blank line after return cmd.
Signed-off-by: Xu Xijian <hdxuxijian@163.com> --- bin/lkp-setup-rootfs | 1 + 1 file changed, 1 insertion(+)
diff --git a/bin/lkp-setup-rootfs b/bin/lkp-setup-rootfs index cf48c8f6b..bc0f04b2a 100755 --- a/bin/lkp-setup-rootfs +++ b/bin/lkp-setup-rootfs @@ -245,6 +245,7 @@ chmod_root_ssh() { [ -d "/root/.ssh" ] || return [ -f "/root/.ssh/id_rsa" ] || return + chmod 700 /root/.ssh/ chmod 600 /root/.ssh/id_rsa } -- 2.23.0
participants (2)
-
Wu Fengguang
-
Xu Xijian