[PATCH lkp-tests] sbin/submit: set default values
before: submit host-info.yaml os_arch=x86_64 arch=x86_64 after : submit host-info.yaml [why] when submit job in x86_64 machine, must execute like this: `submit host-info.yaml os_arch=x86_64 arch=x86_64`, then the job can be consumed by docker testbox, so add default values, it will be more convenient. Signed-off-by: Liu Yinsi <liuyinsi@163.com> --- sbin/submit | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/sbin/submit b/sbin/submit index d2d9bec76..47b377001 100755 --- a/sbin/submit +++ b/sbin/submit @@ -10,7 +10,10 @@ require "#{LKP_SRC}/lib/scheduler_client" require 'optparse' require 'yaml' -opt_set_key_value = {} +opt_set_key_value = { + 'os_arch' => `arch`.chomp, + 'arch' => `arch`.chomp +} opt_cmdline_defaults = {} opt_output_dir = nil opt_auto_define_files = false -- 2.23.0
pls, improve this patch in scheduler and don't use `arch`.chomp. Thanks, Xueliang On Fri, Apr 09, 2021 at 08:05:03PM +0800, Liu Yinsi wrote:
before: submit host-info.yaml os_arch=x86_64 arch=x86_64 after : submit host-info.yaml
[why] when submit job in x86_64 machine, must execute like this: `submit host-info.yaml os_arch=x86_64 arch=x86_64`, then the job can be consumed by docker testbox, so add default values, it will be more convenient.
Signed-off-by: Liu Yinsi <liuyinsi@163.com> --- sbin/submit | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/sbin/submit b/sbin/submit index d2d9bec76..47b377001 100755 --- a/sbin/submit +++ b/sbin/submit @@ -10,7 +10,10 @@ require "#{LKP_SRC}/lib/scheduler_client" require 'optparse' require 'yaml'
-opt_set_key_value = {} +opt_set_key_value = { + 'os_arch' => `arch`.chomp, + 'arch' => `arch`.chomp +} opt_cmdline_defaults = {} opt_output_dir = nil opt_auto_define_files = false -- 2.23.0
On Mon, Apr 12, 2021 at 02:49:39PM +0800, Cao Xueliang wrote:
pls, improve this patch in scheduler and don't use `arch`.chomp.
ok Thanks, Yinsi
Thanks, Xueliang
On Fri, Apr 09, 2021 at 08:05:03PM +0800, Liu Yinsi wrote:
before: submit host-info.yaml os_arch=x86_64 arch=x86_64 after : submit host-info.yaml
[why] when submit job in x86_64 machine, must execute like this: `submit host-info.yaml os_arch=x86_64 arch=x86_64`, then the job can be consumed by docker testbox, so add default values, it will be more convenient.
Signed-off-by: Liu Yinsi <liuyinsi@163.com> --- sbin/submit | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/sbin/submit b/sbin/submit index d2d9bec76..47b377001 100755 --- a/sbin/submit +++ b/sbin/submit @@ -10,7 +10,10 @@ require "#{LKP_SRC}/lib/scheduler_client" require 'optparse' require 'yaml'
-opt_set_key_value = {} +opt_set_key_value = { + 'os_arch' => `arch`.chomp, + 'arch' => `arch`.chomp +} opt_cmdline_defaults = {} opt_output_dir = nil opt_auto_define_files = false -- 2.23.0
require 'optparse' require 'yaml'
-opt_set_key_value = {} +opt_set_key_value = { + 'os_arch' => `arch`.chomp, + 'arch' => `arch`.chomp
you can set a variable standalone for the system's arch Thanks Luan Shengde
+} opt_cmdline_defaults = {} opt_output_dir = nil opt_auto_define_files = false -- 2.23.0
On Mon, Apr 12, 2021 at 04:08:13PM +0800, Luan Shengde wrote:
require 'optparse' require 'yaml'
-opt_set_key_value = {} +opt_set_key_value = { + 'os_arch' => `arch`.chomp, + 'arch' => `arch`.chomp
you can set a variable standalone for the system's arch
ok Thanks, Yinsi
Thanks Luan Shengde
+} opt_cmdline_defaults = {} opt_output_dir = nil opt_auto_define_files = false -- 2.23.0
participants (3)
-
Cao Xueliang -
Liu Yinsi -
Luan Shengde