[PATCH lkp-tests] tests/build-pkg: fix syntax errors caused by missing double quotes
error: PKGBUILD.src: line 2: syntax error near unexpected token `&' PKGBUILD.src: line 2: `glassfish-5.1.0.zip::http://www.eclipse.org/downloads/download.php?file=/glassfish/glassfish-5.1....' PKGBUILD.src: line 3: glassfish5.service: command not found PKGBUILD.src: line 4: syntax error near unexpected token `)' PKGBUILD.src: line 4: `)' Signed-off-by: Lin Jiaxin <ljx.joe@qq.com> --- tests/build-pkg | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/build-pkg b/tests/build-pkg index 8a138055..0b2794b1 100755 --- a/tests/build-pkg +++ b/tests/build-pkg @@ -112,7 +112,7 @@ replace_source() } url=$(echo "$url" | sed 's|https://|http://|g') - echo "$url" >> $1 + echo "\"$url\"" >> $1 done echo ")" >> $1 } -- 2.23.0
On Fri, Dec 11, 2020 at 12:10:32PM +0800, Lin Jiaxin wrote:
error: PKGBUILD.src: line 2: syntax error near unexpected token `&' PKGBUILD.src: line 2: `glassfish-5.1.0.zip::http://www.eclipse.org/downloads/download.php?file=/glassfish/glassfish-5.1....' PKGBUILD.src: line 3: glassfish5.service: command not found PKGBUILD.src: line 4: syntax error near unexpected token `)' PKGBUILD.src: line 4: `)'
Signed-off-by: Lin Jiaxin <ljx.joe@qq.com> --- tests/build-pkg | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/build-pkg b/tests/build-pkg index 8a138055..0b2794b1 100755 --- a/tests/build-pkg +++ b/tests/build-pkg @@ -112,7 +112,7 @@ replace_source() } url=$(echo "$url" | sed 's|https://|http://|g')
- echo "$url" >> $1 + echo "\"$url\"" >> $1
\'$url\' ? Thanks, Xueliang
done echo ")" >> $1 } -- 2.23.0
On Fri, Dec 11, 2020 at 03:01:54PM +0800, Ren Wen wrote:
- echo "$url" >> $1
+ echo "\"$url\"" >> $1
\'$url\' ?
Thanks, Xueliang
Sorry, I misunderstood it. Thanks, RenWen
$ echo "\"$PAGER\"" "less" $ echo "\'$PAGER\'" \'less\'
Two forms are different.
Thanks, RenWen
done echo ")" >> $1 } -- 2.23.0
participants (3)
-
Cao Xueliang -
Lin Jiaxin -
Ren Wen