[PATCH v3 compass-ci] container/srv-http: support display *.log file content in browser
[why] haven't define some file(*.log) behavior of browser in mime.types, so download this file on browser now. [how] 1. add correspondence of file in mime.types 2. set default type in default.conf of nginx, other type file that haven't define in mime.types, will display the file content in browser Signed-off-by: Lu Weitao <luweitaobe@163.com> --- container/srv-http/root/etc/nginx/conf.d/default.conf | 1 + container/srv-http/root/etc/nginx/mime.types | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/container/srv-http/root/etc/nginx/conf.d/default.conf b/container/srv-http/root/etc/nginx/conf.d/default.conf index 9c15d99..91371f1 100644 --- a/container/srv-http/root/etc/nginx/conf.d/default.conf +++ b/container/srv-http/root/etc/nginx/conf.d/default.conf @@ -13,6 +13,7 @@ server { } location / { + default_type text/html; autoindex on; autoindex_localtime on; allow all; diff --git a/container/srv-http/root/etc/nginx/mime.types b/container/srv-http/root/etc/nginx/mime.types index e7f2f1c..a4ee74b 100644 --- a/container/srv-http/root/etc/nginx/mime.types +++ b/container/srv-http/root/etc/nginx/mime.types @@ -4,8 +4,8 @@ types { text/css css; text/xml xml; text/yaml yaml; - text/plain txt time data sh; + text/plain txt time data sh log; application/json json; - application/x-gzip gz tgz; + application/x-gzip gz tgz cgz; } -- 2.23.0
On Fri, Nov 13, 2020 at 02:17:19PM +0800, Lu Weitao wrote:
[why] haven't define some file(*.log) behavior of browser in mime.types, so download this file on browser now.
You said in your last email that download before, don't download now. The 'now' in your log really confused me ~ I suggest the file will be download before. But we expect display it in browser directly Thanks, Yuanchao
On Fri, Nov 13, 2020 at 02:31:32PM +0800, Li Yuanchao wrote:
On Fri, Nov 13, 2020 at 02:17:19PM +0800, Lu Weitao wrote:
[why] haven't define some file(*.log) behavior of browser in mime.types, so download this file on browser now.
You said in your last email that download before, don't download now. The 'now' in your log really confused me ~
ok, how about delete "now", [why]... describle the behavior of file before this patch, and reason for why do this patch
I suggest
the file will be download before. But we expect display it in browser directly
ok Thanks, Weitao
Thanks, Yuanchao
On Fri, Nov 13, 2020 at 02:17:19PM +0800, Lu Weitao wrote:
[why] haven't define some file(*.log) behavior of browser in mime.types, so download this file on browser now.
[why] xxx add a tab may be better
[how] 1. add correspondence of file in mime.types
ditto Thanks, Shenwei
2. set default type in default.conf of nginx, other type file that haven't define in mime.types, will display the file content in browser
Signed-off-by: Lu Weitao <luweitaobe@163.com> --- container/srv-http/root/etc/nginx/conf.d/default.conf | 1 + container/srv-http/root/etc/nginx/mime.types | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/container/srv-http/root/etc/nginx/conf.d/default.conf b/container/srv-http/root/etc/nginx/conf.d/default.conf index 9c15d99..91371f1 100644 --- a/container/srv-http/root/etc/nginx/conf.d/default.conf +++ b/container/srv-http/root/etc/nginx/conf.d/default.conf @@ -13,6 +13,7 @@ server { }
location / { + default_type text/html; autoindex on; autoindex_localtime on; allow all; diff --git a/container/srv-http/root/etc/nginx/mime.types b/container/srv-http/root/etc/nginx/mime.types index e7f2f1c..a4ee74b 100644 --- a/container/srv-http/root/etc/nginx/mime.types +++ b/container/srv-http/root/etc/nginx/mime.types @@ -4,8 +4,8 @@ types { text/css css; text/xml xml; text/yaml yaml; - text/plain txt time data sh; + text/plain txt time data sh log;
application/json json; - application/x-gzip gz tgz; + application/x-gzip gz tgz cgz; } -- 2.23.0
On Fri, Nov 13, 2020 at 02:53:28PM +0800, Xiao Shenwei wrote:
On Fri, Nov 13, 2020 at 02:17:19PM +0800, Lu Weitao wrote:
[why] haven't define some file(*.log) behavior of browser in mime.types, so download this file on browser now.
[why] xxx
add a tab may be better
[how] 1. add correspondence of file in mime.types
just talked the indention after [how], in pervious this patch v2 Re: [PATCH v2 compass-ci] container/srv-http: support display *.log file in browser On Fri, Nov 13, 2020 at 02:07:21PM +0800, Lu Weitao wrote: >On Fri, Nov 13, 2020 at 11:28:14AM +0800, Wu Fengguang wrote: >>TO ALL >> >>On Fri, Nov 13, 2020 at 09:21:38AM +0800, Lu Weitao wrote: >>>[why] >> >>Don't indent below. >> so in future, we will write the [how] block without indention Thanks, Weitao
Thanks, Shenwei
2. set default type in default.conf of nginx, other type file that haven't define in mime.types, will display the file content in browser
Signed-off-by: Lu Weitao <luweitaobe@163.com> --- container/srv-http/root/etc/nginx/conf.d/default.conf | 1 + container/srv-http/root/etc/nginx/mime.types | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/container/srv-http/root/etc/nginx/conf.d/default.conf b/container/srv-http/root/etc/nginx/conf.d/default.conf index 9c15d99..91371f1 100644 --- a/container/srv-http/root/etc/nginx/conf.d/default.conf +++ b/container/srv-http/root/etc/nginx/conf.d/default.conf @@ -13,6 +13,7 @@ server { }
location / { + default_type text/html; autoindex on; autoindex_localtime on; allow all; diff --git a/container/srv-http/root/etc/nginx/mime.types b/container/srv-http/root/etc/nginx/mime.types index e7f2f1c..a4ee74b 100644 --- a/container/srv-http/root/etc/nginx/mime.types +++ b/container/srv-http/root/etc/nginx/mime.types @@ -4,8 +4,8 @@ types { text/css css; text/xml xml; text/yaml yaml; - text/plain txt time data sh; + text/plain txt time data sh log;
application/json json; - application/x-gzip gz tgz; + application/x-gzip gz tgz cgz; } -- 2.23.0
On Fri, Nov 13, 2020 at 03:24:15PM +0800, Lu Weitao wrote:
On Fri, Nov 13, 2020 at 02:53:28PM +0800, Xiao Shenwei wrote:
On Fri, Nov 13, 2020 at 02:17:19PM +0800, Lu Weitao wrote:
[why] haven't define some file(*.log) behavior of browser in mime.types, so download this file on browser now.
[why] xxx
add a tab may be better
[how] 1. add correspondence of file in mime.types
just talked the indention after [how], in pervious this patch v2
Re: [PATCH v2 compass-ci] container/srv-http: support display *.log file in browser
On Fri, Nov 13, 2020 at 02:07:21PM +0800, Lu Weitao wrote: >On Fri, Nov 13, 2020 at 11:28:14AM +0800, Wu Fengguang wrote: >>TO ALL >> >>On Fri, Nov 13, 2020 at 09:21:38AM +0800, Lu Weitao wrote: >>>[why] >> >>Don't indent below. >>
so in future, we will write the [how] block without indention
ok, Thanks, Shenwei
Thanks, Weitao
Thanks, Shenwei
2. set default type in default.conf of nginx, other type file that haven't define in mime.types, will display the file content in browser
Signed-off-by: Lu Weitao <luweitaobe@163.com> --- container/srv-http/root/etc/nginx/conf.d/default.conf | 1 + container/srv-http/root/etc/nginx/mime.types | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/container/srv-http/root/etc/nginx/conf.d/default.conf b/container/srv-http/root/etc/nginx/conf.d/default.conf index 9c15d99..91371f1 100644 --- a/container/srv-http/root/etc/nginx/conf.d/default.conf +++ b/container/srv-http/root/etc/nginx/conf.d/default.conf @@ -13,6 +13,7 @@ server { }
location / { + default_type text/html; autoindex on; autoindex_localtime on; allow all; diff --git a/container/srv-http/root/etc/nginx/mime.types b/container/srv-http/root/etc/nginx/mime.types index e7f2f1c..a4ee74b 100644 --- a/container/srv-http/root/etc/nginx/mime.types +++ b/container/srv-http/root/etc/nginx/mime.types @@ -4,8 +4,8 @@ types { text/css css; text/xml xml; text/yaml yaml; - text/plain txt time data sh; + text/plain txt time data sh log;
application/json json; - application/x-gzip gz tgz; + application/x-gzip gz tgz cgz; } -- 2.23.0
On Fri, Nov 13, 2020 at 02:17:19PM +0800, Lu Weitao wrote:
[why] haven't define some file(*.log) behavior of browser in mime.types, so download this file on browser now.
The first letter is required capitalized.
[how] 1. add correspondence of file in mime.types 2. set default type in default.conf of nginx, other type file that haven't define in mime.types, will display the file content in browser
ditto Thanks, Zhangyu
On Fri, Nov 13, 2020 at 03:00:53PM +0800, Zhang Yu wrote:
On Fri, Nov 13, 2020 at 02:17:19PM +0800, Lu Weitao wrote:
[why] haven't define some file(*.log) behavior of browser in mime.types, so download this file on browser now.
The first letter is required capitalized.
OK
[how] 1. add correspondence of file in mime.types 2. set default type in default.conf of nginx, other type file that haven't define in mime.types, will display the file content in browser
ditto
OK Thanks, Weitao
Thanks, Zhangyu
participants (4)
-
Li Yuanchao -
Lu Weitao -
Xiao Shenwei -
Zhang Yu