[PATCH v2 compass-ci 2/2] container/extract-stats prefix set lab in ENV
Signed-off-by: Lu Weitao <luweitaobe@163.com> --- container/extract-stats/start | 1 + 1 file changed, 1 insertion(+) diff --git a/container/extract-stats/start b/container/extract-stats/start index 25bdd25..6bb9f10 100755 --- a/container/extract-stats/start +++ b/container/extract-stats/start @@ -15,6 +15,7 @@ names = Set.new %w[ FLUENTD_PORT MAIL_HOST MAIL_PORT + LAB ] defaults = relevant_defaults(names) -- 2.23.0
Title can be improved. Thanks, Fengguang On Mon, Sep 28, 2020 at 05:28:51PM +0800, Lu Weitao wrote:
Signed-off-by: Lu Weitao <luweitaobe@163.com> --- container/extract-stats/start | 1 + 1 file changed, 1 insertion(+)
diff --git a/container/extract-stats/start b/container/extract-stats/start index 25bdd25..6bb9f10 100755 --- a/container/extract-stats/start +++ b/container/extract-stats/start @@ -15,6 +15,7 @@ names = Set.new %w[ FLUENTD_PORT MAIL_HOST MAIL_PORT + LAB ]
defaults = relevant_defaults(names) -- 2.23.0
On Mon, Sep 28, 2020 at 08:07:19PM +0800, Wu Fengguang wrote:
Title can be improved.
how about: container/extract-stats prefix: set 'LAB' as an environment variable Thanks, Weitao
Thanks, Fengguang
diff --git a/container/extract-stats/start b/container/extract-stats/start index 25bdd25..6bb9f10 100755 --- a/container/extract-stats/start +++ b/container/extract-stats/start @@ -15,6 +15,7 @@ names = Set.new %w[ FLUENTD_PORT MAIL_HOST MAIL_PORT + LAB ]
defaults = relevant_defaults(names) -- 2.23.0
On Tue, Sep 29, 2020 at 09:11:41AM +0800, Lu Weitao wrote:
On Mon, Sep 28, 2020 at 08:07:19PM +0800, Wu Fengguang wrote:
Title can be improved.
how about: container/extract-stats prefix: set 'LAB' as an environment variable
这个也不好，这个patch 就是增加一个环境变量。所以应该这样写： container/extract-stats prefix: add 'LAB' in environment variables Thanks, Weitao
Thanks, Fengguang
diff --git a/container/extract-stats/start b/container/extract-stats/start index 25bdd25..6bb9f10 100755 --- a/container/extract-stats/start +++ b/container/extract-stats/start @@ -15,6 +15,7 @@ names = Set.new %w[ FLUENTD_PORT MAIL_HOST MAIL_PORT + LAB ]
defaults = relevant_defaults(names) -- 2.23.0
这个也不好，这个patch 就是增加一个环境变量。所以应该这样写：
container/extract-stats prefix: add 'LAB' in environment variables
What is 'prefix'? Let's remove it? Thanks, Fengguang
diff --git a/container/extract-stats/start b/container/extract-stats/start index 25bdd25..6bb9f10 100755 --- a/container/extract-stats/start +++ b/container/extract-stats/start @@ -15,6 +15,7 @@ names = Set.new %w[ FLUENTD_PORT MAIL_HOST MAIL_PORT + LAB ]
defaults = relevant_defaults(names) -- 2.23.0
On Tue, Sep 29, 2020 at 10:57:54AM +0800, Wu Fengguang wrote:
这个也不好，这个patch 就是增加一个环境变量。所以应该这样写：
container/extract-stats prefix: add 'LAB' in environment variables
What is 'prefix'? Let's remove it?
'prefix' -- 想表达提前修复，不过这个词也不是这意思，以后不能这样用了。 remove 'prefix'， it's better! Thanks Weitao
Thanks, Fengguang
diff --git a/container/extract-stats/start b/container/extract-stats/start index 25bdd25..6bb9f10 100755 --- a/container/extract-stats/start +++ b/container/extract-stats/start @@ -15,6 +15,7 @@ names = Set.new %w[ FLUENTD_PORT MAIL_HOST MAIL_PORT + LAB ]
defaults = relevant_defaults(names) -- 2.23.0
participants (2)
-
Lu Weitao -
Wu Fengguang