[PATCH compass-ci] scheduler: fix condition when setting default queue
Hash.*has_key?* returns true although there is no value of the key. Signed-off-by: Ren Wen <15991987063@163.com> --- src/lib/job.cr | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/job.cr b/src/lib/job.cr index e836d1f..55bac7f 100644 --- a/src/lib/job.cr +++ b/src/lib/job.cr @@ -247,7 +247,7 @@ class Job end private def set_queue - return if @hash.has_key?("queue") + return unless self["queue"].empty? # set default value self["queue"] = tbox_group -- 2.23.0
On Fri, Nov 27, 2020 at 07:48:26PM +0800, Ren Wen wrote:
Hash.*has_key?* returns true although there is no value of the key.
have error message? if queue field not exist @hash.has_key?("queue") will return false, why do this change Thanks, Shenwei
Signed-off-by: Ren Wen <15991987063@163.com> --- src/lib/job.cr | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/lib/job.cr b/src/lib/job.cr index e836d1f..55bac7f 100644 --- a/src/lib/job.cr +++ b/src/lib/job.cr @@ -247,7 +247,7 @@ class Job end
private def set_queue - return if @hash.has_key?("queue") + return unless self["queue"].empty?
# set default value self["queue"] = tbox_group -- 2.23.0
On Sat, Nov 28, 2020 at 09:03:48AM +0800, Xiao Shenwei wrote:
On Fri, Nov 27, 2020 at 07:48:26PM +0800, Ren Wen wrote:
Hash.*has_key?* returns true although there is no value of the key.
have error message?
if queue field not exist @hash.has_key?("queue") will return false, why do this change
even if the hash has the key, but the key may has empty value '', Thanks, Luan Shengde
Thanks, Shenwei
Signed-off-by: Ren Wen <15991987063@163.com> --- src/lib/job.cr | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/lib/job.cr b/src/lib/job.cr index e836d1f..55bac7f 100644 --- a/src/lib/job.cr +++ b/src/lib/job.cr @@ -247,7 +247,7 @@ class Job end
private def set_queue - return if @hash.has_key?("queue") + return unless self["queue"].empty?
# set default value self["queue"] = tbox_group -- 2.23.0
On Sat, Nov 28, 2020 at 09:19:23AM +0800, Luan Shengde wrote:
On Sat, Nov 28, 2020 at 09:03:48AM +0800, Xiao Shenwei wrote:
On Fri, Nov 27, 2020 at 07:48:26PM +0800, Ren Wen wrote:
Hash.*has_key?* returns true although there is no value of the key.
have error message?
if queue field not exist @hash.has_key?("queue") will return false, why do this change
even if the hash has the key, but the key may has empty value '',
if define queue field in your yaml, and queue: this case? Thanks, Shenwei
Thanks, Luan Shengde
Thanks, Shenwei
Signed-off-by: Ren Wen <15991987063@163.com> --- src/lib/job.cr | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/lib/job.cr b/src/lib/job.cr index e836d1f..55bac7f 100644 --- a/src/lib/job.cr +++ b/src/lib/job.cr @@ -247,7 +247,7 @@ class Job end
private def set_queue - return if @hash.has_key?("queue") + return unless self["queue"].empty?
# set default value self["queue"] = tbox_group -- 2.23.0
participants (3)
-
Luan Shengde -
Ren Wen -
Xiao Shenwei