[PATCH lkp-tests] lib/bootstrap: fix failed to get MAC and IP
[error] LKP: HOSTNAME vm-8p64g.2288hv5-2s44p-384g--b5-3554212, MAC , IP , kernel 5.9.0-5-riscv64 1, serial console /dev/ttyS0 [ 75.489958] Kernel tests: Boot OK! ... [ 82.149060] sysrq: Resetting [why] check network ok or not by checking network adapter is not accurate, use ping ip more accurate. Signed-off-by: Liu Yinsi <liuyinsi@163.com> --- lib/bootstrap.sh | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/lib/bootstrap.sh b/lib/bootstrap.sh index d4b41f3bd..b7795b40a 100755 --- a/lib/bootstrap.sh +++ b/lib/bootstrap.sh @@ -87,13 +87,7 @@ net_devices_link() network_ok() { - local i - for i in /sys/class/net/*/ - do - [ "${i#*/lo/}" != "$i" ] && continue - [ "$(cat $i/operstate)" = 'up' ] && return 0 - [ "$(cat $i/carrier 2>/dev/null)" = '1' ] && return 0 - done + ping -c 3 $LKP_SERVER | grep -q ttl && return 0 is_clearlinux && { net_devices_link up -- 2.23.0
TO ALL. We need be very careful changing these fundamental lib/ functions. Every patch should give a clear and solid reason. Reasons like "it works for me" is not enough. We need find out and document the exact root cause. That's the only way to a solid solution. On Thu, Jan 07, 2021 at 11:11:14AM +0800, Liu Yinsi wrote:
[error] LKP: HOSTNAME vm-8p64g.2288hv5-2s44p-384g--b5-3554212, MAC , IP , kernel 5.9.0-5-riscv64 1, serial console /dev/ttyS0 [ 75.489958] Kernel tests: Boot OK! ... [ 82.149060] sysrq: Resetting
[why] check network ok or not by checking network adapter is not accurate, use ping ip more accurate.
Why it's not accurate? Please give an exact reason. E.g. what's the exact status of the net interfaces. How exactly the old tests go wrong. Thanks, Fengguang
Signed-off-by: Liu Yinsi <liuyinsi@163.com> --- lib/bootstrap.sh | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/lib/bootstrap.sh b/lib/bootstrap.sh index d4b41f3bd..b7795b40a 100755 --- a/lib/bootstrap.sh +++ b/lib/bootstrap.sh @@ -87,13 +87,7 @@ net_devices_link()
network_ok() { - local i - for i in /sys/class/net/*/ - do - [ "${i#*/lo/}" != "$i" ] && continue - [ "$(cat $i/operstate)" = 'up' ] && return 0 - [ "$(cat $i/carrier 2>/dev/null)" = '1' ] && return 0 - done + ping -c 3 $LKP_SERVER | grep -q ttl && return 0
is_clearlinux && { net_devices_link up -- 2.23.0
On Fri, Jan 08, 2021 at 10:40:40AM +0800, Wu Fengguang wrote:
TO ALL.
We need be very careful changing these fundamental lib/ functions. Every patch should give a clear and solid reason.
Reasons like "it works for me" is not enough. We need find out and document the exact root cause. That's the only way to a solid solution.
On Thu, Jan 07, 2021 at 11:11:14AM +0800, Liu Yinsi wrote:
[error] LKP: HOSTNAME vm-8p64g.2288hv5-2s44p-384g--b5-3554212, MAC , IP , kernel 5.9.0-5-riscv64 1, serial console /dev/ttyS0 [ 75.489958] Kernel tests: Boot OK! ... [ 82.149060] sysrq: Resetting
[why] check network ok or not by checking network adapter is not accurate, use ping ip more accurate.
Why it's not accurate? Please give an exact reason. E.g. what's the exact status of the net interfaces. How exactly the old tests go wrong.
ok, got it. Thanks, Yinsi
Thanks, Fengguang
Signed-off-by: Liu Yinsi <liuyinsi@163.com> --- lib/bootstrap.sh | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/lib/bootstrap.sh b/lib/bootstrap.sh index d4b41f3bd..b7795b40a 100755 --- a/lib/bootstrap.sh +++ b/lib/bootstrap.sh @@ -87,13 +87,7 @@ net_devices_link()
network_ok() { - local i - for i in /sys/class/net/*/ - do - [ "${i#*/lo/}" != "$i" ] && continue - [ "$(cat $i/operstate)" = 'up' ] && return 0 - [ "$(cat $i/carrier 2>/dev/null)" = '1' ] && return 0 - done + ping -c 3 $LKP_SERVER | grep -q ttl && return 0
is_clearlinux && { net_devices_link up -- 2.23.0
participants (2)
-
Liu Yinsi -
Wu Fengguang