[PATCH v8 compass-ci 1/3] assign-account: add check my info
check my_info when assigning account [why] my_info is required when assigning account. my_info is used to config the default yaml file [how] add check my_info before assign new account my_info: - my_email - my_name - my_uuid Signed-off-by: Luan Shengde <shdluan@163.com> --- container/assign-account/assign-account.rb | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/container/assign-account/assign-account.rb b/container/assign-account/assign-account.rb index e356c18..452a284 100755 --- a/container/assign-account/assign-account.rb +++ b/container/assign-account/assign-account.rb @@ -7,7 +7,7 @@ require 'sinatra' require 'open3' require 'json' require 'yaml' -require_relative 'get_account_info.rb' +require_relative 'get_account_info' set :bind, '0.0.0.0' set :port, 29999 @@ -17,8 +17,17 @@ get '/assign_account' do data = YAML.safe_load request.body.read rescue StandardError => e puts e.message + puts e.backtrace end + return_assign_jumper_account(data) +end + +def return_assign_jumper_account(data) + lacked_info = %w[my_email my_name my_uuid] - data.keys + error_message = "lack of my infos: #{lacked_info.join(', ')}." + raise error_message unless lacked_info.empty? + ref_account_info = AccountStorage.new(data) account_info = ref_account_info.setup_jumper_account_info -- 2.23.0
On Mon, Nov 09, 2020 at 11:25:28AM +0800, Luan Shengde wrote:
check my_info when assigning account
[why] my_info is required when assigning account. my_info is used to config the default yaml file
[how] add check my_info before assign new account my_info: - my_email - my_name - my_uuid
Signed-off-by: Luan Shengde <shdluan@163.com> --- container/assign-account/assign-account.rb | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/container/assign-account/assign-account.rb b/container/assign-account/assign-account.rb index e356c18..452a284 100755 --- a/container/assign-account/assign-account.rb +++ b/container/assign-account/assign-account.rb @@ -7,7 +7,7 @@ require 'sinatra' require 'open3' require 'json' require 'yaml' -require_relative 'get_account_info.rb' +require_relative 'get_account_info'
set :bind, '0.0.0.0' set :port, 29999 @@ -17,8 +17,17 @@ get '/assign_account' do data = YAML.safe_load request.body.read rescue StandardError => e puts e.message + puts e.backtrace end
+ return_assign_jumper_account(data) +end + +def return_assign_jumper_account(data)
Every function you call will return something even return nil. Thanks, Xueliang
+ lacked_info = %w[my_email my_name my_uuid] - data.keys + error_message = "lack of my infos: #{lacked_info.join(', ')}." + raise error_message unless lacked_info.empty? + ref_account_info = AccountStorage.new(data) account_info = ref_account_info.setup_jumper_account_info
-- 2.23.0
On Mon, Nov 09, 2020 at 06:46:19PM +0800, Cao Xueliang wrote:
On Mon, Nov 09, 2020 at 11:25:28AM +0800, Luan Shengde wrote:
check my_info when assigning account
[why] my_info is required when assigning account. my_info is used to config the default yaml file
[how] add check my_info before assign new account my_info: - my_email - my_name - my_uuid
Signed-off-by: Luan Shengde <shdluan@163.com> --- container/assign-account/assign-account.rb | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/container/assign-account/assign-account.rb b/container/assign-account/assign-account.rb index e356c18..452a284 100755 --- a/container/assign-account/assign-account.rb +++ b/container/assign-account/assign-account.rb @@ -7,7 +7,7 @@ require 'sinatra' require 'open3' require 'json' require 'yaml' -require_relative 'get_account_info.rb' +require_relative 'get_account_info'
set :bind, '0.0.0.0' set :port, 29999 @@ -17,8 +17,17 @@ get '/assign_account' do data = YAML.safe_load request.body.read rescue StandardError => e puts e.message + puts e.backtrace end
+ return_assign_jumper_account(data) +end + +def return_assign_jumper_account(data)
Every function you call will return something even return nil.
I have fixed it Thanks, Luan Shengde
Thanks, Xueliang
+ lacked_info = %w[my_email my_name my_uuid] - data.keys + error_message = "lack of my infos: #{lacked_info.join(', ')}." + raise error_message unless lacked_info.empty? + ref_account_info = AccountStorage.new(data) account_info = ref_account_info.setup_jumper_account_info
-- 2.23.0
participants (2)
-
Cao Xueliang -
Luan Shengde