[PATCH v2 compass-ci] docker-rootfs/common: add comment for set password file.
[Why] add password file is easy to ignore. Signed-off-by: Wang Chenglong <18509160991@163.com> --- container/docker-rootfs/common | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/container/docker-rootfs/common b/container/docker-rootfs/common index fe37da9..2ee16c8 100755 --- a/container/docker-rootfs/common +++ b/container/docker-rootfs/common @@ -33,7 +33,8 @@ usage() dst_rootfs_new_abspath: destination absolute path to create for rootfs Example: - ./run /tmp/openEuler-docker/openEuler-docker.${aarch}.tar.xz /tmp/openeuler-rootfs/ + ./run /tmp/openEuler-docker/openEuler-docker.${aarch}.tar.xz /tmp/openeuler-rootfs/ + # please ensure $HOME/.config/compass-ci/rootfs-passwd exists " } -- 2.23.0
how about tool name docker2rootfs Thanks, Yinsi On Wed, Dec 30, 2020 at 10:13:16AM +0800, Wang Chenglong wrote:
[Why] add password file is easy to ignore.
Signed-off-by: Wang Chenglong <18509160991@163.com> --- container/docker-rootfs/common | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/container/docker-rootfs/common b/container/docker-rootfs/common index fe37da9..2ee16c8 100755 --- a/container/docker-rootfs/common +++ b/container/docker-rootfs/common @@ -33,7 +33,8 @@ usage() dst_rootfs_new_abspath: destination absolute path to create for rootfs
Example: - ./run /tmp/openEuler-docker/openEuler-docker.${aarch}.tar.xz /tmp/openeuler-rootfs/ + ./run /tmp/openEuler-docker/openEuler-docker.${aarch}.tar.xz /tmp/openeuler-rootfs/ + # please ensure $HOME/.config/compass-ci/rootfs-passwd exists " }
-- 2.23.0
On Wed, Dec 30, 2020 at 10:23:11AM +0800, Liu Yinsi wrote:
how about tool name docker2rootfs
keep same style with qcow2rootfs
Thanks, Yinsi
On Wed, Dec 30, 2020 at 10:13:16AM +0800, Wang Chenglong wrote:
[Why] add password file is easy to ignore.
Signed-off-by: Wang Chenglong <18509160991@163.com> --- container/docker-rootfs/common | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/container/docker-rootfs/common b/container/docker-rootfs/common index fe37da9..2ee16c8 100755 --- a/container/docker-rootfs/common +++ b/container/docker-rootfs/common @@ -33,7 +33,8 @@ usage() dst_rootfs_new_abspath: destination absolute path to create for rootfs
Example: - ./run /tmp/openEuler-docker/openEuler-docker.${aarch}.tar.xz /tmp/openeuler-rootfs/ + ./run /tmp/openEuler-docker/openEuler-docker.${aarch}.tar.xz /tmp/openeuler-rootfs/ + # please ensure $HOME/.config/compass-ci/rootfs-passwd exists " }
-- 2.23.0
On Wed, Dec 30, 2020 at 10:24:35AM +0800, Liu Yinsi wrote:
On Wed, Dec 30, 2020 at 10:23:11AM +0800, Liu Yinsi wrote:
how about tool name docker2rootfs
keep same style with qcow2rootfs
Good idea. Thanks, Chenglong
Thanks, Yinsi
On Wed, Dec 30, 2020 at 10:13:16AM +0800, Wang Chenglong wrote:
[Why] add password file is easy to ignore.
Signed-off-by: Wang Chenglong <18509160991@163.com> --- container/docker-rootfs/common | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/container/docker-rootfs/common b/container/docker-rootfs/common index fe37da9..2ee16c8 100755 --- a/container/docker-rootfs/common +++ b/container/docker-rootfs/common @@ -33,7 +33,8 @@ usage() dst_rootfs_new_abspath: destination absolute path to create for rootfs
Example: - ./run /tmp/openEuler-docker/openEuler-docker.${aarch}.tar.xz /tmp/openeuler-rootfs/ + ./run /tmp/openEuler-docker/openEuler-docker.${aarch}.tar.xz /tmp/openeuler-rootfs/ + # please ensure $HOME/.config/compass-ci/rootfs-passwd exists " }
-- 2.23.0
在文件*common*中, 混用了<TAB>和<SPC>, 呈现出了不一致的效果. 在vim中, 一个<TAB>默认8个空格(根据文件类型有所改变), 但并不会将<TAB>转化为<SPC>. 使用命令行模式 `:set tabstop=4` 可以查看不一致的地方. Thanks, RenWen On Wed, Dec 30, 2020 at 10:13:16AM +0800, Wang Chenglong wrote:
[Why] add password file is easy to ignore.
Signed-off-by: Wang Chenglong <18509160991@163.com> --- container/docker-rootfs/common | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/container/docker-rootfs/common b/container/docker-rootfs/common index fe37da9..2ee16c8 100755 --- a/container/docker-rootfs/common +++ b/container/docker-rootfs/common @@ -33,7 +33,8 @@ usage() dst_rootfs_new_abspath: destination absolute path to create for rootfs
Example: - ./run /tmp/openEuler-docker/openEuler-docker.${aarch}.tar.xz /tmp/openeuler-rootfs/ + ./run /tmp/openEuler-docker/openEuler-docker.${aarch}.tar.xz /tmp/openeuler-rootfs/ + # please ensure $HOME/.config/compass-ci/rootfs-passwd exists " }
-- 2.23.0
participants (3)
-
Liu Yinsi -
Ren Wen -
Wang Chenglong