[PATCH compass-ci] kernel_params.cr: add sched_steal_node_limit=8 when test mysql optimization kernel
[why] When test the kernel with mysql optimization, the parameter "sched_steal_node_limit=8" is required to be added into kernel params. Signed-off-by: Xu Xijian <hdxuxijian@163.com> --- src/scheduler/kernel_params.cr | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/scheduler/kernel_params.cr b/src/scheduler/kernel_params.cr index 54438b5..546f012 100644 --- a/src/scheduler/kernel_params.cr +++ b/src/scheduler/kernel_params.cr @@ -31,6 +31,9 @@ class Job private def set_kernel_params self["kernel_params"] = " #{kernel_common_params()} #{kernel_append_root} #{kernel_console()}" + if "#{linux_vmlinuz_path}".includes?("mysql") + self["kernel_params"] += " sched_steal_node_limit=8" + end end end -- 2.23.0
On Wed, Nov 04, 2020 at 10:59:48AM +0800, Xu Xijian wrote:
[why] When test the kernel with mysql optimization, the parameter "sched_steal_node_limit=8" is required to be added into kernel params.
Signed-off-by: Xu Xijian <hdxuxijian@163.com> --- src/scheduler/kernel_params.cr | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/src/scheduler/kernel_params.cr b/src/scheduler/kernel_params.cr index 54438b5..546f012 100644 --- a/src/scheduler/kernel_params.cr +++ b/src/scheduler/kernel_params.cr @@ -31,6 +31,9 @@ class Job
private def set_kernel_params self["kernel_params"] = " #{kernel_common_params()} #{kernel_append_root} #{kernel_console()}" + if "#{linux_vmlinuz_path}".includes?("mysql") + self["kernel_params"] += " sched_steal_node_limit=8" + end
I think is should add a field like sub_kernel_params in job yaml, then we can add it to the kernel_params. Thanks, Xueliang
end
end -- 2.23.0
On Wed, Nov 04, 2020 at 03:40:59PM +0800, Cao Xueliang wrote:
On Wed, Nov 04, 2020 at 10:59:48AM +0800, Xu Xijian wrote:
[why] When test the kernel with mysql optimization, the parameter "sched_steal_node_limit=8" is required to be added into kernel params.
Signed-off-by: Xu Xijian <hdxuxijian@163.com> --- src/scheduler/kernel_params.cr | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/src/scheduler/kernel_params.cr b/src/scheduler/kernel_params.cr index 54438b5..546f012 100644 --- a/src/scheduler/kernel_params.cr +++ b/src/scheduler/kernel_params.cr @@ -31,6 +31,9 @@ class Job
private def set_kernel_params self["kernel_params"] = " #{kernel_common_params()} #{kernel_append_root} #{kernel_console()}" + if "#{linux_vmlinuz_path}".includes?("mysql") + self["kernel_params"] += " sched_steal_node_limit=8" + end
I think is should add a field like sub_kernel_params in job yaml, then we can add it to the kernel_params.
Thanks, Xueliang
Ok. Thanks, Xijian
This is ugly. What's the job file? Please add 'kernel_params: xxx' to job.yaml instead. Or better, add to include/ Thanks, Fengguang On Wed, Nov 04, 2020 at 10:59:48AM +0800, Xu Xijian wrote:
[why] When test the kernel with mysql optimization, the parameter "sched_steal_node_limit=8" is required to be added into kernel params.
Signed-off-by: Xu Xijian <hdxuxijian@163.com> --- src/scheduler/kernel_params.cr | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/src/scheduler/kernel_params.cr b/src/scheduler/kernel_params.cr index 54438b5..546f012 100644 --- a/src/scheduler/kernel_params.cr +++ b/src/scheduler/kernel_params.cr @@ -31,6 +31,9 @@ class Job
private def set_kernel_params self["kernel_params"] = " #{kernel_common_params()} #{kernel_append_root} #{kernel_console()}" + if "#{linux_vmlinuz_path}".includes?("mysql") + self["kernel_params"] += " sched_steal_node_limit=8" + end end
end -- 2.23.0
participants (3)
-
Cao Xueliang -
Wu Fengguang -
Xu Xijian