[PATCH compass-ci] container/redis: use echo "xxx" for safety reason

before: echo you can use cmd: redis-cli to start a redis client echo and then use cmd: keys * after: echo "you can use cmd: redis-cli to start a redis client" echo "and then use cmd: keys *" [why] when use echo $string, if $string include '*', will be parsed, just like: root@test-lys /c/compass-ci/container/redis# ./start ... and then use cmd: keys build Dockerfile start Signed-off-by: Liu Yinsi <liuyinsi@163.com> --- container/redis/start | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/container/redis/start b/container/redis/start index 34266a0..4611fe4 100755 --- a/container/redis/start +++ b/container/redis/start @@ -24,6 +24,6 @@ cmd=( "${cmd[@]}" # test -echo you can use cmd: redis-cli to start a redis client -echo and then use cmd: keys * +echo "you can use cmd: redis-cli to start a redis client" +echo "and then use cmd: keys *" -- 2.23.0

On Thu, Feb 04, 2021 at 11:25:17AM +0800, Liu Yinsi wrote:
before: echo you can use cmd: redis-cli to start a redis client echo and then use cmd: keys *
after: echo "you can use cmd: redis-cli to start a redis client" echo "and then use cmd: keys *"
[why] when use echo $string, if $string include '*', will be parsed, just like: root@test-lys /c/compass-ci/container/redis# ./start ... and then use cmd: keys build Dockerfile start
Signed-off-by: Liu Yinsi <liuyinsi@163.com> --- container/redis/start | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/container/redis/start b/container/redis/start index 34266a0..4611fe4 100755 --- a/container/redis/start +++ b/container/redis/start @@ -24,6 +24,6 @@ cmd=( "${cmd[@]}"
# test -echo you can use cmd: redis-cli to start a redis client -echo and then use cmd: keys * +echo "you can use cmd: redis-cli to start a redis client"
you can start a redis client use cmd: redis-cli
+echo "and then use cmd: keys *"
Or we can delete these echo, that looks like unnecessary. Thanks, Xueliang
-- 2.23.0

diff --git a/container/redis/start b/container/redis/start index 34266a0..4611fe4 100755 --- a/container/redis/start +++ b/container/redis/start @@ -24,6 +24,6 @@ cmd=( "${cmd[@]}"
# test -echo you can use cmd: redis-cli to start a redis client -echo and then use cmd: keys * +echo "you can use cmd: redis-cli to start a redis client"
you can start a redis client use cmd: redis-cli
+echo "and then use cmd: keys *"
Or we can delete these echo, that looks like unnecessary.
good Thanks, Yinsi
Thanks, Xueliang
-- 2.23.0
participants (2)
-
Cao Xueliang
-
Liu Yinsi