Currently pad refcnt will be added when creating qp/cq/srq, but it is not checked when freeing pad. Add a check to prevent freeing pad when it is still used by any qp/cq/srq. Fixes: ae35032532fb ("libhns: Add support for thread domain and parent domain") Signed-off-by: Junxian Huang <huangjunxian6@hisilicon.com> --- providers/hns/hns_roce_u_verbs.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/providers/hns/hns_roce_u_verbs.c b/providers/hns/hns_roce_u_verbs.c index 62d42c98e..05d5b2d34 100644 --- a/providers/hns/hns_roce_u_verbs.c +++ b/providers/hns/hns_roce_u_verbs.c @@ -208,14 +208,18 @@ struct ibv_pd *hns_roce_u_alloc_pad(struct ibv_context *context, return &pad->pd.ibv_pd; } -static void hns_roce_free_pad(struct hns_roce_pad *pad) +static int hns_roce_free_pad(struct hns_roce_pad *pad) { + if (atomic_load(&pad->pd.refcount) > 1) + return EBUSY; + atomic_fetch_sub(&pad->pd.protection_domain->refcount, 1); if (pad->td) atomic_fetch_sub(&pad->td->refcount, 1); free(pad); + return 0; } static int hns_roce_free_pd(struct hns_roce_pd *pd) @@ -238,10 +242,8 @@ int hns_roce_u_dealloc_pd(struct ibv_pd *ibv_pd) struct hns_roce_pad *pad = to_hr_pad(ibv_pd); struct hns_roce_pd *pd = to_hr_pd(ibv_pd); - if (pad) { - hns_roce_free_pad(pad); - return 0; - } + if (pad) + return hns_roce_free_pad(pad); return hns_roce_free_pd(pd); } -- 2.33.0