From: Yifan Wu <wuyifan50@huawei.com> driver inclusion category: bugfix bugzilla: https://gitee.com/openeuler/kernel/issues/IDBQ74 ---------------------------------------------------------------------- The cpuhp_remove_multi_state was called with CPUHP_AP_ONLINE_DYN instead of the dynamically allocated hisi_l3c_cpuhp_state. This may lead to improper CPU hotplug state removal. Fixes: e6ecc3b028b8 ("soc cache: Add framework driver for HiSilicon SoC cache") Signed-off-by: Yifan Wu <wuyifan50@huawei.com> Signed-off-by: Yushan Wang <wangyushan12@huawei.com> Signed-off-by: Hongye Lin <linhongye@h-partners.com> --- drivers/soc/hisilicon/hisi_soc_l3c.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/soc/hisilicon/hisi_soc_l3c.c b/drivers/soc/hisilicon/hisi_soc_l3c.c index a5a8ac6baeb0..e0bf6cc5b47d 100644 --- a/drivers/soc/hisilicon/hisi_soc_l3c.c +++ b/drivers/soc/hisilicon/hisi_soc_l3c.c @@ -592,7 +592,7 @@ static int __init hisi_soc_l3c_init(void) ret = platform_driver_register(&hisi_soc_l3c_driver); if (ret) - cpuhp_remove_multi_state(CPUHP_AP_ONLINE_DYN); + cpuhp_remove_multi_state(hisi_l3c_cpuhp_state); return ret; } @@ -601,7 +601,7 @@ module_init(hisi_soc_l3c_init); static void __exit hisi_soc_l3c_exit(void) { platform_driver_unregister(&hisi_soc_l3c_driver); - cpuhp_remove_multi_state(CPUHP_AP_ONLINE_DYN); + cpuhp_remove_multi_state(hisi_l3c_cpuhp_state); } module_exit(hisi_soc_l3c_exit); -- 2.33.0