From: Yuyu Li <liyuyu6@huawei.com> driver inclusion category: bugfix bugzilla: https://gitee.com/openeuler/kernel/issues/IBQK42 ---------------------------------------------------------------------- Fix ifnullfree static warning: NULL check before some freeing functions is not needed. Fixes: 21cacb516f20 ("RDMA/hns: Support write with notify") Signed-off-by: Yuyu Li <liyuyu6@huawei.com> Signed-off-by: Xinghai Cen <cenxinghai@h-partners.com> --- drivers/infiniband/hw/hns/hns_roce_ext.c | 3 +-- drivers/infiniband/hw/hns/hns_roce_main.c | 4 ++-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/infiniband/hw/hns/hns_roce_ext.c b/drivers/infiniband/hw/hns/hns_roce_ext.c index 63d0a48abe71..1faa23702d92 100644 --- a/drivers/infiniband/hw/hns/hns_roce_ext.c +++ b/drivers/infiniband/hw/hns/hns_roce_ext.c @@ -133,8 +133,7 @@ int rdma_unregister_notify_addr(struct ib_device *ib_dev) if (!is_hns_roce(ib_dev) || !is_write_notify_supported(hr_dev)) return -EOPNOTSUPP; - if (hr_dev->notify_tbl) - kvfree(hr_dev->notify_tbl); + kvfree(hr_dev->notify_tbl); hr_dev->notify_tbl = NULL; diff --git a/drivers/infiniband/hw/hns/hns_roce_main.c b/drivers/infiniband/hw/hns/hns_roce_main.c index f982b59a668a..13cace92f7ff 100644 --- a/drivers/infiniband/hw/hns/hns_roce_main.c +++ b/drivers/infiniband/hw/hns/hns_roce_main.c @@ -1607,8 +1607,8 @@ void hns_roce_exit(struct hns_roce_dev *hr_dev, bool bond_cleanup) if (hr_dev->hw->cmq_exit) hr_dev->hw->cmq_exit(hr_dev); hns_roce_dealloc_dfx_cnt(hr_dev); - if (hr_dev->notify_tbl) - kvfree(hr_dev->notify_tbl); + + kvfree(hr_dev->notify_tbl); } MODULE_LICENSE("Dual BSD/GPL"); -- 2.33.0