[openeuler:OLK-6.6 3547/3547] drivers/net/ethernet/huawei/hinic3/hinic3_ethtool.c:823:5: warning: no previous prototype for 'hinic3_set_rxq_recovery_flag'

21 Dec 2025

      Hi Zhou,

FYI, the error/warning still remains.

tree:   https://gitee.com/openeuler/kernel.git OLK-6.6
head:   04473ee9ed912a16fff0d8846ad565bbf3d63c77
commit: dcb286ce50a35a77e51b61db72c7cc001647b598 [3547/3547] net/hinic3: add huawei/hinic3 driver
config: arm64-randconfig-003-20251216 (https://download.01.org/0day-ci/archive/20251221/202512210010.kLb4fmr8-lkp@i...)
compiler: aarch64-linux-gcc (GCC) 10.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251221/202512210010.kLb4fmr8-lkp@i...)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202512210010.kLb4fmr8-lkp@intel.com/

All warnings (new ones prefixed by >>):
...
...
drivers/net/ethernet/huawei/hinic3/hinic3_ethtool.c:823:5: warning: no previous prototype for 'hinic3_set_rxq_recovery_flag' [-Wmissing-prototypes]
     823 | int hinic3_set_rxq_recovery_flag(struct net_device *netdev, u32 priv_flags)
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/hinic3_set_rxq_recovery_flag +823 drivers/net/ethernet/huawei/hinic3/hinic3_ethtool.c

   822
...
823	int hinic3_set_rxq_recovery_flag(struct net_device *netdev, u32 priv_flags)
   824	{
   825		struct hinic3_nic_dev *nic_dev = netdev_priv(netdev);
   826	
   827		if (priv_flags & HINIC3_PRIV_FLAGS_RXQ_RECOVERY) {
   828			if (!HINIC3_SUPPORT_RXQ_RECOVERY(nic_dev->hwdev)) {
   829				nicif_info(nic_dev, drv, netdev, "Unsupport open rxq recovery\n");
   830				return -EOPNOTSUPP;
   831			}
   832	
   833			if (test_and_set_bit(HINIC3_RXQ_RECOVERY, &nic_dev->flags))
   834				return 0;
   835			queue_delayed_work(nic_dev->workq, &nic_dev->rxq_check_work, HZ);
   836			nicif_info(nic_dev, drv, netdev, "open rxq recovery\n");
   837		} else {
   838			if (!test_and_clear_bit(HINIC3_RXQ_RECOVERY, &nic_dev->flags))
   839				return 0;
   840			cancel_delayed_work_sync(&nic_dev->rxq_check_work);
   841			nicif_info(nic_dev, drv, netdev, "close rxq recovery\n");
   842		}
   843	
   844		return 0;
   845	}
   846
-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

kernel test robot

tags

participants (1)