[openeuler:OLK-6.6 2687/2687] drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_ethtool.c:299:21: warning: variable 'netdev' set but not used
Hi Bennie, FYI, the error/warning still remains. tree: https://gitee.com/openeuler/kernel.git OLK-6.6 head: dc90c923fed4944f134644261022885c12631518 commit: 2d861e6888256771288076b36aa9beba46c7af67 [2687/2687] Net: nebula_matrix: fix ci compile nbl_ethtool.c warning config: x86_64-buildonly-randconfig-2002-20250818 (https://download.01.org/0day-ci/archive/20250818/202508181604.dgmSZq8P-lkp@i...) compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250818/202508181604.dgmSZq8P-lkp@i...) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202508181604.dgmSZq8P-lkp@intel.com/ All warnings (new ones prefixed by >>): In file included from drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_ethtool.c:7: In file included from drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_ethtool.h:10: In file included from drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_service.h:10: In file included from include/linux/mm.h:2247: include/linux/vmstat.h:522:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion] 522 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_" | ~~~~~~~~~~~ ^ ~~~
drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_ethtool.c:299:21: warning: variable 'netdev' set but not used [-Wunused-but-set-variable] 299 | struct net_device *netdev; | ^ drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_ethtool.c:1666:36: warning: variable 'net_resource_mgt' set but not used [-Wunused-but-set-variable] 1666 | struct nbl_serv_net_resource_mgt *net_resource_mgt; | ^ 3 warnings generated.
vim +/netdev +299 drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_ethtool.c bad535d287c9c1 Bennie Yan 2024-09-24 293 2d861e68882567 Bennie Yan 2024-11-19 294 static void nbl_serv_adjust_interrpt_param(struct nbl_service_mgt *serv_mgt, bool ethtool) bad535d287c9c1 Bennie Yan 2024-09-24 295 { bad535d287c9c1 Bennie Yan 2024-09-24 296 struct nbl_serv_net_resource_mgt *net_resource_mgt; bad535d287c9c1 Bennie Yan 2024-09-24 297 struct nbl_serv_ring_mgt *ring_mgt; bad535d287c9c1 Bennie Yan 2024-09-24 298 struct nbl_dispatch_ops *disp_ops; bad535d287c9c1 Bennie Yan 2024-09-24 @299 struct net_device *netdev; bad535d287c9c1 Bennie Yan 2024-09-24 300 struct nbl_serv_ring_vsi_info *vsi_info; bad535d287c9c1 Bennie Yan 2024-09-24 301 u64 last_tx_packets; bad535d287c9c1 Bennie Yan 2024-09-24 302 u64 last_rx_packets; bad535d287c9c1 Bennie Yan 2024-09-24 303 u64 last_get_stats_jiffies, time_diff; bad535d287c9c1 Bennie Yan 2024-09-24 304 u64 tx_packets, rx_packets; bad535d287c9c1 Bennie Yan 2024-09-24 305 u64 tx_rates, rx_rates, pkt_rates; bad535d287c9c1 Bennie Yan 2024-09-24 306 u16 local_vector_id, vector_num; bad535d287c9c1 Bennie Yan 2024-09-24 307 u16 intr_suppress_level; bad535d287c9c1 Bennie Yan 2024-09-24 308 bad535d287c9c1 Bennie Yan 2024-09-24 309 net_resource_mgt = NBL_SERV_MGT_TO_NET_RES_MGT(serv_mgt); bad535d287c9c1 Bennie Yan 2024-09-24 310 netdev = net_resource_mgt->netdev; bad535d287c9c1 Bennie Yan 2024-09-24 311 ring_mgt = NBL_SERV_MGT_TO_RING_MGT(serv_mgt); bad535d287c9c1 Bennie Yan 2024-09-24 312 disp_ops = NBL_SERV_MGT_TO_DISP_OPS(serv_mgt); bad535d287c9c1 Bennie Yan 2024-09-24 313 vsi_info = &ring_mgt->vsi_info[NBL_VSI_DATA]; bad535d287c9c1 Bennie Yan 2024-09-24 314 bad535d287c9c1 Bennie Yan 2024-09-24 315 last_tx_packets = net_resource_mgt->stats.tx_packets; bad535d287c9c1 Bennie Yan 2024-09-24 316 last_rx_packets = net_resource_mgt->stats.rx_packets; bad535d287c9c1 Bennie Yan 2024-09-24 317 last_get_stats_jiffies = net_resource_mgt->get_stats_jiffies; bad535d287c9c1 Bennie Yan 2024-09-24 318 disp_ops->get_net_stats(NBL_SERV_MGT_TO_DISP_PRIV(serv_mgt), &net_resource_mgt->stats); bad535d287c9c1 Bennie Yan 2024-09-24 319 /* ethtool -S don't adaptive interrupt suppression param */ bad535d287c9c1 Bennie Yan 2024-09-24 320 if (!vsi_info->itr_dynamic || ethtool) bad535d287c9c1 Bennie Yan 2024-09-24 321 return; bad535d287c9c1 Bennie Yan 2024-09-24 322 bad535d287c9c1 Bennie Yan 2024-09-24 323 tx_packets = net_resource_mgt->stats.tx_packets; bad535d287c9c1 Bennie Yan 2024-09-24 324 rx_packets = net_resource_mgt->stats.rx_packets; bad535d287c9c1 Bennie Yan 2024-09-24 325 time_diff = jiffies - last_get_stats_jiffies; bad535d287c9c1 Bennie Yan 2024-09-24 326 bad535d287c9c1 Bennie Yan 2024-09-24 327 net_resource_mgt->get_stats_jiffies = jiffies; bad535d287c9c1 Bennie Yan 2024-09-24 328 tx_rates = (tx_packets - last_tx_packets) / time_diff * HZ; bad535d287c9c1 Bennie Yan 2024-09-24 329 rx_rates = (rx_packets - last_rx_packets) / time_diff * HZ; bad535d287c9c1 Bennie Yan 2024-09-24 330 pkt_rates = max_t(u64, tx_rates, rx_rates); bad535d287c9c1 Bennie Yan 2024-09-24 331 bad535d287c9c1 Bennie Yan 2024-09-24 332 intr_suppress_level = bad535d287c9c1 Bennie Yan 2024-09-24 333 disp_ops->get_intr_suppress_level(NBL_SERV_MGT_TO_DISP_PRIV(serv_mgt), pkt_rates, bad535d287c9c1 Bennie Yan 2024-09-24 334 ring_mgt->vectors->intr_suppress_level); bad535d287c9c1 Bennie Yan 2024-09-24 335 if (intr_suppress_level != ring_mgt->vectors->intr_suppress_level) { bad535d287c9c1 Bennie Yan 2024-09-24 336 local_vector_id = ring_mgt->vectors[vsi_info->ring_offset].local_vector_id; bad535d287c9c1 Bennie Yan 2024-09-24 337 vector_num = vsi_info->ring_num; bad535d287c9c1 Bennie Yan 2024-09-24 338 disp_ops->set_intr_suppress_level(NBL_SERV_MGT_TO_DISP_PRIV(serv_mgt), bad535d287c9c1 Bennie Yan 2024-09-24 339 local_vector_id, vector_num, bad535d287c9c1 Bennie Yan 2024-09-24 340 intr_suppress_level); bad535d287c9c1 Bennie Yan 2024-09-24 341 ring_mgt->vectors->intr_suppress_level = intr_suppress_level; bad535d287c9c1 Bennie Yan 2024-09-24 342 } bad535d287c9c1 Bennie Yan 2024-09-24 343 } bad535d287c9c1 Bennie Yan 2024-09-24 344 :::::: The code at line 299 was first introduced by commit :::::: bad535d287c9c1056d99de3666be7da84de4a8fc Net:nbl_core: Add nbl_core-driver for nebula-matrix S1055AS series smart NIC. :::::: TO: Bennie Yan <bennie.yan@nebula-matrix.com> :::::: CC: Bennie Yan <bennie.yan@nebula-matrix.com> -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
participants (1)
-
kernel test robot