[PATCH 1/6] net/hinic: Fix misspelled word and wrong print format
From: Chiqijun <chiqijun@huawei.com> driver inclusion category: bugfix bugzilla: 4472 ----------------------------------------------------------------------- Fix misspelled word and wrong print format. Signed-off-by: Chiqijun <chiqijun@huawei.com> Reviewed-by: Zengweiliang <zengweiliang.zengweiliang@huawei.com> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- .../net/ethernet/huawei/hinic/hinic_api_cmd.c | 4 +- drivers/net/ethernet/huawei/hinic/hinic_cfg.c | 20 +++--- .../net/ethernet/huawei/hinic/hinic_cmdq.c | 4 +- drivers/net/ethernet/huawei/hinic/hinic_dcb.c | 34 +++++----- drivers/net/ethernet/huawei/hinic/hinic_eqs.c | 4 +- .../net/ethernet/huawei/hinic/hinic_ethtool.c | 20 +++--- .../net/ethernet/huawei/hinic/hinic_hwdev.c | 40 +++++------ drivers/net/ethernet/huawei/hinic/hinic_lld.c | 20 +++--- .../net/ethernet/huawei/hinic/hinic_main.c | 6 +- .../net/ethernet/huawei/hinic/hinic_mbox.c | 9 +-- .../net/ethernet/huawei/hinic/hinic_mgmt.c | 20 +++--- .../net/ethernet/huawei/hinic/hinic_nic_cfg.c | 34 +++++----- .../net/ethernet/huawei/hinic/hinic_nic_dbg.c | 6 +- .../net/ethernet/huawei/hinic/hinic_nic_io.c | 2 +- .../net/ethernet/huawei/hinic/hinic_nictool.c | 68 +++++++++---------- .../ethernet/huawei/hinic/hinic_port_cmd.h | 2 +- .../net/ethernet/huawei/hinic/hinic_sriov.c | 4 +- drivers/net/ethernet/huawei/hinic/hinic_tx.c | 4 +- drivers/net/ethernet/huawei/hinic/hinic_wq.c | 2 +- 19 files changed, 154 insertions(+), 149 deletions(-) diff --git a/drivers/net/ethernet/huawei/hinic/hinic_api_cmd.c b/drivers/net/ethernet/huawei/hinic/hinic_api_cmd.c index 5a1e8655be38..6ce69dc73064 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_api_cmd.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_api_cmd.c @@ -129,7 +129,7 @@ static void dump_api_chain_reg(struct hinic_api_cmd_chain *chain) addr = HINIC_CSR_API_CMD_STATUS_0_ADDR(chain->chain_type); val = hinic_hwif_read_reg(chain->hwdev->hwif, addr); - sdk_err(dev, "Chain type: 0x%x, cpld error: 0x%x, check error: 0x%x, current fsm: 0x%x\n", + sdk_err(dev, "Chain type: 0x%x, cpld error: 0x%x, check error: 0x%x, current fsm: 0x%x\n", chain->chain_type, HINIC_API_CMD_STATUS_GET(val, CPLD_ERR), HINIC_API_CMD_STATUS_GET(val, CHKSUM_ERR), HINIC_API_CMD_STATUS_GET(val, FSM)); @@ -161,7 +161,7 @@ static int chain_busy(struct hinic_api_cmd_chain *chain) resp_header = be64_to_cpu(ctxt->resp->header); if (ctxt->status && !HINIC_API_CMD_RESP_HEADER_VALID(resp_header)) { - sdk_err(dev, "Context(0x%x) busy!, pi: %d, resp_header: 0x%08x%08x\n", + sdk_err(dev, "Context(0x%x) busy, pi: %d, resp_header: 0x%08x%08x\n", ctxt->status, chain->prod_idx, upper_32_bits(resp_header), lower_32_bits(resp_header)); diff --git a/drivers/net/ethernet/huawei/hinic/hinic_cfg.c b/drivers/net/ethernet/huawei/hinic/hinic_cfg.c index 18937d7d9057..303225e5689e 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_cfg.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_cfg.c @@ -629,7 +629,7 @@ static int get_cap_from_pf(struct hinic_hwdev *dev, enum func_type type) err = hinic_msg_to_mgmt_sync(dev, HINIC_MOD_CFGM, HINIC_CFG_MBOX_CAP, &dev_cap, in_len, &dev_cap, &out_len, 0); if (err || dev_cap.status || !out_len) { - sdk_err(dev->dev_hdl, "Failed to get capability from PF, err: %d, status: 0x%x, out size: 0x%x\n", + sdk_err(dev->dev_hdl, "Failed to get capability from PF, err: %d, status: 0x%x, out size: 0x%x\n", err, dev_cap.status, out_len); return -EFAULT; } @@ -925,7 +925,7 @@ int hinic_vector_to_eqn(void *hwdev, enum hinic_service_type type, int vector) if (type != SERVICE_T_ROCE && type != SERVICE_T_IWARP) { sdk_err(dev->dev_hdl, - "Service type :%d, only RDMA service could get eqn by vector.\n", + "Service type: %d, only RDMA service could get eqn by vector\n", type); return -EINVAL; } @@ -982,7 +982,7 @@ static int cfg_enable_interrupt(struct hinic_hwdev *dev) irq_info = cfg_mgmt->irq_param_info.alloc_info; - sdk_info(dev->dev_hdl, "Interrupt type: %d, irq num: %d.\n", + sdk_info(dev->dev_hdl, "Interrupt type: %d, irq num: %d\n", cfg_mgmt->svc_cap.interrupt_type, nreq); switch (cfg_mgmt->svc_cap.interrupt_type) { @@ -1001,7 +1001,7 @@ static int cfg_enable_interrupt(struct hinic_hwdev *dev) actual_irq = pci_enable_msix_range(pcidev, entry, VECTOR_THRESHOLD, nreq); if (actual_irq < 0) { - sdk_err(dev->dev_hdl, "Alloc msix entries with threshold 2 failed.\n"); + sdk_err(dev->dev_hdl, "Alloc msix entries with threshold 2 failed\n"); kfree(entry); return -ENOMEM; } @@ -1009,7 +1009,7 @@ static int cfg_enable_interrupt(struct hinic_hwdev *dev) nreq = (u16)actual_irq; cfg_mgmt->irq_param_info.num_total = nreq; cfg_mgmt->irq_param_info.num_irq_remain = nreq; - sdk_info(dev->dev_hdl, "Request %d msix vector success.\n", + sdk_info(dev->dev_hdl, "Request %d msix vector success\n", nreq); for (i = 0; i < nreq; ++i) { @@ -1059,12 +1059,12 @@ int hinic_alloc_irqs(void *hwdev, enum hinic_service_type type, u16 num, if (num > free_num_irq) { if (free_num_irq == 0) { sdk_err(dev->dev_hdl, - "no free irq resource in cfg mgmt.\n"); + "no free irq resource in cfg mgmt\n"); mutex_unlock(&irq_info->irq_mutex); return -ENOMEM; } - sdk_warn(dev->dev_hdl, "only %d irq resource in cfg mgmt.\n", + sdk_warn(dev->dev_hdl, "only %d irq resource in cfg mgmt\n", free_num_irq); num = free_num_irq; } @@ -1125,7 +1125,7 @@ void hinic_free_irq(void *hwdev, enum hinic_service_type type, u32 irq_id) alloc_info[i].free = CFG_FREE; irq_info->num_irq_remain++; if (irq_info->num_irq_remain > max_num_irq) { - sdk_err(dev->dev_hdl, "Find target,but over range\n"); + sdk_err(dev->dev_hdl, "Find target, but over range\n"); mutex_unlock(&irq_info->irq_mutex); return; } @@ -1135,7 +1135,7 @@ void hinic_free_irq(void *hwdev, enum hinic_service_type type, u32 irq_id) } if (i >= max_num_irq) - sdk_warn(dev->dev_hdl, "Irq %d don`t need to free\n", irq_id); + sdk_warn(dev->dev_hdl, "Irq %d don't need to free\n", irq_id); mutex_unlock(&irq_info->irq_mutex); } @@ -1262,7 +1262,7 @@ void hinic_free_ceq(void *hwdev, enum hinic_service_type type, int ceq_id) } if (i >= num_ceq) - sdk_warn(dev->dev_hdl, "ceq %d don`t need to free.\n", ceq_id); + sdk_warn(dev->dev_hdl, "ceq %d don't need to free\n", ceq_id); mutex_unlock(&eq->eq_mutex); } diff --git a/drivers/net/ethernet/huawei/hinic/hinic_cmdq.c b/drivers/net/ethernet/huawei/hinic/hinic_cmdq.c index 7293ff216a7c..6d78d22272f0 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_cmdq.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_cmdq.c @@ -251,7 +251,7 @@ struct hinic_cmd_buf *hinic_alloc_cmd_buf(void *hwdev) void *dev; if (!hwdev) { - pr_err("Failed to alloc cmd buf, Invalid hwdev\n"); + pr_err("Failed to alloc cmd buf, invalid hwdev\n"); return NULL; } @@ -1516,7 +1516,7 @@ int hinic_cmdqs_init(struct hinic_hwdev *hwdev) err = init_cmdq(&cmdqs->cmdq[cmdq_type], hwdev, &cmdqs->saved_wqs[cmdq_type], cmdq_type); if (err) { - sdk_err(hwdev->dev_hdl, "Failed to initialize cmdq type :%d\n", + sdk_err(hwdev->dev_hdl, "Failed to initialize cmdq type: %d\n", cmdq_type); goto init_cmdq_err; } diff --git a/drivers/net/ethernet/huawei/hinic/hinic_dcb.c b/drivers/net/ethernet/huawei/hinic/hinic_dcb.c index e17a91f8bd59..0c7ae9133407 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_dcb.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_dcb.c @@ -338,8 +338,8 @@ u8 hinic_setup_dcb_tool(struct net_device *netdev, u8 *dcb_en, bool wr_flag) if (wr_flag) { if (nic_dev->max_qps < nic_dev->dcb_cfg.pg_tcs && *dcb_en) { - netif_err(nic_dev, drv, netdev, - "max_qps:%d is less than %d\n", + nicif_err(nic_dev, drv, netdev, + "max_qps: %d is less than %d\n", nic_dev->max_qps, nic_dev->dcb_cfg.pg_tcs); return 1; } @@ -357,7 +357,7 @@ u8 hinic_setup_dcb_tool(struct net_device *netdev, u8 *dcb_en, bool wr_flag) mutex_lock(&nic_dev->nic_mutex); if (!err) - netif_info(nic_dev, drv, netdev, "%s DCB\n", + nicif_info(nic_dev, drv, netdev, "%s DCB\n", *dcb_en ? "Enable" : "Disable"); } else { *dcb_en = (u8)test_bit(HINIC_DCB_ENABLE, &nic_dev->flags); @@ -386,15 +386,15 @@ static u8 hinic_dcbnl_set_state(struct net_device *netdev, u8 state) return 0; if (nic_dev->max_qps < nic_dev->dcb_cfg.pg_tcs && state) { - netif_err(nic_dev, drv, netdev, - "max_qps:%d is less than %d\n", + nicif_err(nic_dev, drv, netdev, + "max_qps: %d is less than %d\n", nic_dev->max_qps, nic_dev->dcb_cfg.pg_tcs); return 1; } err = hinic_setup_tc(netdev, state ? nic_dev->dcb_cfg.pg_tcs : 0); if (!err) - netif_info(nic_dev, drv, netdev, "%s DCB\n", + nicif_info(nic_dev, drv, netdev, "%s DCB\n", state ? "Enable" : "Disable"); return !!err; @@ -1062,12 +1062,12 @@ static int __set_hw_ets(struct hinic_nic_dev *nic_dev) err = hinic_dcb_set_ets(nic_dev->hwdev, up_tc, pg_bw, up_pgid, up_bw, up_strict); if (err) { - hinic_err(nic_dev, drv, "Failed to set ets with mode:%d\n", + hinic_err(nic_dev, drv, "Failed to set ets with mode: %d\n", nic_dev->dcbx_cap); return err; } - hinic_info(nic_dev, drv, "Set ets to hw done with mode:%d\n", + hinic_info(nic_dev, drv, "Set ets to hw done with mode: %d\n", nic_dev->dcbx_cap); return 0; @@ -1332,8 +1332,8 @@ static int hinic_dcbnl_ieee_set_ets(struct net_device *netdev, if (max_tc != netdev_get_num_tc(netdev)) { err = hinic_setup_tc(netdev, max_tc); if (err) { - netif_err(nic_dev, drv, netdev, - "Failed to setup tc with max_tc:%d, err:%d\n", + nicif_err(nic_dev, drv, netdev, + "Failed to setup tc with max_tc: %d, err: %d\n", max_tc, err); memcpy(my_ets, &back_ets, sizeof(struct ieee_ets)); return err; @@ -1386,7 +1386,7 @@ static int hinic_dcbnl_ieee_set_pfc(struct net_device *netdev, pfc_map = pfc->pfc_en & nic_dev->up_valid_bitmap; outof_range_pfc = pfc->pfc_en & (~nic_dev->up_valid_bitmap); if (outof_range_pfc) - netif_info(nic_dev, drv, netdev, + nicif_info(nic_dev, drv, netdev, "pfc setting out of range, 0x%x will be ignored\n", outof_range_pfc); @@ -1407,7 +1407,7 @@ static int hinic_dcbnl_ieee_set_pfc(struct net_device *netdev, err = hinic_dcb_set_pfc(nic_dev->hwdev, pfc_en, pfc_map); if (err) { hinic_info(nic_dev, drv, - "Failed to set pfc to hw with pfc_map:0x%x err:%d\n", + "Failed to set pfc to hw with pfc_map: 0x%x err: %d\n", pfc_map, err); hinic_start_port_traffic_flow(nic_dev); return err; @@ -1416,7 +1416,7 @@ static int hinic_dcbnl_ieee_set_pfc(struct net_device *netdev, hinic_start_port_traffic_flow(nic_dev); my_pfc->pfc_en = pfc->pfc_en; hinic_info(nic_dev, drv, - "Set pfc successfully with pfc_map:0x%x, pfc_en:%d\n", + "Set pfc successfully with pfc_map: 0x%x, pfc_en: %d\n", pfc_map, pfc_en); return 0; @@ -1479,7 +1479,7 @@ static u8 hinic_dcbnl_setdcbx(struct net_device *netdev, u8 mode) ((mode & DCB_CAP_DCBX_LLD_MANAGED) && (!(mode & DCB_CAP_DCBX_HOST)))) { nicif_info(nic_dev, drv, netdev, - "Set dcbx failed with invalid mode:%d\n", mode); + "Set dcbx failed with invalid mode: %d\n", mode); return 1; } @@ -1497,7 +1497,7 @@ static u8 hinic_dcbnl_setdcbx(struct net_device *netdev, u8 mode) err = hinic_setup_tc(netdev, 0); if (err) { nicif_err(nic_dev, drv, netdev, - "Failed to setup tc with mode:%d\n", + "Failed to setup tc with mode: %d\n", mode); return 1; } @@ -1509,7 +1509,7 @@ static u8 hinic_dcbnl_setdcbx(struct net_device *netdev, u8 mode) err = hinic_setup_tc(netdev, 0); if (err) { nicif_err(nic_dev, drv, netdev, - "Failed to setup tc with mode:%d\n", mode); + "Failed to setup tc with mode: %d\n", mode); return 1; } } @@ -1617,7 +1617,7 @@ int __set_cos_up_map(struct hinic_nic_dev *nic_dev, u8 *cos_up) return -EFAULT; } - nicif_info(nic_dev, drv, netdev, "Set cos2up:%d%d%d%d%d%d%d%d\n", + nicif_info(nic_dev, drv, netdev, "Set cos2up: %d%d%d%d%d%d%d%d\n", cos_up[0], cos_up[1], cos_up[2], cos_up[3], cos_up[4], cos_up[5], cos_up[6], cos_up[7]); diff --git a/drivers/net/ethernet/huawei/hinic/hinic_eqs.c b/drivers/net/ethernet/huawei/hinic/hinic_eqs.c index 22fc49d16462..6c352dff996a 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_eqs.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_eqs.c @@ -486,7 +486,7 @@ static void ceq_event_handler(struct hinic_ceqs *ceqs, u32 ceqe) u32 ceqe_data = CEQE_DATA(ceqe); if (event >= HINIC_MAX_CEQ_EVENTS) { - sdk_err(hwdev->dev_hdl, "Ceq unknown event:%d, ceqe date: 0x%x\n", + sdk_err(hwdev->dev_hdl, "Ceq unknown event: %d, ceqe date: 0x%x\n", event, ceqe_data); return; } @@ -1126,7 +1126,7 @@ static int init_eq(struct hinic_eq *eq, struct hinic_hwdev *hwdev, u16 q_id, eq->orig_page_size = eq->page_size; eq->num_pages = GET_EQ_NUM_PAGES(eq, eq->page_size); if (eq->num_pages > HINIC_EQ_MAX_PAGES) { - sdk_err(hwdev->dev_hdl, "Number pages:%d too many pages for eq\n", + sdk_err(hwdev->dev_hdl, "Number pages: %d too many pages for eq\n", eq->num_pages); return -EINVAL; } diff --git a/drivers/net/ethernet/huawei/hinic/hinic_ethtool.c b/drivers/net/ethernet/huawei/hinic/hinic_ethtool.c index 98e230d4e3c1..f79594570002 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_ethtool.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_ethtool.c @@ -753,7 +753,7 @@ static int hinic_set_settings_to_hw(struct hinic_nic_dev *nic_dev, (autoneg ? "autong enable " : "autong disable ") : ""); if (err < 0 || err >= SET_LINK_STR_MAX_LEN) { nicif_err(nic_dev, drv, netdev, - "Failed snprintf link state, function return(%d) and dest_len(%d)\n", + "Failed to snprintf link state, function return(%d) and dest_len(%d)\n", err, SET_LINK_STR_MAX_LEN); return -EFAULT; } @@ -763,7 +763,7 @@ static int hinic_set_settings_to_hw(struct hinic_nic_dev *nic_dev, "%sspeed %d ", set_link_str, speed); if (err <= 0 || err >= SET_LINK_STR_MAX_LEN) { nicif_err(nic_dev, drv, netdev, - "Failed snprintf link speed, function return(%d) and dest_len(%d)\n", + "Failed to snprintf link speed, function return(%d) and dest_len(%d)\n", err, SET_LINK_STR_MAX_LEN); return -EFAULT; } @@ -897,7 +897,7 @@ static void hinic_get_drvinfo(struct net_device *netdev, "%s", mgmt_ver); if (err <= 0 || err >= (int)sizeof(info->fw_version)) nicif_err(nic_dev, drv, netdev, - "Failed snprintf fw_version, function return(%d) and dest_len(%d)\n", + "Failed to snprintf fw_version, function return(%d) and dest_len(%d)\n", err, (int)sizeof(info->fw_version)); } @@ -997,7 +997,7 @@ static int hinic_set_ringparam(struct net_device *netdev, ring->rx_pending > HINIC_MAX_QUEUE_DEPTH || ring->rx_pending < HINIC_MIN_QUEUE_DEPTH) { nicif_err(nic_dev, drv, netdev, - "Queue depth out of rang [%d-%d]\n", + "Queue depth out of range [%d-%d]\n", HINIC_MIN_QUEUE_DEPTH, HINIC_MAX_QUEUE_DEPTH); return -EINVAL; } @@ -1449,7 +1449,7 @@ static int __hinic_set_coalesce(struct net_device *netdev, err = snprintf(obj_str, sizeof(obj_str), "for netdev"); if (err <= 0 || err >= OBJ_STR_MAX_LEN) { nicif_err(nic_dev, drv, netdev, - "Failed snprintf string, function return(%d) and dest_len(%d)\n", + "Failed to snprintf string, function return(%d) and dest_len(%d)\n", err, OBJ_STR_MAX_LEN); return -EFAULT; } @@ -1458,7 +1458,7 @@ static int __hinic_set_coalesce(struct net_device *netdev, err = snprintf(obj_str, sizeof(obj_str), "for queue %d", queue); if (err <= 0 || err >= OBJ_STR_MAX_LEN) { nicif_err(nic_dev, drv, netdev, - "Failed snprintf string, function return(%d) and dest_len(%d)\n", + "Failed to snprintf string, function return(%d) and dest_len(%d)\n", err, OBJ_STR_MAX_LEN); return -EFAULT; } @@ -1712,7 +1712,7 @@ static void hinic_get_strings(struct net_device *netdev, return; default: nicif_err(nic_dev, drv, netdev, - "Invalid string set %d.", stringset); + "Invalid string set %d", stringset); return; } } @@ -1913,7 +1913,7 @@ static int hinic_run_lp_test(struct hinic_nic_dev *nic_dev, u32 test_time) } dev_kfree_skb_any(skb_tmp); - nicif_info(nic_dev, drv, netdev, "Loopback test succeed.\n"); + nicif_info(nic_dev, drv, netdev, "Loopback test succeed\n"); return 0; } @@ -1961,7 +1961,7 @@ void hinic_lp_test(struct net_device *netdev, struct ethtool_test *eth_test, lb_test_rx_buf = vmalloc(LP_PKT_CNT * LP_PKT_LEN); if (!lb_test_rx_buf) { nicif_err(nic_dev, drv, netdev, - "Failed to alloc rx buffer for loopback test.\n"); + "Failed to alloc rx buffer for loopback test\n"); err = 1; } else { nic_dev->lb_test_rx_buf = lb_test_rx_buf; @@ -1980,7 +1980,7 @@ void hinic_lp_test(struct net_device *netdev, struct ethtool_test *eth_test, if (!(test.flags & ETH_TEST_FL_EXTERNAL_LB)) { if (hinic_set_loopback_mode(nic_dev->hwdev, false)) { nicif_err(nic_dev, drv, netdev, - "Failed to cancel port loopback mode after loopback test.\n"); + "Failed to cancel port loopback mode after loopback test\n"); err = 1; goto resume_link; diff --git a/drivers/net/ethernet/huawei/hinic/hinic_hwdev.c b/drivers/net/ethernet/huawei/hinic/hinic_hwdev.c index e815eec59b45..d19da7238f9b 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_hwdev.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_hwdev.c @@ -1369,7 +1369,7 @@ int hinic_clean_root_ctxt(void *hwdev) &root_ctxt, &out_size, 0); if (err || !out_size || root_ctxt.status) { sdk_err(((struct hinic_hwdev *)hwdev)->dev_hdl, - "Failed to set root context, err: %d, status: 0x%x, out_size: 0x%x\n", + "Failed to clean root context, err: %d, status: 0x%x, out_size: 0x%x\n", err, root_ctxt.status, out_size); return -EFAULT; } @@ -1528,7 +1528,7 @@ static int hinic_vf_rx_tx_flush_in_pf(struct hinic_hwdev *hwdev, u16 vf_id) HINIC_MGMT_CMD_START_FLR, &clr_res, sizeof(clr_res), &clr_res, &out_size, 0); if (err || !out_size || clr_res.status) { - sdk_warn(hwdev->dev_hdl, "Failed to flush doorbell, err: %d, status: 0x%x, out_size: 0x%x\n", + sdk_warn(hwdev->dev_hdl, "Failed to start flr, err: %d, status: 0x%x, out_size: 0x%x\n", err, clr_res.status, out_size); ret = err ? err : (-EFAULT); } @@ -1759,7 +1759,7 @@ static int init_aeqs_msix_attr(struct hinic_hwdev *hwdev) info.msix_index = eq->eq_irq.msix_entry_idx; err = hinic_set_interrupt_cfg_direct(hwdev, &info); if (err) { - sdk_err(hwdev->dev_hdl, "Set msix attr for aeq %d failed\n", + sdk_err(hwdev->dev_hdl, "Failed to set msix attr for aeq %d\n", q_id); return -EFAULT; } @@ -1789,7 +1789,7 @@ static int init_ceqs_msix_attr(struct hinic_hwdev *hwdev) info.msix_index = eq->eq_irq.msix_entry_idx; err = hinic_set_interrupt_cfg(hwdev, info); if (err) { - sdk_err(hwdev->dev_hdl, "Set msix attr for ceq %d failed\n", + sdk_err(hwdev->dev_hdl, "Failed to set msix attr for ceq %d\n", q_id); return -EFAULT; } @@ -2032,7 +2032,7 @@ int comm_pf_mbox_handler(void *handle, u16 vf_id, u8 cmd, void *buf_in, if (!hinic_mbox_check_cmd_valid(handle, hw_cmd_support_vf, vf_id, cmd, buf_in, in_size, size)) { sdk_err(((struct hinic_hwdev *)handle)->dev_hdl, - "PF Receive VF(%d) common cmd(0x%x), mbox len(0x%x) is invalid\n", + "PF Receive VF(%d) common cmd(0x%x) or mbox len(0x%x) is invalid\n", vf_id + hinic_glb_pf_vf_offset(handle), cmd, in_size); err = HINIC_MBOX_VF_CMD_ERROR; return err; @@ -2050,8 +2050,8 @@ int comm_pf_mbox_handler(void *handle, u16 vf_id, u8 cmd, void *buf_in, if (err && err != HINIC_DEV_BUSY_ACTIVE_FW && err != HINIC_MBOX_PF_BUSY_ACTIVE_FW) sdk_err(((struct hinic_hwdev *)handle)->dev_hdl, - "PF mbox common callback handler err: %d\n", - err); + "PF mbox common cmd %d callback handler err: %d\n", + cmd, err); } return err; @@ -2462,7 +2462,7 @@ int hinic_init_comm_ch(struct hinic_hwdev *hwdev) err = __get_func_misc_info(hwdev); if (err) { - sdk_err(hwdev->dev_hdl, "Failed to get function msic information\n"); + sdk_err(hwdev->dev_hdl, "Failed to get function misc information\n"); goto get_func_info_err; } @@ -3133,7 +3133,7 @@ int mqm_eqm_init(struct hinic_hwdev *hwdev) &info_eqm_fix, sizeof(info_eqm_fix), &info_eqm_fix, &len, 0); if (ret || !len || info_eqm_fix.status) { - sdk_err(hwdev->dev_hdl, "Get mqm fix info fail,err: %d, status: 0x%x, out_size: 0x%x\n", + sdk_err(hwdev->dev_hdl, "Get mqm fix info failed, err: %d, status: 0x%x, out_size: 0x%x\n", ret, info_eqm_fix.status, len); return -EFAULT; } @@ -3149,25 +3149,25 @@ int mqm_eqm_init(struct hinic_hwdev *hwdev) kcalloc(hwdev->mqm_att.chunk_num, sizeof(struct hinic_page_addr), GFP_KERNEL); if (!(hwdev->mqm_att.brm_srch_page_addr)) { - sdk_err(hwdev->dev_hdl, "Alloc virtual mem failed\r\n"); + sdk_err(hwdev->dev_hdl, "Alloc virtual mem failed\n"); return -EFAULT; } ret = mqm_eqm_alloc_page_mem(hwdev); if (ret) { - sdk_err(hwdev->dev_hdl, "Alloc eqm page mem failed\r\n"); + sdk_err(hwdev->dev_hdl, "Alloc eqm page mem failed\n"); goto err_page; } ret = mqm_eqm_set_page_2_hw(hwdev); if (ret) { - sdk_err(hwdev->dev_hdl, "Set page to hw failed\r\n"); + sdk_err(hwdev->dev_hdl, "Set page to hw failed\n"); goto err_ecmd; } ret = mqm_eqm_set_cfg_2_hw(hwdev, 1); if (ret) { - sdk_err(hwdev->dev_hdl, "Set page to hw failed\r\n"); + sdk_err(hwdev->dev_hdl, "Set page to hw failed\n"); goto err_ecmd; } @@ -3197,7 +3197,7 @@ void mqm_eqm_deinit(struct hinic_hwdev *hwdev) ret = mqm_eqm_set_cfg_2_hw(hwdev, 0); if (ret) { - sdk_err(hwdev->dev_hdl, "Set mqm eqm cfg to chip fail! err: %d\n", + sdk_err(hwdev->dev_hdl, "Set mqm eqm cfg to chip fail, err: %d\n", ret); return; } @@ -3218,7 +3218,7 @@ int hinic_ppf_ext_db_init(void *dev) ret = mqm_eqm_init(hwdev); if (ret) { - sdk_err(hwdev->dev_hdl, "MQM eqm init fail!\n"); + sdk_err(hwdev->dev_hdl, "MQM eqm init failed\n"); return -EFAULT; } @@ -3425,7 +3425,7 @@ static void fault_report_show(struct hinic_hwdev *hwdev, struct hinic_fault_event_stats *fault; u8 node_id; - sdk_err(hwdev->dev_hdl, "Fault event report received, func_id: %d.\n", + sdk_err(hwdev->dev_hdl, "Fault event report received, func_id: %d\n", hinic_global_func_id(hwdev)); memset(type_str, 0, FAULT_SHOW_STR_LEN + 1); @@ -3759,7 +3759,7 @@ static void sw_watchdog_timeout_info_show(struct hinic_hwdev *hwdev, u32 *dump_addr, *reg, stack_len, i, j; if (in_size != sizeof(*watchdog_info)) { - sdk_err(hwdev->dev_hdl, "Invalid mgmt watchdog report, length: %d, should be %ld.\n", + sdk_err(hwdev->dev_hdl, "Invalid mgmt watchdog report, length: %d, should be %ld\n", in_size, sizeof(*watchdog_info)); return; } @@ -3924,7 +3924,7 @@ static void hinic_fmw_act_ntc_handler(struct hinic_hwdev *hwdev, struct hinic_fmw_act_ntc *notice_info; if (in_size != sizeof(*notice_info)) { - sdk_err(hwdev->dev_hdl, "Invalid mgmt firmware active notice, length: %d, should be %ld.\n", + sdk_err(hwdev->dev_hdl, "Invalid mgmt firmware active notice, length: %d, should be %ld\n", in_size, sizeof(*notice_info)); return; } @@ -3957,7 +3957,7 @@ static void hinic_pcie_dfx_event_handler(struct hinic_hwdev *hwdev, u32 *reg; if (in_size != sizeof(*notice_info)) { - sdk_err(hwdev->dev_hdl, "Invalid mgmt firmware active notice, length: %d, should be %ld.\n", + sdk_err(hwdev->dev_hdl, "Invalid mgmt firmware active notice, length: %d, should be %ld\n", in_size, sizeof(*notice_info)); return; } @@ -4724,7 +4724,7 @@ u8 hinic_nic_sw_aeqe_handler(void *handle, u8 event, u64 data) event_level = FAULT_LEVEL_FATAL; break; default: - sdk_err(hwdev->dev_hdl, "Unsupported sw event %d to process.\n", + sdk_err(hwdev->dev_hdl, "Unsupported sw event %d to process\n", event); } diff --git a/drivers/net/ethernet/huawei/hinic/hinic_lld.c b/drivers/net/ethernet/huawei/hinic/hinic_lld.c index 81461da5e9aa..a19a1f67bc97 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_lld.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_lld.c @@ -668,7 +668,7 @@ static void hinic_ignore_minor_version(char *version) err = snprintf(version, max_ver_len, "%s.%s.%s.0", ver_split[0], ver_split[1], ver_split[2]); if (err <= 0 || err >= max_ver_len) - pr_err("Failed snprintf version, function return(%d) and dest_len(%d)\n", + pr_err("Failed to snprintf version, function return(%d) and dest_len(%d)\n", err, max_ver_len); } @@ -1087,7 +1087,7 @@ void *hinic_get_uld_dev_by_ifname(char *ifname, enum hinic_service_type type) struct hinic_pcidev *dev; if (type >= SERVICE_T_MAX) { - pr_err("Service type :%d is error\n", type); + pr_err("Service type: %d is error\n", type); return NULL; } @@ -1467,7 +1467,7 @@ struct net_device *hinic_get_netdev_by_lld(struct hinic_lld_dev *lld_dev) nic_dev = pci_adapter->uld_dev[SERVICE_T_NIC]; if (!nic_dev) { sdk_err(&pci_adapter->pcidev->dev, - "There's no net device attached on the pci device"); + "There's no net device attached on the pci device\n"); return NULL; } @@ -1501,7 +1501,7 @@ struct net_device *hinic_get_netdev_by_pcidev(struct pci_dev *pdev) nic_dev = pci_adapter->uld_dev[SERVICE_T_NIC]; if (!nic_dev) { sdk_err(&pci_adapter->pcidev->dev, - "There`s no net device attached on the pci device"); + "There`s no net device attached on the pci device\n"); return NULL; } @@ -1739,7 +1739,7 @@ int hinic_ovs_set_vf_nic_state(struct hinic_lld_dev *lld_dev, u16 vf_func_id, if (err) { sdk_err(&des_dev->pcidev->dev, - "%s driver Set VF max_queue_num failed, err=%d.\n", + "%s driver Set VF max_queue_num failed, err=%d\n", s_uld_name[SERVICE_T_NIC], err); break; @@ -2071,7 +2071,7 @@ static int alloc_chip_node(struct hinic_pcidev *pci_adapter) HINIC_CHIP_NAME, i); if (err <= 0 || err >= IFNAMSIZ) { sdk_err(&pci_adapter->pcidev->dev, - "Failed snprintf chip_name, function return(%d) and dest_len(%d)\n", + "Failed to snprintf chip_name, function return(%d) and dest_len(%d)\n", err, IFNAMSIZ); goto alloc_dbgtool_attr_file_err; } @@ -2080,7 +2080,7 @@ static int alloc_chip_node(struct hinic_pcidev *pci_adapter) IFNAMSIZ, "%s%d", HINIC_CHIP_NAME, i); if (err <= 0 || err >= IFNAMSIZ) { sdk_err(&pci_adapter->pcidev->dev, - "Failed snprintf dbgtool_attr_file_name, function return(%d) and dest_len(%d)\n", + "Failed to snprintf dbgtool_attr_file_name, function return(%d) and dest_len(%d)\n", err, IFNAMSIZ); goto alloc_dbgtool_attr_file_err; } @@ -2188,13 +2188,13 @@ int hinic_ovs_set_vf_load_state(struct pci_dev *pdev) { struct hinic_pcidev *pci_adapter; if (!pdev) { - pr_err("pdev is null.\n"); + pr_err("pdev is null\n"); return -EINVAL; } pci_adapter = pci_get_drvdata(pdev); if (!pci_adapter) { - pr_err("pci_adapter is null.\n"); + pr_err("pci_adapter is null\n"); return -EFAULT; } @@ -2699,7 +2699,7 @@ static int hinic_probe(struct pci_dev *pdev, const struct pci_device_id *id) create_singlethread_workqueue(HINIC_SLAVE_NIC_DELAY); if (!pci_adapter->slave_nic_init_workq) { sdk_err(&pdev->dev, - "Failed to create work queue:%s\n", + "Failed to create work queue: %s\n", HINIC_SLAVE_NIC_DELAY); goto ceate_nic_delay_work_fail; } diff --git a/drivers/net/ethernet/huawei/hinic/hinic_main.c b/drivers/net/ethernet/huawei/hinic/hinic_main.c index 1679c24eba9d..56af81d132fd 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_main.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_main.c @@ -407,7 +407,7 @@ static int hinic_setup_num_qps(struct hinic_nic_dev *nic_dev) } nic_dev->qps_irq_info = kzalloc(irq_size, GFP_KERNEL); if (!nic_dev->qps_irq_info) { - nicif_err(nic_dev, drv, netdev, "Failed to alloc msix entries\n"); + nicif_err(nic_dev, drv, netdev, "Failed to alloc qps_irq_info\n"); return -ENOMEM; } @@ -560,7 +560,7 @@ static int hinic_request_irq(struct hinic_irq *irq_cfg, u16 q_id) err = hinic_set_interrupt_cfg(nic_dev->hwdev, info); if (err) { nicif_err(nic_dev, drv, irq_cfg->netdev, - "Failed to set RX interrupt coalescing attribute.\n"); + "Failed to set RX interrupt coalescing attribute\n"); qp_del_napi(irq_cfg); return err; } @@ -2977,7 +2977,7 @@ int hinic_enable_func_rss(struct hinic_nic_dev *nic_dev) if (err) { if (err == -ENOSPC) nicif_warn(nic_dev, drv, netdev, - "Failed to alloc RSS template,table is full\n"); + "Failed to alloc RSS template, table is full\n"); else nicif_err(nic_dev, drv, netdev, "Failed to alloc RSS template\n"); diff --git a/drivers/net/ethernet/huawei/hinic/hinic_mbox.c b/drivers/net/ethernet/huawei/hinic/hinic_mbox.c index fc91bdffe1eb..29feb9b4a16c 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_mbox.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_mbox.c @@ -213,8 +213,8 @@ static bool check_func_id(struct hinic_hwdev *hwdev, u16 src_func_idx, if (in_size < offset + sizeof(func_idx)) { sdk_warn(hwdev->dev_hdl, - "Reveice mailbox msg len: %d less than 10 Bytes is invalid\n", - in_size); + "Receive mailbox msg len: %d less than %ld Bytes is invalid\n", + in_size, offset + sizeof(func_idx)); return false; } @@ -222,7 +222,7 @@ static bool check_func_id(struct hinic_hwdev *hwdev, u16 src_func_idx, if (src_func_idx != func_idx) { sdk_warn(hwdev->dev_hdl, - "Reveice mailbox function id(0x%x) not equal to msg function id(0x%x)\n", + "Reveive mailbox function id(0x%x) not equal to msg function id(0x%x)\n", src_func_idx, func_idx); return false; } @@ -909,7 +909,8 @@ void hinic_mbox_func_aeqe_handler(void *handle, u8 *header, u8 size) if (src >= HINIC_MAX_FUNCTIONS) { sdk_err(func_to_func->hwdev->dev_hdl, - "Mailbox source function id:%u is invalid\n", (u32)src); + "Mailbox source function id: %u is invalid\n", + (u32)src); return; } diff --git a/drivers/net/ethernet/huawei/hinic/hinic_mgmt.c b/drivers/net/ethernet/huawei/hinic/hinic_mgmt.c index 38abf8fe0817..3a8362cc7d01 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_mgmt.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_mgmt.c @@ -680,7 +680,7 @@ static int hinic_read_clp_data(struct hinic_hwdev *hwdev, err = hinic_read_clp_reg(hwdev, HINIC_CLP_RSP_HOST, HINIC_CLP_READY_RSP_HOST, &ready); if (err || delay_cnt > HINIC_CLP_DELAY_CNT_MAX) { - sdk_err(hwdev->dev_hdl, "timeout with delay_cnt:%d\n", + sdk_err(hwdev->dev_hdl, "Timeout with delay_cnt: %d\n", delay_cnt); return -EINVAL; } @@ -692,7 +692,7 @@ static int hinic_read_clp_data(struct hinic_hwdev *hwdev, return err; if (temp_out_size > HINIC_CLP_SRAM_SIZE_REG_MAX || !temp_out_size) { - sdk_err(hwdev->dev_hdl, "invalid temp_out_size:%d\n", + sdk_err(hwdev->dev_hdl, "Invalid temp_out_size: %d\n", temp_out_size); return -EINVAL; } @@ -757,14 +757,16 @@ static int hinic_check_clp_init_status(struct hinic_hwdev *hwdev) err = hinic_read_clp_reg(hwdev, HINIC_CLP_REQ_HOST, HINIC_CLP_BA_HOST, ®_value); if (err || !reg_value) { - sdk_err(hwdev->dev_hdl, "Wrong req ba value:0x%x\n", reg_value); + sdk_err(hwdev->dev_hdl, "Wrong req ba value: 0x%x\n", + reg_value); return -EINVAL; } err = hinic_read_clp_reg(hwdev, HINIC_CLP_RSP_HOST, HINIC_CLP_BA_HOST, ®_value); if (err || !reg_value) { - sdk_err(hwdev->dev_hdl, "Wrong rsp ba value:0x%x\n", reg_value); + sdk_err(hwdev->dev_hdl, "Wrong rsp ba value: 0x%x\n", + reg_value); return -EINVAL; } @@ -822,7 +824,7 @@ int hinic_pf_clp_to_mgmt(void *hwdev, enum hinic_mod_type mod, u8 cmd, if (real_size > (HINIC_CLP_INPUT_BUFFER_LEN_HOST / HINIC_CLP_DATA_UNIT_HOST)) { - sdk_err(dev->dev_hdl, "Invalid real_size:%d\n", real_size); + sdk_err(dev->dev_hdl, "Invalid real_size: %d\n", real_size); return -EINVAL; } down(&clp_pf_to_mgmt->clp_msg_lock); @@ -871,13 +873,13 @@ int hinic_pf_clp_to_mgmt(void *hwdev, enum hinic_mod_type mod, u8 cmd, real_size = (u16)((real_size * HINIC_CLP_DATA_UNIT_HOST) & 0xffff); if (real_size <= sizeof(header) || real_size > HINIC_CLP_INPUT_BUFFER_LEN_HOST) { - sdk_err(dev->dev_hdl, "Invalid response size:%d", real_size); + sdk_err(dev->dev_hdl, "Invalid response size: %d", real_size); up(&clp_pf_to_mgmt->clp_msg_lock); return -EINVAL; } real_size = real_size - sizeof(header); if (real_size != *out_size) { - sdk_err(dev->dev_hdl, "Invalid real_size:%d, out_size:%d\n", + sdk_err(dev->dev_hdl, "Invalid real_size: %d, out_size: %d\n", real_size, *out_size); up(&clp_pf_to_mgmt->clp_msg_lock); return -EINVAL; @@ -1090,11 +1092,11 @@ static void mgmt_resp_msg_handler(struct hinic_msg_pf_to_mgmt *pf_to_mgmt, pf_to_mgmt->event_flag == SEND_EVENT_START) { complete(&recv_msg->recv_done); } else if (recv_msg->msg_id != pf_to_mgmt->sync_msg_id) { - sdk_err(dev, "Send msg id(0x%x) recv msg id(0x%x) dismatch, event state=%d\n", + sdk_err(dev, "Send msg id(0x%x) recv msg id(0x%x) dismatch, event state: %d\n", pf_to_mgmt->sync_msg_id, recv_msg->msg_id, pf_to_mgmt->event_flag); } else { - sdk_err(dev, "Wait timeout, send msg id(0x%x) recv msg id(0x%x), event state=%d!\n", + sdk_err(dev, "Wait timeout, send msg id(0x%x) recv msg id(0x%x), event state: %d\n", pf_to_mgmt->sync_msg_id, recv_msg->msg_id, pf_to_mgmt->event_flag); } diff --git a/drivers/net/ethernet/huawei/hinic/hinic_nic_cfg.c b/drivers/net/ethernet/huawei/hinic/hinic_nic_cfg.c index 90b16ea9658d..1bac0ea08a52 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_nic_cfg.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_nic_cfg.c @@ -309,7 +309,7 @@ int hinic_del_mac(void *hwdev, const u8 *mac_addr, u16 vlan_id, u16 func_id) return -EINVAL; } if (mac_info.status == HINIC_PF_SET_VF_ALREADY) { - nic_warn(nic_hwdev->dev_hdl, "PF has already set VF mac, Ignore delete operation.\n"); + nic_warn(nic_hwdev->dev_hdl, "PF has already set VF mac, Ignore delete operation\n"); return HINIC_PF_SET_VF_ALREADY; } @@ -461,12 +461,14 @@ int hinic_set_port_mtu(void *hwdev, u32 new_mtu) if (new_mtu < HINIC_MIN_MTU_SIZE) { nic_err(nic_hwdev->dev_hdl, - "Invalid mtu size, mtu size < 256bytes"); + "Invalid mtu size, mtu size < %dbytes\n", + HINIC_MIN_MTU_SIZE); return -EINVAL; } if (new_mtu > HINIC_MAX_JUMBO_FRAME_SIZE) { - nic_err(nic_hwdev->dev_hdl, "Invalid mtu size, mtu size > 9600bytes"); + nic_err(nic_hwdev->dev_hdl, "Invalid mtu size, mtu size > %dbytes\n", + HINIC_MAX_JUMBO_FRAME_SIZE); return -EINVAL; } @@ -2220,7 +2222,7 @@ int hinic_get_mgmt_version(void *hwdev, u8 *mgmt_ver) err = snprintf(mgmt_ver, HINIC_MGMT_VERSION_MAX_LEN, "%s", up_ver.ver); if (err <= 0 || err >= HINIC_MGMT_VERSION_MAX_LEN) { nic_err(dev->dev_hdl, - "Failed snprintf fw version, function return(%d) and dest_len(%d)\n", + "Failed to snprintf fw version, function return(%d) and dest_len(%d)\n", err, HINIC_MGMT_VERSION_MAX_LEN); return -EINVAL; } @@ -2501,7 +2503,7 @@ static int hinic_del_vf_mac_msg_handler(struct hinic_nic_io *nic_io, u16 vf, if (vf_info->pf_set_mac && !(vf_info->trust) && is_valid_ether_addr(mac_in->mac) && !memcmp(vf_info->vf_mac_addr, mac_in->mac, ETH_ALEN)) { - nic_warn(nic_io->hwdev->dev_hdl, "PF has already set VF mac.\n"); + nic_warn(nic_io->hwdev->dev_hdl, "PF has already set VF mac\n"); mac_out->status = HINIC_PF_SET_VF_ALREADY; *out_size = sizeof(*mac_out); return 0; @@ -2530,12 +2532,12 @@ static int hinic_update_vf_mac_msg_handler(struct hinic_nic_io *nic_io, u16 vf, int err; if (!is_valid_ether_addr(mac_in->new_mac)) { - nic_err(nic_io->hwdev->dev_hdl, "Update VF MAC is invalid.\n"); + nic_err(nic_io->hwdev->dev_hdl, "Update VF MAC is invalid\n"); return -EINVAL; } if (vf_info->pf_set_mac && !(vf_info->trust)) { - nic_warn(nic_io->hwdev->dev_hdl, "PF has already set VF mac.\n"); + nic_warn(nic_io->hwdev->dev_hdl, "PF has already set VF mac\n"); mac_out->status = HINIC_PF_SET_VF_ALREADY; *out_size = sizeof(*mac_out); return 0; @@ -2724,7 +2726,7 @@ int nic_pf_mbox_handler(void *hwdev, u16 vf_id, u8 cmd, void *buf_in, if (!hinic_mbox_check_cmd_valid(hwdev, nic_cmd_support_vf, vf_id, cmd, buf_in, in_size, size)) { nic_err(((struct hinic_hwdev *)hwdev)->dev_hdl, - "PF Receive VF nic cmd(0x%x), mbox len(0x%x) is invalid\n", + "PF Receive VF nic cmd(0x%x) or mbox len(0x%x) is invalid\n", cmd, in_size); err = HINIC_MBOX_VF_CMD_ERROR; return err; @@ -2793,7 +2795,7 @@ int nic_pf_mbox_handler(void *hwdev, u16 vf_id, u8 cmd, void *buf_in, if (err && err != HINIC_DEV_BUSY_ACTIVE_FW && err != HINIC_MBOX_PF_BUSY_ACTIVE_FW) - nic_err(nic_io->hwdev->dev_hdl, "PF receive VF L2NIC cmd: %d process error, err:%d\n", + nic_err(nic_io->hwdev->dev_hdl, "PF receive VF L2NIC cmd: %d process error, err: %d\n", cmd, err); return err; } @@ -3522,13 +3524,13 @@ int hinic_set_anti_attack(void *hwdev, bool enable) &rate, sizeof(rate), &rate, &out_size); if (err || !out_size || rate.status) { - nic_err(nic_hwdev->dev_hdl, "Can`t %s port Anti-Attack rate limit err: %d, status: 0x%x, out size: 0x%x\n", + nic_err(nic_hwdev->dev_hdl, "Can't %s port Anti-Attack rate limit err: %d, status: 0x%x, out size: 0x%x\n", (enable ? "enable" : "disable"), err, rate.status, out_size); return -EINVAL; } - nic_info(nic_hwdev->dev_hdl, "%s port Anti-Attack rate limit succeed.\n", + nic_info(nic_hwdev->dev_hdl, "%s port Anti-Attack rate limit succeed\n", (enable ? "Enable" : "Disable")); return 0; @@ -3616,13 +3618,13 @@ int hinic_set_super_cqe_state(void *hwdev, bool enable) &super_cqe, sizeof(super_cqe), &super_cqe, &out_size); if (err || !out_size || super_cqe.status) { - nic_err(nic_hwdev->dev_hdl, "Can`t %s surper cqe, err: %d, status: 0x%x, out size: 0x%x\n", + nic_err(nic_hwdev->dev_hdl, "Can't %s surper cqe, err: %d, status: 0x%x, out size: 0x%x\n", (enable ? "enable" : "disable"), err, super_cqe.status, out_size); return -EINVAL; } - nic_info(nic_hwdev->dev_hdl, "%s super cqe succeed.\n", + nic_info(nic_hwdev->dev_hdl, "%s super cqe succeed\n", (enable ? "Enable" : "Disable")); return 0; @@ -3960,16 +3962,16 @@ int hinic_disable_tx_promisc(void *hwdev) info.cfg = HINIC_TX_PROMISC_DISABLE; err = hinic_msg_to_mgmt_sync(hwdev, HINIC_MOD_L2NIC, - HINIC_PORT_CMD_DISABLE_PROMISIC, &info, + HINIC_PORT_CMD_DISABLE_PROMISC, &info, sizeof(info), &info, &out_size, 0); if (err || !out_size || info.status) { if (info.status == HINIC_MGMT_CMD_UNSUPPORTED) { nic_info(((struct hinic_hwdev *)hwdev)->dev_hdl, - "Unsupported to disable TX promisic\n"); + "Unsupported to disable TX promisc\n"); return 0; } nic_err(((struct hinic_hwdev *)hwdev)->dev_hdl, - "Failed to disable multihost promisic, err: %d, status: 0x%x, out size: 0x%x\n", + "Failed to disable multihost promisc, err: %d, status: 0x%x, out size: 0x%x\n", err, info.status, out_size); return -EFAULT; } diff --git a/drivers/net/ethernet/huawei/hinic/hinic_nic_dbg.c b/drivers/net/ethernet/huawei/hinic/hinic_nic_dbg.c index e49a21fa952e..9bcdcd3ce1c0 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_nic_dbg.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_nic_dbg.c @@ -101,7 +101,7 @@ u16 hinic_dbg_get_rq_hw_pi(void *hwdev, u16 q_id) if (qp) return cpu_to_be16(*qp->rq.pi_virt_addr); - nic_err(((struct hinic_hwdev *)hwdev)->dev_hdl, "Get rq hw pi failed!\n"); + nic_err(((struct hinic_hwdev *)hwdev)->dev_hdl, "Get rq hw pi failed\n"); return INVALID_PI; } @@ -184,7 +184,7 @@ static int get_wqe_info(struct hinic_wq *wq, u16 idx, u16 wqebb_cnt, return -EFAULT; if (*wqe_size != (u16)(wq->wqebb_size * wqebb_cnt)) { - pr_err("Unexpect out buf size from user :%d, expect: %d\n", + pr_err("Unexpect out buf size from user: %d, expect: %d\n", *wqe_size, (u16)(wq->wqebb_size * wqebb_cnt)); return -EFAULT; } @@ -231,7 +231,7 @@ int hinic_dbg_get_rq_wqe_info(void *hwdev, u16 q_id, u16 idx, u16 wqebb_cnt, int hinic_dbg_get_hw_stats(const void *hwdev, u8 *hw_stats, u16 *out_size) { if (!hw_stats || *out_size != sizeof(struct hinic_hw_stats)) { - pr_err("Unexpect out buf size from user :%d, expect: %lu\n", + pr_err("Unexpect out buf size from user: %d, expect: %lu\n", *out_size, sizeof(struct hinic_hw_stats)); return -EFAULT; } diff --git a/drivers/net/ethernet/huawei/hinic/hinic_nic_io.c b/drivers/net/ethernet/huawei/hinic/hinic_nic_io.c index f2fb0bc54570..b935c41a4435 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_nic_io.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_nic_io.c @@ -253,7 +253,7 @@ int hinic_create_qps(void *dev, u16 num_qp, u16 sq_depth, u16 rq_depth, max_qps = hinic_func_max_qnum(hwdev); if (num_qp > max_qps) { - nic_err(hwdev->dev_hdl, "Create number of qps: %d > max number of qps:%d\n", + nic_err(hwdev->dev_hdl, "Create number of qps: %d > max number of qps: %d\n", num_qp, max_qps); return -EINVAL; } diff --git a/drivers/net/ethernet/huawei/hinic/hinic_nictool.c b/drivers/net/ethernet/huawei/hinic/hinic_nictool.c index 3fcb855bd605..8ef008af05e8 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_nictool.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_nictool.c @@ -336,7 +336,7 @@ static int get_inter_num(struct hinic_nic_dev *nic_dev, void *buf_in, if (*out_size != sizeof(u16)) { nicif_err(nic_dev, drv, nic_dev->netdev, - "Unexpect out buf size from user :%d, expect: %lu\n", + "Unexpect out buf size from user: %d, expect: %lu\n", *out_size, sizeof(u16)); return -EFAULT; } @@ -381,7 +381,7 @@ static int get_num_cos(struct hinic_nic_dev *nic_dev, void *buf_in, if (*out_size != sizeof(*num_cos)) { nicif_err(nic_dev, drv, nic_dev->netdev, - "Unexpect out buf size from user :%d, expect: %lu\n", + "Unexpect out buf size from user: %d, expect: %lu\n", *out_size, sizeof(*num_cos)); return -EFAULT; } @@ -399,7 +399,7 @@ static int get_dcb_cos_up_map(struct hinic_nic_dev *nic_dev, void *buf_in, if (*out_size != sizeof(*map)) { nicif_err(nic_dev, drv, nic_dev->netdev, - "Unexpect out buf size from user :%d, expect: %lu\n", + "Unexpect out buf size from user: %d, expect: %lu\n", *out_size, sizeof(*map)); return -EFAULT; } @@ -438,7 +438,7 @@ static int get_rx_cqe_info(struct hinic_nic_dev *nic_dev, void *buf_in, if (*out_size != sizeof(struct hinic_rq_cqe)) { nicif_err(nic_dev, drv, nic_dev->netdev, - "Unexpect out buf size from user :%d, expect: %lu\n", + "Unexpect out buf size from user: %d, expect: %lu\n", *out_size, sizeof(struct hinic_rq_cqe)); return -EFAULT; } @@ -477,7 +477,7 @@ static int hinic_dbg_get_sq_info(struct hinic_nic_dev *nic_dev, u16 q_id, if (*msg_size != sizeof(*sq_info)) { nicif_err(nic_dev, drv, nic_dev->netdev, - "Unexpect out buf size from user :%d, expect: %lu\n", + "Unexpect out buf size from user: %d, expect: %lu\n", *msg_size, sizeof(*sq_info)); return -EFAULT; } @@ -576,7 +576,7 @@ static int get_loopback_mode(struct hinic_nic_dev *nic_dev, void *buf_in, if (*out_size != sizeof(*mode)) { nicif_err(nic_dev, drv, nic_dev->netdev, - "Unexpect out buf size from user :%d, expect: %lu\n", + "Unexpect out buf size from user: %d, expect: %lu\n", *out_size, sizeof(*mode)); return -EFAULT; } @@ -717,7 +717,7 @@ int set_pfc_control(struct hinic_nic_dev *nic_dev, void *buf_in, pfc_en = *((u8 *)buf_in); if (!(test_bit(HINIC_DCB_ENABLE, &nic_dev->flags))) { nicif_err(nic_dev, drv, nic_dev->netdev, - "Need to enable dcb first.\n"); + "Need to enable dcb first\n"); err = 0xff; goto exit; } @@ -752,7 +752,7 @@ int set_ets(struct hinic_nic_dev *nic_dev, void *buf_in, if (!(test_bit(HINIC_DCB_ENABLE, &nic_dev->flags))) { nicif_err(nic_dev, drv, nic_dev->netdev, - "Need to enable dcb first.\n"); + "Need to enable dcb first\n"); err = 0xff; goto exit; } @@ -765,7 +765,7 @@ int set_ets(struct hinic_nic_dev *nic_dev, void *buf_in, if (!(test_bit(HINIC_ETS_ENABLE, &nic_dev->flags))) { nicif_err(nic_dev, drv, nic_dev->netdev, - "Need to enable ets first.\n"); + "Need to enable ets first\n"); err = 0xff; goto exit; } @@ -792,7 +792,7 @@ int set_ets(struct hinic_nic_dev *nic_dev, void *buf_in, err = hinic_dcbnl_set_ets_tool(nic_dev->netdev); if (err) { nicif_err(nic_dev, drv, nic_dev->netdev, - "Failed to set ets [%d].\n", err); + "Failed to set ets [%d]\n", err); } exit: *((u8 *)buf_out) = err; @@ -838,7 +838,7 @@ int get_support_tc(struct hinic_nic_dev *nic_dev, void *buf_in, if (*out_size != sizeof(*tc_num)) { nicif_err(nic_dev, drv, nic_dev->netdev, - "Unexpect out buf size from user :%d, expect: %lu\n", + "Unexpect out buf size from user: %d, expect: %lu\n", *out_size, sizeof(*tc_num)); return -EFAULT; } @@ -881,7 +881,7 @@ int set_pfc_priority(struct hinic_nic_dev *nic_dev, void *buf_in, if (!((test_bit(HINIC_DCB_ENABLE, &nic_dev->flags)) && nic_dev->tmp_dcb_cfg.pfc_state)) { nicif_err(nic_dev, drv, nic_dev->netdev, - "Need to enable pfc first.\n"); + "Need to enable pfc first\n"); err = 0xff; goto exit; } @@ -983,7 +983,7 @@ static int set_poll_weight(struct hinic_nic_dev *nic_dev, void *buf_in, if (!buf_in || in_size != sizeof(*weight_info)) { nicif_err(nic_dev, drv, nic_dev->netdev, - "Unexpect in buf size from user :%u, expect: %lu\n", + "Unexpect in buf size from user: %u, expect: %lu\n", *out_size, sizeof(*weight_info)); return -EFAULT; } @@ -999,7 +999,7 @@ static int get_homologue(struct hinic_nic_dev *nic_dev, void *buf_in, struct hinic_homologues *homo = buf_out; if (!buf_out || *out_size != sizeof(*homo)) { nicif_err(nic_dev, drv, nic_dev->netdev, - "Unexpect out buf size from user :%d, expect: %lu\n", + "Unexpect out buf size from user: %d, expect: %lu\n", *out_size, sizeof(*homo)); return -EFAULT; } @@ -1020,7 +1020,7 @@ static int set_homologue(struct hinic_nic_dev *nic_dev, void *buf_in, struct hinic_homologues *homo = buf_in; if (!buf_in || in_size != sizeof(*homo)) { nicif_err(nic_dev, drv, nic_dev->netdev, - "Unexpect in buf size from user :%d, expect: %lu\n", + "Unexpect in buf size from user: %d, expect: %lu\n", *out_size, sizeof(*homo)); return -EFAULT; } @@ -1030,7 +1030,7 @@ static int set_homologue(struct hinic_nic_dev *nic_dev, void *buf_in, } else if (homo->homo_state == HINIC_HOMOLOGUES_OFF) { clear_bit(HINIC_SAME_RXTX, &nic_dev->flags); } else { - pr_err("Invalid parameters.\n"); + pr_err("Invalid parameters\n"); return -EFAULT; } @@ -1047,7 +1047,7 @@ static int get_sset_count(struct hinic_nic_dev *nic_dev, void *buf_in, if (!buf_in || !buf_out || in_size != sizeof(u32) || *out_size != sizeof(u32)) { nicif_err(nic_dev, drv, nic_dev->netdev, - "Invalid parameters.\n"); + "Invalid parameters\n"); return -EINVAL; } @@ -1083,7 +1083,7 @@ static int get_sset_stats(struct hinic_nic_dev *nic_dev, void *buf_in, if (count * sizeof(*items) != *out_size) { nicif_err(nic_dev, drv, nic_dev->netdev, - "Unexpect out buf size from user :%d, expect: %lu\n", + "Unexpect out buf size from user: %d, expect: %lu\n", *out_size, count * sizeof(*items)); return -EINVAL; } @@ -1112,7 +1112,7 @@ static int get_func_type(void *hwdev, void *buf_in, u32 in_size, func_typ = hinic_func_type(hwdev); if (!buf_out || *out_size != sizeof(u16)) { - pr_err("Unexpect out buf size from user :%d, expect: %lu\n", + pr_err("Unexpect out buf size from user: %d, expect: %lu\n", *out_size, sizeof(u16)); return -EFAULT; } @@ -1126,7 +1126,7 @@ static int get_func_id(void *hwdev, void *buf_in, u32 in_size, u16 func_id; if (!buf_out || *out_size != sizeof(u16)) { - pr_err("Unexpect out buf size from user :%d, expect: %lu\n", + pr_err("Unexpect out buf size from user: %d, expect: %lu\n", *out_size, sizeof(u16)); return -EFAULT; } @@ -1145,7 +1145,7 @@ static int get_chip_faults_stats(void *hwdev, void *buf_in, u32 in_size, if (!buf_in || !buf_out || *out_size != sizeof(*fault_info) || in_size != sizeof(*fault_info)) { - pr_err("Unexpect out buf size from user :%d, expect: %lu\n", + pr_err("Unexpect out buf size from user: %d, expect: %lu\n", *out_size, sizeof(*fault_info)); return -EFAULT; } @@ -1178,7 +1178,7 @@ static int get_drv_version(void *hwdev, void *buf_in, u32 in_size, int err; if (*out_size != sizeof(*ver_info)) { - pr_err("Unexpect out buf size from user :%d, expect: %lu\n", + pr_err("Unexpect out buf size from user: %d, expect: %lu\n", *out_size, sizeof(*ver_info)); return -EFAULT; } @@ -1212,7 +1212,7 @@ static int get_single_card_info(void *hwdev, void *buf_in, u32 in_size, { if (!buf_in || !buf_out || in_size != sizeof(struct card_info) || *out_size != sizeof(struct card_info)) { - pr_err("Unexpect out buf size from user :%d, expect: %lu\n", + pr_err("Unexpect out buf size from user: %d, expect: %lu\n", *out_size, sizeof(struct card_info)); return -EFAULT; } @@ -1230,7 +1230,7 @@ static int get_device_id(void *hwdev, void *buf_in, u32 in_size, int err; if (!buf_out || !buf_in || *out_size != sizeof(u16) || in_size != sizeof(u16)) { - pr_err("Unexpect out buf size from user :%d, expect: %lu\n", + pr_err("Unexpect out buf size from user: %d, expect: %lu\n", *out_size, sizeof(u16)); return -EFAULT; } @@ -1297,7 +1297,7 @@ static int __get_card_usr_api_chain_mem(int card_idx) (void *)__get_free_pages(GFP_KERNEL, DBGTOOL_PAGE_ORDER); if (!g_card_vir_addr[card_idx]) { - pr_err("Alloc api chain memory fail for card %d.\n", + pr_err("Alloc api chain memory fail for card %d\n", card_idx); mutex_unlock(&g_addr_lock); return -EFAULT; @@ -1309,7 +1309,7 @@ static int __get_card_usr_api_chain_mem(int card_idx) g_card_phy_addr[card_idx] = virt_to_phys(g_card_vir_addr[card_idx]); if (!g_card_phy_addr[card_idx]) { - pr_err("phy addr for card %d is 0.\n", card_idx); + pr_err("phy addr for card %d is 0\n", card_idx); free_pages((unsigned long)g_card_vir_addr[card_idx], DBGTOOL_PAGE_ORDER); g_card_vir_addr[card_idx] = NULL; @@ -1589,7 +1589,7 @@ static int send_to_ucode(void *hwdev, struct msg_module *nt_msg, nt_msg->ucode_cmd.ucode_db.ucode_cmd_type, buf_in, buf_out, 0); if (ret) - pr_err("Send direct cmdq err: %d!\n", ret); + pr_err("Send direct cmdq err: %d\n", ret); } else { ret = hinic_cmdq_detail_resp (hwdev, nt_msg->ucode_cmd.ucode_db.cmdq_ack_type, @@ -1597,7 +1597,7 @@ static int send_to_ucode(void *hwdev, struct msg_module *nt_msg, nt_msg->ucode_cmd.ucode_db.ucode_cmd_type, buf_in, buf_out, 0); if (ret) - pr_err("Send detail cmdq err: %d!\n", ret); + pr_err("Send detail cmdq err: %d\n", ret); } return ret; @@ -1732,7 +1732,7 @@ static int check_useparam_valid(struct msg_module *nt_msg, void *buf_in) u32 rd_len = csr_write_msg->rd_len; if (rd_len > TOOL_COUNTER_MAX_LEN) { - pr_err("Csr read or write len is invalid!\n"); + pr_err("Csr read or write len is invalid\n"); return -EINVAL; } @@ -1810,7 +1810,7 @@ static int sm_rd32(void *hwdev, u32 id, u8 instance, ret = hinic_sm_ctr_rd32(hwdev, node, instance, id, &val1); if (ret) { - pr_err("Get sm ctr information (32 bits)failed!\n"); + pr_err("Get sm ctr information (32 bits)failed\n"); val1 = 0xffffffff; } @@ -1827,7 +1827,7 @@ static int sm_rd64_pair(void *hwdev, u32 id, u8 instance, ret = hinic_sm_ctr_rd64_pair(hwdev, node, instance, id, &val1, &val2); if (ret) { - pr_err("Get sm ctr information (64 bits pair)failed!\n"); + pr_err("Get sm ctr information (64 bits pair)failed\n"); val1 = 0xffffffff; } @@ -1845,7 +1845,7 @@ static int sm_rd64(void *hwdev, u32 id, u8 instance, ret = hinic_sm_ctr_rd64(hwdev, node, instance, id, &val1); if (ret) { - pr_err("Get sm ctr information (64 bits)failed!\n"); + pr_err("Get sm ctr information (64 bits)failed\n"); val1 = 0xffffffff; } buf_out->val1 = val1; @@ -1890,7 +1890,7 @@ static int send_to_sm(void *hwdev, struct msg_module *nt_msg, } if (ret) - pr_err("Get sm information fail!\n"); + pr_err("Get sm information fail\n"); *out_size = sizeof(struct sm_out_st); @@ -2024,7 +2024,7 @@ static int get_self_test_cmd(struct msg_module *nt_msg) ret = hinic_get_self_test_result(nt_msg->device_name, &res); if (ret) { - pr_err("Get self test result failed!\n"); + pr_err("Get self test result failed\n"); return -EFAULT; } diff --git a/drivers/net/ethernet/huawei/hinic/hinic_port_cmd.h b/drivers/net/ethernet/huawei/hinic/hinic_port_cmd.h index 0b13ba9d2f26..1d3c0301ba63 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_port_cmd.h +++ b/drivers/net/ethernet/huawei/hinic/hinic_port_cmd.h @@ -93,7 +93,7 @@ enum hinic_port_cmd { HINIC_PORT_CMD_SET_JUMBO_FRAME_SIZE, /* 0x4c ~ 0x57 have defined in base line */ - HINIC_PORT_CMD_DISABLE_PROMISIC = 0x4c, + HINIC_PORT_CMD_DISABLE_PROMISC = 0x4c, HINIC_PORT_CMD_ENABLE_SPOOFCHK = 0x4e, HINIC_PORT_CMD_GET_MGMT_VERSION = 0x58, HINIC_PORT_CMD_GET_BOOT_VERSION, diff --git a/drivers/net/ethernet/huawei/hinic/hinic_sriov.c b/drivers/net/ethernet/huawei/hinic/hinic_sriov.c index 047023267ead..1a436c133785 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_sriov.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_sriov.c @@ -39,7 +39,7 @@ int hinic_pci_sriov_disable(struct pci_dev *dev) if (test_and_set_bit(HINIC_SRIOV_DISABLE, &sriov_info->state)) { nic_err(&sriov_info->pdev->dev, - "SR-IOV disable in process, please wait"); + "SR-IOV disable in process, please wait\n"); return -EPERM; } @@ -190,7 +190,7 @@ int hinic_ndo_set_vf_mac(struct net_device *netdev, int vf, u8 *mac) return err; nic_info(&sriov_info->pdev->dev, "Setting MAC %pM on VF %d\n", mac, vf); - nic_info(&sriov_info->pdev->dev, "Reload the VF driver to make this change effective."); + nic_info(&sriov_info->pdev->dev, "Reload the VF driver to make this change effective\n"); return 0; } diff --git a/drivers/net/ethernet/huawei/hinic/hinic_tx.c b/drivers/net/ethernet/huawei/hinic/hinic_tx.c index b556132a72af..8d921ad104e8 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_tx.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_tx.c @@ -949,7 +949,7 @@ int hinic_setup_all_tx_resources(struct net_device *netdev) txq = &nic_dev->txqs[q_id]; tx_info_sz = txq->q_depth * sizeof(*txq->tx_info); if (!tx_info_sz) { - nicif_err(nic_dev, drv, netdev, "Cannot allocate zero size tx%d info\n", + nicif_err(nic_dev, drv, netdev, "Cannot allocate zero size txq%d info\n", q_id); err = -EINVAL; goto init_txq_err; @@ -965,7 +965,7 @@ int hinic_setup_all_tx_resources(struct net_device *netdev) err = hinic_setup_tx_wqe(txq); if (err != txq->q_depth) { - nicif_err(nic_dev, drv, netdev, "Failed to setup Tx:%d wqe\n", + nicif_err(nic_dev, drv, netdev, "Failed to setup Tx: %d wqe\n", q_id); q_id++; goto init_txq_err; diff --git a/drivers/net/ethernet/huawei/hinic/hinic_wq.c b/drivers/net/ethernet/huawei/hinic/hinic_wq.c index 032b28332a65..fcf98413d2de 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_wq.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_wq.c @@ -55,7 +55,7 @@ static int queue_alloc_page(void *handle, u64 **vaddr, u64 *paddr, } if (!ADDR_4K_ALIGNED(dma_addr)) { - sdk_err(handle, "Cla is not 4k aligned!\n"); + sdk_err(handle, "Cla is not 4k aligned\n"); goto shadow_vaddr_err; } -- 2.25.1
From: Chiqijun <chiqijun@huawei.com> driver inclusion category: bugfix bugzilla: 4472 ----------------------------------------------------------------------- Delete unused microcode back pressure feature. Signed-off-by: Chiqijun <chiqijun@huawei.com> Reviewed-by: Zengweiliang <zengweiliang.zengweiliang@huawei.com> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- .../net/ethernet/huawei/hinic/hinic_ethtool.c | 16 --- .../net/ethernet/huawei/hinic/hinic_main.c | 32 ----- .../net/ethernet/huawei/hinic/hinic_nic_cfg.c | 131 ------------------ .../net/ethernet/huawei/hinic/hinic_nic_cfg.h | 11 -- .../net/ethernet/huawei/hinic/hinic_nic_dev.h | 3 - drivers/net/ethernet/huawei/hinic/hinic_rx.c | 38 ----- drivers/net/ethernet/huawei/hinic/hinic_rx.h | 9 -- 7 files changed, 240 deletions(-) diff --git a/drivers/net/ethernet/huawei/hinic/hinic_ethtool.c b/drivers/net/ethernet/huawei/hinic/hinic_ethtool.c index f79594570002..e144d11e9c59 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_ethtool.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_ethtool.c @@ -1009,14 +1009,6 @@ static int hinic_set_ringparam(struct net_device *netdev, new_rq_depth == nic_dev->rq_depth) return 0; - if (test_bit(HINIC_BP_ENABLE, &nic_dev->flags) && - new_rq_depth <= nic_dev->bp_upper_thd) { - nicif_err(nic_dev, drv, netdev, - "BP is enable, rq_depth must be larger than upper threshold: %d\n", - nic_dev->bp_upper_thd); - return -EINVAL; - } - nicif_info(nic_dev, drv, netdev, "Change Tx/Rx ring depth from %d/%d to %d/%d\n", nic_dev->sq_depth, nic_dev->rq_depth, @@ -1796,14 +1788,6 @@ static int hinic_set_pauseparam(struct net_device *netdev, return -EOPNOTSUPP; } - if (test_bit(HINIC_BP_ENABLE, &nic_dev->flags) && pause->tx_pause && - nic_dev->rq_depth <= nic_dev->bp_upper_thd) { - nicif_err(nic_dev, drv, netdev, - "Can not set tx pause enable, rq depth is less than bp upper threshold: %d\n", - nic_dev->bp_upper_thd); - return -EINVAL; - } - err = hinic_get_port_info(nic_dev->hwdev, &port_info); if (err) { nicif_err(nic_dev, drv, netdev, diff --git a/drivers/net/ethernet/huawei/hinic/hinic_main.c b/drivers/net/ethernet/huawei/hinic/hinic_main.c index 56af81d132fd..53335834445b 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_main.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_main.c @@ -137,11 +137,6 @@ static unsigned char qp_coalesc_timer_high = HINIC_RX_COAL_TIME_HIGH; module_param(qp_coalesc_timer_high, byte, 0444); MODULE_PARM_DESC(qp_coalesc_timer_high, "MSI-X adaptive high coalesce time, range is 0 - 255"); -static unsigned int enable_bp; - -static unsigned int bp_lower_thd = HINIC_RX_BP_LOWER_THD; -static unsigned int bp_upper_thd = HINIC_RX_BP_UPPER_THD; - #define HINIC_NIC_DEV_WQ_NAME "hinic_nic_dev_wq" #define DEFAULT_MSG_ENABLE (NETIF_MSG_DRV | NETIF_MSG_LINK) @@ -1554,26 +1549,6 @@ static int hinic_set_default_hw_feature(struct hinic_nic_dev *nic_dev) return -EFAULT; } - if (enable_bp) { - nic_dev->bp_upper_thd = (u16)bp_upper_thd; - nic_dev->bp_lower_thd = (u16)bp_lower_thd; - err = hinic_set_bp_thd(nic_dev->hwdev, - nic_dev->bp_lower_thd); - if (err) { - nic_err(&nic_dev->pdev->dev, - "Failed to set bp lower threshold\n"); - return -EFAULT; - } - - set_bit(HINIC_BP_ENABLE, &nic_dev->flags); - } else { - err = hinic_disable_fw_bp(nic_dev->hwdev); - if (err) - return -EFAULT; - - clear_bit(HINIC_BP_ENABLE, &nic_dev->flags); - } - hinic_set_anti_attack(nic_dev->hwdev, true); if (set_link_status_follow < HINIC_LINK_FOLLOW_STATUS_MAX && @@ -2520,13 +2495,6 @@ static int hinic_validate_parameters(struct hinic_lld_dev *lld_dev) { struct pci_dev *pdev = lld_dev->pdev; - if (bp_upper_thd < bp_lower_thd || bp_lower_thd == 0) { - nic_warn(&pdev->dev, "Module Parameter bp_upper_thd: %d, bp_lower_thd: %d is invalid, resetting to default\n", - bp_upper_thd, bp_lower_thd); - bp_lower_thd = HINIC_RX_BP_LOWER_THD; - bp_upper_thd = HINIC_RX_BP_UPPER_THD; - } - /* Check poll_weight value, default poll_weight is 64. * The poll_weight isn't more than max queue depth, * so the valid value range is 1~4096. diff --git a/drivers/net/ethernet/huawei/hinic/hinic_nic_cfg.c b/drivers/net/ethernet/huawei/hinic/hinic_nic_cfg.c index 1bac0ea08a52..ad0dd6e9312b 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_nic_cfg.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_nic_cfg.c @@ -1478,137 +1478,6 @@ int hinic_dcb_set_rq_iq_mapping(void *hwdev, u32 num_rqs, u8 *map) } EXPORT_SYMBOL(hinic_dcb_set_rq_iq_mapping); -int hinic_set_pfc_threshold(void *hwdev, u16 op_type, u16 threshold) -{ - struct hinic_pfc_thd pfc_thd = {0}; - u16 out_size = sizeof(pfc_thd); - int err; - - if (op_type == HINIC_PFC_SET_FUNC_THD) - pfc_thd.func_thd = threshold; - else if (op_type == HINIC_PFC_SET_GLB_THD) - pfc_thd.glb_thd = threshold; - else - return -EINVAL; - - err = hinic_global_func_id_get(hwdev, &pfc_thd.func_id); - if (err) - return err; - - pfc_thd.op_type = op_type; - - err = l2nic_msg_to_mgmt_sync(hwdev, HINIC_PORT_CMD_SET_PFC_THD, - &pfc_thd, sizeof(pfc_thd), - &pfc_thd, &out_size); - if (err || !out_size || pfc_thd.status) { - nic_err(((struct hinic_hwdev *)hwdev)->dev_hdl, - "Failed to set pfc threshold, err: %d, status: 0x%x, out size: 0x%x\n", - err, pfc_thd.status, out_size); - return -EFAULT; - } - - return 0; -} - -int hinic_set_bp_thd(void *hwdev, u16 threshold) -{ - int err; - - err = hinic_set_pfc_threshold(hwdev, HINIC_PFC_SET_GLB_THD, threshold); - if (err) { - nic_err(((struct hinic_hwdev *)hwdev)->dev_hdl, - "Failed to set global threshold\n"); - return -EFAULT; - } - - err = hinic_set_pfc_threshold(hwdev, HINIC_PFC_SET_FUNC_THD, threshold); - if (err) { - nic_err(((struct hinic_hwdev *)hwdev)->dev_hdl, - "Failed to set function threshold\n"); - return -EFAULT; - } - - return 0; -} - -int hinic_disable_fw_bp(void *hwdev) -{ - int err; - - err = hinic_set_pfc_threshold(hwdev, HINIC_PFC_SET_FUNC_THD, 0); - if (err) { - nic_err(((struct hinic_hwdev *)hwdev)->dev_hdl, - "Failed to disable ucode backpressure\n"); - return -EFAULT; - } - - return 0; -} - -int hinic_set_iq_enable(void *hwdev, u16 q_id, u16 lower_thd, u16 prod_idx) -{ - struct hinic_hwdev *dev = hwdev; - struct hinic_cmd_enable_iq *iq_info; - struct hinic_cmd_buf *cmd_buf; - int err; - - cmd_buf = hinic_alloc_cmd_buf(hwdev); - if (!cmd_buf) { - nic_err(dev->dev_hdl, "Failed to allocate cmd buf\n"); - return -ENOMEM; - } - - iq_info = cmd_buf->buf; - cmd_buf->size = sizeof(*iq_info); - - iq_info->force_en = 0; - iq_info->rq_depth = (u8)ilog2(dev->nic_io->rq_depth); - iq_info->num_rq = (u8)dev->nic_io->max_qps; - /* num_qps will not lager than 64 */ - iq_info->glb_rq_id = dev->nic_io->global_qpn + q_id; - iq_info->q_id = q_id; - iq_info->lower_thd = lower_thd; - iq_info->prod_idx = prod_idx; - hinic_cpu_to_be32(iq_info, sizeof(*iq_info)); - - err = hinic_cmdq_async(hwdev, HINIC_ACK_TYPE_CMDQ, HINIC_MOD_L2NIC, - HINIC_UCODE_CMD_SET_IQ_ENABLE, cmd_buf); - if (err) { - hinic_free_cmd_buf(hwdev, cmd_buf); - nic_err(dev->dev_hdl, "Failed to set iq enable, err:%d\n", err); - return -EFAULT; - } - - return 0; -} - -int hinic_set_iq_enable_mgmt(void *hwdev, u16 q_id, u16 lower_thd, u16 prod_idx) -{ - struct hinic_hwdev *dev = hwdev; - struct hinic_cmd_enable_iq_mgmt iq_info = {0}; - int err; - - iq_info.force_en = 0; - - iq_info.rq_depth = (u8)ilog2(dev->nic_io->rq_depth); - iq_info.num_rq = (u8)dev->nic_io->max_qps; - /* num_qps will not lager than 64 */ - iq_info.glb_rq_id = dev->nic_io->global_qpn + q_id; - iq_info.q_id = q_id; - iq_info.lower_thd = lower_thd; - iq_info.prod_idx = prod_idx; - - err = l2nic_msg_to_mgmt_async(hwdev, HINIC_PORT_CMD_SET_IQ_ENABLE, - &iq_info, sizeof(iq_info)); - if (err || iq_info.status) { - nic_err(dev->dev_hdl, "Failed to set iq enable for rq:%d, err: %d, status: 0x%x\n", - q_id, err, iq_info.status); - return -EFAULT; - } - - return 0; -} - /* nictool */ int hinic_set_lro_aging_timer(void *hwdev, u8 timer_en, u32 period) { diff --git a/drivers/net/ethernet/huawei/hinic/hinic_nic_cfg.h b/drivers/net/ethernet/huawei/hinic/hinic_nic_cfg.h index 89b324912879..2f4f893d3f52 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_nic_cfg.h +++ b/drivers/net/ethernet/huawei/hinic/hinic_nic_cfg.h @@ -499,17 +499,6 @@ int hinic_dcb_set_cos_up_map(void *hwdev, u8 cos_valid_bitmap, u8 *cos_up); int hinic_dcb_set_rq_iq_mapping(void *hwdev, u32 num_rqs, u8 *map); -int hinic_set_pfc_threshold(void *hwdev, u16 op_type, u16 threshold); - -int hinic_set_bp_thd(void *hwdev, u16 threshold); - -int hinic_disable_fw_bp(void *hwdev); - -int hinic_set_iq_enable(void *hwdev, u16 q_id, u16 lower_thd, u16 prod_idx); - -int hinic_set_iq_enable_mgmt(void *hwdev, u16 q_id, u16 lower_thd, - u16 prod_idx); - /* nictool adaptation interface*/ int hinic_set_lro_aging_timer(void *hwdev, u8 timer_en, u32 period); /* There should be output parameters, add the diff --git a/drivers/net/ethernet/huawei/hinic/hinic_nic_dev.h b/drivers/net/ethernet/huawei/hinic/hinic_nic_dev.h index d7b931ee842e..e0cebe29735e 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_nic_dev.h +++ b/drivers/net/ethernet/huawei/hinic/hinic_nic_dev.h @@ -41,7 +41,6 @@ enum hinic_flags { HINIC_LP_TEST, HINIC_RSS_ENABLE, HINIC_DCB_ENABLE, - HINIC_BP_ENABLE, HINIC_SAME_RXTX, HINIC_INTR_ADAPT, HINIC_UPDATE_MAC_FILTER, @@ -219,8 +218,6 @@ struct hinic_nic_dev { /* lock for disable or enable traffic flow */ struct semaphore dcb_sem; - u16 bp_lower_thd; - u16 bp_upper_thd; bool heart_status; struct hinic_intr_coal_info *intr_coalesce; diff --git a/drivers/net/ethernet/huawei/hinic/hinic_rx.c b/drivers/net/ethernet/huawei/hinic/hinic_rx.c index 9031186ede95..05d9625267e3 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_rx.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_rx.c @@ -384,7 +384,6 @@ void hinic_rxq_get_stats(struct hinic_rxq *rxq, rxq_stats->other_errors; stats->csum_errors = rxq_stats->csum_errors; stats->other_errors = rxq_stats->other_errors; - stats->unlock_bp = rxq_stats->unlock_bp; stats->dropped = rxq_stats->dropped; } while (u64_stats_fetch_retry(&rxq_stats->syncp, start)); u64_stats_update_end(&stats->syncp); @@ -397,7 +396,6 @@ void hinic_rxq_clean_stats(struct hinic_rxq_stats *rxq_stats) rxq_stats->packets = 0; rxq_stats->errors = 0; rxq_stats->csum_errors = 0; - rxq_stats->unlock_bp = 0; rxq_stats->other_errors = 0; rxq_stats->dropped = 0; @@ -477,34 +475,6 @@ static void hinic_rx_gro(struct hinic_rxq *rxq, u32 offload_type, skb->csum_level = 1; } -#define HINIC_RX_BP_THD 128 - -static void hinic_unlock_bp(struct hinic_rxq *rxq, bool bp_en, bool force_en) -{ - struct net_device *netdev = rxq->netdev; - struct hinic_nic_dev *nic_dev = netdev_priv(netdev); - int free_wqebbs, err; - - if (bp_en) - set_bit(HINIC_RX_STATUS_BP_EN, &rxq->status); - - free_wqebbs = rxq->delta - 1; - if (test_bit(HINIC_RX_STATUS_BP_EN, &rxq->status) && - (nic_dev->rq_depth - free_wqebbs) >= nic_dev->bp_upper_thd && - (rxq->bp_cnt >= HINIC_RX_BP_THD || force_en)) { - err = hinic_set_iq_enable_mgmt(nic_dev->hwdev, rxq->q_id, - nic_dev->bp_lower_thd, - rxq->next_to_update); - if (!err) { - clear_bit(HINIC_RX_STATUS_BP_EN, &rxq->status); - rxq->bp_cnt = 0; - rxq->rxq_stats.unlock_bp++; - } else { - nicif_err(nic_dev, drv, netdev, "Failed to set iq enable\n"); - } - } -} - static void hinic_copy_lp_data(struct hinic_nic_dev *nic_dev, struct sk_buff *skb) { @@ -653,7 +623,6 @@ int hinic_rx_poll(struct hinic_rxq *rxq, int budget) u64 rx_bytes = 0; u16 sw_ci, num_lro; int pkts = 0, nr_pkts = 0; - bool bp_en = false; u16 num_wqe = 0; while (likely(pkts < budget)) { @@ -695,10 +664,6 @@ int hinic_rx_poll(struct hinic_rxq *rxq, int budget) ((pkt_len & (rxq->buf_len - 1)) ? 1 : 0); } } - if (unlikely(HINIC_GET_RX_BP_EN(status))) { - rxq->bp_cnt++; - bp_en = true; - } rx_cqe->status = 0; @@ -709,9 +674,6 @@ int hinic_rx_poll(struct hinic_rxq *rxq, int budget) if (rxq->delta >= HINIC_RX_BUFFER_WRITE) hinic_rx_fill_buffers(rxq); - if (unlikely(bp_en || test_bit(HINIC_RX_STATUS_BP_EN, &rxq->status))) - hinic_unlock_bp(rxq, bp_en, pkts < budget); - u64_stats_update_begin(&rxq->rxq_stats.syncp); rxq->rxq_stats.packets += nr_pkts; rxq->rxq_stats.bytes += rx_bytes; diff --git a/drivers/net/ethernet/huawei/hinic/hinic_rx.h b/drivers/net/ethernet/huawei/hinic/hinic_rx.h index e9854b02f40a..403b390f2fff 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_rx.h +++ b/drivers/net/ethernet/huawei/hinic/hinic_rx.h @@ -29,23 +29,15 @@ #define HINIC_RX_CSUM_OFFLOAD_EN 0xFFF -#define HINIC_RX_BP_LOWER_THD 200 -#define HINIC_RX_BP_UPPER_THD 400 - #define HINIC_SUPPORT_LRO_ADAP_QPS_MAX 16 #define HINIC_RX_BUFFER_WRITE 16 -enum { - HINIC_RX_STATUS_BP_EN, -}; - struct hinic_rxq_stats { u64 packets; u64 bytes; u64 errors; u64 csum_errors; u64 other_errors; - u64 unlock_bp; u64 dropped; u64 alloc_skb_err; @@ -88,7 +80,6 @@ struct hinic_rxq { u16 next_to_update; struct device *dev; /* device for DMA mapping */ - u32 bp_cnt; unsigned long status; dma_addr_t cqe_start_paddr; void *cqe_start_vaddr; -- 2.25.1
From: Chiqijun <chiqijun@huawei.com> driver inclusion category: bugfix bugzilla: 4472 ----------------------------------------------------------------------- Delete the unused chip fault handling process. Signed-off-by: Chiqijun <chiqijun@huawei.com> Reviewed-by: Zengweiliang <zengweiliang.zengweiliang@huawei.com> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- drivers/net/ethernet/huawei/hinic/hinic_cfg.c | 9 - drivers/net/ethernet/huawei/hinic/hinic_eqs.c | 2 - drivers/net/ethernet/huawei/hinic/hinic_hw.h | 14 -- .../net/ethernet/huawei/hinic/hinic_hwdev.c | 184 ------------------ .../net/ethernet/huawei/hinic/hinic_hwdev.h | 20 -- 5 files changed, 229 deletions(-) diff --git a/drivers/net/ethernet/huawei/hinic/hinic_cfg.c b/drivers/net/ethernet/huawei/hinic/hinic_cfg.c index 303225e5689e..96e6043f2321 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_cfg.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_cfg.c @@ -2142,21 +2142,12 @@ static int hinic_os_dep_init(struct hinic_hwdev *hwdev) return -EFAULT; } - sema_init(&hwdev->recover_sem, 1); - sema_init(&hwdev->fault_list_sem, 1); - - INIT_WORK(&hwdev->fault_work, hinic_fault_work_handler); - return 0; } static void hinic_os_dep_deinit(struct hinic_hwdev *hwdev) { destroy_workqueue(hwdev->workq); - - down(&hwdev->fault_list_sem); - - up(&hwdev->fault_list_sem); } void hinic_ppf_hwdev_unreg(void *hwdev) diff --git a/drivers/net/ethernet/huawei/hinic/hinic_eqs.c b/drivers/net/ethernet/huawei/hinic/hinic_eqs.c index 6c352dff996a..e582cc378bd5 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_eqs.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_eqs.c @@ -550,8 +550,6 @@ static bool aeq_irq_handler(struct hinic_eq *eq) lev = aeqs->aeq_swe_cb[sw_event](aeqs->hwdev, ucode_event, aeqe_data); - hinic_swe_fault_handler(aeqs->hwdev, lev, - ucode_event, aeqe_data); } clear_bit(HINIC_AEQ_SW_CB_RUNNING, &aeqs->aeq_sw_cb_state[sw_event]); diff --git a/drivers/net/ethernet/huawei/hinic/hinic_hw.h b/drivers/net/ethernet/huawei/hinic/hinic_hw.h index c4d48ccf8f2a..7b12a8142bab 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_hw.h +++ b/drivers/net/ethernet/huawei/hinic/hinic_hw.h @@ -570,18 +570,6 @@ struct hinic_fault_event { union hinic_fault_hw_mgmt event; }; -struct hinic_fault_recover_info { - u8 fault_src; /* enum hinic_fault_source_type */ - u8 fault_lev; /* enum hinic_fault_err_level */ - u8 rsvd0[2]; - union { - union hinic_fault_hw_mgmt hw_mgmt; - struct hinic_fault_sw_mgmt sw_mgmt; - u32 mgmt_rsvd[4]; - u32 host_rsvd[4]; - } fault_data; -}; - struct hinic_dcb_state { u8 dcb_on; u8 default_cos; @@ -682,8 +670,6 @@ enum hinic_ucode_event_type { typedef void (*hinic_event_handler)(void *handle, struct hinic_event_info *event); -typedef void (*hinic_fault_recover_handler)(void *pri_handle, - struct hinic_fault_recover_info info); /* only register once */ void hinic_event_register(void *dev, void *pri_handle, hinic_event_handler callback); diff --git a/drivers/net/ethernet/huawei/hinic/hinic_hwdev.c b/drivers/net/ethernet/huawei/hinic/hinic_hwdev.c index d19da7238f9b..0971745689ab 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_hwdev.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_hwdev.c @@ -761,15 +761,6 @@ int hinic_get_chip_present_flag(void *hwdev) } EXPORT_SYMBOL(hinic_get_chip_present_flag); - -static void hinic_set_fast_recycle_status(void *hwdev) -{ - struct hinic_hwdev *dev = hwdev; - - sdk_err(dev->dev_hdl, "Enter fast recycle status\n"); - dev->chip_present_flag = HINIC_CHIP_ABSENT; -} - void hinic_force_complete_all(void *hwdev) { struct hinic_hwdev *dev = (struct hinic_hwdev *)hwdev; @@ -3509,20 +3500,6 @@ static void fault_report_show(struct hinic_hwdev *hwdev, } } -static void hinic_refresh_history_fault(struct hinic_hwdev *hwdev, - struct hinic_fault_recover_info *info) -{ - if (!hwdev->history_fault_flag) { - hwdev->history_fault_flag = true; - memcpy(&hwdev->history_fault, info, - sizeof(struct hinic_fault_recover_info)); - } else { - if (hwdev->history_fault.fault_lev >= info->fault_lev) - memcpy(&hwdev->history_fault, info, - sizeof(struct hinic_fault_recover_info)); - } -} - void hinic_migrate_report(void *dev) { struct hinic_hwdev *hwdev = (struct hinic_hwdev *)dev; @@ -3542,7 +3519,6 @@ static void fault_event_handler(struct hinic_hwdev *hwdev, void *buf_in, { struct hinic_cmd_fault_event *fault_event; struct hinic_event_info event_info; - struct hinic_fault_info_node *fault_node; u8 fault_level; if (in_size != sizeof(*fault_event)) { @@ -3566,35 +3542,10 @@ static void fault_event_handler(struct hinic_hwdev *hwdev, void *buf_in, event_info.info.fault_level = fault_level; hwdev->event_callback(hwdev->event_pri_handle, &event_info); } - - /* refresh history fault info */ - fault_node = kzalloc(sizeof(*fault_node), GFP_KERNEL); - if (!fault_node) { - sdk_err(hwdev->dev_hdl, "Malloc fault node memory failed\n"); - return; - } - - if (fault_event->event.type <= FAULT_TYPE_REG_WR_TIMEOUT) - fault_node->info.fault_src = fault_event->event.type; - else if (fault_event->event.type == FAULT_TYPE_PHY_FAULT) - fault_node->info.fault_src = HINIC_FAULT_SRC_HW_PHY_FAULT; - - fault_node->info.fault_lev = fault_level; - - memcpy(&fault_node->info.fault_data.hw_mgmt, &fault_event->event.event, - sizeof(union hinic_fault_hw_mgmt)); - hinic_refresh_history_fault(hwdev, &fault_node->info); - - down(&hwdev->fault_list_sem); - kfree(fault_node); - up(&hwdev->fault_list_sem); - - queue_work(hwdev->workq, &hwdev->fault_work); } static void heartbeat_lost_event_handler(struct hinic_hwdev *hwdev) { - struct hinic_fault_info_node *fault_node; struct hinic_event_info event_info = {0}; atomic_inc(&hwdev->hw_stats.heart_lost_stats); @@ -3605,23 +3556,6 @@ static void heartbeat_lost_event_handler(struct hinic_hwdev *hwdev) event_info.type = HINIC_EVENT_HEART_LOST; hwdev->event_callback(hwdev->event_pri_handle, &event_info); } - - /* refresh history fault info */ - fault_node = kzalloc(sizeof(*fault_node), GFP_KERNEL); - if (!fault_node) { - sdk_err(hwdev->dev_hdl, "Malloc fault node memory failed\n"); - return; - } - - fault_node->info.fault_src = HINIC_FAULT_SRC_HOST_HEARTBEAT_LOST; - fault_node->info.fault_lev = FAULT_LEVEL_FATAL; - hinic_refresh_history_fault(hwdev, &fault_node->info); - - down(&hwdev->fault_list_sem); - kfree(fault_node); - up(&hwdev->fault_list_sem); - - queue_work(hwdev->workq, &hwdev->fault_work); } static void link_status_event_handler(struct hinic_hwdev *hwdev, void *buf_in, @@ -3818,7 +3752,6 @@ static void mgmt_watchdog_timeout_event_handler(struct hinic_hwdev *hwdev, void *buf_in, u16 in_size, void *buf_out, u16 *out_size) { - struct hinic_fault_info_node *fault_node; struct hinic_event_info event_info = { 0 }; sw_watchdog_timeout_info_show(hwdev, buf_in, in_size, @@ -3828,23 +3761,6 @@ static void mgmt_watchdog_timeout_event_handler(struct hinic_hwdev *hwdev, event_info.type = HINIC_EVENT_MGMT_WATCHDOG_EVENT; hwdev->event_callback(hwdev->event_pri_handle, &event_info); } - - /* refresh history fault info */ - fault_node = kzalloc(sizeof(*fault_node), GFP_KERNEL); - if (!fault_node) { - sdk_err(hwdev->dev_hdl, "Malloc fault node memory failed\n"); - return; - } - - fault_node->info.fault_src = HINIC_FAULT_SRC_MGMT_WATCHDOG; - fault_node->info.fault_lev = FAULT_LEVEL_FATAL; - hinic_refresh_history_fault(hwdev, &fault_node->info); - - down(&hwdev->fault_list_sem); - kfree(fault_node); - up(&hwdev->fault_list_sem); - - queue_work(hwdev->workq, &hwdev->fault_work); } static void port_sfp_info_event(struct hinic_hwdev *hwdev, void *buf_in, @@ -5118,106 +5034,6 @@ int hinic_read_reg(void *hwdev, u32 reg_addr, u32 *val) return 0; } -static void hinic_exec_recover_cb(struct hinic_hwdev *hwdev, - struct hinic_fault_recover_info *info) -{ - sdk_info(hwdev->dev_hdl, "Enter hinic_exec_recover_cb\n"); - - if (!hinic_get_chip_present_flag(hwdev)) { - sdk_err(hwdev->dev_hdl, "Device surprised removed, abort recover\n"); - return; - } - - if (info->fault_lev >= FAULT_LEVEL_MAX) { - sdk_err(hwdev->dev_hdl, "Invalid fault level\n"); - return; - } - - down(&hwdev->recover_sem); - if (hwdev->recover_cb) { - if (info->fault_lev <= FAULT_LEVEL_SERIOUS_FLR) - hinic_set_fast_recycle_status(hwdev); - - hwdev->recover_cb(hwdev->recover_pri_hd, *info); - } - up(&hwdev->recover_sem); -} - -void hinic_fault_work_handler(struct work_struct *work) -{ - struct hinic_hwdev *hwdev = - container_of(work, struct hinic_hwdev, fault_work); - - down(&hwdev->fault_list_sem); - up(&hwdev->fault_list_sem); -} - -void hinic_swe_fault_handler(struct hinic_hwdev *hwdev, u8 level, - u8 event, u64 val) -{ - struct hinic_fault_info_node *fault_node; - - if (level < FAULT_LEVEL_MAX) { - fault_node = kzalloc(sizeof(*fault_node), GFP_KERNEL); - if (!fault_node) { - sdk_err(hwdev->dev_hdl, "Malloc fault node memory failed\n"); - return; - } - - fault_node->info.fault_src = HINIC_FAULT_SRC_SW_MGMT_UCODE; - fault_node->info.fault_lev = level; - fault_node->info.fault_data.sw_mgmt.event_id = event; - fault_node->info.fault_data.sw_mgmt.event_data = val; - hinic_refresh_history_fault(hwdev, &fault_node->info); - - down(&hwdev->fault_list_sem); - kfree(fault_node); - up(&hwdev->fault_list_sem); - - queue_work(hwdev->workq, &hwdev->fault_work); - } -} - -int hinic_register_fault_recover(void *hwdev, void *pri_handle, - hinic_fault_recover_handler cb) -{ - struct hinic_hwdev *dev = hwdev; - - if (!hwdev || !pri_handle || !cb) { - pr_err("Invalid input parameters when register fault recover handler\n"); - return -EINVAL; - } - - down(&dev->recover_sem); - dev->recover_pri_hd = pri_handle; - dev->recover_cb = cb; - up(&dev->recover_sem); - - if (dev->history_fault_flag) - hinic_exec_recover_cb(dev, &dev->history_fault); - - return 0; -} -EXPORT_SYMBOL(hinic_register_fault_recover); - -int hinic_unregister_fault_recover(void *hwdev) -{ - struct hinic_hwdev *dev = hwdev; - - if (!hwdev) { - pr_err("Invalid input parameters when unregister fault recover handler\n"); - return -EINVAL; - } - - down(&dev->recover_sem); - dev->recover_pri_hd = NULL; - dev->recover_cb = NULL; - up(&dev->recover_sem); - - return 0; -} -EXPORT_SYMBOL(hinic_unregister_fault_recover); - void hinic_set_func_deinit_flag(void *hwdev) { struct hinic_hwdev *dev = hwdev; diff --git a/drivers/net/ethernet/huawei/hinic/hinic_hwdev.h b/drivers/net/ethernet/huawei/hinic/hinic_hwdev.h index 32e285939d4a..68a452496841 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_hwdev.h +++ b/drivers/net/ethernet/huawei/hinic/hinic_hwdev.h @@ -175,12 +175,6 @@ struct hinic_hw_stats { struct hinic_fault_event_stats fault_event_stats; }; -struct hinic_fault_info_node { - struct list_head list; - struct hinic_hwdev *hwdev; - struct hinic_fault_recover_info info; -}; - enum heartbeat_support_state { HEARTBEAT_NOT_SUPPORT = 0, HEARTBEAT_SUPPORT, @@ -284,16 +278,6 @@ struct hinic_hwdev { hinic_event_handler event_callback; void *event_pri_handle; - struct semaphore recover_sem; - bool collect_log_flag; - bool history_fault_flag; - struct hinic_fault_recover_info history_fault; - void *recover_pri_hd; - hinic_fault_recover_handler recover_cb; - - struct work_struct fault_work; - struct semaphore fault_list_sem; - struct work_struct timer_work; struct workqueue_struct *workq; struct timer_list heartbeat_timer; @@ -379,10 +363,6 @@ int hinic_pf_send_clp_cmd(void *hwdev, enum hinic_mod_type mod, u8 cmd, int hinic_get_bios_pf_bw_limit(void *hwdev, u32 *pf_bw_limit); -void hinic_fault_work_handler(struct work_struct *work); -void hinic_swe_fault_handler(struct hinic_hwdev *hwdev, u8 level, - u8 event, u64 val); - bool hinic_mgmt_event_ack_first(u8 mod, u8 cmd); int hinic_set_wq_page_size(struct hinic_hwdev *hwdev, u16 func_idx, -- 2.25.1
From: Chiqijun <chiqijun@huawei.com> driver inclusion category: bugfix bugzilla: 4472 ----------------------------------------------------------------------- Delete unused heartbeat enhancement feature. Signed-off-by: Chiqijun <chiqijun@huawei.com> Reviewed-by: Zengweiliang <zengweiliang.zengweiliang@huawei.com> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- .../net/ethernet/huawei/hinic/hinic_hwdev.c | 188 +----------------- .../net/ethernet/huawei/hinic/hinic_hwdev.h | 20 -- 2 files changed, 1 insertion(+), 207 deletions(-) diff --git a/drivers/net/ethernet/huawei/hinic/hinic_hwdev.c b/drivers/net/ethernet/huawei/hinic/hinic_hwdev.c index 0971745689ab..18e017d84257 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_hwdev.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_hwdev.c @@ -485,34 +485,8 @@ struct hinic_cmd_fault_event { struct hinic_fault_event event; }; -#define HEARTBEAT_DRV_MAGIC_ACK 0x5A5A5A5A - -struct hinic_heartbeat_support { - u8 status; - u8 version; - u8 rsvd0[6]; - - u8 ppf_id; - u8 pf_issupport; - u8 mgmt_issupport; - u8 rsvd1[5]; -}; - -struct hinic_heartbeat_event { - u8 status; - u8 version; - u8 rsvd0[6]; - - u8 mgmt_init_state; - u8 rsvd1[3]; - u32 heart; /* increased every event */ - u32 drv_heart; -}; - static void hinic_enable_mgmt_channel(void *hwdev, void *buf_out); static void hinic_set_mgmt_channel_status(void *handle, bool state); -static inline void __set_heartbeat_ehd_detect_delay(struct hinic_hwdev *hwdev, - u32 delay_ms); #define HINIC_QUEUE_MIN_DEPTH 6 #define HINIC_QUEUE_MAX_DEPTH 12 @@ -845,12 +819,6 @@ static int __pf_to_mgmt_pre_handle(struct hinic_hwdev *hwdev, /* Sleep 2s wait other pf's mgmt messages to complete */ msleep(2000); - - /* stop heartbeat enhanced detection temporary, and will - * restart in firmware active event when mgmt is resetted - */ - __set_heartbeat_ehd_detect_delay(hwdev, - HINIC_DEV_ACTIVE_FW_TIMEOUT); } return 0; @@ -1912,34 +1880,6 @@ static int resources_state_set(struct hinic_hwdev *hwdev, return 0; } -int hinic_sync_heartbeat_status(struct hinic_hwdev *hwdev, - enum heartbeat_support_state pf_state, - enum heartbeat_support_state *mgmt_state) -{ - struct hinic_heartbeat_support hb_support = {0}; - u16 out_size = sizeof(hb_support); - int err; - - hb_support.ppf_id = hinic_ppf_idx(hwdev); - hb_support.pf_issupport = pf_state; - - err = hinic_msg_to_mgmt_sync(hwdev, HINIC_MOD_COMM, - HINIC_MGMT_CMD_HEARTBEAT_SUPPORTED, - &hb_support, sizeof(hb_support), - &hb_support, &out_size, 0); - if ((hb_support.status != HINIC_MGMT_CMD_UNSUPPORTED && - hb_support.status) || err || !out_size) { - sdk_err(hwdev->dev_hdl, "Failed to synchronize heartbeat status, err: %d, status: 0x%x, out_size: 0x%x\n", - err, hb_support.status, out_size); - return -EFAULT; - } - - if (!hb_support.status) - *mgmt_state = hb_support.mgmt_issupport; - - return hb_support.status; -} - static void comm_mgmt_msg_handler(void *hwdev, void *pri_handle, u8 cmd, void *buf_in, u16 in_size, void *buf_out, u16 *out_size) @@ -2292,13 +2232,6 @@ static void hinic_comm_cmdqs_free(struct hinic_hwdev *hwdev) hinic_cmdqs_free(hwdev); } -static inline void __set_heartbeat_ehd_detect_delay(struct hinic_hwdev *hwdev, - u32 delay_ms) -{ - hwdev->heartbeat_ehd.start_detect_jiffies = - jiffies + msecs_to_jiffies(delay_ms); -} - static int hinic_sync_mgmt_func_state(struct hinic_hwdev *hwdev) { int err; @@ -2312,14 +2245,6 @@ static int hinic_sync_mgmt_func_state(struct hinic_hwdev *hwdev) goto resources_state_set_err; } - hwdev->heartbeat_ehd.en = false; - if (HINIC_FUNC_TYPE(hwdev) == TYPE_PPF) { - /* heartbeat synchronize must be after set pf active status */ - hinic_comm_recv_mgmt_self_cmd_reg(hwdev, - HINIC_MGMT_CMD_HEARTBEAT_EVENT, - mgmt_heartbeat_event_handler); - } - return 0; resources_state_set_err: @@ -2332,12 +2257,6 @@ static void hinic_unsync_mgmt_func_state(struct hinic_hwdev *hwdev) { hinic_set_pf_status(hwdev->hwif, HINIC_PF_STATUS_INIT); - hwdev->heartbeat_ehd.en = false; - if (HINIC_FUNC_TYPE(hwdev) == TYPE_PPF) { - hinic_comm_recv_up_self_cmd_unreg(hwdev, - HINIC_MGMT_CMD_HEARTBEAT_EVENT); - } - resources_state_set(hwdev, HINIC_RES_CLEAN); } @@ -3276,7 +3195,6 @@ enum hinic_event_cmd { HINIC_EVENT_MGMT_RESET, HINIC_EVENT_MGMT_PCIE_DFX, HINIC_EVENT_MCTP_HOST_INFO, - HINIC_EVENT_MGMT_HEARTBEAT_EHD, HINIC_EVENT_SFP_INFO_REPORT, HINIC_EVENT_SFP_ABS_REPORT, @@ -3356,11 +3274,6 @@ static struct hinic_event_convert __event_convert[] = { .cmd = HINIC_MGMT_CMD_GET_HOST_INFO, .event = HINIC_EVENT_MCTP_HOST_INFO, }, - { - .mod = HINIC_MOD_COMM, - .cmd = HINIC_MGMT_CMD_HEARTBEAT_EVENT, - .event = HINIC_EVENT_MGMT_HEARTBEAT_EHD, - }, { .mod = HINIC_MOD_L2NIC, .cmd = HINIC_PORT_CMD_GET_SFP_INFO, @@ -3845,9 +3758,6 @@ static void hinic_fmw_act_ntc_handler(struct hinic_hwdev *hwdev, return; } - /* mgmt is activated now, restart heartbeat enhanced detection */ - __set_heartbeat_ehd_detect_delay(hwdev, 0); - if (!hwdev->event_callback) return; @@ -4221,31 +4131,6 @@ int hinic_hilink_info_show(struct hinic_hwdev *hwdev) return 0; } -static void mgmt_heartbeat_enhanced_event(struct hinic_hwdev *hwdev, - void *buf_in, u16 in_size, - void *buf_out, u16 *out_size) -{ - struct hinic_heartbeat_event *hb_event = buf_in; - struct hinic_heartbeat_event *hb_event_out = buf_out; - struct hinic_hwdev *dev = hwdev; - - if (in_size != sizeof(*hb_event)) { - sdk_err(dev->dev_hdl, "Invalid data size from mgmt for heartbeat event: %d\n", - in_size); - return; - } - - if (dev->heartbeat_ehd.last_heartbeat != hb_event->heart) { - dev->heartbeat_ehd.last_update_jiffies = jiffies; - dev->heartbeat_ehd.last_heartbeat = hb_event->heart; - } - - hb_event_out->drv_heart = HEARTBEAT_DRV_MAGIC_ACK; - - hb_event_out->status = 0; - *out_size = sizeof(*hb_event_out); -} - /* public process for this event: * pf link change event * pf heart lost event ,TBD @@ -4324,11 +4209,6 @@ static void _event_handler(struct hinic_hwdev *hwdev, enum hinic_event_cmd cmd, buf_out, out_size); break; - case HINIC_EVENT_MGMT_HEARTBEAT_EHD: - mgmt_heartbeat_enhanced_event(hwdev, buf_in, in_size, - buf_out, out_size); - break; - case HINIC_EVENT_SFP_INFO_REPORT: port_sfp_info_event(hwdev, buf_in, in_size, buf_out, out_size); break; @@ -4449,13 +4329,6 @@ void mgmt_get_mctp_event_handler(void *hwdev, void *buf_in, u16 in_size, in_size, buf_out, out_size); } -void mgmt_heartbeat_event_handler(void *hwdev, void *buf_in, u16 in_size, - void *buf_out, u16 *out_size) -{ - _event_handler(hwdev, HINIC_EVENT_MGMT_HEARTBEAT_EHD, buf_in, - in_size, buf_out, out_size); -} - static void pf_event_register(struct hinic_hwdev *hwdev) { if (hinic_is_hwdev_mod_inited(hwdev, HINIC_HWDEV_MGMT_INITED)) { @@ -4565,39 +4438,11 @@ static void hinic_heartbeat_event_handler(struct work_struct *work) NULL, 0, &out, &out); } -static bool __detect_heartbeat_ehd_lost(struct hinic_hwdev *hwdev) -{ - struct hinic_heartbeat_enhanced *hb_ehd = &hwdev->heartbeat_ehd; - u64 update_time; - bool hb_ehd_lost = false; - - if (!hb_ehd->en) - return false; - - if (time_after(jiffies, hb_ehd->start_detect_jiffies)) { - update_time = jiffies_to_msecs(jiffies - - hb_ehd->last_update_jiffies); - if (update_time > HINIC_HEARBEAT_ENHANCED_LOST) { - sdk_warn(hwdev->dev_hdl, "Heartbeat enhanced lost for %d millisecond\n", - (u32)update_time); - hb_ehd_lost = true; - } - } else { - /* mgmt may not report heartbeart enhanced event and won't - * update last_update_jiffies - */ - hb_ehd->last_update_jiffies = jiffies; - } - - return hb_ehd_lost; -} - static void hinic_heartbeat_timer_handler(struct timer_list *t) { struct hinic_hwdev *hwdev = from_timer(hwdev, t, heartbeat_timer); - if (__detect_heartbeat_ehd_lost(hwdev) || - !hinic_get_heartbeat_status(hwdev)) { + if (!hinic_get_heartbeat_status(hwdev)) { hwdev->heartbeat_lost = 1; queue_work(hwdev->workq, &hwdev->timer_work); } else { @@ -5003,37 +4848,6 @@ bool hinic_get_ppf_status(void *hwdev) return (bool)ppf_state.ppf_state; } -#define HINIC_RED_REG_TIME_OUT 3000 - -int hinic_read_reg(void *hwdev, u32 reg_addr, u32 *val) -{ - struct hinic_reg_info reg_info = {0}; - u16 out_size = sizeof(reg_info); - int err; - - if (!hwdev || !val) - return -EINVAL; - - reg_info.reg_addr = reg_addr; - reg_info.val_length = sizeof(u32); - - err = hinic_pf_msg_to_mgmt_sync(hwdev, HINIC_MOD_COMM, - HINIC_MGMT_CMD_REG_READ, - ®_info, sizeof(reg_info), - ®_info, &out_size, - HINIC_RED_REG_TIME_OUT); - if (reg_info.status || err || !out_size) { - sdk_err(((struct hinic_hwdev *)hwdev)->dev_hdl, - "Failed to read reg, err: %d, status: 0x%x, out size: 0x%x\n", - err, reg_info.status, out_size); - return -EFAULT; - } - - *val = reg_info.data[0]; - - return 0; -} - void hinic_set_func_deinit_flag(void *hwdev) { struct hinic_hwdev *dev = hwdev; diff --git a/drivers/net/ethernet/huawei/hinic/hinic_hwdev.h b/drivers/net/ethernet/huawei/hinic/hinic_hwdev.h index 68a452496841..60567f18a17f 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_hwdev.h +++ b/drivers/net/ethernet/huawei/hinic/hinic_hwdev.h @@ -175,22 +175,6 @@ struct hinic_hw_stats { struct hinic_fault_event_stats fault_event_stats; }; -enum heartbeat_support_state { - HEARTBEAT_NOT_SUPPORT = 0, - HEARTBEAT_SUPPORT, -}; - -/* 25s for max 5 heartbeat event lost */ -#define HINIC_HEARBEAT_ENHANCED_LOST 25000 -struct hinic_heartbeat_enhanced { - bool en; /* enable enhanced heartbeat or not */ - - unsigned long last_update_jiffies; - u32 last_heartbeat; - - unsigned long start_detect_jiffies; -}; - #define HINIC_NORMAL_HOST_CAP (HINIC_FUNC_MGMT | HINIC_FUNC_PORT | \ HINIC_FUNC_SUPP_RATE_LIMIT | \ HINIC_FUNC_SUPP_DFX_REG | \ @@ -284,7 +268,6 @@ struct hinic_hwdev { /* true represent heartbeat lost, false represent heartbeat restore */ u32 heartbeat_lost; int chip_present_flag; - struct hinic_heartbeat_enhanced heartbeat_ehd; struct hinic_hw_stats hw_stats; u8 *chip_fault_stats; @@ -384,7 +367,4 @@ int hinic_ppf_process_mbox_msg(struct hinic_hwdev *hwdev, u16 pf_idx, u16 vf_id, #define HINIC_SDI_MODE_MAX 3 int hinic_get_sdi_mode(struct hinic_hwdev *hwdev, u16 *cur_mode); -void mgmt_heartbeat_event_handler(void *hwdev, void *buf_in, u16 in_size, - void *buf_out, u16 *out_size); - #endif -- 2.25.1
From: Chiqijun <chiqijun@huawei.com> driver inclusion category: bugfix bugzilla: 4472 ----------------------------------------------------------------------- Fix alignment and code style. Signed-off-by: Chiqijun <chiqijun@huawei.com> Reviewed-by: Zengweiliang <zengweiliang.zengweiliang@huawei.com> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- .../net/ethernet/huawei/hinic/hinic_api_cmd.c | 16 +- .../net/ethernet/huawei/hinic/hinic_api_cmd.h | 20 +- drivers/net/ethernet/huawei/hinic/hinic_cfg.c | 14 +- .../net/ethernet/huawei/hinic/hinic_cmdq.c | 110 ++++----- drivers/net/ethernet/huawei/hinic/hinic_csr.h | 4 +- .../net/ethernet/huawei/hinic/hinic_ctx_def.h | 184 ++++++++-------- .../ethernet/huawei/hinic/hinic_dbgtool_knl.c | 8 +- drivers/net/ethernet/huawei/hinic/hinic_dcb.c | 10 +- .../net/ethernet/huawei/hinic/hinic_dfx_def.h | 4 +- drivers/net/ethernet/huawei/hinic/hinic_eqs.c | 28 +-- drivers/net/ethernet/huawei/hinic/hinic_eqs.h | 3 +- .../net/ethernet/huawei/hinic/hinic_ethtool.c | 40 ++-- drivers/net/ethernet/huawei/hinic/hinic_hw.h | 23 +- .../net/ethernet/huawei/hinic/hinic_hw_mgmt.h | 1 + .../net/ethernet/huawei/hinic/hinic_hwdev.c | 79 +++---- .../net/ethernet/huawei/hinic/hinic_hwdev.h | 20 +- .../net/ethernet/huawei/hinic/hinic_hwif.c | 3 +- drivers/net/ethernet/huawei/hinic/hinic_lld.c | 18 +- drivers/net/ethernet/huawei/hinic/hinic_lld.h | 4 +- .../net/ethernet/huawei/hinic/hinic_main.c | 27 +-- .../net/ethernet/huawei/hinic/hinic_mbox.c | 23 +- .../net/ethernet/huawei/hinic/hinic_mbox.h | 10 +- .../net/ethernet/huawei/hinic/hinic_mgmt.c | 43 ++-- .../net/ethernet/huawei/hinic/hinic_mgmt.h | 58 ++--- .../huawei/hinic/hinic_mgmt_interface.h | 2 + .../ethernet/huawei/hinic/hinic_msix_attr.c | 8 +- .../ethernet/huawei/hinic/hinic_msix_attr.h | 22 +- .../huawei/hinic/hinic_multi_host_mgmt.c | 15 +- .../net/ethernet/huawei/hinic/hinic_nic_cfg.c | 15 +- .../net/ethernet/huawei/hinic/hinic_nic_cfg.h | 34 +-- .../net/ethernet/huawei/hinic/hinic_nic_dbg.c | 2 +- .../net/ethernet/huawei/hinic/hinic_nic_dev.h | 16 +- .../net/ethernet/huawei/hinic/hinic_nic_io.c | 14 +- .../net/ethernet/huawei/hinic/hinic_nictool.c | 39 ++-- .../net/ethernet/huawei/hinic/hinic_nictool.h | 36 +-- .../ethernet/huawei/hinic/hinic_port_cmd.h | 18 +- .../net/ethernet/huawei/hinic/hinic_qe_def.h | 208 +++++++++--------- drivers/net/ethernet/huawei/hinic/hinic_rx.c | 8 +- drivers/net/ethernet/huawei/hinic/hinic_rx.h | 2 +- .../net/ethernet/huawei/hinic/hinic_sm_lt.h | 64 +++--- .../ethernet/huawei/hinic/hinic_sml_counter.h | 44 ++-- .../net/ethernet/huawei/hinic/hinic_sml_lt.c | 8 +- .../net/ethernet/huawei/hinic/hinic_sriov.c | 2 +- drivers/net/ethernet/huawei/hinic/hinic_tx.c | 15 +- drivers/net/ethernet/huawei/hinic/hinic_wq.c | 6 +- drivers/net/ethernet/huawei/hinic/hinic_wq.h | 8 +- drivers/net/ethernet/huawei/hinic/ossl_knl.h | 16 +- .../ethernet/huawei/hinic/ossl_knl_linux.h | 10 +- 48 files changed, 690 insertions(+), 672 deletions(-) diff --git a/drivers/net/ethernet/huawei/hinic/hinic_api_cmd.c b/drivers/net/ethernet/huawei/hinic/hinic_api_cmd.c index 6ce69dc73064..4df801459111 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_api_cmd.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_api_cmd.c @@ -203,9 +203,9 @@ static u16 get_cell_data_size(enum hinic_api_cmd_chain_type type, u16 cmd_size) switch (type) { case HINIC_API_CMD_POLL_READ: cell_data_size = ALIGN(API_CMD_CELL_DESC_SIZE + - API_CMD_CELL_WB_ADDR_SIZE + - API_CMD_CELL_DATA_ADDR_SIZE, - API_CHAIN_CELL_ALIGNMENT); + API_CMD_CELL_WB_ADDR_SIZE + + API_CMD_CELL_DATA_ADDR_SIZE, + API_CHAIN_CELL_ALIGNMENT); break; case HINIC_API_CMD_WRITE_TO_MGMT_CPU: @@ -253,9 +253,9 @@ static void prepare_cell_ctrl(u64 *cell_ctrl, u16 cell_len) * @cmd_size: the command size */ static void prepare_api_cmd(struct hinic_api_cmd_chain *chain, - struct hinic_api_cmd_cell *cell, - enum hinic_node_id dest, - const void *cmd, u16 cmd_size) + struct hinic_api_cmd_cell *cell, + enum hinic_node_id dest, + const void *cmd, u16 cmd_size) { struct hinic_api_cmd_cell_ctxt *cell_ctxt; u32 priv; @@ -299,7 +299,7 @@ static void prepare_api_cmd(struct hinic_api_cmd_chain *chain, HINIC_API_CMD_DESC_SET(SIZE_4BYTES(cmd_size), SIZE); cell->desc |= HINIC_API_CMD_DESC_SET(xor_chksum_set(&cell->desc), - XOR_CHKSUM); + XOR_CHKSUM); /* The data in the HW should be in Big Endian Format */ cell->desc = cpu_to_be64(cell->desc); @@ -559,7 +559,7 @@ int hinic_api_cmd_write(struct hinic_api_cmd_chain *chain, int hinic_api_cmd_read(struct hinic_api_cmd_chain *chain, enum hinic_node_id dest, - void *cmd, u16 size, void *ack, u16 ack_size) + void *cmd, u16 size, void *ack, u16 ack_size) { return api_cmd(chain, dest, cmd, size, ack, ack_size); } diff --git a/drivers/net/ethernet/huawei/hinic/hinic_api_cmd.h b/drivers/net/ethernet/huawei/hinic/hinic_api_cmd.h index 06060b0ae480..9c77ac181d91 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_api_cmd.h +++ b/drivers/net/ethernet/huawei/hinic/hinic_api_cmd.h @@ -52,7 +52,7 @@ ((((u64)val) & HINIC_API_CMD_DESC_##member##_MASK) << \ HINIC_API_CMD_DESC_##member##_SHIFT) -#define HINIC_API_CMD_STATUS_HEADER_VALID_SHIFT 0 +#define HINIC_API_CMD_STATUS_HEADER_VALID_SHIFT 0 #define HINIC_API_CMD_STATUS_HEADER_CHAIN_ID_SHIFT 16 #define HINIC_API_CMD_STATUS_HEADER_VALID_MASK 0xFFU @@ -109,7 +109,7 @@ #define HINIC_API_CMD_RESP_HEADER_VALID(val) \ (((val) & HINIC_API_CMD_RESP_HEAD_VALID_MASK) == \ - HINIC_API_CMD_RESP_HEAD_VALID_CODE) + HINIC_API_CMD_RESP_HEAD_VALID_CODE) #define HINIC_API_CMD_RESP_HEAD_STATUS_SHIFT 8 #define HINIC_API_CMD_RESP_HEAD_STATUS_MASK 0xFFU @@ -117,8 +117,8 @@ #define HINIC_API_CMD_RESP_HEAD_ERR_CODE 0x1 #define HINIC_API_CMD_RESP_HEAD_ERR(val) \ ((((val) >> HINIC_API_CMD_RESP_HEAD_STATUS_SHIFT) & \ - HINIC_API_CMD_RESP_HEAD_STATUS_MASK) == \ - HINIC_API_CMD_RESP_HEAD_ERR_CODE) + HINIC_API_CMD_RESP_HEAD_STATUS_MASK) == \ + HINIC_API_CMD_RESP_HEAD_ERR_CODE) #define HINIC_API_CMD_RESP_HEAD_CHAIN_ID_SHIFT 16 #define HINIC_API_CMD_RESP_HEAD_CHAIN_ID_MASK 0xFF @@ -126,19 +126,19 @@ #define HINIC_API_CMD_RESP_RESERVED 3 #define HINIC_API_CMD_RESP_HEAD_CHAIN_ID(val) \ (((val) >> HINIC_API_CMD_RESP_HEAD_CHAIN_ID_SHIFT) & \ - HINIC_API_CMD_RESP_HEAD_CHAIN_ID_MASK) + HINIC_API_CMD_RESP_HEAD_CHAIN_ID_MASK) #define HINIC_API_CMD_RESP_HEAD_DRIVER_PRIV_SHIFT 40 #define HINIC_API_CMD_RESP_HEAD_DRIVER_PRIV_MASK 0xFFFFFFU #define HINIC_API_CMD_RESP_HEAD_DRIVER_PRIV(val) \ (u16)(((val) >> HINIC_API_CMD_RESP_HEAD_DRIVER_PRIV_SHIFT) & \ - HINIC_API_CMD_RESP_HEAD_DRIVER_PRIV_MASK) + HINIC_API_CMD_RESP_HEAD_DRIVER_PRIV_MASK) #define HINIC_API_CMD_STATUS_HEAD_VALID_MASK 0xFFU #define HINIC_API_CMD_STATUS_HEAD_VALID_SHIFT 0 -#define HINIC_API_CMD_STATUS_HEAD_CHAIN_ID_MASK 0xFFU +#define HINIC_API_CMD_STATUS_HEAD_CHAIN_ID_MASK 0xFFU #define HINIC_API_CMD_STATUS_HEAD_CHAIN_ID_VALID_SHIFT 16 #define HINIC_API_CMD_STATUS_CONS_IDX_MASK 0xFFFFFFU @@ -155,18 +155,18 @@ #define HINIC_API_CMD_STATUS_CHAIN_ID(val) \ (((val) >> HINIC_API_CMD_STATUS_HEAD_CHAIN_ID_VALID_SHIFT) & \ - HINIC_API_CMD_STATUS_HEAD_VALID_MASK) + HINIC_API_CMD_STATUS_HEAD_VALID_MASK) #define HINIC_API_CMD_STATUS_CONS_IDX(val) \ ((val) & HINIC_API_CMD_STATUS_CONS_IDX_MASK) #define HINIC_API_CMD_STATUS_CHKSUM_ERR(val) \ (((val) >> HINIC_API_CMD_STATUS_CHKSUM_ERR_SHIFT) & \ - HINIC_API_CMD_STATUS_CHKSUM_ERR_MASK) + HINIC_API_CMD_STATUS_CHKSUM_ERR_MASK) #define HINIC_API_CMD_STATUS_GET(val, member) \ (((val) >> HINIC_API_CMD_STATUS_##member##_SHIFT) & \ - HINIC_API_CMD_STATUS_##member##_MASK) + HINIC_API_CMD_STATUS_##member##_MASK) enum hinic_api_cmd_chain_type { /* write command with completion notification */ diff --git a/drivers/net/ethernet/huawei/hinic/hinic_cfg.c b/drivers/net/ethernet/huawei/hinic/hinic_cfg.c index 96e6043f2321..a408a01adeae 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_cfg.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_cfg.c @@ -561,7 +561,6 @@ static void parse_dev_cap(struct hinic_hwdev *dev, if (IS_NIC_TYPE(dev)) parse_l2nic_res_cap(dev, cap, dev_cap, type); - /* FCoE/IOE/TOE/FC without virtulization */ if (type == TYPE_PF || type == TYPE_PPF) { if (IS_FC_TYPE(dev)) @@ -677,7 +676,6 @@ static void nic_param_fix(struct hinic_hwdev *dev) nic_cap->max_rqs = nic_cap->max_queue_allowed; nic_cap->max_sqs = nic_cap->max_queue_allowed; } - } static void rdma_param_fix(struct hinic_hwdev *dev) @@ -1207,7 +1205,7 @@ int hinic_alloc_ceqs(void *hwdev, enum hinic_service_type type, int num, for (i = 0; i < num; i++) { if (eq->num_ceq_remain == 0) { sdk_warn(dev->dev_hdl, "Alloc %d ceqs, less than required %d ceqs\n", - *act_num, num); + *act_num, num); mutex_unlock(&eq->eq_mutex); return 0; } @@ -1385,8 +1383,8 @@ static int cfg_mbx_pf_proc_vf_msg(void *hwdev, u16 vf_id, u8 cmd, void *buf_in, } static int cfg_mbx_ppf_proc_msg(void *hwdev, u16 pf_id, u16 vf_id, u8 cmd, - void *buf_in, u16 in_size, void *buf_out, - u16 *out_size) + void *buf_in, u16 in_size, void *buf_out, + u16 *out_size) { struct hinic_hwdev *dev = hwdev; @@ -1399,7 +1397,7 @@ static int cfg_mbx_ppf_proc_msg(void *hwdev, u16 pf_id, u16 vf_id, u8 cmd, } static int cfg_mbx_vf_proc_msg(void *hwdev, u8 cmd, void *buf_in, u16 in_size, - void *buf_out, u16 *out_size) + void *buf_out, u16 *out_size) { struct hinic_hwdev *dev = hwdev; @@ -1546,8 +1544,8 @@ void free_cfg_mgmt(struct hinic_hwdev *dev) int init_capability(struct hinic_hwdev *dev) { - int err; struct cfg_mgmt_info *cfg_mgmt = dev->cfg_mgmt; + int err; set_cfg_test_param(cfg_mgmt); @@ -2153,6 +2151,7 @@ static void hinic_os_dep_deinit(struct hinic_hwdev *hwdev) void hinic_ppf_hwdev_unreg(void *hwdev) { struct hinic_hwdev *dev = hwdev; + if (!hwdev) return; @@ -2166,6 +2165,7 @@ void hinic_ppf_hwdev_unreg(void *hwdev) void hinic_ppf_hwdev_reg(void *hwdev, void *ppf_hwdev) { struct hinic_hwdev *dev = hwdev; + if (!hwdev) return; diff --git a/drivers/net/ethernet/huawei/hinic/hinic_cmdq.c b/drivers/net/ethernet/huawei/hinic/hinic_cmdq.c index 6d78d22272f0..96df2f70e0b0 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_cmdq.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_cmdq.c @@ -54,8 +54,8 @@ #define CMDQ_DB_INFO_SRC_TYPE_MASK 0x1FU #define CMDQ_DB_INFO_SET(val, member) \ - ((val & CMDQ_DB_INFO_##member##_MASK) \ - << CMDQ_DB_INFO_##member##_SHIFT) + (((val) & CMDQ_DB_INFO_##member##_MASK) \ + << CMDQ_DB_INFO_##member##_SHIFT) #define CMDQ_CTRL_PI_SHIFT 0 #define CMDQ_CTRL_CMD_SHIFT 16 @@ -71,11 +71,11 @@ #define CMDQ_CTRL_SET(val, member) \ (((val) & CMDQ_CTRL_##member##_MASK) \ - << CMDQ_CTRL_##member##_SHIFT) + << CMDQ_CTRL_##member##_SHIFT) #define CMDQ_CTRL_GET(val, member) \ (((val) >> CMDQ_CTRL_##member##_SHIFT) \ - & CMDQ_CTRL_##member##_MASK) + & CMDQ_CTRL_##member##_MASK) #define CMDQ_WQE_HEADER_BUFDESC_LEN_SHIFT 0 #define CMDQ_WQE_HEADER_COMPLETE_FMT_SHIFT 15 @@ -95,69 +95,69 @@ #define CMDQ_WQE_HEADER_SET(val, member) \ (((val) & CMDQ_WQE_HEADER_##member##_MASK) \ - << CMDQ_WQE_HEADER_##member##_SHIFT) + << CMDQ_WQE_HEADER_##member##_SHIFT) #define CMDQ_WQE_HEADER_GET(val, member) \ (((val) >> CMDQ_WQE_HEADER_##member##_SHIFT) \ - & CMDQ_WQE_HEADER_##member##_MASK) + & CMDQ_WQE_HEADER_##member##_MASK) -#define CMDQ_CTXT_CURR_WQE_PAGE_PFN_SHIFT 0 -#define CMDQ_CTXT_EQ_ID_SHIFT 56 -#define CMDQ_CTXT_CEQ_ARM_SHIFT 61 -#define CMDQ_CTXT_CEQ_EN_SHIFT 62 -#define CMDQ_CTXT_HW_BUSY_BIT_SHIFT 63 +#define CMDQ_CTXT_CURR_WQE_PAGE_PFN_SHIFT 0 +#define CMDQ_CTXT_EQ_ID_SHIFT 56 +#define CMDQ_CTXT_CEQ_ARM_SHIFT 61 +#define CMDQ_CTXT_CEQ_EN_SHIFT 62 +#define CMDQ_CTXT_HW_BUSY_BIT_SHIFT 63 -#define CMDQ_CTXT_CURR_WQE_PAGE_PFN_MASK 0xFFFFFFFFFFFFF -#define CMDQ_CTXT_EQ_ID_MASK 0x1F -#define CMDQ_CTXT_CEQ_ARM_MASK 0x1 -#define CMDQ_CTXT_CEQ_EN_MASK 0x1 -#define CMDQ_CTXT_HW_BUSY_BIT_MASK 0x1 +#define CMDQ_CTXT_CURR_WQE_PAGE_PFN_MASK 0xFFFFFFFFFFFFF +#define CMDQ_CTXT_EQ_ID_MASK 0x1F +#define CMDQ_CTXT_CEQ_ARM_MASK 0x1 +#define CMDQ_CTXT_CEQ_EN_MASK 0x1 +#define CMDQ_CTXT_HW_BUSY_BIT_MASK 0x1 #define CMDQ_CTXT_PAGE_INFO_SET(val, member) \ (((u64)(val) & CMDQ_CTXT_##member##_MASK) \ - << CMDQ_CTXT_##member##_SHIFT) + << CMDQ_CTXT_##member##_SHIFT) #define CMDQ_CTXT_PAGE_INFO_GET(val, member) \ (((u64)(val) >> CMDQ_CTXT_##member##_SHIFT) \ & CMDQ_CTXT_##member##_MASK) -#define CMDQ_CTXT_WQ_BLOCK_PFN_SHIFT 0 -#define CMDQ_CTXT_CI_SHIFT 52 +#define CMDQ_CTXT_WQ_BLOCK_PFN_SHIFT 0 +#define CMDQ_CTXT_CI_SHIFT 52 -#define CMDQ_CTXT_WQ_BLOCK_PFN_MASK 0xFFFFFFFFFFFFF -#define CMDQ_CTXT_CI_MASK 0xFFF +#define CMDQ_CTXT_WQ_BLOCK_PFN_MASK 0xFFFFFFFFFFFFF +#define CMDQ_CTXT_CI_MASK 0xFFF #define CMDQ_CTXT_BLOCK_INFO_SET(val, member) \ (((u64)(val) & CMDQ_CTXT_##member##_MASK) \ - << CMDQ_CTXT_##member##_SHIFT) + << CMDQ_CTXT_##member##_SHIFT) #define CMDQ_CTXT_BLOCK_INFO_GET(val, member) \ (((u64)(val) >> CMDQ_CTXT_##member##_SHIFT) \ & CMDQ_CTXT_##member##_MASK) -#define SAVED_DATA_ARM_SHIFT 31 +#define SAVED_DATA_ARM_SHIFT 31 -#define SAVED_DATA_ARM_MASK 0x1U +#define SAVED_DATA_ARM_MASK 0x1U #define SAVED_DATA_SET(val, member) \ (((val) & SAVED_DATA_##member##_MASK) \ - << SAVED_DATA_##member##_SHIFT) + << SAVED_DATA_##member##_SHIFT) #define SAVED_DATA_CLEAR(val, member) \ ((val) & (~(SAVED_DATA_##member##_MASK \ - << SAVED_DATA_##member##_SHIFT))) + << SAVED_DATA_##member##_SHIFT))) -#define WQE_ERRCODE_VAL_SHIFT 20 +#define WQE_ERRCODE_VAL_SHIFT 20 -#define WQE_ERRCODE_VAL_MASK 0xF +#define WQE_ERRCODE_VAL_MASK 0xF #define WQE_ERRCODE_GET(val, member) \ (((val) >> WQE_ERRCODE_##member##_SHIFT) & \ - WQE_ERRCODE_##member##_MASK) + WQE_ERRCODE_##member##_MASK) -#define CEQE_CMDQ_TYPE_SHIFT 0 +#define CEQE_CMDQ_TYPE_SHIFT 0 -#define CEQE_CMDQ_TYPE_MASK 0x7 +#define CEQE_CMDQ_TYPE_MASK 0x7 #define CEQE_CMDQ_GET(val, member) \ (((val) >> CEQE_CMDQ_##member##_SHIFT) & CEQE_CMDQ_##member##_MASK) @@ -169,28 +169,28 @@ #define CMDQ_DB_PI_OFF(pi) (((u16)LOWER_8_BITS(pi)) << 3) #define CMDQ_DB_ADDR(db_base, pi) \ - (((u8 *)db_base + HINIC_DB_OFF) + CMDQ_DB_PI_OFF(pi)) + (((u8 *)(db_base) + HINIC_DB_OFF) + CMDQ_DB_PI_OFF(pi)) #define CMDQ_PFN_SHIFT 12 #define CMDQ_PFN(addr) ((addr) >> CMDQ_PFN_SHIFT) #define FIRST_DATA_TO_WRITE_LAST sizeof(u64) -#define WQE_LCMD_SIZE 64 -#define WQE_SCMD_SIZE 64 +#define WQE_LCMD_SIZE 64 +#define WQE_SCMD_SIZE 64 -#define COMPLETE_LEN 3 +#define COMPLETE_LEN 3 -#define CMDQ_WQEBB_SIZE 64 -#define CMDQ_WQE_SIZE 64 +#define CMDQ_WQEBB_SIZE 64 +#define CMDQ_WQE_SIZE 64 -#define CMDQ_WQ_PAGE_SIZE 4096 +#define CMDQ_WQ_PAGE_SIZE 4096 #define WQE_NUM_WQEBBS(wqe_size, wq) \ ((u16)(ALIGN((u32)(wqe_size), (wq)->wqebb_size) / (wq)->wqebb_size)) #define cmdq_to_cmdqs(cmdq) container_of((cmdq) - (cmdq)->cmdq_type, \ - struct hinic_cmdqs, cmdq[0]) + struct hinic_cmdqs, cmdq[0]) #define CMDQ_SEND_CMPT_CODE 10 #define CMDQ_COMPLETE_CMPT_CODE 11 @@ -385,10 +385,10 @@ static void cmdq_wqe_fill(void *dst, const void *src) static void cmdq_prepare_wqe_ctrl(struct hinic_cmdq_wqe *wqe, int wrapped, enum hinic_ack_type ack_type, - enum hinic_mod_type mod, u8 cmd, u16 prod_idx, - enum completion_format complete_format, - enum data_format data_format, - enum bufdesc_len buf_len) + enum hinic_mod_type mod, u8 cmd, u16 prod_idx, + enum completion_format complete_format, + enum data_format data_format, + enum bufdesc_len buf_len) { struct hinic_ctrl *ctrl; enum ctrl_sect_len ctrl_len; @@ -436,10 +436,10 @@ static void cmdq_prepare_wqe_ctrl(struct hinic_cmdq_wqe *wqe, int wrapped, static void cmdq_set_lcmd_wqe(struct hinic_cmdq_wqe *wqe, enum cmdq_cmd_type cmd_type, - struct hinic_cmd_buf *buf_in, - struct hinic_cmd_buf *buf_out, int wrapped, - enum hinic_ack_type ack_type, - enum hinic_mod_type mod, u8 cmd, u16 prod_idx) + struct hinic_cmd_buf *buf_in, + struct hinic_cmd_buf *buf_out, int wrapped, + enum hinic_ack_type ack_type, + enum hinic_mod_type mod, u8 cmd, u16 prod_idx) { struct hinic_cmdq_wqe_lcmd *wqe_lcmd = &wqe->wqe_lcmd; enum completion_format complete_format = COMPLETE_DIRECT; @@ -465,7 +465,7 @@ static void cmdq_set_lcmd_wqe(struct hinic_cmdq_wqe *wqe, cmdq_prepare_wqe_ctrl(wqe, wrapped, ack_type, mod, cmd, prod_idx, complete_format, DATA_SGE, - BUFDESC_LCMD_LEN); + BUFDESC_LCMD_LEN); cmdq_set_lcmd_bufdesc(wqe_lcmd, buf_in); } @@ -706,10 +706,10 @@ static int cmdq_sync_cmd_direct_resp(struct hinic_cmdq *cmdq, static int cmdq_sync_cmd_detail_resp(struct hinic_cmdq *cmdq, enum hinic_ack_type ack_type, - enum hinic_mod_type mod, u8 cmd, - struct hinic_cmd_buf *buf_in, - struct hinic_cmd_buf *buf_out, - u32 timeout) + enum hinic_mod_type mod, u8 cmd, + struct hinic_cmd_buf *buf_in, + struct hinic_cmd_buf *buf_out, + u32 timeout) { struct hinic_wq *wq = cmdq->wq; struct hinic_cmdq_wqe *curr_wqe, wqe; @@ -913,7 +913,7 @@ static int cmdq_set_arm_bit(struct hinic_cmdq *cmdq, void *buf_in, u16 in_size) cmdq_set_inline_wqe(&wqe, SYNC_CMD_DIRECT_RESP, buf_in, in_size, NULL, wrapped, HINIC_ACK_TYPE_CMDQ, HINIC_MOD_COMM, - CMDQ_SET_ARM_CMD, curr_prod_idx); + CMDQ_SET_ARM_CMD, curr_prod_idx); /* The data that is written to HW should be in Big Endian Format */ hinic_cpu_to_be32(&wqe, wqe_size); @@ -1038,7 +1038,7 @@ EXPORT_SYMBOL(hinic_cmdq_detail_resp); int hinic_cmdq_async(void *hwdev, enum hinic_ack_type ack_type, enum hinic_mod_type mod, u8 cmd, - struct hinic_cmd_buf *buf_in) + struct hinic_cmd_buf *buf_in) { struct hinic_cmdqs *cmdqs; int err = cmdq_params_valid(hwdev, buf_in); @@ -1494,7 +1494,7 @@ int hinic_cmdqs_init(struct hinic_hwdev *hwdev) cmdqs->cmd_buf_pool = dma_pool_create("hinic_cmdq", hwdev->dev_hdl, HINIC_CMDQ_BUF_SIZE, - HINIC_CMDQ_BUF_SIZE, 0ULL); + HINIC_CMDQ_BUF_SIZE, 0ULL); if (!cmdqs->cmd_buf_pool) { sdk_err(hwdev->dev_hdl, "Failed to create cmdq buffer pool\n"); err = -ENOMEM; diff --git a/drivers/net/ethernet/huawei/hinic/hinic_csr.h b/drivers/net/ethernet/huawei/hinic/hinic_csr.h index 76025e5bcfff..045a32d07359 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_csr.h +++ b/drivers/net/ethernet/huawei/hinic/hinic_csr.h @@ -92,12 +92,12 @@ (pg_num) * HINIC_CSR_EQ_PAGE_OFF_STRIDE + 4) #define HINIC_EQ_HI_PHYS_ADDR_REG(type, q_id, pg_num) \ - ((u32)((type == HINIC_AEQ) ? \ + ((u32)(((type) == HINIC_AEQ) ? \ HINIC_AEQ_HI_PHYS_ADDR_REG(q_id, pg_num) : \ HINIC_CEQ_HI_PHYS_ADDR_REG(q_id, pg_num))) #define HINIC_EQ_LO_PHYS_ADDR_REG(type, q_id, pg_num) \ - ((u32)((type == HINIC_AEQ) ? \ + ((u32)(((type) == HINIC_AEQ) ? \ HINIC_AEQ_LO_PHYS_ADDR_REG(q_id, pg_num) : \ HINIC_CEQ_LO_PHYS_ADDR_REG(q_id, pg_num))) diff --git a/drivers/net/ethernet/huawei/hinic/hinic_ctx_def.h b/drivers/net/ethernet/huawei/hinic/hinic_ctx_def.h index 68071411833b..d6a23e28e178 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_ctx_def.h +++ b/drivers/net/ethernet/huawei/hinic/hinic_ctx_def.h @@ -20,16 +20,16 @@ #define HINIC_CEQE_QN_MASK 0x3FFU -#define HINIC_Q_CTXT_MAX 42 +#define HINIC_Q_CTXT_MAX 42 -#define HINIC_RQ_CQ_MAX 128 +#define HINIC_RQ_CQ_MAX 128 #define MAX_WQE_SIZE(max_sge, wqebb_size) \ (((max_sge) <= 2) ? (wqebb_size) : \ ((ALIGN(((max_sge) - 2), 4) / 4 + 1) * (wqebb_size))) /* performance: ci addr RTE_CACHE_SIZE(64B) alignment */ -#define HINIC_CI_Q_ADDR_SIZE (64) +#define HINIC_CI_Q_ADDR_SIZE 64 #define CI_TABLE_SIZE(num_qps, pg_sz) \ (ALIGN((num_qps) * HINIC_CI_Q_ADDR_SIZE, pg_sz)) @@ -40,8 +40,8 @@ #define HINIC_CI_PADDR(base_paddr, q_id) ((base_paddr) + \ (q_id) * HINIC_CI_Q_ADDR_SIZE) -#define Q_CTXT_SIZE 48 -#define TSO_LRO_CTXT_SIZE 240 +#define Q_CTXT_SIZE 48 +#define TSO_LRO_CTXT_SIZE 240 #define SQ_CTXT_OFFSET(max_sqs, max_rqs, q_id) \ (((max_rqs) + (max_sqs)) * TSO_LRO_CTXT_SIZE \ @@ -57,128 +57,128 @@ #define RQ_CTXT_SIZE(num_rqs) ((u16)(sizeof(struct hinic_qp_ctxt_header) \ + (num_rqs) * sizeof(struct hinic_rq_ctxt))) -#define SQ_CTXT_CEQ_ATTR_CEQ_ID_SHIFT 8 -#define SQ_CTXT_CEQ_ATTR_GLOBAL_SQ_ID_SHIFT 13 -#define SQ_CTXT_CEQ_ATTR_EN_SHIFT 23 -#define SQ_CTXT_CEQ_ATTR_ARM_SHIFT 31 +#define SQ_CTXT_CEQ_ATTR_CEQ_ID_SHIFT 8 +#define SQ_CTXT_CEQ_ATTR_GLOBAL_SQ_ID_SHIFT 13 +#define SQ_CTXT_CEQ_ATTR_EN_SHIFT 23 +#define SQ_CTXT_CEQ_ATTR_ARM_SHIFT 31 -#define SQ_CTXT_CEQ_ATTR_CEQ_ID_MASK 0x1FU -#define SQ_CTXT_CEQ_ATTR_GLOBAL_SQ_ID_MASK 0x3FFU -#define SQ_CTXT_CEQ_ATTR_EN_MASK 0x1U -#define SQ_CTXT_CEQ_ATTR_ARM_MASK 0x1U +#define SQ_CTXT_CEQ_ATTR_CEQ_ID_MASK 0x1FU +#define SQ_CTXT_CEQ_ATTR_GLOBAL_SQ_ID_MASK 0x3FFU +#define SQ_CTXT_CEQ_ATTR_EN_MASK 0x1U +#define SQ_CTXT_CEQ_ATTR_ARM_MASK 0x1U -#define SQ_CTXT_CEQ_ATTR_SET(val, member) (((val) & \ - SQ_CTXT_CEQ_ATTR_##member##_MASK) \ - << SQ_CTXT_CEQ_ATTR_##member##_SHIFT) +#define SQ_CTXT_CEQ_ATTR_SET(val, member) \ + (((val) & SQ_CTXT_CEQ_ATTR_##member##_MASK) \ + << SQ_CTXT_CEQ_ATTR_##member##_SHIFT) -#define SQ_CTXT_CI_IDX_SHIFT 11 -#define SQ_CTXT_CI_OWNER_SHIFT 23 +#define SQ_CTXT_CI_IDX_SHIFT 11 +#define SQ_CTXT_CI_OWNER_SHIFT 23 -#define SQ_CTXT_CI_IDX_MASK 0xFFFU -#define SQ_CTXT_CI_OWNER_MASK 0x1U +#define SQ_CTXT_CI_IDX_MASK 0xFFFU +#define SQ_CTXT_CI_OWNER_MASK 0x1U -#define SQ_CTXT_CI_SET(val, member) (((val) & \ - SQ_CTXT_CI_##member##_MASK) \ - << SQ_CTXT_CI_##member##_SHIFT) +#define SQ_CTXT_CI_SET(val, member) \ + (((val) & SQ_CTXT_CI_##member##_MASK) \ + << SQ_CTXT_CI_##member##_SHIFT) -#define SQ_CTXT_WQ_PAGE_HI_PFN_SHIFT 0 -#define SQ_CTXT_WQ_PAGE_PI_SHIFT 20 +#define SQ_CTXT_WQ_PAGE_HI_PFN_SHIFT 0 +#define SQ_CTXT_WQ_PAGE_PI_SHIFT 20 -#define SQ_CTXT_WQ_PAGE_HI_PFN_MASK 0xFFFFFU -#define SQ_CTXT_WQ_PAGE_PI_MASK 0xFFFU +#define SQ_CTXT_WQ_PAGE_HI_PFN_MASK 0xFFFFFU +#define SQ_CTXT_WQ_PAGE_PI_MASK 0xFFFU -#define SQ_CTXT_WQ_PAGE_SET(val, member) (((val) & \ - SQ_CTXT_WQ_PAGE_##member##_MASK) \ - << SQ_CTXT_WQ_PAGE_##member##_SHIFT) +#define SQ_CTXT_WQ_PAGE_SET(val, member) \ + (((val) & SQ_CTXT_WQ_PAGE_##member##_MASK) \ + << SQ_CTXT_WQ_PAGE_##member##_SHIFT) -#define SQ_CTXT_PREF_CACHE_THRESHOLD_SHIFT 0 -#define SQ_CTXT_PREF_CACHE_MAX_SHIFT 14 -#define SQ_CTXT_PREF_CACHE_MIN_SHIFT 25 +#define SQ_CTXT_PREF_CACHE_THRESHOLD_SHIFT 0 +#define SQ_CTXT_PREF_CACHE_MAX_SHIFT 14 +#define SQ_CTXT_PREF_CACHE_MIN_SHIFT 25 -#define SQ_CTXT_PREF_CACHE_THRESHOLD_MASK 0x3FFFU -#define SQ_CTXT_PREF_CACHE_MAX_MASK 0x7FFU -#define SQ_CTXT_PREF_CACHE_MIN_MASK 0x7FU +#define SQ_CTXT_PREF_CACHE_THRESHOLD_MASK 0x3FFFU +#define SQ_CTXT_PREF_CACHE_MAX_MASK 0x7FFU +#define SQ_CTXT_PREF_CACHE_MIN_MASK 0x7FU -#define SQ_CTXT_PREF_WQ_PFN_HI_SHIFT 0 -#define SQ_CTXT_PREF_CI_SHIFT 20 +#define SQ_CTXT_PREF_WQ_PFN_HI_SHIFT 0 +#define SQ_CTXT_PREF_CI_SHIFT 20 -#define SQ_CTXT_PREF_WQ_PFN_HI_MASK 0xFFFFFU -#define SQ_CTXT_PREF_CI_MASK 0xFFFU +#define SQ_CTXT_PREF_WQ_PFN_HI_MASK 0xFFFFFU +#define SQ_CTXT_PREF_CI_MASK 0xFFFU -#define SQ_CTXT_PREF_SET(val, member) (((val) & \ - SQ_CTXT_PREF_##member##_MASK) \ - << SQ_CTXT_PREF_##member##_SHIFT) +#define SQ_CTXT_PREF_SET(val, member) \ + (((val) & SQ_CTXT_PREF_##member##_MASK) \ + << SQ_CTXT_PREF_##member##_SHIFT) -#define SQ_CTXT_WQ_BLOCK_PFN_HI_SHIFT 0 +#define SQ_CTXT_WQ_BLOCK_PFN_HI_SHIFT 0 -#define SQ_CTXT_WQ_BLOCK_PFN_HI_MASK 0x7FFFFFU +#define SQ_CTXT_WQ_BLOCK_PFN_HI_MASK 0x7FFFFFU -#define SQ_CTXT_WQ_BLOCK_SET(val, member) (((val) & \ - SQ_CTXT_WQ_BLOCK_##member##_MASK) \ - << SQ_CTXT_WQ_BLOCK_##member##_SHIFT) +#define SQ_CTXT_WQ_BLOCK_SET(val, member) \ + (((val) & SQ_CTXT_WQ_BLOCK_##member##_MASK) \ + << SQ_CTXT_WQ_BLOCK_##member##_SHIFT) -#define RQ_CTXT_CEQ_ATTR_EN_SHIFT 0 -#define RQ_CTXT_CEQ_ATTR_OWNER_SHIFT 1 +#define RQ_CTXT_CEQ_ATTR_EN_SHIFT 0 +#define RQ_CTXT_CEQ_ATTR_OWNER_SHIFT 1 -#define RQ_CTXT_CEQ_ATTR_EN_MASK 0x1U -#define RQ_CTXT_CEQ_ATTR_OWNER_MASK 0x1U +#define RQ_CTXT_CEQ_ATTR_EN_MASK 0x1U +#define RQ_CTXT_CEQ_ATTR_OWNER_MASK 0x1U -#define RQ_CTXT_CEQ_ATTR_SET(val, member) (((val) & \ - RQ_CTXT_CEQ_ATTR_##member##_MASK) \ - << RQ_CTXT_CEQ_ATTR_##member##_SHIFT) +#define RQ_CTXT_CEQ_ATTR_SET(val, member) \ + (((val) & RQ_CTXT_CEQ_ATTR_##member##_MASK) \ + << RQ_CTXT_CEQ_ATTR_##member##_SHIFT) -#define RQ_CTXT_PI_IDX_SHIFT 0 -#define RQ_CTXT_PI_INTR_SHIFT 22 -#define RQ_CTXT_PI_CEQ_ARM_SHIFT 31 +#define RQ_CTXT_PI_IDX_SHIFT 0 +#define RQ_CTXT_PI_INTR_SHIFT 22 +#define RQ_CTXT_PI_CEQ_ARM_SHIFT 31 -#define RQ_CTXT_PI_IDX_MASK 0xFFFU -#define RQ_CTXT_PI_INTR_MASK 0x3FFU -#define RQ_CTXT_PI_CEQ_ARM_MASK 0x1U +#define RQ_CTXT_PI_IDX_MASK 0xFFFU +#define RQ_CTXT_PI_INTR_MASK 0x3FFU +#define RQ_CTXT_PI_CEQ_ARM_MASK 0x1U -#define RQ_CTXT_PI_SET(val, member) (((val) & \ - RQ_CTXT_PI_##member##_MASK) << \ - RQ_CTXT_PI_##member##_SHIFT) +#define RQ_CTXT_PI_SET(val, member) \ + (((val) & RQ_CTXT_PI_##member##_MASK) << \ + RQ_CTXT_PI_##member##_SHIFT) -#define RQ_CTXT_WQ_PAGE_HI_PFN_SHIFT 0 -#define RQ_CTXT_WQ_PAGE_CI_SHIFT 20 +#define RQ_CTXT_WQ_PAGE_HI_PFN_SHIFT 0 +#define RQ_CTXT_WQ_PAGE_CI_SHIFT 20 -#define RQ_CTXT_WQ_PAGE_HI_PFN_MASK 0xFFFFFU -#define RQ_CTXT_WQ_PAGE_CI_MASK 0xFFFU +#define RQ_CTXT_WQ_PAGE_HI_PFN_MASK 0xFFFFFU +#define RQ_CTXT_WQ_PAGE_CI_MASK 0xFFFU -#define RQ_CTXT_WQ_PAGE_SET(val, member) (((val) & \ - RQ_CTXT_WQ_PAGE_##member##_MASK) << \ - RQ_CTXT_WQ_PAGE_##member##_SHIFT) +#define RQ_CTXT_WQ_PAGE_SET(val, member) \ + (((val) & RQ_CTXT_WQ_PAGE_##member##_MASK) << \ + RQ_CTXT_WQ_PAGE_##member##_SHIFT) -#define RQ_CTXT_PREF_CACHE_THRESHOLD_SHIFT 0 -#define RQ_CTXT_PREF_CACHE_MAX_SHIFT 14 -#define RQ_CTXT_PREF_CACHE_MIN_SHIFT 25 +#define RQ_CTXT_PREF_CACHE_THRESHOLD_SHIFT 0 +#define RQ_CTXT_PREF_CACHE_MAX_SHIFT 14 +#define RQ_CTXT_PREF_CACHE_MIN_SHIFT 25 -#define RQ_CTXT_PREF_CACHE_THRESHOLD_MASK 0x3FFFU -#define RQ_CTXT_PREF_CACHE_MAX_MASK 0x7FFU -#define RQ_CTXT_PREF_CACHE_MIN_MASK 0x7FU +#define RQ_CTXT_PREF_CACHE_THRESHOLD_MASK 0x3FFFU +#define RQ_CTXT_PREF_CACHE_MAX_MASK 0x7FFU +#define RQ_CTXT_PREF_CACHE_MIN_MASK 0x7FU -#define RQ_CTXT_PREF_WQ_PFN_HI_SHIFT 0 -#define RQ_CTXT_PREF_CI_SHIFT 20 +#define RQ_CTXT_PREF_WQ_PFN_HI_SHIFT 0 +#define RQ_CTXT_PREF_CI_SHIFT 20 -#define RQ_CTXT_PREF_WQ_PFN_HI_MASK 0xFFFFFU -#define RQ_CTXT_PREF_CI_MASK 0xFFFU +#define RQ_CTXT_PREF_WQ_PFN_HI_MASK 0xFFFFFU +#define RQ_CTXT_PREF_CI_MASK 0xFFFU -#define RQ_CTXT_PREF_SET(val, member) (((val) & \ - RQ_CTXT_PREF_##member##_MASK) << \ - RQ_CTXT_PREF_##member##_SHIFT) +#define RQ_CTXT_PREF_SET(val, member) \ + (((val) & RQ_CTXT_PREF_##member##_MASK) << \ + RQ_CTXT_PREF_##member##_SHIFT) -#define RQ_CTXT_WQ_BLOCK_PFN_HI_SHIFT 0 +#define RQ_CTXT_WQ_BLOCK_PFN_HI_SHIFT 0 -#define RQ_CTXT_WQ_BLOCK_PFN_HI_MASK 0x7FFFFFU +#define RQ_CTXT_WQ_BLOCK_PFN_HI_MASK 0x7FFFFFU -#define RQ_CTXT_WQ_BLOCK_SET(val, member) (((val) & \ - RQ_CTXT_WQ_BLOCK_##member##_MASK) << \ - RQ_CTXT_WQ_BLOCK_##member##_SHIFT) +#define RQ_CTXT_WQ_BLOCK_SET(val, member) \ + (((val) & RQ_CTXT_WQ_BLOCK_##member##_MASK) << \ + RQ_CTXT_WQ_BLOCK_##member##_SHIFT) -#define SIZE_16BYTES(size) (ALIGN((size), 16) >> 4) +#define SIZE_16BYTES(size) (ALIGN((size), 16) >> 4) -#define WQ_PAGE_PFN_SHIFT 12 -#define WQ_BLOCK_PFN_SHIFT 9 +#define WQ_PAGE_PFN_SHIFT 12 +#define WQ_BLOCK_PFN_SHIFT 9 #define WQ_PAGE_PFN(page_addr) ((page_addr) >> WQ_PAGE_PFN_SHIFT) #define WQ_BLOCK_PFN(page_addr) ((page_addr) >> WQ_BLOCK_PFN_SHIFT) diff --git a/drivers/net/ethernet/huawei/hinic/hinic_dbgtool_knl.c b/drivers/net/ethernet/huawei/hinic/hinic_dbgtool_knl.c index 0137ee0c072d..0337a6b5fb80 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_dbgtool_knl.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_dbgtool_knl.c @@ -46,7 +46,7 @@ struct ffm_intr_info { u32 err_csr_value; }; -#define DBGTOOL_MSG_MAX_SIZE 2048ULL +#define DBGTOOL_MSG_MAX_SIZE 2048ULL #define HINIC_SELF_CMD_UP2PF_FFM 0x26 void *g_card_node_array[MAX_CARD_NUM] = {0}; @@ -57,9 +57,9 @@ struct mutex g_addr_lock; int card_id; /* dbgtool character device name, class name, dev path */ -#define CHR_DEV_DBGTOOL "dbgtool_chr_dev" -#define CLASS_DBGTOOL "dbgtool_class" -#define DBGTOOL_DEV_PATH "/dev/dbgtool_chr_dev" +#define CHR_DEV_DBGTOOL "dbgtool_chr_dev" +#define CLASS_DBGTOOL "dbgtool_class" +#define DBGTOOL_DEV_PATH "/dev/dbgtool_chr_dev" struct dbgtool_k_glb_info { struct semaphore dbgtool_sem; diff --git a/drivers/net/ethernet/huawei/hinic/hinic_dcb.c b/drivers/net/ethernet/huawei/hinic/hinic_dcb.c index 0c7ae9133407..033549b24983 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_dcb.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_dcb.c @@ -120,8 +120,6 @@ void hinic_init_ieee_settings(struct hinic_nic_dev *nic_dev) if (dcb_cfg->tc_cfg[i].pfc_en) pfc->pfc_en |= (u8)BIT(i); } - - return; } static int hinic_set_up_cos_map(struct hinic_nic_dev *nic_dev, @@ -1273,7 +1271,7 @@ u8 hinic_dcbnl_set_all(struct net_device *netdev) } static int hinic_dcbnl_ieee_get_ets(struct net_device *netdev, - struct ieee_ets *ets) + struct ieee_ets *ets) { struct hinic_nic_dev *nic_dev = netdev_priv(netdev); struct ieee_ets *my_ets = &nic_dev->hinic_ieee_ets; @@ -1288,7 +1286,7 @@ static int hinic_dcbnl_ieee_get_ets(struct net_device *netdev, } static int hinic_dcbnl_ieee_set_ets(struct net_device *netdev, - struct ieee_ets *ets) + struct ieee_ets *ets) { struct hinic_nic_dev *nic_dev = netdev_priv(netdev); struct hinic_dcb_config *dcb_cfg = &nic_dev->dcb_cfg; @@ -1354,7 +1352,7 @@ static int hinic_dcbnl_ieee_set_ets(struct net_device *netdev, } static int hinic_dcbnl_ieee_get_pfc(struct net_device *netdev, - struct ieee_pfc *pfc) + struct ieee_pfc *pfc) { struct hinic_nic_dev *nic_dev = netdev_priv(netdev); struct ieee_pfc *my_pfc = &nic_dev->hinic_ieee_pfc; @@ -1366,7 +1364,7 @@ static int hinic_dcbnl_ieee_get_pfc(struct net_device *netdev, } static int hinic_dcbnl_ieee_set_pfc(struct net_device *netdev, - struct ieee_pfc *pfc) + struct ieee_pfc *pfc) { struct hinic_nic_dev *nic_dev = netdev_priv(netdev); struct hinic_dcb_config *dcb_cfg = &nic_dev->dcb_cfg; diff --git a/drivers/net/ethernet/huawei/hinic/hinic_dfx_def.h b/drivers/net/ethernet/huawei/hinic/hinic_dfx_def.h index 8767cc077871..9a89eed2ddfe 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_dfx_def.h +++ b/drivers/net/ethernet/huawei/hinic/hinic_dfx_def.h @@ -139,9 +139,9 @@ struct hinic_show_item { u64 value; }; -#define UP_UPDATEFW_TIME_OUT_VAL 20000U +#define UP_UPDATEFW_TIME_OUT_VAL 20000U #define UCODE_COMP_TIME_OUT_VAL 0xFF00000 -#define NIC_TOOL_MAGIC 'x' +#define NIC_TOOL_MAGIC 'x' enum hinic_nictool_drv_cap { NICTOOL_SUPPORT_API_CSR = 0x1, diff --git a/drivers/net/ethernet/huawei/hinic/hinic_eqs.c b/drivers/net/ethernet/huawei/hinic/hinic_eqs.c index e582cc378bd5..ac8240431c3c 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_eqs.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_eqs.c @@ -51,15 +51,15 @@ #define AEQ_CTRL_0_GET(val, member) \ (((val) >> AEQ_CTRL_0_##member##_SHIFT) & \ - AEQ_CTRL_0_##member##_MASK) + AEQ_CTRL_0_##member##_MASK) #define AEQ_CTRL_0_SET(val, member) \ (((val) & AEQ_CTRL_0_##member##_MASK) << \ - AEQ_CTRL_0_##member##_SHIFT) + AEQ_CTRL_0_##member##_SHIFT) #define AEQ_CTRL_0_CLEAR(val, member) \ ((val) & (~(AEQ_CTRL_0_##member##_MASK \ - << AEQ_CTRL_0_##member##_SHIFT))) + << AEQ_CTRL_0_##member##_SHIFT))) #define AEQ_CTRL_1_LEN_SHIFT 0 #define AEQ_CTRL_1_FUNC_OWN_SHIFT 21 @@ -73,15 +73,15 @@ #define AEQ_CTRL_1_GET(val, member) \ (((val) >> AEQ_CTRL_1_##member##_SHIFT) & \ - AEQ_CTRL_1_##member##_MASK) + AEQ_CTRL_1_##member##_MASK) #define AEQ_CTRL_1_SET(val, member) \ (((val) & AEQ_CTRL_1_##member##_MASK) << \ - AEQ_CTRL_1_##member##_SHIFT) + AEQ_CTRL_1_##member##_SHIFT) #define AEQ_CTRL_1_CLEAR(val, member) \ ((val) & (~(AEQ_CTRL_1_##member##_MASK \ - << AEQ_CTRL_1_##member##_SHIFT))) + << AEQ_CTRL_1_##member##_SHIFT))) #define HINIC_EQ_PROD_IDX_MASK 0xFFFFF #define HINIC_TASK_PROCESS_EQE_LIMIT 1024 @@ -118,7 +118,7 @@ MODULE_PARM_DESC(g_num_ceqe_in_tasklet, #define CEQ_CTRL_0_SET(val, member) \ (((val) & CEQ_CTRL_0_##member##_MASK) << \ - CEQ_CTRL_0_##member##_SHIFT) + CEQ_CTRL_0_##member##_SHIFT) #define CEQ_CTRL_1_LEN_SHIFT 0 #define CEQ_CTRL_1_PAGE_SIZE_SHIFT 28 @@ -128,7 +128,7 @@ MODULE_PARM_DESC(g_num_ceqe_in_tasklet, #define CEQ_CTRL_1_SET(val, member) \ (((val) & CEQ_CTRL_1_##member##_MASK) << \ - CEQ_CTRL_1_##member##_SHIFT) + CEQ_CTRL_1_##member##_SHIFT) #define EQ_ELEM_DESC_TYPE_SHIFT 0 #define EQ_ELEM_DESC_SRC_SHIFT 7 @@ -142,7 +142,7 @@ MODULE_PARM_DESC(g_num_ceqe_in_tasklet, #define EQ_ELEM_DESC_GET(val, member) \ (((val) >> EQ_ELEM_DESC_##member##_SHIFT) & \ - EQ_ELEM_DESC_##member##_MASK) + EQ_ELEM_DESC_##member##_MASK) #define EQ_CONS_IDX_CONS_IDX_SHIFT 0 #define EQ_CONS_IDX_XOR_CHKSUM_SHIFT 24 @@ -154,11 +154,11 @@ MODULE_PARM_DESC(g_num_ceqe_in_tasklet, #define EQ_CONS_IDX_SET(val, member) \ (((val) & EQ_CONS_IDX_##member##_MASK) << \ - EQ_CONS_IDX_##member##_SHIFT) + EQ_CONS_IDX_##member##_SHIFT) #define EQ_CONS_IDX_CLEAR(val, member) \ ((val) & (~(EQ_CONS_IDX_##member##_MASK \ - << EQ_CONS_IDX_##member##_SHIFT))) + << EQ_CONS_IDX_##member##_SHIFT))) #define EQ_WRAPPED(eq) ((u32)(eq)->wrapped << EQ_VALID_SHIFT) @@ -546,7 +546,7 @@ static bool aeq_irq_handler(struct hinic_eq *eq) &aeqs->aeq_sw_cb_state[sw_event]); if (aeqs->aeq_swe_cb[sw_event] && test_bit(HINIC_AEQ_SW_CB_REG, - &aeqs->aeq_sw_cb_state[sw_event])) { + &aeqs->aeq_sw_cb_state[sw_event])) { lev = aeqs->aeq_swe_cb[sw_event](aeqs->hwdev, ucode_event, aeqe_data); @@ -560,7 +560,7 @@ static bool aeq_irq_handler(struct hinic_eq *eq) &aeqs->aeq_hw_cb_state[event]); if (aeqs->aeq_hwe_cb[event] && test_bit(HINIC_AEQ_HW_CB_REG, - &aeqs->aeq_hw_cb_state[event])) + &aeqs->aeq_hw_cb_state[event])) aeqs->aeq_hwe_cb[event](aeqs->hwdev, aeqe_pos->aeqe_data, size); clear_bit(HINIC_AEQ_HW_CB_RUNNING, @@ -1064,6 +1064,7 @@ static void free_eq_pages(struct hinic_eq *eq) kfree(eq->virt_addr); kfree(eq->dma_addr); } + static inline u32 get_page_size(struct hinic_eq *eq) { u32 total_size; @@ -1087,6 +1088,7 @@ static inline u32 get_page_size(struct hinic_eq *eq) return EQ_MIN_PAGE_SIZE << n; } + /** * init_eq - initialize eq * @eq: the event queue diff --git a/drivers/net/ethernet/huawei/hinic/hinic_eqs.h b/drivers/net/ethernet/huawei/hinic/hinic_eqs.h index dec541995ee2..bd2c96d9b650 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_eqs.h +++ b/drivers/net/ethernet/huawei/hinic/hinic_eqs.h @@ -71,6 +71,7 @@ struct hinic_eq_work { struct hinic_ceq_tasklet_data { void *data; }; + struct hinic_eq { struct hinic_hwdev *hwdev; u16 q_id; @@ -86,7 +87,7 @@ struct hinic_eq { u16 num_pages; u32 num_elem_in_pg; - struct irq_info eq_irq; + struct irq_info eq_irq; char irq_name[EQ_IRQ_NAME_LEN]; dma_addr_t *dma_addr; diff --git a/drivers/net/ethernet/huawei/hinic/hinic_ethtool.c b/drivers/net/ethernet/huawei/hinic/hinic_ethtool.c index e144d11e9c59..aca9bd9a6624 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_ethtool.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_ethtool.c @@ -337,12 +337,12 @@ void hinic_get_io_stats(struct hinic_nic_dev *nic_dev, } } -#define LP_DEFAULT_TIME (5) /* seconds */ -#define LP_PKT_LEN (1514) -#define OBJ_STR_MAX_LEN (32) -#define SET_LINK_STR_MAX_LEN (128) +#define LP_DEFAULT_TIME 5 /* seconds */ +#define LP_PKT_LEN 1514 +#define OBJ_STR_MAX_LEN 32 +#define SET_LINK_STR_MAX_LEN 128 -#define PORT_DOWN_ERR_IDX 0 +#define PORT_DOWN_ERR_IDX 0 enum diag_test_index { INTERNAL_LP_TEST = 0, EXTERNAL_LP_TEST = 1, @@ -684,23 +684,23 @@ static int hinic_get_settings(struct net_device *netdev, } static int hinic_get_link_ksettings(struct net_device *netdev, - struct ethtool_link_ksettings *link_settings) + struct ethtool_link_ksettings *cmd) { struct cmd_link_settings settings = {0}; - struct ethtool_link_settings *base = &link_settings->base; + struct ethtool_link_settings *base = &cmd->base; int err; - ethtool_link_ksettings_zero_link_mode(link_settings, supported); - ethtool_link_ksettings_zero_link_mode(link_settings, advertising); + ethtool_link_ksettings_zero_link_mode(cmd, supported); + ethtool_link_ksettings_zero_link_mode(cmd, advertising); err = get_link_settings(netdev, &settings); if (err) return err; - bitmap_copy(link_settings->link_modes.supported, + bitmap_copy(cmd->link_modes.supported, (unsigned long *)&settings.supported, __ETHTOOL_LINK_MODE_MASK_NBITS); - bitmap_copy(link_settings->link_modes.advertising, + bitmap_copy(cmd->link_modes.advertising, (unsigned long *)&settings.advertising, __ETHTOOL_LINK_MODE_MASK_NBITS); @@ -868,11 +868,11 @@ static int hinic_set_settings(struct net_device *netdev, } static int hinic_set_link_ksettings(struct net_device *netdev, - const struct ethtool_link_ksettings *link_settings) + const struct ethtool_link_ksettings *cmd) { /* Only support to set autoneg and speed */ - return set_link_settings(netdev, link_settings->base.autoneg, - link_settings->base.speed); + return set_link_settings(netdev, cmd->base.autoneg, + cmd->base.speed); } static void hinic_get_drvinfo(struct net_device *netdev, @@ -1387,27 +1387,27 @@ static int is_coalesce_legal(struct net_device *netdev, #define CHECK_COALESCE_ALIGN(coal, item, unit) \ do { \ - if (coal->item % (unit)) \ + if ((coal)->item % (unit)) \ nicif_warn(nic_dev, drv, netdev, \ "%s in %d units, change to %d\n", \ - #item, (unit), ALIGN_DOWN(coal->item, unit));\ + #item, (unit), ALIGN_DOWN((coal)->item, unit));\ } while (0) #define CHECK_COALESCE_CHANGED(coal, item, unit, ori_val, obj_str) \ do { \ - if ((coal->item / (unit)) != (ori_val)) \ + if (((coal)->item / (unit)) != (ori_val)) \ nicif_info(nic_dev, drv, netdev, \ "Change %s from %d to %d %s\n", \ #item, (ori_val) * (unit), \ - ALIGN_DOWN(coal->item, unit), (obj_str)); \ + ALIGN_DOWN((coal)->item, unit), (obj_str));\ } while (0) #define CHECK_PKT_RATE_CHANGED(coal, item, ori_val, obj_str) \ do { \ - if (coal->item != (ori_val)) \ + if ((coal)->item != (ori_val)) \ nicif_info(nic_dev, drv, netdev, \ "Change %s from %llu to %u %s\n", \ - #item, (ori_val), coal->item, (obj_str)); \ + #item, (ori_val), (coal)->item, (obj_str));\ } while (0) static int __hinic_set_coalesce(struct net_device *netdev, diff --git a/drivers/net/ethernet/huawei/hinic/hinic_hw.h b/drivers/net/ethernet/huawei/hinic/hinic_hw.h index 7b12a8142bab..9f50bc27a856 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_hw.h +++ b/drivers/net/ethernet/huawei/hinic/hinic_hw.h @@ -70,8 +70,8 @@ int hinic_msg_to_mgmt_async(void *hwdev, enum hinic_mod_type mod, u8 cmd, void *buf_in, u16 in_size); int hinic_mbox_to_vf(void *hwdev, enum hinic_mod_type mod, - u16 vf_id, u8 cmd, void *buf_in, u16 in_size, - void *buf_out, u16 *out_size, u32 timeout); + u16 vf_id, u8 cmd, void *buf_in, u16 in_size, + void *buf_out, u16 *out_size, u32 timeout); int hinic_api_cmd_write_nack(void *hwdev, u8 dest, void *cmd, u16 size); @@ -155,7 +155,8 @@ int hinic_aeq_register_swe_cb(void *hwdev, enum hinic_aeq_sw_type event, void hinic_aeq_unregister_swe_cb(void *hwdev, enum hinic_aeq_sw_type event); typedef void (*hinic_mgmt_msg_cb)(void *hwdev, void *pri_handle, - u8 cmd, void *buf_in, u16 in_size, void *buf_out, u16 *out_size); + u8 cmd, void *buf_in, u16 in_size, + void *buf_out, u16 *out_size); int hinic_register_mgmt_msg_cb(void *hwdev, enum hinic_mod_type mod, void *pri_handle, @@ -428,6 +429,7 @@ enum hinic_service_mode { HINIC_WORK_MODE_NIC, HINIC_WORK_MODE_INVALID = 0xFF, }; + enum hinic_service_mode hinic_get_service_mode(void *hwdev); int hinic_slq_init(void *dev, int num_wqs); @@ -439,7 +441,8 @@ u64 hinic_slq_get_addr(void *handle, u16 index); u64 hinic_slq_get_first_pageaddr(void *handle); typedef void (*comm_up_self_msg_proc)(void *handle, void *buf_in, - u16 in_size, void *buf_out, u16 *out_size); + u16 in_size, void *buf_out, + u16 *out_size); void hinic_comm_recv_mgmt_self_cmd_reg(void *hwdev, u8 cmd, comm_up_self_msg_proc proc); @@ -668,7 +671,7 @@ enum hinic_ucode_event_type { }; typedef void (*hinic_event_handler)(void *handle, - struct hinic_event_info *event); + struct hinic_event_info *event); /* only register once */ void hinic_event_register(void *dev, void *pri_handle, @@ -751,11 +754,11 @@ struct hinic_hw_pf_infos { int hinic_get_hw_pf_infos(void *hwdev, struct hinic_hw_pf_infos *infos); int hinic_set_ip_check(void *hwdev, bool ip_check_ctl); int hinic_mbox_to_host_sync(void *hwdev, enum hinic_mod_type mod, - u8 cmd, void *buf_in, u16 in_size, void *buf_out, - u16 *out_size, u32 timeout); -int hinic_mbox_ppf_to_vf(void *hwdev, - enum hinic_mod_type mod, u16 func_id, u8 cmd, void *buf_in, - u16 in_size, void *buf_out, u16 *out_size, u32 timeout); + u8 cmd, void *buf_in, u16 in_size, void *buf_out, + u16 *out_size, u32 timeout); +int hinic_mbox_ppf_to_vf(void *hwdev, enum hinic_mod_type mod, u16 func_id, + u8 cmd, void *buf_in, u16 in_size, void *buf_out, + u16 *out_size, u32 timeout); int hinic_get_card_present_state(void *hwdev, bool *card_present_state); diff --git a/drivers/net/ethernet/huawei/hinic/hinic_hw_mgmt.h b/drivers/net/ethernet/huawei/hinic/hinic_hw_mgmt.h index 39778e8b762a..ff742b37c232 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_hw_mgmt.h +++ b/drivers/net/ethernet/huawei/hinic/hinic_hw_mgmt.h @@ -533,6 +533,7 @@ struct hinic_micro_log_info { int (*init)(void *hwdev); void (*deinit)(void *hwdev); }; + int hinic_register_micro_log(struct hinic_micro_log_info *micro_log_info); void hinic_unregister_micro_log(struct hinic_micro_log_info *micro_log_info); diff --git a/drivers/net/ethernet/huawei/hinic/hinic_hwdev.c b/drivers/net/ethernet/huawei/hinic/hinic_hwdev.c index 18e017d84257..db6c468818ef 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_hwdev.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_hwdev.c @@ -47,23 +47,23 @@ #define HINIC_DEAULT_EQ_MSIX_COALESC_TIMER_CFG 0xFF #define HINIC_DEAULT_EQ_MSIX_RESEND_TIMER_CFG 7 -#define HINIC_WAIT_IO_STATUS_TIMEOUT 100 +#define HINIC_WAIT_IO_STATUS_TIMEOUT 100 -#define HINIC_FLR_TIMEOUT 1000 +#define HINIC_FLR_TIMEOUT 1000 -#define HINIC_HT_GPA_PAGE_SIZE 4096UL +#define HINIC_HT_GPA_PAGE_SIZE 4096UL -#define HINIC_PPF_HT_GPA_SET_RETRY_TIMES 10 +#define HINIC_PPF_HT_GPA_SET_RETRY_TIMES 10 #define HINIC_OK_FLAG_OK 0 -#define HINIC_OK_FLAG_FAILED 1 +#define HINIC_OK_FLAG_FAILED 1 -#define HINIC_GET_SFP_INFO_REAL_TIME 0x1 +#define HINIC_GET_SFP_INFO_REAL_TIME 0x1 -#define HINIC_GLB_SO_RO_CFG_SHIFT 0x0 -#define HINIC_GLB_SO_RO_CFG_MASK 0x1 -#define HINIC_DISABLE_ORDER 0 +#define HINIC_GLB_SO_RO_CFG_SHIFT 0x0 +#define HINIC_GLB_SO_RO_CFG_MASK 0x1 +#define HINIC_DISABLE_ORDER 0 #define HINIC_GLB_DMA_SO_RO_GET(val, member) \ (((val) >> HINIC_GLB_##member##_SHIFT) & HINIC_GLB_##member##_MASK) @@ -73,10 +73,10 @@ #define HINIC_GLB_DMA_SO_R0_SET(val, member) \ (((val) & HINIC_GLB_##member##_MASK) << HINIC_GLB_##member##_SHIFT) -#define HINIC_MGMT_CHANNEL_STATUS_SHIFT 0x0 -#define HINIC_MGMT_CHANNEL_STATUS_MASK 0x1 -#define HINIC_ACTIVE_STATUS_MASK 0x80000000 -#define HINIC_ACTIVE_STATUS_CLEAR 0x7FFFFFFF +#define HINIC_MGMT_CHANNEL_STATUS_SHIFT 0x0 +#define HINIC_MGMT_CHANNEL_STATUS_MASK 0x1 +#define HINIC_ACTIVE_STATUS_MASK 0x80000000 +#define HINIC_ACTIVE_STATUS_CLEAR 0x7FFFFFFF #define HINIC_GET_MGMT_CHANNEL_STATUS(val, member) \ (((val) >> HINIC_##member##_SHIFT) & HINIC_##member##_MASK) @@ -386,7 +386,7 @@ struct hinic_wq_page_size { u32 rsvd1; }; -#define MAX_PCIE_DFX_BUF_SIZE (1024) +#define MAX_PCIE_DFX_BUF_SIZE 1024 struct hinic_pcie_dfx_ntc { u8 status; @@ -642,10 +642,11 @@ static void __print_status_info(struct hinic_hwdev *dev, mod, cmd, mgmt_status_log[index].log); } else if (mod == HINIC_MOD_L2NIC || mod == HINIC_MOD_HILINK) { - if (HINIC_IS_VF(dev) && (cmd == HINIC_PORT_CMD_SET_MAC || cmd == - HINIC_PORT_CMD_DEL_MAC || cmd == - HINIC_PORT_CMD_UPDATE_MAC) && - (mgmt_status_log[index].status == HINIC_PF_SET_VF_ALREADY)) + if (HINIC_IS_VF(dev) && + (cmd == HINIC_PORT_CMD_SET_MAC || + cmd == HINIC_PORT_CMD_DEL_MAC || + cmd == HINIC_PORT_CMD_UPDATE_MAC) && + mgmt_status_log[index].status == HINIC_PF_SET_VF_ALREADY) return; nic_err(dev->dev_hdl, "Mgmt process mod(0x%x) cmd(0x%x) fail: %s", @@ -694,7 +695,7 @@ static void hinic_print_status_info(void *hwdev, enum hinic_mod_type mod, if (hinic_status_need_special_handle(mod, cmd, status)) return; - size = sizeof(mgmt_status_log) / sizeof(mgmt_status_log[0]); + size = ARRAY_SIZE(mgmt_status_log); for (i = 0; i < size; i++) { if (status == mgmt_status_log[i].status) { __print_status_info(dev, mod, cmd, i); @@ -795,7 +796,8 @@ static int __func_send_mbox(struct hinic_hwdev *hwdev, enum hinic_mod_type mod, out_size, timeout); else if (NEED_MBOX_FORWARD(hwdev)) err = hinic_mbox_to_host_sync(hwdev, mod, cmd, buf_in, - in_size, buf_out, out_size, timeout); + in_size, buf_out, out_size, + timeout); else err = -EFAULT; @@ -1088,8 +1090,7 @@ int hinic_mbox_to_vf(void *hwdev, EXPORT_SYMBOL(hinic_mbox_to_vf); int hinic_clp_to_mgmt(void *hwdev, enum hinic_mod_type mod, u8 cmd, - void *buf_in, u16 in_size, - void *buf_out, u16 *out_size) + void *buf_in, u16 in_size, void *buf_out, u16 *out_size) { struct hinic_hwdev *dev = hwdev; @@ -1108,7 +1109,7 @@ int hinic_clp_to_mgmt(void *hwdev, enum hinic_mod_type mod, u8 cmd, return -EPERM; err = hinic_pf_clp_to_mgmt(dev, mod, cmd, buf_in, - in_size, buf_out, out_size); + in_size, buf_out, out_size); return err; } @@ -1769,8 +1770,8 @@ static int init_ceqs_msix_attr(struct hinic_hwdev *hwdev) */ static void set_pf_dma_attr_entry(struct hinic_hwdev *hwdev, u32 entry_idx, u8 st, u8 at, u8 ph, - enum hinic_pcie_nosnoop no_snooping, - enum hinic_pcie_tph tph_en) + enum hinic_pcie_nosnoop no_snooping, + enum hinic_pcie_tph tph_en) { u32 addr, val, dma_attr_entry; @@ -1796,8 +1797,8 @@ static void set_pf_dma_attr_entry(struct hinic_hwdev *hwdev, u32 entry_idx, static int set_vf_dma_attr_entry(struct hinic_hwdev *hwdev, u8 entry_idx, u8 st, u8 at, u8 ph, - enum hinic_pcie_nosnoop no_snooping, - enum hinic_pcie_tph tph_en) + enum hinic_pcie_nosnoop no_snooping, + enum hinic_pcie_tph tph_en) { struct hinic_vf_dma_attr_table attr = {0}; u16 out_size = sizeof(attr); @@ -1958,7 +1959,7 @@ int comm_pf_mbox_handler(void *handle, u16 vf_id, u8 cmd, void *buf_in, u16 in_size, void *buf_out, u16 *out_size) { int err = 0; - u8 size = sizeof(hw_cmd_support_vf) / sizeof(hw_cmd_support_vf[0]); + u8 size = ARRAY_SIZE(hw_cmd_support_vf); if (!hinic_mbox_check_cmd_valid(handle, hw_cmd_support_vf, vf_id, cmd, buf_in, in_size, size)) { @@ -2173,6 +2174,7 @@ static void hinic_comm_pf_to_mgmt_free(struct hinic_hwdev *hwdev) hinic_pf_to_mgmt_free(hwdev); } + static int hinic_comm_clp_to_mgmt_init(struct hinic_hwdev *hwdev) { int err; @@ -2327,7 +2329,6 @@ static int __get_func_misc_info(struct hinic_hwdev *hwdev) return 0; } - /* initialize communication channel */ int hinic_init_comm_ch(struct hinic_hwdev *hwdev) { @@ -3289,7 +3290,7 @@ static struct hinic_event_convert __event_convert[] = { static enum hinic_event_cmd __get_event_type(u8 mod, u8 cmd) { int idx; - int arr_size = sizeof(__event_convert) / sizeof(__event_convert[0]); + int arr_size = ARRAY_SIZE(__event_convert); for (idx = 0; idx < arr_size; idx++) { if (__event_convert[idx].mod == mod && @@ -4232,6 +4233,7 @@ static int vf_nic_event_handler(void *hwdev, u8 cmd, void *buf_in, { enum hinic_event_cmd type = __get_event_type(HINIC_MOD_L2NIC, cmd); + if (type == HINIC_EVENT_MAX_TYPE) { sdk_warn(((struct hinic_hwdev *)hwdev)->dev_hdl, "Unsupport L2NIC event: cmd %d\n", cmd); @@ -4249,6 +4251,7 @@ static int vf_comm_event_handler(void *hwdev, u8 cmd, void *buf_in, { enum hinic_event_cmd type = __get_event_type(HINIC_MOD_COMM, cmd); + if (type == HINIC_EVENT_MAX_TYPE) { sdk_warn(((struct hinic_hwdev *)hwdev)->dev_hdl, "Unsupport COMM event: cmd %d\n", cmd); @@ -4267,6 +4270,7 @@ static void pf_nic_event_handler(void *hwdev, void *pri_handle, u8 cmd, void *buf_out, u16 *out_size) { enum hinic_event_cmd type = __get_event_type(HINIC_MOD_L2NIC, cmd); + if (type == HINIC_EVENT_MAX_TYPE) { sdk_warn(((struct hinic_hwdev *)hwdev)->dev_hdl, "Unsupport L2NIC event: cmd %d\n", cmd); @@ -4282,6 +4286,7 @@ static void pf_hilink_event_handler(void *hwdev, void *pri_handle, u8 cmd, void *buf_out, u16 *out_size) { enum hinic_event_cmd type = __get_event_type(HINIC_MOD_HILINK, cmd); + if (type == HINIC_EVENT_MAX_TYPE) { sdk_warn(((struct hinic_hwdev *)hwdev)->dev_hdl, "Unsupport HILINK event: cmd %d\n", cmd); @@ -4316,7 +4321,7 @@ void mgmt_fmw_act_event_handler(void *hwdev, void *buf_in, u16 in_size, } void mgmt_pcie_dfx_event_handler(void *hwdev, void *buf_in, u16 in_size, - void *buf_out, u16 *out_size) + void *buf_out, u16 *out_size) { _event_handler(hwdev, HINIC_EVENT_MGMT_PCIE_DFX, buf_in, in_size, buf_out, out_size); @@ -4897,8 +4902,8 @@ int hinic_set_ip_check(void *hwdev, bool ip_check_ctl) for (i = 0; i <= HINIC_IPSU_CHANNEL_NUM; i++) { ret = hinic_api_csr_rd32(hwdev, HINIC_NODE_ID_IPSU, - (HINIC_IPSU_CHANNEL0_ADDR + - i * HINIC_IPSU_CHANNEL_OFFSET), &val); + (HINIC_IPSU_CHANNEL0_ADDR + + i * HINIC_IPSU_CHANNEL_OFFSET), &val); if (ret) return ret; @@ -4910,8 +4915,8 @@ int hinic_set_ip_check(void *hwdev, bool ip_check_ctl) val = cpu_to_be32(val); ret = hinic_api_csr_wr32(hwdev, HINIC_NODE_ID_IPSU, - (HINIC_IPSU_CHANNEL0_ADDR + - i * HINIC_IPSU_CHANNEL_OFFSET), val); + (HINIC_IPSU_CHANNEL0_ADDR + + i * HINIC_IPSU_CHANNEL_OFFSET), val); if (ret) return ret; } @@ -4957,7 +4962,7 @@ int hinic_set_vxlan_udp_dport(void *hwdev, u32 udp_port) return 0; ret = hinic_api_csr_rd32(hwdev, HINIC_NODE_ID_IPSU, - HINIC_IPSURX_VXLAN_DPORT_ADDR, &val); + HINIC_IPSURX_VXLAN_DPORT_ADDR, &val); if (ret) return ret; @@ -4970,7 +4975,7 @@ int hinic_set_vxlan_udp_dport(void *hwdev, u32 udp_port) udp_port = cpu_to_be32(udp_port); ret = hinic_api_csr_wr32(hwdev, HINIC_NODE_ID_IPSU, - HINIC_IPSURX_VXLAN_DPORT_ADDR, udp_port); + HINIC_IPSURX_VXLAN_DPORT_ADDR, udp_port); if (ret) return ret; diff --git a/drivers/net/ethernet/huawei/hinic/hinic_hwdev.h b/drivers/net/ethernet/huawei/hinic/hinic_hwdev.h index 60567f18a17f..22a95ea184df 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_hwdev.h +++ b/drivers/net/ethernet/huawei/hinic/hinic_hwdev.h @@ -22,7 +22,7 @@ #define HINIC_DEFAULT_WQ_PAGE_SIZE 0x40000 #define HINIC_HW_WQ_PAGE_SIZE 0x1000 -#define HINIC_MSG_TO_MGMT_MAX_LEN 2016 +#define HINIC_MSG_TO_MGMT_MAX_LEN 2016 #define HINIC_MGMT_STATUS_ERR_OK 0 /* Ok */ #define HINIC_MGMT_STATUS_ERR_PARAM 1 /* Invalid parameter */ @@ -48,8 +48,8 @@ #define HINIC_MGMT_STATUS_ERR_LEN 32 /* Length too short or too long */ #define HINIC_MGMT_STATUS_ERR_UNSUPPORT 0xFF /* Feature not supported */ -#define HINIC_CHIP_PRESENT 1 -#define HINIC_CHIP_ABSENT 0 +#define HINIC_CHIP_PRESENT 1 +#define HINIC_CHIP_ABSENT 0 struct cfg_mgmt_info; struct rdma_comp_resource; @@ -100,7 +100,7 @@ struct mqm_addr_trans_tbl_info { #define HINIC_DEV_ACTIVE_FW_TIMEOUT (35 * 1000) #define HINIC_DEV_BUSY_ACTIVE_FW 0xFE -#define HINIC_HW_WQ_NAME "hinic_hardware" +#define HINIC_HW_WQ_NAME "hinic_hardware" #define HINIC_HEARTBEAT_PERIOD 1000 #define HINIC_HEARTBEAT_START_EXPIRE 5000 @@ -224,9 +224,9 @@ struct hinic_hw_stats { #define HINIC_BOARD_TYPE_MULTI_HOST_ETH_25GE 12 /* new version of roce qp not limited by power of 2 */ -#define HINIC_CMD_VER_ROCE_QP 1 +#define HINIC_CMD_VER_ROCE_QP 1 /* new version for add function id in multi-host */ -#define HINIC_CMD_VER_FUNC_ID 2 +#define HINIC_CMD_VER_FUNC_ID 2 struct hinic_hwdev { void *adapter_hdl; /* pointer to hinic_pcidev or NDIS_Adapter */ @@ -341,8 +341,8 @@ int hinic_pf_msg_to_mgmt_sync(void *hwdev, enum hinic_mod_type mod, u8 cmd, void *buf_out, u16 *out_size, u32 timeout); int hinic_pf_send_clp_cmd(void *hwdev, enum hinic_mod_type mod, u8 cmd, - void *buf_in, u16 in_size, - void *buf_out, u16 *out_size); + void *buf_in, u16 in_size, + void *buf_out, u16 *out_size); int hinic_get_bios_pf_bw_limit(void *hwdev, u32 *pf_bw_limit); @@ -354,8 +354,8 @@ int hinic_set_wq_page_size(struct hinic_hwdev *hwdev, u16 func_idx, int hinic_phy_init_status_judge(void *hwdev); int hinic_hilink_info_show(struct hinic_hwdev *hwdev); -extern int hinic_api_csr_rd32(void *hwdev, u8 dest, u32 addr, u32 *val); -extern int hinic_api_csr_wr32(void *hwdev, u8 dest, u32 addr, u32 val); +int hinic_api_csr_rd32(void *hwdev, u8 dest, u32 addr, u32 *val); +int hinic_api_csr_wr32(void *hwdev, u8 dest, u32 addr, u32 val); int hinic_ppf_process_mbox_msg(struct hinic_hwdev *hwdev, u16 pf_idx, u16 vf_id, enum hinic_mod_type mod, u8 cmd, void *buf_in, diff --git a/drivers/net/ethernet/huawei/hinic/hinic_hwif.c b/drivers/net/ethernet/huawei/hinic/hinic_hwif.c index ee01ca21e3f2..626b76f17e6d 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_hwif.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_hwif.c @@ -796,7 +796,6 @@ void hinic_func_own_free(void *hwdev) hinic_func_own_bit_set(dev, 0); up(&dev->func_sem); - return; } /** @@ -969,7 +968,7 @@ EXPORT_SYMBOL(hinic_ppf_idx); #define CEQ_CTRL_0_CHIP_MODE_MASK 0xFU #define CEQ_CTRL_0_GET(val, member) \ (((val) >> CEQ_CTRL_0_##member##_SHIFT) & \ - CEQ_CTRL_0_##member##_MASK) + CEQ_CTRL_0_##member##_MASK) /** * hinic_get_db_size - get db size ceq ctrl: bit26~29: uP write vf mode is diff --git a/drivers/net/ethernet/huawei/hinic/hinic_lld.c b/drivers/net/ethernet/huawei/hinic/hinic_lld.c index a19a1f67bc97..977e333131fb 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_lld.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_lld.c @@ -45,10 +45,10 @@ #define SELF_TEST_BAR_ADDR_OFFSET 0x883c -#define HINIC_SECOND_BASE (1000) -#define HINIC_SYNC_YEAR_OFFSET (1900) -#define HINIC_SYNC_MONTH_OFFSET (1) -#define HINIC_MINUTE_BASE (60) +#define HINIC_SECOND_BASE 1000 +#define HINIC_SYNC_YEAR_OFFSET 1900 +#define HINIC_SYNC_MONTH_OFFSET 1 +#define HINIC_MINUTE_BASE 60 #define HINIC_WAIT_TOOL_CNT_TIMEOUT 10000 #define HINIC_WAIT_SRIOV_CFG_TIMEOUT 15000 @@ -120,6 +120,7 @@ struct hinic_pcidev { struct timer_list syncfw_time_timer; }; + #define HINIC_EVENT_PROCESS_TIMEOUT 10000 #define FIND_BIT(num, n) (((num) & (1UL << (n))) ? 1 : 0) @@ -261,6 +262,7 @@ static int attach_uld(struct hinic_pcidev *dev, enum hinic_service_type type, { void *uld_dev = NULL; int err; + mutex_lock(&dev->pdev_mutex); if (dev->init_state < HINIC_INIT_STATE_HWDEV_INITED) { @@ -1334,8 +1336,6 @@ void hinic_get_card_func_info_by_card_name(const char *chip_name, } lld_dev_put(); - - return; } int hinic_get_device_id(void *hwdev, u16 *dev_id) @@ -2187,6 +2187,7 @@ static void hinic_set_vf_load_state(struct hinic_pcidev *pci_adapter, int hinic_ovs_set_vf_load_state(struct pci_dev *pdev) { struct hinic_pcidev *pci_adapter; + if (!pdev) { pr_err("pdev is null\n"); return -EINVAL; @@ -2659,12 +2660,10 @@ static void slave_host_init_delay_work(struct work_struct *work) clear_bit(HINIC_FUNC_PRB_DELAY, &pci_adapter->flag); if (err) set_bit(HINIC_FUNC_PRB_ERR, &pci_adapter->flag); - return; } else { queue_delayed_work(pci_adapter->slave_nic_init_workq, &pci_adapter->slave_nic_init_dwork, HINIC_SLAVE_NIC_DELAY_TIME); - return; } } @@ -2861,10 +2860,11 @@ static void __exit hinic_lld_exit(void) pci_unregister_driver(&hinic_driver); hinic_unregister_uld(SERVICE_T_NIC); - } + module_init(hinic_lld_init); module_exit(hinic_lld_exit); + int hinic_register_micro_log(struct hinic_micro_log_info *micro_log_info) { struct card_node *chip_node; diff --git a/drivers/net/ethernet/huawei/hinic/hinic_lld.h b/drivers/net/ethernet/huawei/hinic/hinic_lld.h index f257ca544ec7..7def733f8bc4 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_lld.h +++ b/drivers/net/ethernet/huawei/hinic/hinic_lld.h @@ -16,8 +16,8 @@ #ifndef HINIC_LLD_H_ #define HINIC_LLD_H_ -#define HINIC_SLAVE_NIC_DELAY "hinic_slave_nic_delay" -#define HINIC_SLAVE_NIC_DELAY_TIME (5 * HZ) +#define HINIC_SLAVE_NIC_DELAY "hinic_slave_nic_delay" +#define HINIC_SLAVE_NIC_DELAY_TIME (5 * HZ) struct hinic_lld_dev { struct pci_dev *pdev; diff --git a/drivers/net/ethernet/huawei/hinic/hinic_main.c b/drivers/net/ethernet/huawei/hinic/hinic_main.c index 53335834445b..b5d0bdadf509 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_main.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_main.c @@ -107,12 +107,10 @@ static unsigned char set_link_status_follow = HINIC_LINK_FOLLOW_STATUS_MAX; module_param(set_link_status_follow, byte, 0444); MODULE_PARM_DESC(set_link_status_follow, "Set link status follow port status. 0 - default, 1 - follow, 2 - separate, other - unset. (default unset)"); - static unsigned int lro_replenish_thld = 256; module_param(lro_replenish_thld, uint, 0444); MODULE_PARM_DESC(lro_replenish_thld, "Number wqe for lro replenish buffer (default=256)"); - static bool l2nic_interrupt_switch = true; module_param(l2nic_interrupt_switch, bool, 0644); MODULE_PARM_DESC(l2nic_interrupt_switch, "Control whether execute l2nic io interrupt switch or not, default is true"); @@ -632,9 +630,9 @@ static void __calc_coal_para(struct hinic_nic_dev *nic_dev, if (nic_dev->in_vm) *pending_limt = (u8)((rate - q_coal->pkt_rate_low) * (q_coal->rx_pending_limt_high - - q_coal->rx_pending_limt_low) / + q_coal->rx_pending_limt_low) / (q_coal->pkt_rate_high - - q_coal->pkt_rate_low) + + q_coal->pkt_rate_low) + q_coal->rx_pending_limt_low); else *pending_limt = q_coal->rx_pending_limt_low; @@ -1158,8 +1156,8 @@ static u16 select_queue_by_toeplitz(struct net_device *dev, } static u16 hinic_select_queue(struct net_device *netdev, struct sk_buff *skb, - struct net_device *sb_dev, - select_queue_fallback_t fallback) + struct net_device *sb_dev, + select_queue_fallback_t fallback) { struct hinic_nic_dev *nic_dev = netdev_priv(netdev); @@ -1178,7 +1176,7 @@ static u16 hinic_select_queue(struct net_device *netdev, struct sk_buff *skb, } static void hinic_get_stats64(struct net_device *netdev, - struct rtnl_link_stats64 *stats) + struct rtnl_link_stats64 *stats) { struct hinic_nic_dev *nic_dev = netdev_priv(netdev); struct hinic_txq_stats *txq_stats; @@ -2131,14 +2129,14 @@ static void netdev_feature_init(struct net_device *netdev) } #define MOD_PARA_VALIDATE_NUM_QPS(nic_dev, num_qps, out_qps) { \ - if ((num_qps) > nic_dev->max_qps) \ - nic_warn(&nic_dev->pdev->dev, \ + if ((num_qps) > (nic_dev)->max_qps) \ + nic_warn(&(nic_dev)->pdev->dev, \ "Module Parameter %s value %d is out of range, "\ "Maximum value for the device: %d, using %d\n",\ - #num_qps, num_qps, nic_dev->max_qps, \ - nic_dev->max_qps); \ - if (!(num_qps) || (num_qps) > nic_dev->max_qps) \ - out_qps = nic_dev->max_qps; \ + #num_qps, num_qps, (nic_dev)->max_qps, \ + (nic_dev)->max_qps); \ + if (!(num_qps) || (num_qps) > (nic_dev)->max_qps) \ + out_qps = (nic_dev)->max_qps; \ else \ out_qps = num_qps; \ } @@ -2151,7 +2149,6 @@ static void hinic_try_to_enable_rss(struct hinic_nic_dev *nic_dev) enum hinic_service_mode service_mode = hinic_get_service_mode(nic_dev->hwdev); - nic_dev->max_qps = hinic_func_max_nic_qnum(nic_dev->hwdev); if (nic_dev->max_qps <= 1) { clear_bit(HINIC_RSS_ENABLE, &nic_dev->flags); @@ -2733,7 +2730,6 @@ static int nic_probe(struct hinic_lld_dev *lld_dev, void **uld_dev, return -ENOMEM; } - SET_NETDEV_DEV(netdev, &pdev->dev); nic_dev = (struct hinic_nic_dev *)netdev_priv(netdev); nic_dev->hwdev = lld_dev->hwdev; @@ -2749,7 +2745,6 @@ static int nic_probe(struct hinic_lld_dev *lld_dev, void **uld_dev, page_num = (RX_BUFF_NUM_PER_PAGE * nic_dev->rx_buff_len) / PAGE_SIZE; nic_dev->page_order = page_num > 0 ? ilog2(page_num) : 0; - mutex_init(&nic_dev->nic_mutex); adaptive_configuration_init(nic_dev); diff --git a/drivers/net/ethernet/huawei/hinic/hinic_mbox.c b/drivers/net/ethernet/huawei/hinic/hinic_mbox.c index 29feb9b4a16c..24f119bb5938 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_mbox.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_mbox.c @@ -52,7 +52,7 @@ #define HINIC_MBOX_INT_SET(val, field) \ (((val) & HINIC_MBOX_INT_##field##_MASK) << \ - HINIC_MBOX_INT_##field##_SHIFT) + HINIC_MBOX_INT_##field##_SHIFT) enum hinic_mbox_tx_status { TX_NOT_DONE = 1, @@ -70,7 +70,7 @@ enum hinic_mbox_tx_status { #define HINIC_MBOX_CTRL_SET(val, field) \ (((val) & HINIC_MBOX_CTRL_##field##_MASK) << \ - HINIC_MBOX_CTRL_##field##_SHIFT) + HINIC_MBOX_CTRL_##field##_SHIFT) #define HINIC_MBOX_HEADER_MSG_LEN_SHIFT 0 #define HINIC_MBOX_HEADER_MODULE_SHIFT 11 @@ -102,10 +102,10 @@ enum hinic_mbox_tx_status { #define HINIC_MBOX_HEADER_GET(val, field) \ (((val) >> HINIC_MBOX_HEADER_##field##_SHIFT) & \ - HINIC_MBOX_HEADER_##field##_MASK) + HINIC_MBOX_HEADER_##field##_MASK) #define HINIC_MBOX_HEADER_SET(val, field) \ ((u64)((val) & HINIC_MBOX_HEADER_##field##_MASK) << \ - HINIC_MBOX_HEADER_##field##_SHIFT) + HINIC_MBOX_HEADER_##field##_SHIFT) #define MBOX_SEGLEN_MASK \ HINIC_MBOX_HEADER_SET(HINIC_MBOX_HEADER_SEG_LEN_MASK, SEG_LEN) @@ -395,7 +395,7 @@ void hinic_unregister_vf_mbox_cb(struct hinic_hwdev *hwdev, clear_bit(HINIC_VF_MBOX_CB_REG, &func_to_func->vf_mbox_cb_state[mod]); while (test_bit(HINIC_VF_MBOX_CB_RUNNING, - &func_to_func->vf_mbox_cb_state[mod])) + &func_to_func->vf_mbox_cb_state[mod])) usleep_range(900, 1000); func_to_func->vf_mbox_cb[mod] = NULL; @@ -671,8 +671,8 @@ static bool check_mbox_seq_id_and_seg_len(struct hinic_recv_mbox *recv_mbox, } else { if (seq_id != recv_mbox->seq_id + 1) return false; - else - recv_mbox->seq_id = seq_id; + + recv_mbox->seq_id = seq_id; } return true; @@ -1448,9 +1448,9 @@ int __hinic_mbox_to_vf(void *hwdev, in_size, buf_out, out_size, timeout); } -int hinic_mbox_ppf_to_vf(void *hwdev, - enum hinic_mod_type mod, u16 func_id, u8 cmd, void *buf_in, - u16 in_size, void *buf_out, u16 *out_size, u32 timeout) +int hinic_mbox_ppf_to_vf(void *hwdev, enum hinic_mod_type mod, u16 func_id, + u8 cmd, void *buf_in, u16 in_size, void *buf_out, + u16 *out_size, u32 timeout) { struct hinic_mbox_func_to_func *func_to_func; int err; @@ -1620,7 +1620,8 @@ int hinic_vf_mbox_random_id_init(struct hinic_hwdev *hwdev) for (vf_in_pf = 1; vf_in_pf <= hinic_func_max_vf(hwdev); vf_in_pf++) { err = set_vf_mbox_random_id(hwdev, - (hinic_glb_pf_vf_offset(hwdev) + vf_in_pf)); + hinic_glb_pf_vf_offset(hwdev) + + vf_in_pf); if (err) break; } diff --git a/drivers/net/ethernet/huawei/hinic/hinic_mbox.h b/drivers/net/ethernet/huawei/hinic/hinic_mbox.h index b76b960af651..a03a5b8113f2 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_mbox.h +++ b/drivers/net/ethernet/huawei/hinic/hinic_mbox.h @@ -221,12 +221,12 @@ int hinic_mbox_to_pf_no_ack(struct hinic_hwdev *hwdev, enum hinic_mod_type mod, int hinic_mbox_ppf_to_pf(struct hinic_hwdev *hwdev, enum hinic_mod_type mod, u16 dst_pf_id, u8 cmd, - void *buf_in, u16 in_size, void *buf_out, - u16 *out_size, u32 timeout); + void *buf_in, u16 in_size, void *buf_out, + u16 *out_size, u32 timeout); int hinic_mbox_to_func(struct hinic_mbox_func_to_func *func_to_func, - enum hinic_mod_type mod, u16 cmd, u16 dst_func, - void *buf_in, u16 in_size, void *buf_out, - u16 *out_size, u32 timeout); + enum hinic_mod_type mod, u16 cmd, u16 dst_func, + void *buf_in, u16 in_size, void *buf_out, + u16 *out_size, u32 timeout); int __hinic_mbox_to_vf(void *hwdev, enum hinic_mod_type mod, u16 vf_id, u8 cmd, void *buf_in, diff --git a/drivers/net/ethernet/huawei/hinic/hinic_mgmt.c b/drivers/net/ethernet/huawei/hinic/hinic_mgmt.c index 3a8362cc7d01..2a74fa00b308 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_mgmt.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_mgmt.c @@ -62,11 +62,11 @@ #define MAX_MSG_SZ 2016 -#define MAX_CMD_BUF_SIZE 2048ULL +#define MAX_CMD_BUF_SIZE 2048ULL #define MSG_SZ_IS_VALID(in_size) ((in_size) <= MAX_MSG_SZ) -#define SYNC_MSG_ID(pf_to_mgmt) ((pf_to_mgmt)->sync_msg_id) +#define SYNC_MSG_ID(pf_to_mgmt) ((pf_to_mgmt)->sync_msg_id) #define SYNC_MSG_ID_INC(pf_to_mgmt) (SYNC_MSG_ID(pf_to_mgmt) = \ (SYNC_MSG_ID(pf_to_mgmt) + 1) & SYNC_MSG_ID_MASK) @@ -251,10 +251,11 @@ static void prepare_header(struct hinic_msg_pf_to_mgmt *pf_to_mgmt, } static void clp_prepare_header(struct hinic_hwdev *hwdev, - u64 *header, u16 msg_len, enum hinic_mod_type mod, - enum hinic_msg_ack_type ack_type, - enum hinic_msg_direction_type direction, - enum hinic_mgmt_cmd cmd, u32 msg_id) + u64 *header, u16 msg_len, + enum hinic_mod_type mod, + enum hinic_msg_ack_type ack_type, + enum hinic_msg_direction_type direction, + enum hinic_mgmt_cmd cmd, u32 msg_id) { struct hinic_hwif *hwif = hwdev->hwif; @@ -304,9 +305,9 @@ static void prepare_mgmt_cmd(u8 *mgmt_cmd, u64 *header, const void *msg, */ static int send_msg_to_mgmt_async(struct hinic_msg_pf_to_mgmt *pf_to_mgmt, enum hinic_mod_type mod, u8 cmd, - void *msg, u16 msg_len, - enum hinic_msg_direction_type direction, - u16 resp_msg_id) + void *msg, u16 msg_len, + enum hinic_msg_direction_type direction, + u16 resp_msg_id) { void *mgmt_cmd = pf_to_mgmt->async_msg_buf; struct hinic_api_cmd_chain *chain; @@ -331,7 +332,7 @@ static int send_msg_to_mgmt_async(struct hinic_msg_pf_to_mgmt *pf_to_mgmt, chain = pf_to_mgmt->cmd_chain[HINIC_API_CMD_WRITE_ASYNC_TO_MGMT_CPU]; return hinic_api_cmd_write(chain, HINIC_NODE_ID_MGMT_HOST, mgmt_cmd, - cmd_size); + cmd_size); } int hinic_pf_to_mgmt_async(void *hwdev, enum hinic_mod_type mod, @@ -373,10 +374,10 @@ int hinic_pf_to_mgmt_async(void *hwdev, enum hinic_mod_type mod, */ static int send_msg_to_mgmt_sync(struct hinic_msg_pf_to_mgmt *pf_to_mgmt, enum hinic_mod_type mod, u8 cmd, - void *msg, u16 msg_len, - enum hinic_msg_ack_type ack_type, - enum hinic_msg_direction_type direction, - u16 resp_msg_id) + void *msg, u16 msg_len, + enum hinic_msg_ack_type ack_type, + enum hinic_msg_direction_type direction, + u16 resp_msg_id) { void *mgmt_cmd = pf_to_mgmt->sync_msg_buf; struct hinic_api_cmd_chain *chain; @@ -486,7 +487,7 @@ int hinic_pf_to_mgmt_sync(void *hwdev, enum hinic_mod_type mod, u8 cmd, } static int __get_clp_reg(void *hwdev, enum clp_data_type data_type, - enum clp_reg_type reg_type, u32 *reg_addr) + enum clp_reg_type reg_type, u32 *reg_addr) { struct hinic_hwdev *dev = hwdev; u32 offset; @@ -530,8 +531,8 @@ static int __get_clp_reg(void *hwdev, enum clp_data_type data_type, } static int hinic_read_clp_reg(struct hinic_hwdev *hwdev, - enum clp_data_type data_type, - enum clp_reg_type reg_type, u32 *read_value) + enum clp_data_type data_type, + enum clp_reg_type reg_type, u32 *read_value) { int err; u32 reg_addr, reg_value; @@ -660,7 +661,7 @@ static void hinic_write_clp_reg(struct hinic_hwdev *hwdev, } static int hinic_read_clp_data(struct hinic_hwdev *hwdev, - void *buf_out, u16 *out_size) + void *buf_out, u16 *out_size) { int err; u32 reg = HINIC_CLP_DATA(RSP); @@ -788,7 +789,7 @@ static int hinic_check_clp_init_status(struct hinic_hwdev *hwdev) } static void hinic_clear_clp_data(struct hinic_hwdev *hwdev, - enum clp_data_type data_type) + enum clp_data_type data_type) { u32 reg = (data_type == HINIC_CLP_REQ_HOST) ? HINIC_CLP_DATA(REQ) : HINIC_CLP_DATA(RSP); @@ -801,8 +802,8 @@ static void hinic_clear_clp_data(struct hinic_hwdev *hwdev, } int hinic_pf_clp_to_mgmt(void *hwdev, enum hinic_mod_type mod, u8 cmd, - const void *buf_in, u16 in_size, - void *buf_out, u16 *out_size) + const void *buf_in, u16 in_size, + void *buf_out, u16 *out_size) { struct hinic_clp_pf_to_mgmt *clp_pf_to_mgmt; struct hinic_hwdev *dev = hwdev; diff --git a/drivers/net/ethernet/huawei/hinic/hinic_mgmt.h b/drivers/net/ethernet/huawei/hinic/hinic_mgmt.h index 12aae39c70d7..23ac9d2362a1 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_mgmt.h +++ b/drivers/net/ethernet/huawei/hinic/hinic_mgmt.h @@ -44,18 +44,19 @@ #define HINIC_MSG_HEADER_GET(val, member) \ (((val) >> HINIC_MSG_HEADER_##member##_SHIFT) & \ - HINIC_MSG_HEADER_##member##_MASK) + HINIC_MSG_HEADER_##member##_MASK) #define HINIC_MSG_HEADER_SET(val, member) \ ((u64)((val) & HINIC_MSG_HEADER_##member##_MASK) << \ - HINIC_MSG_HEADER_##member##_SHIFT) + HINIC_MSG_HEADER_##member##_SHIFT) -#define HINIC_MGMT_WQ_NAME "hinic_mgmt" +#define HINIC_MGMT_WQ_NAME "hinic_mgmt" enum clp_data_type { HINIC_CLP_REQ_HOST = 0, HINIC_CLP_RSP_HOST = 1 }; + enum clp_reg_type { HINIC_CLP_BA_HOST = 0, HINIC_CLP_SIZE_HOST = 1, @@ -63,12 +64,13 @@ enum clp_reg_type { HINIC_CLP_START_REQ_HOST = 3, HINIC_CLP_READY_RSP_HOST = 4 }; -#define HINIC_CLP_REG_GAP (0x20) -#define HINIC_CLP_INPUT_BUFFER_LEN_HOST (4096UL) -#define HINIC_CLP_DATA_UNIT_HOST (4UL) -#define HINIC_BAR01_GLOABAL_CTL_OFFSET (0x4000) -#define HINIC_BAR01_CLP_OFFSET (0x5000) +#define HINIC_CLP_REG_GAP 0x20 +#define HINIC_CLP_INPUT_BUFFER_LEN_HOST 4096UL +#define HINIC_CLP_DATA_UNIT_HOST 4UL + +#define HINIC_BAR01_GLOABAL_CTL_OFFSET 0x4000 +#define HINIC_BAR01_CLP_OFFSET 0x5000 #define HINIC_CLP_SRAM_SIZE_REG (HINIC_BAR01_GLOABAL_CTL_OFFSET + 0x220) #define HINIC_CLP_REQ_SRAM_BA_REG (HINIC_BAR01_GLOABAL_CTL_OFFSET + 0x224) @@ -77,29 +79,29 @@ enum clp_reg_type { #define HINIC_CLP_RSP_REG (HINIC_BAR01_GLOABAL_CTL_OFFSET + 0x230) #define HINIC_CLP_REG(member) (HINIC_CLP_##member##_REG) -#define HINIC_CLP_REQ_DATA (HINIC_BAR01_CLP_OFFSET) +#define HINIC_CLP_REQ_DATA (HINIC_BAR01_CLP_OFFSET) #define HINIC_CLP_RSP_DATA (HINIC_BAR01_CLP_OFFSET + 0x1000) -#define HINIC_CLP_DATA(member) (HINIC_CLP_##member##_DATA) +#define HINIC_CLP_DATA(member) (HINIC_CLP_##member##_DATA) -#define HINIC_CLP_SRAM_SIZE_OFFSET (16) -#define HINIC_CLP_SRAM_BASE_OFFSET (0) -#define HINIC_CLP_LEN_OFFSET (0) -#define HINIC_CLP_START_OFFSET (31) -#define HINIC_CLP_READY_OFFSET (31) +#define HINIC_CLP_SRAM_SIZE_OFFSET 16 +#define HINIC_CLP_SRAM_BASE_OFFSET 0 +#define HINIC_CLP_LEN_OFFSET 0 +#define HINIC_CLP_START_OFFSET 31 +#define HINIC_CLP_READY_OFFSET 31 #define HINIC_CLP_OFFSET(member) (HINIC_CLP_##member##_OFFSET) -#define HINIC_CLP_SRAM_SIZE_BIT_LEN (0x7ffUL) -#define HINIC_CLP_SRAM_BASE_BIT_LEN (0x7ffffffUL) -#define HINIC_CLP_LEN_BIT_LEN (0x7ffUL) -#define HINIC_CLP_START_BIT_LEN (0x1UL) -#define HINIC_CLP_READY_BIT_LEN (0x1UL) +#define HINIC_CLP_SRAM_SIZE_BIT_LEN 0x7ffUL +#define HINIC_CLP_SRAM_BASE_BIT_LEN 0x7ffffffUL +#define HINIC_CLP_LEN_BIT_LEN 0x7ffUL +#define HINIC_CLP_START_BIT_LEN 0x1UL +#define HINIC_CLP_READY_BIT_LEN 0x1UL #define HINIC_CLP_MASK(member) (HINIC_CLP_##member##_BIT_LEN) -#define HINIC_CLP_DELAY_CNT_MAX (200UL) -#define HINIC_CLP_SRAM_SIZE_REG_MAX (0x3ff) -#define HINIC_CLP_SRAM_BASE_REG_MAX (0x7ffffff) -#define HINIC_CLP_LEN_REG_MAX (0x3ff) -#define HINIC_CLP_START_OR_READY_REG_MAX (0x1) +#define HINIC_CLP_DELAY_CNT_MAX 200UL +#define HINIC_CLP_SRAM_SIZE_REG_MAX 0x3ff +#define HINIC_CLP_SRAM_BASE_REG_MAX 0x7ffffff +#define HINIC_CLP_LEN_REG_MAX 0x3ff +#define HINIC_CLP_START_OR_READY_REG_MAX 0x1 enum hinic_msg_direction_type { HINIC_MSG_DIRECT_SEND = 0, @@ -228,14 +230,14 @@ void hinic_pf_to_mgmt_free(struct hinic_hwdev *hwdev); int hinic_pf_to_mgmt_sync(void *hwdev, enum hinic_mod_type mod, u8 cmd, void *buf_in, u16 in_size, void *buf_out, - u16 *out_size, u32 timeout); + u16 *out_size, u32 timeout); int hinic_pf_to_mgmt_async(void *hwdev, enum hinic_mod_type mod, u8 cmd, void *buf_in, u16 in_size); int hinic_pf_clp_to_mgmt(void *hwdev, enum hinic_mod_type mod, u8 cmd, - const void *buf_in, u16 in_size, - void *buf_out, u16 *out_size); + const void *buf_in, u16 in_size, + void *buf_out, u16 *out_size); int hinic_clp_pf_to_mgmt_init(struct hinic_hwdev *hwdev); void hinic_clp_pf_to_mgmt_free(struct hinic_hwdev *hwdev); diff --git a/drivers/net/ethernet/huawei/hinic/hinic_mgmt_interface.h b/drivers/net/ethernet/huawei/hinic/hinic_mgmt_interface.h index 700642469732..48ef0a4b0e7d 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_mgmt_interface.h +++ b/drivers/net/ethernet/huawei/hinic/hinic_mgmt_interface.h @@ -939,10 +939,12 @@ struct hinic_link_ksettings_info { u8 fec; /* 0 - RSFEC; 1 - BASEFEC; 2 - NOFEC */ u8 rsvd2[18]; /* reserved for duplex, port, etc. */ }; + enum hinic_tx_promsic { HINIC_TX_PROMISC_ENABLE = 0, HINIC_TX_PROMISC_DISABLE = 1, }; + struct hinic_promsic_info { u8 status; u8 version; diff --git a/drivers/net/ethernet/huawei/hinic/hinic_msix_attr.c b/drivers/net/ethernet/huawei/hinic/hinic_msix_attr.c index 0c3539fd127d..350d10e4997f 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_msix_attr.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_msix_attr.c @@ -74,8 +74,8 @@ int hinic_msix_attr_set(struct hinic_hwif *hwif, u16 msix_index, */ int hinic_msix_attr_get(struct hinic_hwif *hwif, u16 msix_index, u8 *pending_limit, u8 *coalesc_timer_cfg, - u8 *lli_timer_cfg, u8 *lli_credit_limit, - u8 *resend_timer_cfg) + u8 *lli_timer_cfg, u8 *lli_credit_limit, + u8 *resend_timer_cfg) { u32 addr, val; @@ -108,8 +108,8 @@ int hinic_msix_attr_get(struct hinic_hwif *hwif, u16 msix_index, */ int hinic_msix_attr_cnt_set(struct hinic_hwif *hwif, u16 msix_index, u8 lli_timer_cnt, u8 lli_credit_cnt, - u8 coalesc_timer_cnt, u8 pending_cnt, - u8 resend_timer_cnt) + u8 coalesc_timer_cnt, u8 pending_cnt, + u8 resend_timer_cnt) { u32 msix_ctrl, addr; diff --git a/drivers/net/ethernet/huawei/hinic/hinic_msix_attr.h b/drivers/net/ethernet/huawei/hinic/hinic_msix_attr.h index 288b39691ce6..0397dfb41fca 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_msix_attr.h +++ b/drivers/net/ethernet/huawei/hinic/hinic_msix_attr.h @@ -29,12 +29,12 @@ #define HINIC_MSIX_RESEND_TIMER_MASK 0x7U #define HINIC_MSIX_ATTR_GET(val, member) \ - (((val) >> HINIC_MSIX_##member##_SHIFT) \ - & HINIC_MSIX_##member##_MASK) + (((val) >> HINIC_MSIX_##member##_SHIFT) \ + & HINIC_MSIX_##member##_MASK) #define HINIC_MSIX_ATTR_SET(val, member) \ - (((val) & HINIC_MSIX_##member##_MASK) \ - << HINIC_MSIX_##member##_SHIFT) + (((val) & HINIC_MSIX_##member##_MASK) \ + << HINIC_MSIX_##member##_SHIFT) #define HINIC_MSIX_CNT_LLI_TIMER_SHIFT 0 #define HINIC_MSIX_CNT_LLI_CREDIT_SHIFT 8 @@ -50,20 +50,20 @@ #define HINIC_MSIX_CNT_SET(val, member) \ (((val) & HINIC_MSIX_CNT_##member##_MASK) << \ - HINIC_MSIX_CNT_##member##_SHIFT) + HINIC_MSIX_CNT_##member##_SHIFT) int hinic_msix_attr_set(struct hinic_hwif *hwif, u16 msix_index, u8 pending_limit, u8 coalesc_timer, - u8 lli_timer_cfg, u8 lli_credit_limit, - u8 resend_timer); + u8 lli_timer_cfg, u8 lli_credit_limit, + u8 resend_timer); int hinic_msix_attr_get(struct hinic_hwif *hwif, u16 msix_index, u8 *pending_limit, u8 *coalesc_timer_cfg, - u8 *lli_timer_cfg, u8 *lli_credit_limit, - u8 *resend_timer_cfg); + u8 *lli_timer_cfg, u8 *lli_credit_limit, + u8 *resend_timer_cfg); int hinic_msix_attr_cnt_set(struct hinic_hwif *hwif, u16 msix_index, u8 pending_limit, u8 coalesc_timer, - u8 lli_timer_cfg, u8 lli_credit_limit, - u8 resend_timer); + u8 lli_timer_cfg, u8 lli_credit_limit, + u8 resend_timer); #endif diff --git a/drivers/net/ethernet/huawei/hinic/hinic_multi_host_mgmt.c b/drivers/net/ethernet/huawei/hinic/hinic_multi_host_mgmt.c index 247a0b7338d0..408b813dd374 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_multi_host_mgmt.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_multi_host_mgmt.c @@ -450,7 +450,8 @@ static int multi_host_event_handler(struct hinic_hwdev *hwdev, } static int sw_fwd_msg_to_vf(struct hinic_hwdev *hwdev, - void *buf_in, u16 in_size, void *buf_out, u16 *out_size) + void *buf_in, u16 in_size, void *buf_out, + u16 *out_size) { struct hinic_host_fwd_head *fwd_head; u16 fwd_head_len; @@ -461,9 +462,9 @@ static int sw_fwd_msg_to_vf(struct hinic_hwdev *hwdev, fwd_head_len = sizeof(struct hinic_host_fwd_head); msg = (void *)((u8 *)buf_in + fwd_head_len); err = hinic_mbox_ppf_to_vf(hwdev, fwd_head->mod, - fwd_head->dst_glb_func_idx, fwd_head->cmd, - msg, (in_size - fwd_head_len), - buf_out, out_size, 0); + fwd_head->dst_glb_func_idx, fwd_head->cmd, + msg, in_size - fwd_head_len, + buf_out, out_size, 0); if (err) nic_err(hwdev->dev_hdl, "Fwd msg to func %u failed, err: %d\n", @@ -471,6 +472,7 @@ static int sw_fwd_msg_to_vf(struct hinic_hwdev *hwdev, return err; } + static int __slave_host_sw_func_handler(struct hinic_hwdev *hwdev, u16 pf_idx, u8 cmd, void *buf_in, u16 in_size, void *buf_out, u16 *out_size) @@ -505,7 +507,7 @@ static int __slave_host_sw_func_handler(struct hinic_hwdev *hwdev, u16 pf_idx, case HINIC_SW_CMD_SEND_MSG_TO_VF: err = sw_fwd_msg_to_vf(hwdev, buf_in, in_size, - buf_out, out_size); + buf_out, out_size); break; case HINIC_SW_CMD_MIGRATE_READY: @@ -550,7 +552,8 @@ int __ppf_process_mbox_msg(struct hinic_hwdev *hwdev, u16 pf_idx, u16 vf_id, if (IS_SLAVE_HOST(hwdev)) { err = hinic_mbox_to_host_sync(hwdev, mod, cmd, - buf_in, in_size, buf_out, out_size, 0); + buf_in, in_size, buf_out, + out_size, 0); if (err) sdk_err(hwdev->dev_hdl, "send to mpf failed, err: %d\n", err); diff --git a/drivers/net/ethernet/huawei/hinic/hinic_nic_cfg.c b/drivers/net/ethernet/huawei/hinic/hinic_nic_cfg.c index ad0dd6e9312b..a42dea0ad707 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_nic_cfg.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_nic_cfg.c @@ -49,7 +49,7 @@ MODULE_PARM_DESC(set_vf_link_state, "Set vf link state, 0 represents link auto, hinic_msg_to_mgmt_async(hwdev, HINIC_MOD_L2NIC, cmd, buf_in, in_size) #define CPATH_FUNC_ID_VALID_LIMIT 2 -#define CHECK_IPSU_15BIT 0X8000 +#define CHECK_IPSU_15BIT 0X8000 static int hinic_set_rx_lro_timer(void *hwdev, u32 timer_value); @@ -256,9 +256,9 @@ int hinic_set_mac(void *hwdev, const u8 *mac_addr, u16 vlan_id, u16 func_id) sizeof(mac_info), &mac_info, &out_size); if (err || !out_size || (mac_info.status && mac_info.status != HINIC_MGMT_STATUS_EXIST && - mac_info.status != HINIC_PF_SET_VF_ALREADY) || + mac_info.status != HINIC_PF_SET_VF_ALREADY) || (mac_info.vlan_id & CHECK_IPSU_15BIT && - mac_info.status == HINIC_MGMT_STATUS_EXIST)) { + mac_info.status == HINIC_MGMT_STATUS_EXIST)) { nic_err(nic_hwdev->dev_hdl, "Failed to update MAC, err: %d, status: 0x%x, out size: 0x%x\n", err, mac_info.status, out_size); @@ -344,9 +344,9 @@ int hinic_update_mac(void *hwdev, u8 *old_mac, u8 *new_mac, u16 vlan_id, &mac_info, &out_size); if (err || !out_size || (mac_info.status && mac_info.status != HINIC_MGMT_STATUS_EXIST && - mac_info.status != HINIC_PF_SET_VF_ALREADY) || + mac_info.status != HINIC_PF_SET_VF_ALREADY) || (mac_info.vlan_id & CHECK_IPSU_15BIT && - mac_info.status == HINIC_MGMT_STATUS_EXIST)) { + mac_info.status == HINIC_MGMT_STATUS_EXIST)) { nic_err(nic_hwdev->dev_hdl, "Failed to update MAC, err: %d, status: 0x%x, out size: 0x%x\n", err, mac_info.status, out_size); @@ -711,7 +711,7 @@ int hinic_del_vlan(void *hwdev, u16 vlan_id, u16 func_id) err = l2nic_msg_to_mgmt_sync(hwdev, HINIC_PORT_CMD_DEL_VLAN, &vlan_info, sizeof(vlan_info), - &vlan_info, &out_size); + &vlan_info, &out_size); if (err || !out_size || vlan_info.status) { nic_err(nic_hwdev->dev_hdl, "Failed to delte vlan, err: %d, status: 0x%x, out size: 0x%x\n", @@ -2584,7 +2584,7 @@ static void hinic_get_vf_cos_msg_handler(struct hinic_nic_io *nic_io, int nic_pf_mbox_handler(void *hwdev, u16 vf_id, u8 cmd, void *buf_in, u16 in_size, void *buf_out, u16 *out_size) { - u8 size = sizeof(nic_cmd_support_vf) / sizeof(nic_cmd_support_vf[0]); + u8 size = ARRAY_SIZE(nic_cmd_support_vf); struct hinic_nic_io *nic_io; int err = 0; u32 timeout = 0; @@ -3819,6 +3819,7 @@ int hinic_set_link_settings(void *hwdev, struct hinic_link_ksettings *settings) return info.status; } + int hinic_disable_tx_promisc(void *hwdev) { struct hinic_promsic_info info = {0}; diff --git a/drivers/net/ethernet/huawei/hinic/hinic_nic_cfg.h b/drivers/net/ethernet/huawei/hinic/hinic_nic_cfg.h index 2f4f893d3f52..f0810b201d51 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_nic_cfg.h +++ b/drivers/net/ethernet/huawei/hinic/hinic_nic_cfg.h @@ -41,20 +41,20 @@ #define HINIC_MIN_MTU_SIZE 256 #define HINIC_MAX_JUMBO_FRAME_SIZE 9600 -#define HINIC_LRO_MAX_WQE_NUM_UPPER 32 -#define HINIC_LRO_MAX_WQE_NUM_LOWER 1 -#define HINIC_LRO_MAX_WQE_NUM_DEFAULT_ARM 4 -#define HINIC_LRO_MAX_WQE_NUM_DEFAULT_X86 8 -#define HINIC_LRO_MAX_WQE_NUM_DEFAULT 8 +#define HINIC_LRO_MAX_WQE_NUM_UPPER 32 +#define HINIC_LRO_MAX_WQE_NUM_LOWER 1 +#define HINIC_LRO_MAX_WQE_NUM_DEFAULT_ARM 4 +#define HINIC_LRO_MAX_WQE_NUM_DEFAULT_X86 8 +#define HINIC_LRO_MAX_WQE_NUM_DEFAULT 8 #define HINIC_LRO_WQE_NUM_PANGEA_DEFAULT 32 -#define HINIC_LRO_RX_TIMER_UPPER 1024 -#define HINIC_LRO_RX_TIMER_LOWER 1 -#define HINIC_LRO_RX_TIMER_DEFAULT 16 -#define HINIC_LRO_RX_TIMER_DEFAULT_25GE 16 -#define HINIC_LRO_RX_TIMER_DEFAULT_100GE 64 +#define HINIC_LRO_RX_TIMER_UPPER 1024 +#define HINIC_LRO_RX_TIMER_LOWER 1 +#define HINIC_LRO_RX_TIMER_DEFAULT 16 +#define HINIC_LRO_RX_TIMER_DEFAULT_25GE 16 +#define HINIC_LRO_RX_TIMER_DEFAULT_100GE 64 #define HINIC_LRO_RX_TIMER_DEFAULT_PG_10GE 10 -#define HINIC_LRO_RX_TIMER_DEFAULT_PG_100GE 8 +#define HINIC_LRO_RX_TIMER_DEFAULT_PG_100GE 8 #if defined(__aarch64__) #define HINIC_LOWEST_LATENCY 1 @@ -83,7 +83,7 @@ #endif enum hinic_board_type { - HINIC_BOARD_UNKNOWN = 0, + HINIC_BOARD_UNKNOWN = 0, HINIC_BOARD_10GE = 1, HINIC_BOARD_25GE = 2, HINIC_BOARD_40GE = 3, @@ -94,13 +94,13 @@ enum hinic_board_type { }; enum hinic_os_type { - HINIC_OS_UNKNOWN = 0, + HINIC_OS_UNKNOWN = 0, HINIC_OS_HUAWEI = 1, HINIC_OS_NON_HUAWEI = 2, }; enum hinic_cpu_type { - HINIC_CPU_UNKNOWN = 0, + HINIC_CPU_UNKNOWN = 0, HINIC_CPU_X86_GENERIC = 1, HINIC_CPU_ARM_GENERIC = 2, }; @@ -387,7 +387,7 @@ struct hinic_rq_filter_info { #define HINIC_MGMT_VERSION_MAX_LEN 32 -#define HINIC_FW_VERSION_NAME 16 +#define HINIC_FW_VERSION_NAME 16 #define HINIC_FW_VERSION_SECTION_CNT 4 #define HINIC_FW_VERSION_SECTION_BORDER 0xFF struct hinic_fw_version { @@ -627,9 +627,9 @@ int hinic_set_link_settings(void *hwdev, struct hinic_link_ksettings *settings); int hinic_enable_netq(void *hwdev, u8 en); int hinic_add_hw_rqfilter(void *hwdev, - struct hinic_rq_filter_info *filter_info); + struct hinic_rq_filter_info *filter_info); int hinic_del_hw_rqfilter(void *hwdev, - struct hinic_rq_filter_info *filter_info); + struct hinic_rq_filter_info *filter_info); int hinic_get_sfp_eeprom(void *hwdev, u8 *data, u16 *len); int hinic_get_sfp_type(void *hwdev, u8 *data0, u8 *data1); diff --git a/drivers/net/ethernet/huawei/hinic/hinic_nic_dbg.c b/drivers/net/ethernet/huawei/hinic/hinic_nic_dbg.c index 9bcdcd3ce1c0..15a006e29927 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_nic_dbg.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_nic_dbg.c @@ -31,7 +31,7 @@ #include "hinic_nic.h" #include "hinic_dbg.h" -#define INVALID_PI (0xFFFF) +#define INVALID_PI 0xFFFF u16 hinic_dbg_get_qp_num(void *hwdev) { diff --git a/drivers/net/ethernet/huawei/hinic/hinic_nic_dev.h b/drivers/net/ethernet/huawei/hinic/hinic_nic_dev.h index e0cebe29735e..33b2aca3ce4c 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_nic_dev.h +++ b/drivers/net/ethernet/huawei/hinic/hinic_nic_dev.h @@ -134,11 +134,11 @@ struct hinic_intr_coal_info { u8 user_set_intr_coal_flag; }; -#define HINIC_NIC_STATS_INC(nic_dev, field) \ -{ \ - u64_stats_update_begin(&nic_dev->stats.syncp); \ - nic_dev->stats.field++; \ - u64_stats_update_end(&nic_dev->stats.syncp); \ +#define HINIC_NIC_STATS_INC(nic_dev, field) \ +{ \ + u64_stats_update_begin(&(nic_dev)->stats.syncp); \ + (nic_dev)->stats.field++; \ + u64_stats_update_end(&(nic_dev)->stats.syncp); \ } struct hinic_nic_stats { @@ -268,12 +268,12 @@ int hinic_enable_func_rss(struct hinic_nic_dev *nic_dev); #define hinic_msg(level, nic_dev, msglvl, format, arg...) \ do { \ - if (nic_dev->netdev && nic_dev->netdev->reg_state \ + if ((nic_dev)->netdev && (nic_dev)->netdev->reg_state \ == NETREG_REGISTERED) \ - nicif_##level(nic_dev, msglvl, nic_dev->netdev, \ + nicif_##level((nic_dev), msglvl, (nic_dev)->netdev, \ format, ## arg); \ else \ - nic_##level(&nic_dev->pdev->dev, \ + nic_##level(&(nic_dev)->pdev->dev, \ format, ## arg); \ } while (0) diff --git a/drivers/net/ethernet/huawei/hinic/hinic_nic_io.c b/drivers/net/ethernet/huawei/hinic/hinic_nic_io.c index b935c41a4435..cd5765165773 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_nic_io.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_nic_io.c @@ -545,9 +545,9 @@ static int init_sq_ctxts(struct hinic_nic_io *nic_io) cmd_buf->size = SQ_CTXT_SIZE(max_ctxts); err = hinic_cmdq_direct_resp(hwdev, HINIC_ACK_TYPE_CMDQ, - HINIC_MOD_L2NIC, + HINIC_MOD_L2NIC, HINIC_UCODE_CMD_MODIFY_QUEUE_CONTEXT, - cmd_buf, &out_param, 0); + cmd_buf, &out_param, 0); if (err || out_param != 0) { nic_err(hwdev->dev_hdl, "Failed to set SQ ctxts, err: %d, out_param: 0x%llx\n", err, out_param); @@ -602,9 +602,9 @@ static int init_rq_ctxts(struct hinic_nic_io *nic_io) cmd_buf->size = RQ_CTXT_SIZE(max_ctxts); err = hinic_cmdq_direct_resp(hwdev, HINIC_ACK_TYPE_CMDQ, - HINIC_MOD_L2NIC, - HINIC_UCODE_CMD_MODIFY_QUEUE_CONTEXT, - cmd_buf, &out_param, 0); + HINIC_MOD_L2NIC, + HINIC_UCODE_CMD_MODIFY_QUEUE_CONTEXT, + cmd_buf, &out_param, 0); if (err || out_param != 0) { nic_err(hwdev->dev_hdl, "Failed to set RQ ctxts, err: %d, out_param: 0x%llx\n", @@ -676,8 +676,8 @@ static int clean_queue_offload_ctxt(struct hinic_nic_io *nic_io, err = hinic_cmdq_direct_resp(hwdev, HINIC_ACK_TYPE_CMDQ, HINIC_MOD_L2NIC, - HINIC_UCODE_CMD_CLEAN_QUEUE_CONTEXT, - cmd_buf, &out_param, 0); + HINIC_UCODE_CMD_CLEAN_QUEUE_CONTEXT, + cmd_buf, &out_param, 0); if ((err) || (out_param)) { nic_err(hwdev->dev_hdl, "Failed to clean queue offload ctxts, err: %d, out_param: 0x%llx\n", diff --git a/drivers/net/ethernet/huawei/hinic/hinic_nictool.c b/drivers/net/ethernet/huawei/hinic/hinic_nictool.c index 8ef008af05e8..a7d56f99bb85 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_nictool.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_nictool.c @@ -36,8 +36,8 @@ #define HIADM_DEV_CLASS "nictool_class" #define HIADM_DEV_NAME "nictool_dev" -#define HINIC_CMDQ_BUF_MAX_SIZE 2048U -#define MSG_MAX_IN_SIZE (2048 * 1024) +#define HINIC_CMDQ_BUF_MAX_SIZE 2048U +#define MSG_MAX_IN_SIZE (2048 * 1024) #define MSG_MAX_OUT_SIZE (2048 * 1024) static dev_t g_dev_id = {0}; @@ -50,14 +50,14 @@ static int g_nictool_init_flag; static int g_nictool_ref_cnt; typedef int (*nic_driv_module)(struct hinic_nic_dev *nic_dev, void *buf_in, - u32 in_size, void *buf_out, u32 *out_size); + u32 in_size, void *buf_out, u32 *out_size); struct nic_drv_module_handle { enum driver_cmd_type driv_cmd_name; nic_driv_module driv_func; }; typedef int (*hw_driv_module)(void *hwdev, void *buf_in, - u32 in_size, void *buf_out, u32 *out_size); + u32 in_size, void *buf_out, u32 *out_size); struct hw_drv_module_handle { enum driver_cmd_type driv_cmd_name; hw_driv_module driv_func; @@ -654,7 +654,7 @@ static int set_link_mode(struct hinic_nic_dev *nic_dev, void *buf_in, } static int set_dcb_cfg(struct hinic_nic_dev *nic_dev, void *buf_in, - u32 in_size, void *buf_out, u32 *out_size) + u32 in_size, void *buf_out, u32 *out_size) { union _dcb_ctl dcb_ctl = {.data = 0}; int err; @@ -666,8 +666,8 @@ static int set_dcb_cfg(struct hinic_nic_dev *nic_dev, void *buf_in, dcb_ctl.data = *((u32 *)buf_in); err = hinic_setup_dcb_tool(nic_dev->netdev, - &dcb_ctl.dcb_data.dcb_en, - !!dcb_ctl.dcb_data.wr_flag); + &dcb_ctl.dcb_data.dcb_en, + !!dcb_ctl.dcb_data.wr_flag); if (err) { nicif_err(nic_dev, drv, nic_dev->netdev, "Failed to setup dcb state to %d\n", @@ -682,7 +682,7 @@ static int set_dcb_cfg(struct hinic_nic_dev *nic_dev, void *buf_in, } int get_pfc_info(struct hinic_nic_dev *nic_dev, void *buf_in, - u32 in_size, void *buf_out, u32 *out_size) + u32 in_size, void *buf_out, u32 *out_size) { union _pfc pfc = {.data = 0}; @@ -705,7 +705,7 @@ int get_pfc_info(struct hinic_nic_dev *nic_dev, void *buf_in, } int set_pfc_control(struct hinic_nic_dev *nic_dev, void *buf_in, - u32 in_size, void *buf_out, u32 *out_size) + u32 in_size, void *buf_out, u32 *out_size) { u8 pfc_en = 0; u8 err = 0; @@ -737,7 +737,7 @@ int set_pfc_control(struct hinic_nic_dev *nic_dev, void *buf_in, } int set_ets(struct hinic_nic_dev *nic_dev, void *buf_in, - u32 in_size, void *buf_out, u32 *out_size) + u32 in_size, void *buf_out, u32 *out_size) { struct _ets ets = {0}; u8 err = 0; @@ -801,7 +801,7 @@ int set_ets(struct hinic_nic_dev *nic_dev, void *buf_in, } int get_support_up(struct hinic_nic_dev *nic_dev, void *buf_in, - u32 in_size, void *buf_out, u32 *out_size) + u32 in_size, void *buf_out, u32 *out_size) { u8 *up_num = buf_out; u8 support_up = 0; @@ -829,7 +829,7 @@ int get_support_up(struct hinic_nic_dev *nic_dev, void *buf_in, } int get_support_tc(struct hinic_nic_dev *nic_dev, void *buf_in, - u32 in_size, void *buf_out, u32 *out_size) + u32 in_size, void *buf_out, u32 *out_size) { u8 *tc_num = buf_out; @@ -849,7 +849,7 @@ int get_support_tc(struct hinic_nic_dev *nic_dev, void *buf_in, } int get_ets_info(struct hinic_nic_dev *nic_dev, void *buf_in, - u32 in_size, void *buf_out, u32 *out_size) + u32 in_size, void *buf_out, u32 *out_size) { struct _ets *ets = buf_out; @@ -868,7 +868,7 @@ int get_ets_info(struct hinic_nic_dev *nic_dev, void *buf_in, } int set_pfc_priority(struct hinic_nic_dev *nic_dev, void *buf_in, - u32 in_size, void *buf_out, u32 *out_size) + u32 in_size, void *buf_out, u32 *out_size) { u8 pfc_prority = 0; u8 err = 0; @@ -997,6 +997,7 @@ static int get_homologue(struct hinic_nic_dev *nic_dev, void *buf_in, u32 in_size, void *buf_out, u32 *out_size) { struct hinic_homologues *homo = buf_out; + if (!buf_out || *out_size != sizeof(*homo)) { nicif_err(nic_dev, drv, nic_dev->netdev, "Unexpect out buf size from user: %d, expect: %lu\n", @@ -1018,6 +1019,7 @@ static int set_homologue(struct hinic_nic_dev *nic_dev, void *buf_in, u32 in_size, void *buf_out, u32 *out_size) { struct hinic_homologues *homo = buf_in; + if (!buf_in || in_size != sizeof(*homo)) { nicif_err(nic_dev, drv, nic_dev->netdev, "Unexpect in buf size from user: %d, expect: %lu\n", @@ -1228,6 +1230,7 @@ static int get_device_id(void *hwdev, void *buf_in, u32 in_size, { u16 dev_id; int err; + if (!buf_out || !buf_in || *out_size != sizeof(u16) || in_size != sizeof(u16)) { pr_err("Unexpect out buf size from user: %d, expect: %lu\n", @@ -1263,7 +1266,7 @@ static int is_driver_in_vm(void *hwdev, void *buf_in, u32 in_size, } static int get_pf_id(void *hwdev, void *buf_in, u32 in_size, - void *buf_out, u32 *out_size) + void *buf_out, u32 *out_size) { struct hinic_pf_info *pf_info; u32 port_id = 0; @@ -1898,7 +1901,7 @@ static int send_to_sm(void *hwdev, struct msg_module *nt_msg, } static bool is_hwdev_cmd_support(unsigned int mod, - char *ifname, u32 up_api_type) + char *ifname, u32 up_api_type) { void *hwdev; @@ -1954,7 +1957,7 @@ static bool is_hwdev_cmd_support(unsigned int mod, } static bool nictool_k_is_cmd_support(unsigned int mod, - char *ifname, u32 up_api_type) + char *ifname, u32 up_api_type) { enum hinic_init_state init_state = hinic_get_init_state_by_ifname(ifname); @@ -1971,7 +1974,7 @@ static bool nictool_k_is_cmd_support(unsigned int mod, } else if (mod >= SEND_TO_UCODE && mod <= SEND_TO_SM) { return is_hwdev_cmd_support(mod, ifname, up_api_type); } else if ((mod >= HINICADM_OVS_DRIVER && - mod <= HINICADM_FCOE_DRIVER) || + mod <= HINICADM_FCOE_DRIVER) || mod == SEND_TO_HW_DRIVER) { if (init_state < HINIC_INIT_STATE_HWDEV_INITED) { pr_err("Hwdev have not initialized\n"); diff --git a/drivers/net/ethernet/huawei/hinic/hinic_nictool.h b/drivers/net/ethernet/huawei/hinic/hinic_nictool.h index 3b8259a7b973..be0f5fd6e3ed 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_nictool.h +++ b/drivers/net/ethernet/huawei/hinic/hinic_nictool.h @@ -50,11 +50,11 @@ struct ipsurx_stats_info { struct ucode_cmd_st { union { struct { - u32 comm_mod_type:8; - u32 ucode_cmd_type:4; - u32 cmdq_ack_type:3; - u32 ucode_imm:1; - u32 len:16; + u32 comm_mod_type : 8; + u32 ucode_cmd_type : 4; + u32 cmdq_ack_type : 3; + u32 ucode_imm : 1; + u32 len : 16; } ucode_db; u32 value; }; @@ -63,9 +63,9 @@ struct ucode_cmd_st { struct up_cmd_st { union { struct { - u32 comm_mod_type:8; - u32 chipif_cmd:8; - u32 up_api_type:16; + u32 comm_mod_type : 8; + u32 chipif_cmd : 8; + u32 up_api_type : 16; } up_db; u32 value; }; @@ -97,11 +97,11 @@ union _pfc { union _flag_com { struct _ets_flag { - u8 flag_ets_enable:1; - u8 flag_ets_percent:1; - u8 flag_ets_cos:1; - u8 flag_ets_strict:1; - u8 rev:4; + u8 flag_ets_enable : 1; + u8 flag_ets_percent : 1; + u8 flag_ets_cos : 1; + u8 flag_ets_strict : 1; + u8 rev : 4; } ets_flag; u8 data; }; @@ -166,8 +166,8 @@ struct hinic_tx_hw_page { struct hinic_dbg_sq_info { u16 q_id; u16 pi; - u16 ci;/* sw_ci */ - u16 fi;/* hw_ci */ + u16 ci; /* sw_ci */ + u16 fi; /* hw_ci */ u32 q_depth; u16 pi_reverse; @@ -268,9 +268,9 @@ struct hinic_pf_info { int nictool_k_init(void); void nictool_k_uninit(void); -extern u32 hinic_get_io_stats_size(struct hinic_nic_dev *nic_dev); -extern void hinic_get_io_stats(struct hinic_nic_dev *nic_dev, - struct hinic_show_item *items); +u32 hinic_get_io_stats_size(struct hinic_nic_dev *nic_dev); +void hinic_get_io_stats(struct hinic_nic_dev *nic_dev, + struct hinic_show_item *items); #define TOOL_COUNTER_MAX_LEN 512 diff --git a/drivers/net/ethernet/huawei/hinic/hinic_port_cmd.h b/drivers/net/ethernet/huawei/hinic/hinic_port_cmd.h index 1d3c0301ba63..518c815e0e77 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_port_cmd.h +++ b/drivers/net/ethernet/huawei/hinic/hinic_port_cmd.h @@ -278,7 +278,7 @@ enum hinic_mgmt_cmd { HINIC_MGMT_CMD_GET_HW_PF_INFOS = 0x6D, HINIC_MGMT_CMD_GET_SDI_MODE = 0x6E, - HINIC_MGMT_CMD_ENABLE_MIGRATE = 0x6F, + HINIC_MGMT_CMD_ENABLE_MIGRATE = 0x6F, }; /* uCode relates commands */ @@ -343,8 +343,8 @@ enum sq_tunnel_l4_type { TUNNEL_UDP_CSUM, }; -#define NIC_RSS_CMD_TEMP_ALLOC 0x01 -#define NIC_RSS_CMD_TEMP_FREE 0x02 +#define NIC_RSS_CMD_TEMP_ALLOC 0x01 +#define NIC_RSS_CMD_TEMP_FREE 0x02 #define HINIC_RSS_TYPE_VALID_SHIFT 23 #define HINIC_RSS_TYPE_TCP_IPV6_EXT_SHIFT 24 @@ -495,7 +495,7 @@ enum { #define DB_IDX(db, db_base) \ ((u32)(((ulong)(db) - (ulong)(db_base)) / \ - HINIC_DB_PAGE_SIZE)) + HINIC_DB_PAGE_SIZE)) enum hinic_pcie_nosnoop { HINIC_PCIE_SNOOP = 0, @@ -518,21 +518,21 @@ enum hinic_doorbell_ctrl { }; enum hinic_pf_status { - HINIC_PF_STATUS_INIT = 0X0, + HINIC_PF_STATUS_INIT = 0x0, HINIC_PF_STATUS_ACTIVE_FLAG = 0x11, HINIC_PF_STATUS_FLR_START_FLAG = 0x12, HINIC_PF_STATUS_FLR_FINISH_FLAG = 0x13, }; /* total doorbell or direct wqe size is 512kB, db num: 128, dwqe: 128 */ -#define HINIC_DB_DWQE_SIZE 0x00080000 +#define HINIC_DB_DWQE_SIZE 0x00080000 /* BMGW & VMGW VF db size 256k, have no dwqe space */ -#define HINIC_GW_VF_DB_SIZE 0x00040000 +#define HINIC_GW_VF_DB_SIZE 0x00040000 /* db/dwqe page size: 4K */ -#define HINIC_DB_PAGE_SIZE 0x00001000ULL +#define HINIC_DB_PAGE_SIZE 0x00001000ULL -#define HINIC_DB_MAX_AREAS (HINIC_DB_DWQE_SIZE / HINIC_DB_PAGE_SIZE) +#define HINIC_DB_MAX_AREAS (HINIC_DB_DWQE_SIZE / HINIC_DB_PAGE_SIZE) #define HINIC_PCI_MSIX_ENTRY_SIZE 16 #define HINIC_PCI_MSIX_ENTRY_VECTOR_CTRL 12 diff --git a/drivers/net/ethernet/huawei/hinic/hinic_qe_def.h b/drivers/net/ethernet/huawei/hinic/hinic_qe_def.h index 6e55b505dbb5..00863a77ef4d 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_qe_def.h +++ b/drivers/net/ethernet/huawei/hinic/hinic_qe_def.h @@ -16,22 +16,22 @@ #ifndef __HINIC_QE_DEF_H__ #define __HINIC_QE_DEF_H__ -#define HINIC_SQ_WQEBB_SIZE 64 -#define HINIC_RQ_WQE_SIZE 32 -#define HINIC_SQ_WQEBB_SHIFT 6 -#define HINIC_RQ_WQEBB_SHIFT 5 +#define HINIC_SQ_WQEBB_SIZE 64 +#define HINIC_RQ_WQE_SIZE 32 +#define HINIC_SQ_WQEBB_SHIFT 6 +#define HINIC_RQ_WQEBB_SHIFT 5 #define HINIC_MAX_QUEUE_DEPTH 4096 #define HINIC_MIN_QUEUE_DEPTH 128 -#define HINIC_TXD_ALIGN 1 -#define HINIC_RXD_ALIGN 1 +#define HINIC_TXD_ALIGN 1 +#define HINIC_RXD_ALIGN 1 #define HINIC_SQ_DEPTH 1024 #define HINIC_RQ_DEPTH 1024 -#define HINIC_RQ_WQE_MAX_SIZE 32 +#define HINIC_RQ_WQE_MAX_SIZE 32 -#define SIZE_8BYTES(size) (ALIGN((u32)(size), 8) >> 3)//lint !e767 +#define SIZE_8BYTES(size) (ALIGN((u32)(size), 8) >> 3)//lint !e767 /************** SQ_CTRL ***************/ #define SQ_CTRL_BUFDESC_SECT_LEN_SHIFT 0 @@ -47,11 +47,11 @@ #define SQ_CTRL_OWNER_MASK 0x1U #define SQ_CTRL_GET(val, member) (((val) >> SQ_CTRL_##member##_SHIFT) \ - & SQ_CTRL_##member##_MASK) + & SQ_CTRL_##member##_MASK) #define SQ_CTRL_CLEAR(val, member) ((val) & \ - (~(SQ_CTRL_##member##_MASK << \ - SQ_CTRL_##member##_SHIFT))) + (~(SQ_CTRL_##member##_MASK << \ + SQ_CTRL_##member##_SHIFT))) #define SQ_CTRL_QUEUE_INFO_PLDOFF_SHIFT 2 #define SQ_CTRL_QUEUE_INFO_UFO_SHIFT 10 @@ -73,15 +73,15 @@ #define SQ_CTRL_QUEUE_INFO_SET(val, member) \ (((u32)(val) & SQ_CTRL_QUEUE_INFO_##member##_MASK) \ - << SQ_CTRL_QUEUE_INFO_##member##_SHIFT) + << SQ_CTRL_QUEUE_INFO_##member##_SHIFT) #define SQ_CTRL_QUEUE_INFO_GET(val, member) \ (((val) >> SQ_CTRL_QUEUE_INFO_##member##_SHIFT) \ - & SQ_CTRL_QUEUE_INFO_##member##_MASK) + & SQ_CTRL_QUEUE_INFO_##member##_MASK) #define SQ_CTRL_QUEUE_INFO_CLEAR(val, member) \ ((val) & (~(SQ_CTRL_QUEUE_INFO_##member##_MASK << \ - SQ_CTRL_QUEUE_INFO_##member##_SHIFT))) + SQ_CTRL_QUEUE_INFO_##member##_SHIFT))) #define SQ_TASK_INFO0_L2HDR_LEN_SHIFT 0 #define SQ_TASK_INFO0_L4OFFLOAD_SHIFT 8 @@ -103,10 +103,10 @@ #define SQ_TASK_INFO0_SET(val, member) \ (((u32)(val) & SQ_TASK_INFO0_##member##_MASK) << \ - SQ_TASK_INFO0_##member##_SHIFT) + SQ_TASK_INFO0_##member##_SHIFT) #define SQ_TASK_INFO0_GET(val, member) \ (((val) >> SQ_TASK_INFO0_##member##_SHIFT) & \ - SQ_TASK_INFO0_##member##_MASK) + SQ_TASK_INFO0_##member##_MASK) #define SQ_TASK_INFO1_MD_TYPE_SHIFT 8 #define SQ_TASK_INFO1_INNER_L4LEN_SHIFT 16 @@ -118,10 +118,10 @@ #define SQ_TASK_INFO1_SET(val, member) \ (((val) & SQ_TASK_INFO1_##member##_MASK) << \ - SQ_TASK_INFO1_##member##_SHIFT) + SQ_TASK_INFO1_##member##_SHIFT) #define SQ_TASK_INFO1_GET(val, member) \ (((val) >> SQ_TASK_INFO1_##member##_SHIFT) & \ - SQ_TASK_INFO1_##member##_MASK) + SQ_TASK_INFO1_##member##_MASK) #define SQ_TASK_INFO2_TUNNEL_L4LEN_SHIFT 0 #define SQ_TASK_INFO2_OUTER_L3LEN_SHIFT 8 @@ -135,43 +135,43 @@ #define SQ_TASK_INFO2_SET(val, member) \ (((val) & SQ_TASK_INFO2_##member##_MASK) << \ - SQ_TASK_INFO2_##member##_SHIFT) + SQ_TASK_INFO2_##member##_SHIFT) #define SQ_TASK_INFO2_GET(val, member) \ (((val) >> SQ_TASK_INFO2_##member##_SHIFT) & \ - SQ_TASK_INFO2_##member##_MASK) + SQ_TASK_INFO2_##member##_MASK) -#define SQ_TASK_INFO4_L2TYPE_SHIFT 31 +#define SQ_TASK_INFO4_L2TYPE_SHIFT 31 -#define SQ_TASK_INFO4_L2TYPE_MASK 0x1U +#define SQ_TASK_INFO4_L2TYPE_MASK 0x1U #define SQ_TASK_INFO4_SET(val, member) \ (((u32)(val) & SQ_TASK_INFO4_##member##_MASK) << \ SQ_TASK_INFO4_##member##_SHIFT) /********************* SQ_DB *********************/ -#define SQ_DB_OFF 0x00000800 -#define SQ_DB_INFO_HI_PI_SHIFT 0 -#define SQ_DB_INFO_QID_SHIFT 8 -#define SQ_DB_INFO_CFLAG_SHIFT 23 -#define SQ_DB_INFO_COS_SHIFT 24 -#define SQ_DB_INFO_TYPE_SHIFT 27 -#define SQ_DB_INFO_HI_PI_MASK 0xFFU -#define SQ_DB_INFO_QID_MASK 0x3FFU -#define SQ_DB_INFO_CFLAG_MASK 0x1U -#define SQ_DB_INFO_COS_MASK 0x7U -#define SQ_DB_INFO_TYPE_MASK 0x1FU -#define SQ_DB_INFO_SET(val, member) (((u32)(val) & \ - SQ_DB_INFO_##member##_MASK) << \ - SQ_DB_INFO_##member##_SHIFT) - -#define SQ_DB_PI_LOW_MASK 0xFF -#define SQ_DB_PI_LOW(pi) ((pi) & SQ_DB_PI_LOW_MASK) -#define SQ_DB_PI_HI_SHIFT 8 -#define SQ_DB_PI_HIGH(pi) ((pi) >> SQ_DB_PI_HI_SHIFT) +#define SQ_DB_OFF 0x00000800 +#define SQ_DB_INFO_HI_PI_SHIFT 0 +#define SQ_DB_INFO_QID_SHIFT 8 +#define SQ_DB_INFO_CFLAG_SHIFT 23 +#define SQ_DB_INFO_COS_SHIFT 24 +#define SQ_DB_INFO_TYPE_SHIFT 27 +#define SQ_DB_INFO_HI_PI_MASK 0xFFU +#define SQ_DB_INFO_QID_MASK 0x3FFU +#define SQ_DB_INFO_CFLAG_MASK 0x1U +#define SQ_DB_INFO_COS_MASK 0x7U +#define SQ_DB_INFO_TYPE_MASK 0x1FU +#define SQ_DB_INFO_SET(val, member) \ + (((u32)(val) & SQ_DB_INFO_##member##_MASK) << \ + SQ_DB_INFO_##member##_SHIFT) + +#define SQ_DB_PI_LOW_MASK 0xFF +#define SQ_DB_PI_LOW(pi) ((pi) & SQ_DB_PI_LOW_MASK) +#define SQ_DB_PI_HI_SHIFT 8 +#define SQ_DB_PI_HIGH(pi) ((pi) >> SQ_DB_PI_HI_SHIFT) #define SQ_DB_ADDR(sq, pi) ((u64 *)((sq)->db_addr + SQ_DB_OFF) + \ - SQ_DB_PI_LOW(pi)) -#define SQ_DB 1 -#define SQ_CFLAG_DP 0 /* CFLAG_DATA_PATH */ + SQ_DB_PI_LOW(pi)) +#define SQ_DB 1 +#define SQ_CFLAG_DP 0 /* CFLAG_DATA_PATH */ /*********************** RQ_CTRL ******************/ #define RQ_CTRL_BUFDESC_SECT_LEN_SHIFT 0 @@ -184,17 +184,17 @@ #define RQ_CTRL_COMPLETE_LEN_MASK 0x3U #define RQ_CTRL_LEN_MASK 0x3U -#define RQ_CTRL_SET(val, member) (((val) & \ - RQ_CTRL_##member##_MASK) << \ - RQ_CTRL_##member##_SHIFT) +#define RQ_CTRL_SET(val, member) \ + (((val) & RQ_CTRL_##member##_MASK) << \ + RQ_CTRL_##member##_SHIFT) -#define RQ_CTRL_GET(val, member) (((val) >> \ - RQ_CTRL_##member##_SHIFT) & \ - RQ_CTRL_##member##_MASK) +#define RQ_CTRL_GET(val, member) \ + (((val) >> RQ_CTRL_##member##_SHIFT) & \ + RQ_CTRL_##member##_MASK) -#define RQ_CTRL_CLEAR(val, member) ((val) & \ - (~(RQ_CTRL_##member##_MASK << \ - RQ_CTRL_##member##_SHIFT))) +#define RQ_CTRL_CLEAR(val, member) \ + ((val) & (~(RQ_CTRL_##member##_MASK << \ + RQ_CTRL_##member##_SHIFT))) #define RQ_CQE_STATUS_CSUM_ERR_SHIFT 0 #define RQ_CQE_STATUS_NUM_LRO_SHIFT 16 @@ -215,49 +215,49 @@ #define RQ_CQE_STATUS_RXDONE_MASK 0x1U #define RQ_CQE_STATUS_FLUSH_MASK 0x1U -#define RQ_CQE_STATUS_GET(val, member) (((val) >> \ - RQ_CQE_STATUS_##member##_SHIFT) & \ - RQ_CQE_STATUS_##member##_MASK) +#define RQ_CQE_STATUS_GET(val, member) \ + (((val) >> RQ_CQE_STATUS_##member##_SHIFT) & \ + RQ_CQE_STATUS_##member##_MASK) -#define RQ_CQE_STATUS_CLEAR(val, member) ((val) & \ - (~(RQ_CQE_STATUS_##member##_MASK << \ - RQ_CQE_STATUS_##member##_SHIFT))) +#define RQ_CQE_STATUS_CLEAR(val, member) \ + ((val) & (~(RQ_CQE_STATUS_##member##_MASK << \ + RQ_CQE_STATUS_##member##_SHIFT))) -#define RQ_CQE_SGE_VLAN_SHIFT 0 -#define RQ_CQE_SGE_LEN_SHIFT 16 +#define RQ_CQE_SGE_VLAN_SHIFT 0 +#define RQ_CQE_SGE_LEN_SHIFT 16 -#define RQ_CQE_SGE_VLAN_MASK 0xFFFFU -#define RQ_CQE_SGE_LEN_MASK 0xFFFFU +#define RQ_CQE_SGE_VLAN_MASK 0xFFFFU +#define RQ_CQE_SGE_LEN_MASK 0xFFFFU -#define RQ_CQE_SGE_GET(val, member) (((val) >> \ - RQ_CQE_SGE_##member##_SHIFT) & \ - RQ_CQE_SGE_##member##_MASK) +#define RQ_CQE_SGE_GET(val, member) \ + (((val) >> RQ_CQE_SGE_##member##_SHIFT) & \ + RQ_CQE_SGE_##member##_MASK) -#define RQ_CQE_PKT_NUM_SHIFT 1 -#define RQ_CQE_PKT_FIRST_LEN_SHIFT 19 -#define RQ_CQE_PKT_LAST_LEN_SHIFT 6 -#define RQ_CQE_SUPER_CQE_EN_SHIFT 0 +#define RQ_CQE_PKT_NUM_SHIFT 1 +#define RQ_CQE_PKT_FIRST_LEN_SHIFT 19 +#define RQ_CQE_PKT_LAST_LEN_SHIFT 6 +#define RQ_CQE_SUPER_CQE_EN_SHIFT 0 -#define RQ_CQE_PKT_FIRST_LEN_MASK 0x1FFFU -#define RQ_CQE_PKT_LAST_LEN_MASK 0x1FFFU -#define RQ_CQE_PKT_NUM_MASK 0x1FU -#define RQ_CQE_SUPER_CQE_EN_MASK 0x1 +#define RQ_CQE_PKT_FIRST_LEN_MASK 0x1FFFU +#define RQ_CQE_PKT_LAST_LEN_MASK 0x1FFFU +#define RQ_CQE_PKT_NUM_MASK 0x1FU +#define RQ_CQE_SUPER_CQE_EN_MASK 0x1 -#define RQ_CQE_PKT_NUM_GET(val, member) (((val) >> \ - RQ_CQE_PKT_##member##_SHIFT) & \ - RQ_CQE_PKT_##member##_MASK) +#define RQ_CQE_PKT_NUM_GET(val, member) \ + (((val) >> RQ_CQE_PKT_##member##_SHIFT) & \ + RQ_CQE_PKT_##member##_MASK) #define HINIC_GET_RQ_CQE_PKT_NUM(pkt_info) RQ_CQE_PKT_NUM_GET(pkt_info, NUM) -#define RQ_CQE_SUPER_CQE_EN_GET(val, member) (((val) >> \ - RQ_CQE_##member##_SHIFT) & \ - RQ_CQE_##member##_MASK) +#define RQ_CQE_SUPER_CQE_EN_GET(val, member) \ + (((val) >> RQ_CQE_##member##_SHIFT) & \ + RQ_CQE_##member##_MASK) #define HINIC_GET_SUPER_CQE_EN(pkt_info) \ RQ_CQE_SUPER_CQE_EN_GET(pkt_info, SUPER_CQE_EN) #define HINIC_GET_SUPER_CQE_EN_BE(pkt_info) ((pkt_info) & 0x1000000U) -#define RQ_CQE_PKT_LEN_GET(val, member) (((val) >> \ - RQ_CQE_PKT_##member##_SHIFT) & \ - RQ_CQE_PKT_##member##_MASK) +#define RQ_CQE_PKT_LEN_GET(val, member) \ + (((val) >> RQ_CQE_PKT_##member##_SHIFT) & \ + RQ_CQE_PKT_##member##_MASK) #define RQ_CQE_OFFOLAD_TYPE_VLAN_EN_SHIFT 21 #define RQ_CQE_OFFOLAD_TYPE_VLAN_EN_MASK 0x1U @@ -271,23 +271,23 @@ #define RQ_CQE_OFFOLAD_TYPE_RSS_TYPE_SHIFT 24 #define RQ_CQE_OFFOLAD_TYPE_RSS_TYPE_MASK 0xFFU -#define RQ_CQE_OFFOLAD_TYPE_GET(val, member) (((val) >> \ - RQ_CQE_OFFOLAD_TYPE_##member##_SHIFT) & \ - RQ_CQE_OFFOLAD_TYPE_##member##_MASK) +#define RQ_CQE_OFFOLAD_TYPE_GET(val, member) \ + (((val) >> RQ_CQE_OFFOLAD_TYPE_##member##_SHIFT) & \ + RQ_CQE_OFFOLAD_TYPE_##member##_MASK) -#define RQ_CQE_PKT_TYPES_NON_L2_MASK 0x800U -#define RQ_CQE_PKT_TYPES_L2_MASK 0x7FU +#define RQ_CQE_PKT_TYPES_NON_L2_MASK 0x800U +#define RQ_CQE_PKT_TYPES_L2_MASK 0x7FU -#define RQ_CQE_STATUS_CSUM_BYPASS_VAL 0x80 -#define RQ_CQE_STATUS_CSUM_ERR_IP_MASK 0x31U -#define RQ_CQE_STATUS_CSUM_ERR_L4_MASK 0x4EU +#define RQ_CQE_STATUS_CSUM_BYPASS_VAL 0x80 +#define RQ_CQE_STATUS_CSUM_ERR_IP_MASK 0x31U +#define RQ_CQE_STATUS_CSUM_ERR_L4_MASK 0x4EU -#define SECT_SIZE_BYTES(size) ((size) << 3) +#define SECT_SIZE_BYTES(size) ((size) << 3) -#define HINIC_PF_SET_VF_ALREADY 0x4 -#define HINIC_MGMT_STATUS_EXIST 0x6 +#define HINIC_PF_SET_VF_ALREADY 0x4 +#define HINIC_MGMT_STATUS_EXIST 0x6 -#define WQS_BLOCKS_PER_PAGE 4 +#define WQS_BLOCKS_PER_PAGE 4 #define WQ_SIZE(wq) (u32)((u64)(wq)->q_depth * (wq)->wqebb_size) @@ -298,7 +298,7 @@ ((idx) & ((wq)->num_wqebbs_per_page - 1))) #define WQ_PAGE_ADDR_SIZE sizeof(u64) -#define WQ_PAGE_ADDR_SIZE_SHIFT 3 +#define WQ_PAGE_ADDR_SIZE_SHIFT 3 #define WQ_PAGE_ADDR(wq, idx) \ (u8 *)(*(u64 *)((u64)((wq)->shadow_block_vaddr) + \ (WQE_PAGE_NUM(wq, idx) << WQ_PAGE_ADDR_SIZE_SHIFT))) @@ -310,7 +310,7 @@ #define CMDQ_BLOCKS_PER_PAGE 8 #define CMDQ_BLOCK_SIZE 512UL #define CMDQ_PAGE_SIZE ALIGN((CMDQ_BLOCKS_PER_PAGE * \ - CMDQ_BLOCK_SIZE), PAGE_SIZE) + CMDQ_BLOCK_SIZE), PAGE_SIZE) #define ADDR_4K_ALIGNED(addr) (0 == ((addr) & 0xfff)) #define ADDR_256K_ALIGNED(addr) (0 == ((addr) & 0x3ffff)) @@ -342,11 +342,11 @@ #define WQE_SHADOW_PAGE(wq, wqe) \ (u16)(((ulong)(wqe) - (ulong)(wq)->shadow_wqe) \ - / (wq)->max_wqe_size) + / (wq)->max_wqe_size) #define WQE_IN_RANGE(wqe, start, end) \ (((ulong)(wqe) >= (ulong)(start)) && \ - ((ulong)(wqe) < (ulong)(end))) + ((ulong)(wqe) < (ulong)(end))) #define WQ_NUM_PAGES(num_wqs) \ (ALIGN((u32)num_wqs, WQS_BLOCKS_PER_PAGE) / WQS_BLOCKS_PER_PAGE) @@ -381,7 +381,7 @@ enum hinic_res_state { HINIC_RES_ACTIVE = 1, }; -#define DEFAULT_RX_BUF_SIZE ((u16)0xB) +#define DEFAULT_RX_BUF_SIZE ((u16)0xB) #define BUF_DESC_SIZE_SHIFT 4 @@ -434,16 +434,16 @@ enum hinic_res_state { ((pkt_types) & RQ_CQE_PKT_TYPES_NON_L2_MASK) #define HINIC_PKT_TYPES_L2(pkt_types) \ - (pkt_types & RQ_CQE_PKT_TYPES_L2_MASK) + ((pkt_types) & RQ_CQE_PKT_TYPES_L2_MASK) #define HINIC_CSUM_ERR_BYPASSED(csum_err) \ - (csum_err == RQ_CQE_STATUS_CSUM_BYPASS_VAL) + ((csum_err) == RQ_CQE_STATUS_CSUM_BYPASS_VAL) #define HINIC_CSUM_ERR_IP(csum_err) \ - (csum_err & RQ_CQE_STATUS_CSUM_ERR_IP_MASK) + ((csum_err) & RQ_CQE_STATUS_CSUM_ERR_IP_MASK) #define HINIC_CSUM_ERR_L4(csum_err) \ - (csum_err & RQ_CQE_STATUS_CSUM_ERR_L4_MASK) + ((csum_err) & RQ_CQE_STATUS_CSUM_ERR_L4_MASK) #define TX_MSS_DEFAULT 0x3E00 #define TX_MSS_MIN 0x50 diff --git a/drivers/net/ethernet/huawei/hinic/hinic_rx.c b/drivers/net/ethernet/huawei/hinic/hinic_rx.c index 05d9625267e3..0f597c38c02d 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_rx.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_rx.c @@ -48,9 +48,9 @@ static void hinic_clear_rss_config_user(struct hinic_nic_dev *nic_dev); #define RXQ_STATS_INC(rxq, field) \ { \ - u64_stats_update_begin(&rxq->rxq_stats.syncp); \ - rxq->rxq_stats.field++; \ - u64_stats_update_end(&rxq->rxq_stats.syncp); \ + u64_stats_update_begin(&(rxq)->rxq_stats.syncp); \ + (rxq)->rxq_stats.field++; \ + u64_stats_update_end(&(rxq)->rxq_stats.syncp); \ } static bool rx_alloc_mapped_page(struct hinic_rxq *rxq, @@ -657,7 +657,7 @@ int hinic_rx_poll(struct hinic_rxq *rxq, int budget) num_lro = HINIC_GET_RX_NUM_LRO(status); if (num_lro) { rx_bytes += ((num_lro - 1) * - LRO_PKT_HDR_LEN(rx_cqe)); + LRO_PKT_HDR_LEN(rx_cqe)); num_wqe += (u16)(pkt_len >> rxq->rx_buff_shift) + diff --git a/drivers/net/ethernet/huawei/hinic/hinic_rx.h b/drivers/net/ethernet/huawei/hinic/hinic_rx.h index 403b390f2fff..11c68c09835b 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_rx.h +++ b/drivers/net/ethernet/huawei/hinic/hinic_rx.h @@ -30,7 +30,7 @@ #define HINIC_RX_CSUM_OFFLOAD_EN 0xFFF #define HINIC_SUPPORT_LRO_ADAP_QPS_MAX 16 -#define HINIC_RX_BUFFER_WRITE 16 +#define HINIC_RX_BUFFER_WRITE 16 struct hinic_rxq_stats { u64 packets; diff --git a/drivers/net/ethernet/huawei/hinic/hinic_sm_lt.h b/drivers/net/ethernet/huawei/hinic/hinic_sm_lt.h index 5fc66c0f3091..e88e556274fc 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_sm_lt.h +++ b/drivers/net/ethernet/huawei/hinic/hinic_sm_lt.h @@ -16,27 +16,27 @@ #ifndef __CHIPIF_SM_LT_H__ #define __CHIPIF_SM_LT_H__ -#define SM_LT_LOAD (0x12) -#define SM_LT_STORE (0x14) +#define SM_LT_LOAD 0x12 +#define SM_LT_STORE 0x14 -#define SM_LT_NUM_OFFSET 13 -#define SM_LT_ABUF_FLG_OFFSET 12 -#define SM_LT_BC_OFFSET 11 +#define SM_LT_NUM_OFFSET 13 +#define SM_LT_ABUF_FLG_OFFSET 12 +#define SM_LT_BC_OFFSET 11 -#define SM_LT_ENTRY_16B 16 -#define SM_LT_ENTRY_32B 32 -#define SM_LT_ENTRY_48B 48 -#define SM_LT_ENTRY_64B 64 +#define SM_LT_ENTRY_16B 16 +#define SM_LT_ENTRY_32B 32 +#define SM_LT_ENTRY_48B 48 +#define SM_LT_ENTRY_64B 64 -#define TBL_LT_OFFSET_DEFAULT 0 +#define TBL_LT_OFFSET_DEFAULT 0 -#define SM_CACHE_LINE_SHFT 4 /* log2(16) */ -#define SM_CACHE_LINE_SIZE 16 /* the size of cache line */ +#define SM_CACHE_LINE_SHFT 4 /* log2(16) */ +#define SM_CACHE_LINE_SIZE 16 /* the size of cache line */ -#define MAX_SM_LT_READ_LINE_NUM 4 -#define MAX_SM_LT_WRITE_LINE_NUM 3 +#define MAX_SM_LT_READ_LINE_NUM 4 +#define MAX_SM_LT_WRITE_LINE_NUM 3 -#define SM_LT_FULL_BYTEENB 0xFFFF +#define SM_LT_FULL_BYTEENB 0xFFFF #define TBL_GET_ENB3_MASK(bitmask) (u16)(((bitmask) >> 32) & 0xFFFF) #define TBL_GET_ENB2_MASK(bitmask) (u16)(((bitmask) >> 16) & 0xFFFF) @@ -52,15 +52,15 @@ enum { /* lt load request */ typedef union { struct { - u32 offset:8; - u32 pad:3; - u32 bc:1; - u32 abuf_flg:1; - u32 num:2; - u32 ack:1; - u32 op_id:5; - u32 instance:6; - u32 src:5; + u32 offset : 8; + u32 pad : 3; + u32 bc : 1; + u32 abuf_flg : 1; + u32 num : 2; + u32 ack : 1; + u32 op_id : 5; + u32 instance : 6; + u32 src : 5; } bs; u32 value; @@ -178,30 +178,30 @@ struct hinic_csr_request_api_data { union { struct { - u32 reserved1:13; + u32 reserved1 : 13; /* this field indicates the write/read data size: * 2'b00: 32 bits * 2'b01: 64 bits * 2'b10~2'b11:reserved */ - u32 data_size:2; + u32 data_size : 2; /* this field indicates that requestor expect receive a * response data or not. * 1'b0: expect not to receive a response data. * 1'b1: expect to receive a response data. */ - u32 need_response:1; + u32 need_response : 1; /* this field indicates the operation that the requestor * expected. * 5'b1_1110: write value to csr space. * 5'b1_1111: read register from csr space. */ - u32 operation_id:5; - u32 reserved2:6; + u32 operation_id : 5; + u32 reserved2 : 6; /* this field specifies the Src node ID for this API * request message. */ - u32 src_node_id:5; + u32 src_node_id : 5; } bits; u32 val32; @@ -210,8 +210,8 @@ struct hinic_csr_request_api_data { union { struct { /* it specifies the CSR address. */ - u32 csr_addr:26; - u32 reserved3:6; + u32 csr_addr : 26; + u32 reserved3 : 6; } bits; u32 val32; diff --git a/drivers/net/ethernet/huawei/hinic/hinic_sml_counter.h b/drivers/net/ethernet/huawei/hinic/hinic_sml_counter.h index 21aa572f82ae..a2e772ee727b 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_sml_counter.h +++ b/drivers/net/ethernet/huawei/hinic/hinic_sml_counter.h @@ -16,27 +16,27 @@ #ifndef __CHIPIF_SML_COUNTER_H__ #define __CHIPIF_SML_COUNTER_H__ -#define CHIPIF_FUNC_PF 0 -#define CHIPIF_FUNC_VF 1 -#define CHIPIF_FUNC_PPF 2 +#define CHIPIF_FUNC_PF 0 +#define CHIPIF_FUNC_VF 1 +#define CHIPIF_FUNC_PPF 2 -#define CHIPIF_ACK 1 -#define CHIPIF_NOACK 0 +#define CHIPIF_ACK 1 +#define CHIPIF_NOACK 0 -#define CHIPIF_SM_CTR_OP_READ 0x2 -#define CHIPIF_SM_CTR_OP_READ_CLEAR 0x6 -#define CHIPIF_SM_CTR_OP_WRITE 0x3 +#define CHIPIF_SM_CTR_OP_READ 0x2 +#define CHIPIF_SM_CTR_OP_READ_CLEAR 0x6 +#define CHIPIF_SM_CTR_OP_WRITE 0x3 -#define SMALL_CNT_READ_RSP_SIZE 16 +#define SMALL_CNT_READ_RSP_SIZE 16 /* request head */ typedef union { struct { - u32 pad:15; - u32 ack:1; - u32 op_id:5; - u32 instance:6; - u32 src:5; + u32 pad : 15; + u32 ack : 1; + u32 op_id : 5; + u32 instance : 6; + u32 src : 5; } bs; u32 value; @@ -53,8 +53,8 @@ typedef struct { /* counter read response union */ typedef union { struct { - u32 value1:16; - u32 pad0:16; + u32 value1 : 16; + u32 pad0 : 16; u32 pad1[3]; } bs_ss16_rsp; @@ -64,10 +64,10 @@ typedef union { } bs_ss32_rsp; struct { - u32 value1:20; - u32 pad0:12; - u32 value2:12; - u32 pad1:20; + u32 value1 : 20; + u32 pad0 : 12; + u32 value2 : 12; + u32 pad1 : 20; u32 pad2[2]; } bs_sp_rsp; @@ -89,8 +89,8 @@ typedef union { /* resopnse head */ typedef union { struct { - u32 pad:30; /* reserve */ - u32 code:2; /* error code */ + u32 pad : 30; /* reserve */ + u32 code : 2; /* error code */ } bs; u32 value; diff --git a/drivers/net/ethernet/huawei/hinic/hinic_sml_lt.c b/drivers/net/ethernet/huawei/hinic/hinic_sml_lt.c index c4afc1a14109..5ed2ea4a3531 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_sml_lt.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_sml_lt.c @@ -31,11 +31,11 @@ #include "hinic_hwif.h" #include "hinic_dbg.h" -#define ACK 1 -#define NOACK 0 +#define ACK 1 +#define NOACK 0 -#define LT_LOAD16_API_SIZE (16 + 4) -#define LT_STORE16_API_SIZE (32 + 4) +#define LT_LOAD16_API_SIZE (16 + 4) +#define LT_STORE16_API_SIZE (32 + 4) #define HINIC_API_RD_8B 8 #define HINIC_API_RD_4B 4 diff --git a/drivers/net/ethernet/huawei/hinic/hinic_sriov.c b/drivers/net/ethernet/huawei/hinic/hinic_sriov.c index 1a436c133785..9198f13ff9e1 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_sriov.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_sriov.c @@ -280,7 +280,7 @@ int hinic_ndo_set_vf_spoofchk(struct net_device *netdev, int vf, bool setting) return 0; err = hinic_set_vf_spoofchk(sriov_info->hwdev, - OS_VF_ID_TO_HW(vf), setting); + OS_VF_ID_TO_HW(vf), setting); if (!err) { nicif_info(adapter, drv, netdev, "Set VF %d spoofchk %s\n", diff --git a/drivers/net/ethernet/huawei/hinic/hinic_tx.c b/drivers/net/ethernet/huawei/hinic/hinic_tx.c index 8d921ad104e8..bc0a7e77de34 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_tx.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_tx.c @@ -41,16 +41,16 @@ #include "hinic_tx.h" #include "hinic_dbg.h" -#define MIN_SKB_LEN 32 -#define MAX_PAYLOAD_OFFSET 221 +#define MIN_SKB_LEN 32 +#define MAX_PAYLOAD_OFFSET 221 #define NIC_QID(q_id, nic_dev) ((q_id) & ((nic_dev)->num_qps - 1)) #define TXQ_STATS_INC(txq, field) \ { \ - u64_stats_update_begin(&txq->txq_stats.syncp); \ - txq->txq_stats.field++; \ - u64_stats_update_end(&txq->txq_stats.syncp); \ + u64_stats_update_begin(&(txq)->txq_stats.syncp); \ + (txq)->txq_stats.field++; \ + u64_stats_update_end(&(txq)->txq_stats.syncp); \ } void hinic_txq_get_stats(struct hinic_txq *txq, @@ -164,7 +164,7 @@ static int tx_map_skb(struct hinic_nic_dev *nic_dev, struct sk_buff *skb, } dma_len[0].dma = dma_map_single(&pdev->dev, skb->data, - skb_headlen(skb), DMA_TO_DEVICE); + skb_headlen(skb), DMA_TO_DEVICE); if (dma_mapping_error(&pdev->dev, dma_len[0].dma)) { TXQ_STATS_INC(txq, map_frag_err); err = -EFAULT; @@ -184,7 +184,7 @@ static int tx_map_skb(struct hinic_nic_dev *nic_dev, struct sk_buff *skb, nsize = skb_frag_size(frag); i++; dma_len[i].dma = skb_frag_dma_map(&pdev->dev, frag, 0, - nsize, DMA_TO_DEVICE); + nsize, DMA_TO_DEVICE); if (dma_mapping_error(&pdev->dev, dma_len[i].dma)) { TXQ_STATS_INC(txq, map_frag_err); i--; @@ -287,6 +287,7 @@ static void get_inner_l3_l4_type(struct sk_buff *skb, union hinic_ip *ip, *l4_proto = ip->v6->nexthdr; if (exthdr != l4->hdr) { __be16 frag_off = 0; + ipv6_skip_exthdr(skb, (int)(exthdr - skb->data), l4_proto, &frag_off); } diff --git a/drivers/net/ethernet/huawei/hinic/hinic_wq.c b/drivers/net/ethernet/huawei/hinic/hinic_wq.c index fcf98413d2de..86588539a60b 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_wq.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_wq.c @@ -34,7 +34,7 @@ #define WQS_MAX_NUM_BLOCKS 256 #define WQS_FREE_BLOCKS_SIZE(wqs) (WQS_MAX_NUM_BLOCKS * \ - sizeof((wqs)->free_blocks[0])) + sizeof((wqs)->free_blocks[0])) static int wqs_next_block(struct hinic_wqs *wqs, u32 *page_idx, u32 *block_idx); @@ -381,8 +381,8 @@ void hinic_wq_wqe_pg_clear(struct hinic_wq *wq) int hinic_cmdq_alloc(struct hinic_cmdq_pages *cmdq_pages, struct hinic_wq *wq, void *dev_hdl, - int cmdq_blocks, u32 wq_page_size, u32 wqebb_size, - u16 q_depth, u32 max_wqe_size) + int cmdq_blocks, u32 wq_page_size, u32 wqebb_size, + u16 q_depth, u32 max_wqe_size) { int i, j, err = -ENOMEM; diff --git a/drivers/net/ethernet/huawei/hinic/hinic_wq.h b/drivers/net/ethernet/huawei/hinic/hinic_wq.h index 88a07d80b4dd..c2a408c3396d 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_wq.h +++ b/drivers/net/ethernet/huawei/hinic/hinic_wq.h @@ -69,7 +69,7 @@ struct hinic_wqs { u64 **page_vaddr; u64 **shadow_page_vaddr; - struct hinic_free_block *free_blocks; + struct hinic_free_block *free_blocks; u32 alloc_blk_pos; u32 return_blk_pos; int num_free_blks; @@ -86,8 +86,8 @@ void hinic_wq_wqe_pg_clear(struct hinic_wq *wq); int hinic_cmdq_alloc(struct hinic_cmdq_pages *cmdq_pages, struct hinic_wq *wq, void *dev_hdl, - int cmdq_blocks, u32 wq_page_size, u32 wqebb_size, - u16 q_depth, u32 max_wqe_size); + int cmdq_blocks, u32 wq_page_size, u32 wqebb_size, + u16 q_depth, u32 max_wqe_size); void hinic_cmdq_free(struct hinic_cmdq_pages *cmdq_pages, struct hinic_wq *wq, int cmdq_blocks); @@ -98,7 +98,7 @@ void hinic_wqs_free(struct hinic_wqs *wqs); int hinic_wq_allocate(struct hinic_wqs *wqs, struct hinic_wq *wq, u32 wqebb_size, u32 wq_page_size, u16 q_depth, - u32 max_wqe_size); + u32 max_wqe_size); void hinic_wq_free(struct hinic_wqs *wqs, struct hinic_wq *wq); diff --git a/drivers/net/ethernet/huawei/hinic/ossl_knl.h b/drivers/net/ethernet/huawei/hinic/ossl_knl.h index 1dae5ca63d04..c596cdc72318 100644 --- a/drivers/net/ethernet/huawei/hinic/ossl_knl.h +++ b/drivers/net/ethernet/huawei/hinic/ossl_knl.h @@ -19,21 +19,21 @@ #include "ossl_knl_linux.h" #define sdk_err(dev, format, ...) \ - dev_err(dev, "[COMM]"format, ##__VA_ARGS__) + dev_err(dev, "[COMM]" format, ##__VA_ARGS__) #define sdk_warn(dev, format, ...) \ - dev_warn(dev, "[COMM]"format, ##__VA_ARGS__) + dev_warn(dev, "[COMM]" format, ##__VA_ARGS__) #define sdk_notice(dev, format, ...) \ - dev_notice(dev, "[COMM]"format, ##__VA_ARGS__) + dev_notice(dev, "[COMM]" format, ##__VA_ARGS__) #define sdk_info(dev, format, ...) \ - dev_info(dev, "[COMM]"format, ##__VA_ARGS__) + dev_info(dev, "[COMM]" format, ##__VA_ARGS__) #define nic_err(dev, format, ...) \ - dev_err(dev, "[NIC]"format, ##__VA_ARGS__) + dev_err(dev, "[NIC]" format, ##__VA_ARGS__) #define nic_warn(dev, format, ...) \ - dev_warn(dev, "[NIC]"format, ##__VA_ARGS__) + dev_warn(dev, "[NIC]" format, ##__VA_ARGS__) #define nic_notice(dev, format, ...) \ - dev_notice(dev, "[NIC]"format, ##__VA_ARGS__) + dev_notice(dev, "[NIC]" format, ##__VA_ARGS__) #define nic_info(dev, format, ...) \ - dev_info(dev, "[NIC]"format, ##__VA_ARGS__) + dev_info(dev, "[NIC]" format, ##__VA_ARGS__) #endif /* OSSL_KNL_H */ diff --git a/drivers/net/ethernet/huawei/hinic/ossl_knl_linux.h b/drivers/net/ethernet/huawei/hinic/ossl_knl_linux.h index acd5f200b487..24c0bbc8f3f9 100644 --- a/drivers/net/ethernet/huawei/hinic/ossl_knl_linux.h +++ b/drivers/net/ethernet/huawei/hinic/ossl_knl_linux.h @@ -59,15 +59,15 @@ int local_atoi(const char *name); #define nicif_err(priv, type, dev, fmt, args...) \ - netif_level(err, priv, type, dev, "[NIC]"fmt, ##args) + netif_level(err, priv, type, dev, "[NIC]" fmt, ##args) #define nicif_warn(priv, type, dev, fmt, args...) \ - netif_level(warn, priv, type, dev, "[NIC]"fmt, ##args) + netif_level(warn, priv, type, dev, "[NIC]" fmt, ##args) #define nicif_notice(priv, type, dev, fmt, args...) \ - netif_level(notice, priv, type, dev, "[NIC]"fmt, ##args) + netif_level(notice, priv, type, dev, "[NIC]" fmt, ##args) #define nicif_info(priv, type, dev, fmt, args...) \ - netif_level(info, priv, type, dev, "[NIC]"fmt, ##args) + netif_level(info, priv, type, dev, "[NIC]" fmt, ##args) #define nicif_dbg(priv, type, dev, fmt, args...) \ - netif_level(dbg, priv, type, dev, "[NIC]"fmt, ##args) + netif_level(dbg, priv, type, dev, "[NIC]" fmt, ##args) #define tasklet_state(tasklet) ((tasklet)->state) -- 2.25.1
From: Chiqijun <chiqijun@huawei.com> driver inclusion category: bugfix bugzilla: 4472 ----------------------------------------------------------------------- Rename camelCase used in nictool. Signed-off-by: Chiqijun <chiqijun@huawei.com> Reviewed-by: Zengweiliang <zengweiliang.zengweiliang@huawei.com> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- .../net/ethernet/huawei/hinic/hinic_nictool.c | 32 +++++++++---------- .../net/ethernet/huawei/hinic/hinic_nictool.h | 6 ++-- 2 files changed, 19 insertions(+), 19 deletions(-) diff --git a/drivers/net/ethernet/huawei/hinic/hinic_nictool.c b/drivers/net/ethernet/huawei/hinic/hinic_nictool.c index a7d56f99bb85..740ec4adf6ba 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_nictool.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_nictool.c @@ -1338,11 +1338,11 @@ static int get_pf_dev_info(char *dev_name, struct msg_module *nt_msg) int i; int err; - if (nt_msg->lenInfo.outBuffLen != sizeof(dev_info) || - nt_msg->lenInfo.inBuffLen != sizeof(dev_info)) { + if (nt_msg->len_info.out_buff_len != sizeof(dev_info) || + nt_msg->len_info.in_buff_len != sizeof(dev_info)) { pr_err("Invalid out_buf_size %d or Invalid in_buf_size %d, expect %lu\n", - nt_msg->lenInfo.outBuffLen, nt_msg->lenInfo.inBuffLen, - (sizeof(dev_info) * 16)); + nt_msg->len_info.out_buff_len, + nt_msg->len_info.in_buff_len, (sizeof(dev_info) * 16)); return -EINVAL; } @@ -1410,11 +1410,11 @@ static int get_card_func_info(char *dev_name, struct msg_module *nt_msg) struct hinic_card_func_info card_func_info = {0}; int id, err; - if (nt_msg->lenInfo.outBuffLen != sizeof(card_func_info) || - nt_msg->lenInfo.inBuffLen != sizeof(card_func_info)) { + if (nt_msg->len_info.out_buff_len != sizeof(card_func_info) || + nt_msg->len_info.in_buff_len != sizeof(card_func_info)) { pr_err("Invalid out_buf_size %d or Invalid in_buf_size %d, expect %lu\n", - nt_msg->lenInfo.outBuffLen, nt_msg->lenInfo.inBuffLen, - sizeof(card_func_info)); + nt_msg->len_info.out_buff_len, + nt_msg->len_info.in_buff_len, sizeof(card_func_info)); return -EINVAL; } @@ -1860,8 +1860,8 @@ typedef int (*sm_module)(void *hwdev, u32 id, u8 instance, u8 node, struct sm_out_st *buf_out); struct sm_module_handle { - enum sm_cmd_type smCmdName; - sm_module smFunc; + enum sm_cmd_type sm_cmd_name; + sm_module sm_func; }; struct sm_module_handle sm_module_cmd_handle[] = { @@ -1885,8 +1885,8 @@ static int send_to_sm(void *hwdev, struct msg_module *nt_msg, return -EINVAL; for (index = 0; index < num_cmds; index++) { - if (msg_formate == sm_module_cmd_handle[index].smCmdName) - ret = sm_module_cmd_handle[index].smFunc(hwdev, + if (msg_formate == sm_module_cmd_handle[index].sm_cmd_name) + ret = sm_module_cmd_handle[index].sm_func(hwdev, (u32)sm_in->id, (u8)sm_in->instance, (u8)sm_in->node, sm_out); @@ -2208,9 +2208,9 @@ static int get_nictool_drv_cap(struct msg_module *nt_msg) int ret; u64 support = 0; - if (nt_msg->lenInfo.outBuffLen != sizeof(u64)) { + if (nt_msg->len_info.out_buff_len != sizeof(u64)) { pr_err("Unexpect out buf size from user: %d, expect: %lu\n", - nt_msg->lenInfo.outBuffLen, sizeof(u64)); + nt_msg->len_info.out_buff_len, sizeof(u64)); return -EINVAL; } @@ -2282,8 +2282,8 @@ static long nictool_k_unlocked_ioctl(struct file *pfile, cmd_raw = nt_msg.module; - out_size_expect = nt_msg.lenInfo.outBuffLen; - in_size = nt_msg.lenInfo.inBuffLen; + out_size_expect = nt_msg.len_info.out_buff_len; + in_size = nt_msg.len_info.in_buff_len; hinic_tool_cnt_inc(); diff --git a/drivers/net/ethernet/huawei/hinic/hinic_nictool.h b/drivers/net/ethernet/huawei/hinic/hinic_nictool.h index be0f5fd6e3ed..a79a8b694515 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_nictool.h +++ b/drivers/net/ethernet/huawei/hinic/hinic_nictool.h @@ -129,9 +129,9 @@ struct msg_module { }; struct { - u32 inBuffLen; - u32 outBuffLen; - } lenInfo; + u32 in_buff_len; + u32 out_buff_len; + } len_info; u32 res; void *in_buff; void *out_buf; -- 2.25.1
participants (1)
-
Yang Yingliang