[openeuler:OLK-6.6 777/2894] arch/loongarch/kernel/legacy_boot.c:439:25-27: WARNING !A || A && B is equivalent to !A || B - Kernel

1 Feb 2024

      tree:   https://gitee.com/openeuler/kernel.git OLK-6.6
head:   f6f9abf1a5ef2fc559630c77b3570346dcd19d40
commit: db5bb24abc8dd120fd81b7ce21819e96578d011e [777/2894] LoongArch: Old BPI compatibility
config: loongarch-randconfig-r051-20240131 (https://download.01.org/0day-ci/archive/20240201/202402010731.xBi0q0zv-lkp@i...)
compiler: loongarch64-linux-gcc (GCC) 13.2.0

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202402010731.xBi0q0zv-lkp@intel.com/

cocci warnings: (new ones prefixed by >>)
...
...
arch/loongarch/kernel/legacy_boot.c:439:25-27: WARNING !A || A && B is equivalent to !A || B
vim +439 arch/loongarch/kernel/legacy_boot.c

   423	
   424	static struct fwnode_handle * __init parse_isa_base(u64 *cpu_addr)
   425	{
   426		struct device_node *np;
   427		const __be32 *ranges = NULL;
   428		int len;
   429		struct device_node *node;
   430	
   431		for_each_node_by_name(np, "isa") {
   432			node = of_node_get(np);
   433	
   434			if (!node)
   435				break;
   436	
   437			ranges = of_get_property(node, "ranges", &len);
   438
...
439			if (!ranges || (ranges && len > 0))
   440				break;
   441		}
   442		if (ranges) {
   443			ranges += 2;
   444			*cpu_addr = of_translate_address(np, ranges);
   445			return &np->fwnode;
   446		}
   447	
   448		return NULL;
   449	}
   450
-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki