[openeuler:OLK-6.6 2195/2195] include/linux/fortify-string.h:606:4: error: call to '__read_overflow2_field' declared with 'warning' attribute: detected read beyond size of field (2nd parameter); maybe use struct_group()?
tree: https://gitee.com/openeuler/kernel.git OLK-6.6 head: c02455c4cce8052f74fc11c09e9073c01c7f33a4 commit: dd013ad487534c1838afc2f55efdb5daec15aace [2195/2195] Ethernet: Linkdata: Supports Linkdata ethernet Controllers config: x86_64-randconfig-2002-20250501 (https://download.01.org/0day-ci/archive/20250627/202506270011.JbqIzVUa-lkp@i...) compiler: clang version 20.1.2 (https://github.com/llvm/llvm-project 58df0ef89dd64126512e4ee27b4ac3fd8ddf6247) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250627/202506270011.JbqIzVUa-lkp@i...) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202506270011.JbqIzVUa-lkp@intel.com/ All errors (new ones prefixed by >>): In file included from drivers/net/ethernet/linkdata/sxevf/sxevf/sxevf_ethtool.c:12: In file included from drivers/net/ethernet/linkdata/sxevf/sxevf/sxevf_ethtool.h:14: In file included from include/linux/ethtool.h:16: In file included from include/linux/bitmap.h:11: In file included from include/linux/string.h:294:
include/linux/fortify-string.h:606:4: error: call to '__read_overflow2_field' declared with 'warning' attribute: detected read beyond size of field (2nd parameter); maybe use struct_group()? [-Werror,-Wattribute-warning] 606 | __read_overflow2_field(q_size_field, size); | ^ 1 error generated.
vim +606 include/linux/fortify-string.h a28a6e860c6cf2 Francis Laniel 2021-02-25 541 f68f2ff91512c1 Kees Cook 2021-04-20 542 /* f68f2ff91512c1 Kees Cook 2021-04-20 543 * To make sure the compiler can enforce protection against buffer overflows, f68f2ff91512c1 Kees Cook 2021-04-20 544 * memcpy(), memmove(), and memset() must not be used beyond individual f68f2ff91512c1 Kees Cook 2021-04-20 545 * struct members. If you need to copy across multiple members, please use f68f2ff91512c1 Kees Cook 2021-04-20 546 * struct_group() to create a named mirror of an anonymous struct union. f68f2ff91512c1 Kees Cook 2021-04-20 547 * (e.g. see struct sk_buff.) Read overflow checking is currently only f68f2ff91512c1 Kees Cook 2021-04-20 548 * done when a write overflow is also present, or when building with W=1. f68f2ff91512c1 Kees Cook 2021-04-20 549 * f68f2ff91512c1 Kees Cook 2021-04-20 550 * Mitigation coverage matrix f68f2ff91512c1 Kees Cook 2021-04-20 551 * Bounds checking at: f68f2ff91512c1 Kees Cook 2021-04-20 552 * +-------+-------+-------+-------+ f68f2ff91512c1 Kees Cook 2021-04-20 553 * | Compile time | Run time | f68f2ff91512c1 Kees Cook 2021-04-20 554 * memcpy() argument sizes: | write | read | write | read | f68f2ff91512c1 Kees Cook 2021-04-20 555 * dest source length +-------+-------+-------+-------+ f68f2ff91512c1 Kees Cook 2021-04-20 556 * memcpy(known, known, constant) | y | y | n/a | n/a | f68f2ff91512c1 Kees Cook 2021-04-20 557 * memcpy(known, unknown, constant) | y | n | n/a | V | f68f2ff91512c1 Kees Cook 2021-04-20 558 * memcpy(known, known, dynamic) | n | n | B | B | f68f2ff91512c1 Kees Cook 2021-04-20 559 * memcpy(known, unknown, dynamic) | n | n | B | V | f68f2ff91512c1 Kees Cook 2021-04-20 560 * memcpy(unknown, known, constant) | n | y | V | n/a | f68f2ff91512c1 Kees Cook 2021-04-20 561 * memcpy(unknown, unknown, constant) | n | n | V | V | f68f2ff91512c1 Kees Cook 2021-04-20 562 * memcpy(unknown, known, dynamic) | n | n | V | B | f68f2ff91512c1 Kees Cook 2021-04-20 563 * memcpy(unknown, unknown, dynamic) | n | n | V | V | f68f2ff91512c1 Kees Cook 2021-04-20 564 * +-------+-------+-------+-------+ f68f2ff91512c1 Kees Cook 2021-04-20 565 * f68f2ff91512c1 Kees Cook 2021-04-20 566 * y = perform deterministic compile-time bounds checking f68f2ff91512c1 Kees Cook 2021-04-20 567 * n = cannot perform deterministic compile-time bounds checking f68f2ff91512c1 Kees Cook 2021-04-20 568 * n/a = no run-time bounds checking needed since compile-time deterministic f68f2ff91512c1 Kees Cook 2021-04-20 569 * B = can perform run-time bounds checking (currently unimplemented) f68f2ff91512c1 Kees Cook 2021-04-20 570 * V = vulnerable to run-time overflow (will need refactoring to solve) f68f2ff91512c1 Kees Cook 2021-04-20 571 * f68f2ff91512c1 Kees Cook 2021-04-20 572 */ 54d9469bc515dc Kees Cook 2021-06-24 573 __FORTIFY_INLINE bool fortify_memcpy_chk(__kernel_size_t size, f68f2ff91512c1 Kees Cook 2021-04-20 574 const size_t p_size, f68f2ff91512c1 Kees Cook 2021-04-20 575 const size_t q_size, f68f2ff91512c1 Kees Cook 2021-04-20 576 const size_t p_size_field, f68f2ff91512c1 Kees Cook 2021-04-20 577 const size_t q_size_field, f68f2ff91512c1 Kees Cook 2021-04-20 578 const char *func) a28a6e860c6cf2 Francis Laniel 2021-02-25 579 { a28a6e860c6cf2 Francis Laniel 2021-02-25 580 if (__builtin_constant_p(size)) { f68f2ff91512c1 Kees Cook 2021-04-20 581 /* f68f2ff91512c1 Kees Cook 2021-04-20 582 * Length argument is a constant expression, so we f68f2ff91512c1 Kees Cook 2021-04-20 583 * can perform compile-time bounds checking where fa35198f39571b Kees Cook 2022-09-19 584 * buffer sizes are also known at compile time. f68f2ff91512c1 Kees Cook 2021-04-20 585 */ f68f2ff91512c1 Kees Cook 2021-04-20 586 f68f2ff91512c1 Kees Cook 2021-04-20 587 /* Error when size is larger than enclosing struct. */ fa35198f39571b Kees Cook 2022-09-19 588 if (__compiletime_lessthan(p_size_field, p_size) && fa35198f39571b Kees Cook 2022-09-19 589 __compiletime_lessthan(p_size, size)) a28a6e860c6cf2 Francis Laniel 2021-02-25 590 __write_overflow(); fa35198f39571b Kees Cook 2022-09-19 591 if (__compiletime_lessthan(q_size_field, q_size) && fa35198f39571b Kees Cook 2022-09-19 592 __compiletime_lessthan(q_size, size)) a28a6e860c6cf2 Francis Laniel 2021-02-25 593 __read_overflow2(); f68f2ff91512c1 Kees Cook 2021-04-20 594 f68f2ff91512c1 Kees Cook 2021-04-20 595 /* Warn when write size argument larger than dest field. */ fa35198f39571b Kees Cook 2022-09-19 596 if (__compiletime_lessthan(p_size_field, size)) f68f2ff91512c1 Kees Cook 2021-04-20 597 __write_overflow_field(p_size_field, size); f68f2ff91512c1 Kees Cook 2021-04-20 598 /* f68f2ff91512c1 Kees Cook 2021-04-20 599 * Warn for source field over-read when building with W=1 f68f2ff91512c1 Kees Cook 2021-04-20 600 * or when an over-write happened, so both can be fixed at f68f2ff91512c1 Kees Cook 2021-04-20 601 * the same time. f68f2ff91512c1 Kees Cook 2021-04-20 602 */ fa35198f39571b Kees Cook 2022-09-19 603 if ((IS_ENABLED(KBUILD_EXTRA_WARN1) || fa35198f39571b Kees Cook 2022-09-19 604 __compiletime_lessthan(p_size_field, size)) && fa35198f39571b Kees Cook 2022-09-19 605 __compiletime_lessthan(q_size_field, size)) f68f2ff91512c1 Kees Cook 2021-04-20 @606 __read_overflow2_field(q_size_field, size); a28a6e860c6cf2 Francis Laniel 2021-02-25 607 } f68f2ff91512c1 Kees Cook 2021-04-20 608 /* f68f2ff91512c1 Kees Cook 2021-04-20 609 * At this point, length argument may not be a constant expression, f68f2ff91512c1 Kees Cook 2021-04-20 610 * so run-time bounds checking can be done where buffer sizes are f68f2ff91512c1 Kees Cook 2021-04-20 611 * known. (This is not an "else" because the above checks may only f68f2ff91512c1 Kees Cook 2021-04-20 612 * be compile-time warnings, and we want to still warn for run-time f68f2ff91512c1 Kees Cook 2021-04-20 613 * overflows.) f68f2ff91512c1 Kees Cook 2021-04-20 614 */ f68f2ff91512c1 Kees Cook 2021-04-20 615 f68f2ff91512c1 Kees Cook 2021-04-20 616 /* f68f2ff91512c1 Kees Cook 2021-04-20 617 * Always stop accesses beyond the struct that contains the f68f2ff91512c1 Kees Cook 2021-04-20 618 * field, when the buffer's remaining size is known. 311fb40aa0569a Kees Cook 2022-09-02 619 * (The SIZE_MAX test is to optimize away checks where the buffer f68f2ff91512c1 Kees Cook 2021-04-20 620 * lengths are unknown.) f68f2ff91512c1 Kees Cook 2021-04-20 621 */ 311fb40aa0569a Kees Cook 2022-09-02 622 if ((p_size != SIZE_MAX && p_size < size) || 311fb40aa0569a Kees Cook 2022-09-02 623 (q_size != SIZE_MAX && q_size < size)) f68f2ff91512c1 Kees Cook 2021-04-20 624 fortify_panic(func); 54d9469bc515dc Kees Cook 2021-06-24 625 54d9469bc515dc Kees Cook 2021-06-24 626 /* 54d9469bc515dc Kees Cook 2021-06-24 627 * Warn when writing beyond destination field size. 54d9469bc515dc Kees Cook 2021-06-24 628 * 54d9469bc515dc Kees Cook 2021-06-24 629 * We must ignore p_size_field == 0 for existing 0-element 54d9469bc515dc Kees Cook 2021-06-24 630 * fake flexible arrays, until they are all converted to 54d9469bc515dc Kees Cook 2021-06-24 631 * proper flexible arrays. 54d9469bc515dc Kees Cook 2021-06-24 632 * 9f7d69c5cd2390 Kees Cook 2022-09-19 633 * The implementation of __builtin_*object_size() behaves 54d9469bc515dc Kees Cook 2021-06-24 634 * like sizeof() when not directly referencing a flexible 54d9469bc515dc Kees Cook 2021-06-24 635 * array member, which means there will be many bounds checks 54d9469bc515dc Kees Cook 2021-06-24 636 * that will appear at run-time, without a way for them to be 54d9469bc515dc Kees Cook 2021-06-24 637 * detected at compile-time (as can be done when the destination 54d9469bc515dc Kees Cook 2021-06-24 638 * is specifically the flexible array member). 54d9469bc515dc Kees Cook 2021-06-24 639 * https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101832 54d9469bc515dc Kees Cook 2021-06-24 640 */ 54d9469bc515dc Kees Cook 2021-06-24 641 if (p_size_field != 0 && p_size_field != SIZE_MAX && 54d9469bc515dc Kees Cook 2021-06-24 642 p_size != p_size_field && p_size_field < size) 54d9469bc515dc Kees Cook 2021-06-24 643 return true; 54d9469bc515dc Kees Cook 2021-06-24 644 54d9469bc515dc Kees Cook 2021-06-24 645 return false; a28a6e860c6cf2 Francis Laniel 2021-02-25 646 } a28a6e860c6cf2 Francis Laniel 2021-02-25 647 :::::: The code at line 606 was first introduced by commit :::::: f68f2ff91512c199ec24883001245912afc17873 fortify: Detect struct member overflows in memcpy() at compile-time :::::: TO: Kees Cook <keescook@chromium.org> :::::: CC: Kees Cook <keescook@chromium.org> -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
participants (1)
-
kernel test robot