Re: [PATCH openEuler-1.0-LTS 0/6] Fix the problem that the number of tcp timeout retransmissions is lost
hi zhenyuan: 针对你先前提交的“Fix the problem that the number of tcp timeout retransmissions is lost”补丁集，我们在内部review的时候committer给了如下 检视意见 切换EDT主线有 tcp 和 fq 的几个patchset和bugfix, 这里建议先合入解决本问题 后边的3个patch。 因此是否只合后三个patch就可以满足能够解决你目前遇到的问题。 best regard On 2021/10/22 18:52, Jiazhenyuan wrote:
From: Jiazhenyuan <jiazhenyuan@uniontech.com>
issue: https://gitee.com/openeuler/kernel/issues/I4AFRJ?from=project-issue
jiazhenyuan (6): tcp: switch tcp and sch_fq to new earliest departure time net_sched: sch_fq: ensure maxrate fq parameter applies to EDT flows From 9efdda4e3abed13f0903b7b6e4d4c2102019440a Mon Sep 17 00:00:00 2001 From: Eric Dumazet <edumazet@google.com> Date: Sat, 24 Nov 2018 09:12:24 -0800 Subject: [PATCH] tcp: address problems caused by EDT misshaps From 7ae189759cc48cf8b54beebff566e9fd2d4e7d7c Mon Sep 17 00:00:00 2001 From: Yuchung Cheng <ycheng@google.com> Date: Wed, 16 Jan 2019 15:05:30 -0800 Subject: [PATCH] tcp: always set retrans_stamp on recovery From 01a523b071618abbc634d1958229fe3bd2dfa5fa Mon Sep 17 00:00:00 2001 From: Yuchung Cheng <ycheng@google.com> Date: Wed, 16 Jan 2019 15:05:32 -0800 Subject: [PATCH] tcp: create a helper to model exponential backoff From 3256a2d6ab1f71f9a1bd2d7f6f18eb8108c48d17 Mon Sep 17 00:00:00 2001 From: Eric Dumazet <edumazet@google.com> Date: Mon, 30 Sep 2019 15:44:44 -0700 Subject: [PATCH] tcp: adjust rto_base in retransmits_timed_out()
net/ipv4/tcp_bbr.c | 7 +++-- net/ipv4/tcp_input.c | 17 +++++++----- net/ipv4/tcp_output.c | 29 ++++++++++++++------ > net/ipv4/tcp_timer.c | 64 ++++++++++++++++++++----------------------- net/sched/sch_fq.c | 46 ++++++++++++++++++------------- 5 files changed, 92 insertions(+), 71 deletions(-)
-- 2.27.0
_______________________________________________ Kernel mailing list -- kernel@openeuler.org To unsubscribe send an email to kernel-leave@openeuler.org
hi qiulaibin: 该问题的主要修复补丁是补丁集中的第６个补丁，对应commitId: 3256a2d6ab1f71f9a1bd2d7f6f18eb8108c48d17 其它几个补丁被依赖或间接依赖，２、３补丁是为修复第１个补丁引入的，这３个补丁可以都不合，４和５都是一些函数的变形或提炼， 未有大的改动，之前提意见使用patchset合入的原因就是为了保持与开源代码一致性，如果要最小的改动解决问题，提交 https://mailweb.openeuler.org/hyperkitty/list/kernel@openeuler.org/message/O... 满足要求，请评审使用哪种方式合入。 祝：工作愉快 ------------------ Original ------------------ From: "QiuLaibin"<qiulaibin@huawei.com>; Date: Thu, Nov 4, 2021 02:47 AM To: "kernel"<kernel@openeuler.org>; "jiazhenyuan"<jiazhenyuan@uniontech.com>; Cc: "Xiexiuqi"<xiexiuqi@huawei.com>; "Libin (Huawei)"<huawei.libin@huawei.com>; "chengjian (D)"<cj.chengjian@huawei.com>; "liujian56"<liujian56@huawei.com>; "william.xuanziyang"<william.xuanziyang@huawei.com>; Subject: Re: [PATCH openEuler-1.0-LTS 0/6] Fix the problem that the number of tcp timeout retransmissions is lost hi zhenyuan: 针对你先前提交的“Fix the problem that the number of tcp timeout retransmissions is lost”补丁集，我们在内部review的时候committer给了如下 检视意见 切换EDT主线有 tcp 和 fq 的几个patchset和bugfix, 这里建议先合入解决本问题 后边的3个patch。 因此是否只合后三个patch就可以满足能够解决你目前遇到的问题。 best regard On 2021/10/22 18:52, Jiazhenyuan wrote: > > > > From: Jiazhenyuan <jiazhenyuan@uniontech.com> > > issue: https://gitee.com/openeuler/kernel/issues/I4AFRJ?from=project-issue > > jiazhenyuan (6): > tcp: switch tcp and sch_fq to new earliest departure time > net_sched: sch_fq: ensure maxrate fq parameter applies to EDT flows > From 9efdda4e3abed13f0903b7b6e4d4c2102019440a Mon Sep 17 00:00:00 2001 > From: Eric Dumazet <edumazet@google.com> Date: Sat, 24 Nov 2018 > 09:12:24 -0800 Subject: [PATCH] tcp: address problems caused by EDT > misshaps > From 7ae189759cc48cf8b54beebff566e9fd2d4e7d7c Mon Sep 17 00:00:00 2001 > From: Yuchung Cheng <ycheng@google.com> Date: Wed, 16 Jan 2019 > 15:05:30 -0800 Subject: [PATCH] tcp: always set retrans_stamp on > recovery > From 01a523b071618abbc634d1958229fe3bd2dfa5fa Mon Sep 17 00:00:00 2001 > From: Yuchung Cheng <ycheng@google.com> Date: Wed, 16 Jan 2019 > 15:05:32 -0800 Subject: [PATCH] tcp: create a helper to model > exponential backoff > From 3256a2d6ab1f71f9a1bd2d7f6f18eb8108c48d17 Mon Sep 17 00:00:00 2001 > From: Eric Dumazet <edumazet@google.com> Date: Mon, 30 Sep 2019 > 15:44:44 -0700 Subject: [PATCH] tcp: adjust rto_base in > retransmits_timed_out() > > net/ipv4/tcp_bbr.c | 7 +++-- > net/ipv4/tcp_input.c | 17 +++++++----- > net/ipv4/tcp_output.c | 29 ++++++++++++++------ > net/ipv4/tcp_timer.c | 64 ++++++++++++++++++++----------------------- > net/sched/sch_fq.c | 46 ++++++++++++++++++------------- > 5 files changed, 92 insertions(+), 71 deletions(-) > > -- > 2.27.0 > _______________________________________________ Kernel mailing list -- kernel@openeuler.org To unsubscribe send an email to kernel-leave@openeuler.org
participants (2)
-
QiuLaibin -
贾镇源