[openeuler:OLK-6.6 3534/3534] htmldocs: ./kernel/livepatch/core.c:2046: warning: bad line:
Hi Zheng, FYI, the error/warning still remains. tree: https://gitee.com/openeuler/kernel.git OLK-6.6 head: 5930fa3740c518a9f6ba688fd0c1873d6f3adbce commit: 29f85d3cff2dfa35ace94d3e4036d5ea456eb859 [3534/3534] livepatch: Add klp_module_delete_safety_check reproduce: (https://download.01.org/0day-ci/archive/20251211/202512111739.Q8ijhkEi-lkp@i...) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202512111739.Q8ijhkEi-lkp@intel.com/ All warnings (new ones prefixed by >>): Error: Cannot open file ./include/linux/hid_bpf.h Error: Cannot open file ./include/linux/hid.h Error: Cannot open file ./include/linux/i2c-atr.h Error: Cannot open file ./include/linux/mutex.h Error: Cannot open file ./include/linux/mutex.h
./kernel/livepatch/core.c:2046: warning: bad line: Error: Cannot open file ./include/linux/livepatch.h Error: Cannot open file ./include/linux/seqlock.h Error: Cannot open file ./include/linux/damon.h Error: Cannot open file ./include/linux/highmem.h Error: Cannot open file ./include/linux/highmem-internal.h
vim +2046 ./kernel/livepatch/core.c 2033 2034 /** 2035 * klp_module_delete_safety_check() - safety check in livepatch scenario when delete a module 2036 * @mod: Module to be deleted 2037 * 2038 * Module refcnt ensures that there is no rare case between enable_patch and delete_module: 2039 * 1. safety_check -> try_enable_patch -> try_release_module_ref: 2040 * try_enable_patch would increase module refcnt, which cause try_release_module_ref fails. 2041 * 2. safety_check -> try_release_module_ref -> try_enable_patch: 2042 * after release module ref, try_enable_patch would fail because try_module_get fails. 2043 * So the problem that release resources unsafely when enable livepatch after safety_check is 2044 * passed during module deletion does not exist, complex synchronization protection is not 2045 * required.
2046 2047 * Return: 0 on success, otherwise error 2048 */ 2049 int klp_module_delete_safety_check(struct module *mod) 2050 { 2051 int ret; 2052 2053 if (!mod || !is_livepatch_module(mod)) 2054 return 0; 2055 2056 ret = stop_machine(arch_klp_module_check_calltrace, (void *)mod, NULL); 2057 if (ret) { 2058 pr_debug("failed to check klp module calltrace: %d\n", ret); 2059 return ret; 2060 } 2061 2062 return 0; 2063 } 2064
-- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
participants (1)
-
kernel test robot